* [RESEND PATCH v2] scsi: ufs: use an generic error code in ufshcd_set_dev_pwr_mode
[not found] <CGME20220120031457epcas2p2ae55ef07581ed699a49b27391d7ab133@epcas2p2.samsung.com>
@ 2022-01-20 3:13 ` Kiwoong Kim
0 siblings, 0 replies; only message in thread
From: Kiwoong Kim @ 2022-01-20 3:13 UTC (permalink / raw)
To: linux-scsi, linux-kernel, alim.akhtar, avri.altman, jejb,
martin.petersen, beanhuo, cang, adrian.hunter, sc.suh, hy50.seo,
sh425.lee, bhoon95.kim, vkumar.1997
Cc: Kiwoong Kim
v1 -> v2: modify the comment of ufshcd_set_dev_pwr_mode
The return value of ufshcd_set_dev_pwr_mode is given to
device pm core. However, the function currently returns a result
in scsi command and the device pm core doesn't understand it.
It might lead to unexpected behaviors of user land. I found
the return value led to platform reset in Android.
This patch is to use an generic code for SSU failures.
Signed-off-by: Kiwoong Kim <kwmad.kim@samsung.com>
---
drivers/scsi/ufs/ufshcd.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index 1049e41..472c382 100644
--- a/drivers/scsi/ufs/ufshcd.c
+++ b/drivers/scsi/ufs/ufshcd.c
@@ -8613,7 +8613,7 @@ static void ufshcd_hba_exit(struct ufs_hba *hba)
* @pwr_mode: device power mode to set
*
* Returns 0 if requested power mode is set successfully
- * Returns non-zero if failed to set the requested power mode
+ * Returns < 0 if failed to set the requested power mode
*/
static int ufshcd_set_dev_pwr_mode(struct ufs_hba *hba,
enum ufs_dev_pwr_mode pwr_mode)
@@ -8669,6 +8669,7 @@ static int ufshcd_set_dev_pwr_mode(struct ufs_hba *hba,
pwr_mode, ret);
if (ret > 0 && scsi_sense_valid(&sshdr))
scsi_print_sense_hdr(sdp, NULL, &sshdr);
+ ret = -EIO;
}
if (!ret)
--
2.7.4
^ permalink raw reply related [flat|nested] only message in thread