* [PATCH v2] scsi: ufs: see link lost as fatal
[not found] <CGME20220121053945epcas2p386871d63f104de31d8fd0c123615b876@epcas2p3.samsung.com>
@ 2022-01-21 5:37 ` Kiwoong Kim
2022-01-25 5:41 ` Martin K. Petersen
0 siblings, 1 reply; 2+ messages in thread
From: Kiwoong Kim @ 2022-01-21 5:37 UTC (permalink / raw)
To: linux-scsi, linux-kernel, alim.akhtar, avri.altman, jejb,
martin.petersen, beanhuo, cang, adrian.hunter, sc.suh, hy50.seo,
sh425.lee, bhoon95.kim, vkumar.1997
Cc: Kiwoong Kim
v1 -> v2: modify comment
This event is raised when link is lost as specified
in UFSHCI spec and that means communication is
not possible. Thus initializing UFS interface needs to be done.
This patch is to make UFS driver see Link Lost as fatal by using
INT_FATAL_ERRORS. This lead to host reset whenever a link lost
interrupt occurs.
Signed-off-by: Kiwoong Kim <kwmad.kim@samsung.com>
---
drivers/scsi/ufs/ufshci.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/scsi/ufs/ufshci.h b/drivers/scsi/ufs/ufshci.h
index 6a295c8..a7ff0e5 100644
--- a/drivers/scsi/ufs/ufshci.h
+++ b/drivers/scsi/ufs/ufshci.h
@@ -142,7 +142,8 @@ static inline u32 ufshci_version(u32 major, u32 minor)
#define INT_FATAL_ERRORS (DEVICE_FATAL_ERROR |\
CONTROLLER_FATAL_ERROR |\
SYSTEM_BUS_FATAL_ERROR |\
- CRYPTO_ENGINE_FATAL_ERROR)
+ CRYPTO_ENGINE_FATAL_ERROR |\
+ UIC_LINK_LOST)
/* HCS - Host Controller Status 30h */
#define DEVICE_PRESENT 0x1
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] scsi: ufs: see link lost as fatal
2022-01-21 5:37 ` [PATCH v2] scsi: ufs: see link lost as fatal Kiwoong Kim
@ 2022-01-25 5:41 ` Martin K. Petersen
0 siblings, 0 replies; 2+ messages in thread
From: Martin K. Petersen @ 2022-01-25 5:41 UTC (permalink / raw)
To: cang, avri.altman, linux-kernel, sc.suh, beanhuo, bhoon95.kim,
Kiwoong Kim, vkumar.1997, hy50.seo, jejb, adrian.hunter,
alim.akhtar, linux-scsi, sh425.lee
Cc: Martin K . Petersen
On Fri, 21 Jan 2022 14:37:55 +0900, Kiwoong Kim wrote:
> v1 -> v2: modify comment
>
> This event is raised when link is lost as specified
> in UFSHCI spec and that means communication is
> not possible. Thus initializing UFS interface needs to be done.
>
> This patch is to make UFS driver see Link Lost as fatal by using
> INT_FATAL_ERRORS. This lead to host reset whenever a link lost
> interrupt occurs.
>
> [...]
Applied to 5.17/scsi-fixes, thanks!
[1/1] scsi: ufs: see link lost as fatal
https://git.kernel.org/mkp/scsi/c/c99b9b230149
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-01-25 5:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20220121053945epcas2p386871d63f104de31d8fd0c123615b876@epcas2p3.samsung.com>
2022-01-21 5:37 ` [PATCH v2] scsi: ufs: see link lost as fatal Kiwoong Kim
2022-01-25 5:41 ` Martin K. Petersen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.