* [PATCH] usb: gadget: f_sourcesink: Fix isoc transfer for USB_SPEED_SUPER_PLUS
@ 2022-01-21 11:31 Pavankumar Kondeti
2022-01-21 14:31 ` Greg Kroah-Hartman
2022-01-21 15:09 ` Alan Stern
0 siblings, 2 replies; 5+ messages in thread
From: Pavankumar Kondeti @ 2022-01-21 11:31 UTC (permalink / raw)
To: Felipe Balbi, Greg Kroah-Hartman
Cc: linux-usb, linux-kernel, Pavankumar Kondeti
Currently when gadget enumerates in super speed plus, the isoc
endpoint request buffer size is not calculated correctly. Fix
this by checking the gadget speed against USB_SPEED_SUPER_PLUS
and update the request buffer size.
Signed-off-by: Pavankumar Kondeti <quic_pkondeti@quicinc.com>
---
drivers/usb/gadget/function/f_sourcesink.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/usb/gadget/function/f_sourcesink.c b/drivers/usb/gadget/function/f_sourcesink.c
index 1abf08e..0a423ba 100644
--- a/drivers/usb/gadget/function/f_sourcesink.c
+++ b/drivers/usb/gadget/function/f_sourcesink.c
@@ -584,6 +584,8 @@ static int source_sink_start_ep(struct f_sourcesink *ss, bool is_in,
if (is_iso) {
switch (speed) {
+ case USB_SPEED_SUPER_PLUS:
+ fallthrough;
case USB_SPEED_SUPER:
size = ss->isoc_maxpacket *
(ss->isoc_mult + 1) *
--
2.7.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] usb: gadget: f_sourcesink: Fix isoc transfer for USB_SPEED_SUPER_PLUS
2022-01-21 11:31 [PATCH] usb: gadget: f_sourcesink: Fix isoc transfer for USB_SPEED_SUPER_PLUS Pavankumar Kondeti
@ 2022-01-21 14:31 ` Greg Kroah-Hartman
2022-01-22 2:56 ` Pavan Kondeti
2022-01-21 15:09 ` Alan Stern
1 sibling, 1 reply; 5+ messages in thread
From: Greg Kroah-Hartman @ 2022-01-21 14:31 UTC (permalink / raw)
To: Pavankumar Kondeti; +Cc: Felipe Balbi, linux-usb, linux-kernel
On Fri, Jan 21, 2022 at 05:01:24PM +0530, Pavankumar Kondeti wrote:
> Currently when gadget enumerates in super speed plus, the isoc
> endpoint request buffer size is not calculated correctly. Fix
> this by checking the gadget speed against USB_SPEED_SUPER_PLUS
> and update the request buffer size.
>
> Signed-off-by: Pavankumar Kondeti <quic_pkondeti@quicinc.com>
What commit id does this fix?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] usb: gadget: f_sourcesink: Fix isoc transfer for USB_SPEED_SUPER_PLUS
2022-01-21 11:31 [PATCH] usb: gadget: f_sourcesink: Fix isoc transfer for USB_SPEED_SUPER_PLUS Pavankumar Kondeti
2022-01-21 14:31 ` Greg Kroah-Hartman
@ 2022-01-21 15:09 ` Alan Stern
2022-01-22 2:54 ` Pavan Kondeti
1 sibling, 1 reply; 5+ messages in thread
From: Alan Stern @ 2022-01-21 15:09 UTC (permalink / raw)
To: Pavankumar Kondeti
Cc: Felipe Balbi, Greg Kroah-Hartman, linux-usb, linux-kernel
On Fri, Jan 21, 2022 at 05:01:24PM +0530, Pavankumar Kondeti wrote:
> Currently when gadget enumerates in super speed plus, the isoc
> endpoint request buffer size is not calculated correctly. Fix
> this by checking the gadget speed against USB_SPEED_SUPER_PLUS
> and update the request buffer size.
>
> Signed-off-by: Pavankumar Kondeti <quic_pkondeti@quicinc.com>
> ---
> drivers/usb/gadget/function/f_sourcesink.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/usb/gadget/function/f_sourcesink.c b/drivers/usb/gadget/function/f_sourcesink.c
> index 1abf08e..0a423ba 100644
> --- a/drivers/usb/gadget/function/f_sourcesink.c
> +++ b/drivers/usb/gadget/function/f_sourcesink.c
> @@ -584,6 +584,8 @@ static int source_sink_start_ep(struct f_sourcesink *ss, bool is_in,
>
> if (is_iso) {
> switch (speed) {
> + case USB_SPEED_SUPER_PLUS:
> + fallthrough;
There's no need for this "fallthough" line. You're allowed to have
multiple case labels for a single block of code.
Alan Stern
> case USB_SPEED_SUPER:
> size = ss->isoc_maxpacket *
> (ss->isoc_mult + 1) *
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] usb: gadget: f_sourcesink: Fix isoc transfer for USB_SPEED_SUPER_PLUS
2022-01-21 15:09 ` Alan Stern
@ 2022-01-22 2:54 ` Pavan Kondeti
0 siblings, 0 replies; 5+ messages in thread
From: Pavan Kondeti @ 2022-01-22 2:54 UTC (permalink / raw)
To: Alan Stern
Cc: Pavankumar Kondeti, Felipe Balbi, Greg Kroah-Hartman, linux-usb,
linux-kernel
Hi Alan,
On Fri, Jan 21, 2022 at 10:09:00AM -0500, Alan Stern wrote:
> On Fri, Jan 21, 2022 at 05:01:24PM +0530, Pavankumar Kondeti wrote:
> > Currently when gadget enumerates in super speed plus, the isoc
> > endpoint request buffer size is not calculated correctly. Fix
> > this by checking the gadget speed against USB_SPEED_SUPER_PLUS
> > and update the request buffer size.
> >
> > Signed-off-by: Pavankumar Kondeti <quic_pkondeti@quicinc.com>
> > ---
> > drivers/usb/gadget/function/f_sourcesink.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/usb/gadget/function/f_sourcesink.c b/drivers/usb/gadget/function/f_sourcesink.c
> > index 1abf08e..0a423ba 100644
> > --- a/drivers/usb/gadget/function/f_sourcesink.c
> > +++ b/drivers/usb/gadget/function/f_sourcesink.c
> > @@ -584,6 +584,8 @@ static int source_sink_start_ep(struct f_sourcesink *ss, bool is_in,
> >
> > if (is_iso) {
> > switch (speed) {
> > + case USB_SPEED_SUPER_PLUS:
> > + fallthrough;
>
> There's no need for this "fallthough" line. You're allowed to have
> multiple case labels for a single block of code.
>
Thanks for the review. I will incorporate your suggestion in v2.
Thanks,
Pavan
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] usb: gadget: f_sourcesink: Fix isoc transfer for USB_SPEED_SUPER_PLUS
2022-01-21 14:31 ` Greg Kroah-Hartman
@ 2022-01-22 2:56 ` Pavan Kondeti
0 siblings, 0 replies; 5+ messages in thread
From: Pavan Kondeti @ 2022-01-22 2:56 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Pavankumar Kondeti, Felipe Balbi, linux-usb, linux-kernel
Hi Greg,
On Fri, Jan 21, 2022 at 03:31:12PM +0100, Greg Kroah-Hartman wrote:
> On Fri, Jan 21, 2022 at 05:01:24PM +0530, Pavankumar Kondeti wrote:
> > Currently when gadget enumerates in super speed plus, the isoc
> > endpoint request buffer size is not calculated correctly. Fix
> > this by checking the gadget speed against USB_SPEED_SUPER_PLUS
> > and update the request buffer size.
> >
> > Signed-off-by: Pavankumar Kondeti <quic_pkondeti@quicinc.com>
>
> What commit id does this fix?
>
I see that the issue is present since the super speed plus support
is added to this driver. I will add the below commit in the Fixes
tag and send the v2.
commit 90c4d05780d47e14a50e11a7f17373104cd47d25
Author: Maciej Żenczykowski <maze@google.com>
Date: Mon Jun 7 21:41:41 2021 -0700
usb: fix various gadgets null ptr deref on 10gbps cabling.
This avoids a null pointer dereference in
f_{ecm,eem,hid,loopback,printer,rndis,serial,sourcesink,subset,tcm}
by simply reusing the 5gbps config for 10gbps.
Thanks,
Pavan
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-01-22 2:56 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-21 11:31 [PATCH] usb: gadget: f_sourcesink: Fix isoc transfer for USB_SPEED_SUPER_PLUS Pavankumar Kondeti
2022-01-21 14:31 ` Greg Kroah-Hartman
2022-01-22 2:56 ` Pavan Kondeti
2022-01-21 15:09 ` Alan Stern
2022-01-22 2:54 ` Pavan Kondeti
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.