* [PATCH] arm64: Mark start_backtrace() notrace and NOKPROBE_SYMBOL
@ 2022-01-24 8:17 ` Masami Hiramatsu
0 siblings, 0 replies; 6+ messages in thread
From: Masami Hiramatsu @ 2022-01-24 8:17 UTC (permalink / raw)
To: linux-arm-kernel
Cc: Masami Hiramatsu, linux-kernel, Catalin Marinas, Will Deacon,
Mark Brown, Steven Rostedt, stable
Mark the start_backtrace() as notrace and NOKPROBE_SYMBOL
because this function is called from ftrace and lockdep to
get the caller address via return_address(). The lockdep
is used in kprobes, it should also be NOKPROBE_SYMBOL.
Fixes: b07f3499661c ("arm64: stacktrace: Move start_backtrace() out of the header")
Cc: stable@vger.kernel.org
Signed-off-by: Masami Hiramatsu <mhiramat@kernel.org>
---
arch/arm64/kernel/stacktrace.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/arm64/kernel/stacktrace.c b/arch/arm64/kernel/stacktrace.c
index 94f83cd44e50..b0f21677764d 100644
--- a/arch/arm64/kernel/stacktrace.c
+++ b/arch/arm64/kernel/stacktrace.c
@@ -33,7 +33,7 @@
*/
-void start_backtrace(struct stackframe *frame, unsigned long fp,
+void notrace start_backtrace(struct stackframe *frame, unsigned long fp,
unsigned long pc)
{
frame->fp = fp;
@@ -55,6 +55,7 @@ void start_backtrace(struct stackframe *frame, unsigned long fp,
frame->prev_fp = 0;
frame->prev_type = STACK_TYPE_UNKNOWN;
}
+NOKPROBE_SYMBOL(start_backtrace);
/*
* Unwind from one frame record (A) to the next frame record (B).
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] arm64: Mark start_backtrace() notrace and NOKPROBE_SYMBOL
@ 2022-01-24 8:17 ` Masami Hiramatsu
0 siblings, 0 replies; 6+ messages in thread
From: Masami Hiramatsu @ 2022-01-24 8:17 UTC (permalink / raw)
To: linux-arm-kernel
Cc: Masami Hiramatsu, linux-kernel, Catalin Marinas, Will Deacon,
Mark Brown, Steven Rostedt, stable
Mark the start_backtrace() as notrace and NOKPROBE_SYMBOL
because this function is called from ftrace and lockdep to
get the caller address via return_address(). The lockdep
is used in kprobes, it should also be NOKPROBE_SYMBOL.
Fixes: b07f3499661c ("arm64: stacktrace: Move start_backtrace() out of the header")
Cc: stable@vger.kernel.org
Signed-off-by: Masami Hiramatsu <mhiramat@kernel.org>
---
arch/arm64/kernel/stacktrace.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/arm64/kernel/stacktrace.c b/arch/arm64/kernel/stacktrace.c
index 94f83cd44e50..b0f21677764d 100644
--- a/arch/arm64/kernel/stacktrace.c
+++ b/arch/arm64/kernel/stacktrace.c
@@ -33,7 +33,7 @@
*/
-void start_backtrace(struct stackframe *frame, unsigned long fp,
+void notrace start_backtrace(struct stackframe *frame, unsigned long fp,
unsigned long pc)
{
frame->fp = fp;
@@ -55,6 +55,7 @@ void start_backtrace(struct stackframe *frame, unsigned long fp,
frame->prev_fp = 0;
frame->prev_type = STACK_TYPE_UNKNOWN;
}
+NOKPROBE_SYMBOL(start_backtrace);
/*
* Unwind from one frame record (A) to the next frame record (B).
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] arm64: Mark start_backtrace() notrace and NOKPROBE_SYMBOL
2022-01-24 8:17 ` Masami Hiramatsu
@ 2022-01-24 13:05 ` Mark Brown
-1 siblings, 0 replies; 6+ messages in thread
From: Mark Brown @ 2022-01-24 13:05 UTC (permalink / raw)
To: Masami Hiramatsu
Cc: linux-arm-kernel, linux-kernel, Catalin Marinas, Will Deacon,
Steven Rostedt, stable
[-- Attachment #1: Type: text/plain, Size: 348 bytes --]
On Mon, Jan 24, 2022 at 05:17:54PM +0900, Masami Hiramatsu wrote:
> Mark the start_backtrace() as notrace and NOKPROBE_SYMBOL
> because this function is called from ftrace and lockdep to
> get the caller address via return_address(). The lockdep
> is used in kprobes, it should also be NOKPROBE_SYMBOL.
Reviwed-by: Mark Brown <broonie@kernel.org>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] arm64: Mark start_backtrace() notrace and NOKPROBE_SYMBOL
@ 2022-01-24 13:05 ` Mark Brown
0 siblings, 0 replies; 6+ messages in thread
From: Mark Brown @ 2022-01-24 13:05 UTC (permalink / raw)
To: Masami Hiramatsu
Cc: linux-arm-kernel, linux-kernel, Catalin Marinas, Will Deacon,
Steven Rostedt, stable
[-- Attachment #1.1: Type: text/plain, Size: 348 bytes --]
On Mon, Jan 24, 2022 at 05:17:54PM +0900, Masami Hiramatsu wrote:
> Mark the start_backtrace() as notrace and NOKPROBE_SYMBOL
> because this function is called from ftrace and lockdep to
> get the caller address via return_address(). The lockdep
> is used in kprobes, it should also be NOKPROBE_SYMBOL.
Reviwed-by: Mark Brown <broonie@kernel.org>
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] arm64: Mark start_backtrace() notrace and NOKPROBE_SYMBOL
2022-01-24 8:17 ` Masami Hiramatsu
@ 2022-01-24 15:10 ` Catalin Marinas
-1 siblings, 0 replies; 6+ messages in thread
From: Catalin Marinas @ 2022-01-24 15:10 UTC (permalink / raw)
To: linux-arm-kernel, Masami Hiramatsu
Cc: Will Deacon, stable, linux-kernel, Mark Brown, Steven Rostedt
On Mon, 24 Jan 2022 17:17:54 +0900, Masami Hiramatsu wrote:
> Mark the start_backtrace() as notrace and NOKPROBE_SYMBOL
> because this function is called from ftrace and lockdep to
> get the caller address via return_address(). The lockdep
> is used in kprobes, it should also be NOKPROBE_SYMBOL.
Applied to arm64 (for-next/fixes), thanks!
[1/1] arm64: Mark start_backtrace() notrace and NOKPROBE_SYMBOL
https://git.kernel.org/arm64/c/1e0924bd0991
--
Catalin
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] arm64: Mark start_backtrace() notrace and NOKPROBE_SYMBOL
@ 2022-01-24 15:10 ` Catalin Marinas
0 siblings, 0 replies; 6+ messages in thread
From: Catalin Marinas @ 2022-01-24 15:10 UTC (permalink / raw)
To: linux-arm-kernel, Masami Hiramatsu
Cc: Will Deacon, stable, linux-kernel, Mark Brown, Steven Rostedt
On Mon, 24 Jan 2022 17:17:54 +0900, Masami Hiramatsu wrote:
> Mark the start_backtrace() as notrace and NOKPROBE_SYMBOL
> because this function is called from ftrace and lockdep to
> get the caller address via return_address(). The lockdep
> is used in kprobes, it should also be NOKPROBE_SYMBOL.
Applied to arm64 (for-next/fixes), thanks!
[1/1] arm64: Mark start_backtrace() notrace and NOKPROBE_SYMBOL
https://git.kernel.org/arm64/c/1e0924bd0991
--
Catalin
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-01-24 15:11 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-24 8:17 [PATCH] arm64: Mark start_backtrace() notrace and NOKPROBE_SYMBOL Masami Hiramatsu
2022-01-24 8:17 ` Masami Hiramatsu
2022-01-24 13:05 ` Mark Brown
2022-01-24 13:05 ` Mark Brown
2022-01-24 15:10 ` Catalin Marinas
2022-01-24 15:10 ` Catalin Marinas
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.