* [PATCH] wilc1000: use min() to make code cleaner
@ 2021-12-16 9:17 cgel.zte
2021-12-21 18:13 ` Kalle Valo
0 siblings, 1 reply; 4+ messages in thread
From: cgel.zte @ 2021-12-16 9:17 UTC (permalink / raw)
To: ajay.kathat
Cc: claudiu.beznea, kvalo, davem, kuba, linux-wireless, netdev,
linux-kernel, Changcheng Deng, Zeal Robot
From: Changcheng Deng <deng.changcheng@zte.com.cn>
Use min() in order to make code cleaner.
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Changcheng Deng <deng.changcheng@zte.com.cn>
---
drivers/net/wireless/microchip/wilc1000/spi.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/net/wireless/microchip/wilc1000/spi.c b/drivers/net/wireless/microchip/wilc1000/spi.c
index 6e7fd18c14e7..629ba5d7a7df 100644
--- a/drivers/net/wireless/microchip/wilc1000/spi.c
+++ b/drivers/net/wireless/microchip/wilc1000/spi.c
@@ -675,10 +675,7 @@ static int wilc_spi_dma_rw(struct wilc *wilc, u8 cmd, u32 adr, u8 *b, u32 sz)
int nbytes;
u8 rsp;
- if (sz <= DATA_PKT_SZ)
- nbytes = sz;
- else
- nbytes = DATA_PKT_SZ;
+ nbytes = min(sz, DATA_PKT_SZ);
/*
* Data Response header
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] wilc1000: use min() to make code cleaner
2021-12-16 9:17 [PATCH] wilc1000: use min() to make code cleaner cgel.zte
@ 2021-12-21 18:13 ` Kalle Valo
2021-12-22 7:08 ` [PATCH v2] wilc1000: use min_t() " cgel.zte
0 siblings, 1 reply; 4+ messages in thread
From: Kalle Valo @ 2021-12-21 18:13 UTC (permalink / raw)
To: cgel.zte
Cc: ajay.kathat, claudiu.beznea, davem, kuba, linux-wireless, netdev,
linux-kernel, Changcheng Deng, Zeal Robot
cgel.zte@gmail.com wrote:
> From: Changcheng Deng <deng.changcheng@zte.com.cn>
>
> Use min() in order to make code cleaner.
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Changcheng Deng <deng.changcheng@zte.com.cn>
Failed to compile:
In file included from ./include/linux/kernel.h:17,
from ./include/linux/clk.h:13,
from drivers/net/wireless/microchip/wilc1000/spi.c:7:
drivers/net/wireless/microchip/wilc1000/spi.c: In function 'wilc_spi_dma_rw':
./include/linux/minmax.h:20:35: error: comparison of distinct pointer types lacks a cast [-Werror]
20 | (!!(sizeof((typeof(x) *)1 == (typeof(y) *)1)))
| ^~
./include/linux/minmax.h:26:18: note: in expansion of macro '__typecheck'
26 | (__typecheck(x, y) && __no_side_effects(x, y))
| ^~~~~~~~~~~
./include/linux/minmax.h:36:31: note: in expansion of macro '__safe_cmp'
36 | __builtin_choose_expr(__safe_cmp(x, y), \
| ^~~~~~~~~~
./include/linux/minmax.h:45:25: note: in expansion of macro '__careful_cmp'
45 | #define min(x, y) __careful_cmp(x, y, <)
| ^~~~~~~~~~~~~
drivers/net/wireless/microchip/wilc1000/spi.c:677:26: note: in expansion of macro 'min'
677 | nbytes = min(sz, DATA_PKT_SZ);
| ^~~
cc1: all warnings being treated as errors
make[5]: *** [scripts/Makefile.build:287: drivers/net/wireless/microchip/wilc1000/spi.o] Error 1
make[4]: *** [scripts/Makefile.build:549: drivers/net/wireless/microchip/wilc1000] Error 2
make[3]: *** [scripts/Makefile.build:549: drivers/net/wireless/microchip] Error 2
make[2]: *** [scripts/Makefile.build:549: drivers/net/wireless] Error 2
make[1]: *** [scripts/Makefile.build:549: drivers/net] Error 2
make: *** [Makefile:1846: drivers] Error 2
Patch set to Changes Requested.
--
https://patchwork.kernel.org/project/linux-wireless/patch/20211216091713.449841-1-deng.changcheng@zte.com.cn/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH v2] wilc1000: use min_t() to make code cleaner
2021-12-21 18:13 ` Kalle Valo
@ 2021-12-22 7:08 ` cgel.zte
2022-01-31 15:48 ` Kalle Valo
0 siblings, 1 reply; 4+ messages in thread
From: cgel.zte @ 2021-12-22 7:08 UTC (permalink / raw)
To: kvalo
Cc: ajay.kathat, cgel.zte, claudiu.beznea, davem, deng.changcheng,
kuba, linux-kernel, linux-wireless, netdev, zealci
From: Changcheng Deng <deng.changcheng@zte.com.cn>
Use min_t() in order to make code cleaner.
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Changcheng Deng <deng.changcheng@zte.com.cn>
---
drivers/net/wireless/microchip/wilc1000/spi.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/net/wireless/microchip/wilc1000/spi.c b/drivers/net/wireless/microchip/wilc1000/spi.c
index 5ace9e3a56fc..1057573d086b 100644
--- a/drivers/net/wireless/microchip/wilc1000/spi.c
+++ b/drivers/net/wireless/microchip/wilc1000/spi.c
@@ -674,10 +674,7 @@ static int wilc_spi_dma_rw(struct wilc *wilc, u8 cmd, u32 adr, u8 *b, u32 sz)
int nbytes;
u8 rsp;
- if (sz <= DATA_PKT_SZ)
- nbytes = sz;
- else
- nbytes = DATA_PKT_SZ;
+ nbytes = min_t(u32, sz, DATA_PKT_SZ);
/*
* Data Response header
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2] wilc1000: use min_t() to make code cleaner
2021-12-22 7:08 ` [PATCH v2] wilc1000: use min_t() " cgel.zte
@ 2022-01-31 15:48 ` Kalle Valo
0 siblings, 0 replies; 4+ messages in thread
From: Kalle Valo @ 2022-01-31 15:48 UTC (permalink / raw)
To: cgel.zte
Cc: ajay.kathat, cgel.zte, claudiu.beznea, davem, deng.changcheng,
kuba, linux-kernel, linux-wireless, netdev, zealci
cgel.zte@gmail.com wrote:
> From: Changcheng Deng <deng.changcheng@zte.com.cn>
>
> Use min_t() in order to make code cleaner.
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Changcheng Deng <deng.changcheng@zte.com.cn>
Patch applied to wireless-next.git, thanks.
708db268459f wilc1000: use min_t() to make code cleaner
--
https://patchwork.kernel.org/project/linux-wireless/patch/20211222070815.483009-1-deng.changcheng@zte.com.cn/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-01-31 15:48 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-16 9:17 [PATCH] wilc1000: use min() to make code cleaner cgel.zte
2021-12-21 18:13 ` Kalle Valo
2021-12-22 7:08 ` [PATCH v2] wilc1000: use min_t() " cgel.zte
2022-01-31 15:48 ` Kalle Valo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.