All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/2] cifs: Fix the readahead conversion to manage the batch when reading from cache
@ 2022-01-31 17:54 David Howells
  0 siblings, 0 replies; only message in thread
From: David Howells @ 2022-01-31 17:54 UTC (permalink / raw)
  To: smfrench
  Cc: Rohith Surabattula, Shyam Prasad N, Jeff Layton, linux-cifs, dhowells

Fix the readahead conversion to correctly manage the last batch skipping
when reading from cache.  This involves a readahead batch of one page or
one folio, so set the batch size according to the number of constituent
pages (should be 1 for a filesystem that doesn't do multipage folios yet).

Signed-off-by: David Howells <dhowells@redhat.com>
cc: Steve French <smfrench@gmail.com>
cc: Rohith Surabattula <rohiths.msft@gmail.com>
cc: Shyam Prasad N <nspmangalore@gmail.com>
cc: Jeff Layton <jlayton@kernel.org>
cc: linux-cifs@vger.kernel.org
---

 fs/cifs/file.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/cifs/file.c b/fs/cifs/file.c
index 1b41b6f2a04b..e7af802dcfa6 100644
--- a/fs/cifs/file.c
+++ b/fs/cifs/file.c
@@ -4446,7 +4446,7 @@ static void cifs_readahead(struct readahead_control *ractl)
 				 * by the cache.
 				 */
 				page = readahead_page(ractl);
-				BUG_ON(!page);
+				last_batch_size = 1 << thp_order(page);
 				if (cifs_readpage_from_fscache(ractl->mapping->host,
 							       page) < 0) {
 					/*



^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2022-01-31 17:54 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-31 17:54 [PATCH 1/2] cifs: Fix the readahead conversion to manage the batch when reading from cache David Howells

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.