* [PATCH] counter: fix ftm-quaddec build error on UML
@ 2019-06-17 16:21 Randy Dunlap
2019-06-17 19:54 ` Richard Weinberger
0 siblings, 1 reply; 3+ messages in thread
From: Randy Dunlap @ 2019-06-17 16:21 UTC (permalink / raw)
To: LKML, linux-iio
Cc: Geert Uytterhoeven, Kjeld Flarup, Patrick Havelange,
William Breathitt Gray, Richard Weinberger
From: Randy Dunlap <rdunlap@infradead.org>
Fix build error on user-mode Linux, which does not set HAS_IOMEM,
so devm_ioremap() is not available. Fixes this build error:
ERROR: "devm_ioremap" [drivers/counter/ftm-quaddec.ko] undefined!
Fixes: a3b9a99980d9 ("counter: add FlexTimer Module Quadrature decoder counter driver")
Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Kjeld Flarup <kfa@deif.com>
Cc: Patrick Havelange <patrick.havelange@essensium.com>
Cc: William Breathitt Gray <vilhelm.gray@gmail.com>
Cc: linux-iio@vger.kernel.org
---
BTW, please fix these lines to have ending '>' characters:
MODULE_AUTHOR("Kjeld Flarup <kfa@deif.com");
MODULE_AUTHOR("Patrick Havelange <patrick.havelange@essensium.com");
drivers/counter/Kconfig | 1 +
1 file changed, 1 insertion(+)
--- lnx-52-rc5.orig/drivers/counter/Kconfig
+++ lnx-52-rc5/drivers/counter/Kconfig
@@ -51,6 +51,7 @@ config STM32_LPTIMER_CNT
config FTM_QUADDEC
tristate "Flex Timer Module Quadrature decoder driver"
+ depends on HAS_IOMEM
help
Select this option to enable the Flex Timer Quadrature decoder
driver.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] counter: fix ftm-quaddec build error on UML
2019-06-17 16:21 [PATCH] counter: fix ftm-quaddec build error on UML Randy Dunlap
@ 2019-06-17 19:54 ` Richard Weinberger
2019-06-18 5:21 ` William Breathitt Gray
0 siblings, 1 reply; 3+ messages in thread
From: Richard Weinberger @ 2019-06-17 19:54 UTC (permalink / raw)
To: Randy Dunlap
Cc: linux-kernel, linux-iio, Geert Uytterhoeven, Kjeld Flarup,
Patrick Havelange, William Breathitt Gray
Hi!
----- Ursprüngliche Mail -----
> Von: "Randy Dunlap" <rdunlap@infradead.org>
> An: "linux-kernel" <linux-kernel@vger.kernel.org>, linux-iio@vger.kernel.org
> CC: "Geert Uytterhoeven" <geert@linux-m68k.org>, "Kjeld Flarup" <kfa@deif.com>, "Patrick Havelange"
> <patrick.havelange@essensium.com>, "William Breathitt Gray" <vilhelm.gray@gmail.com>, "richard" <richard@nod.at>
> Gesendet: Montag, 17. Juni 2019 18:21:40
> Betreff: [PATCH] counter: fix ftm-quaddec build error on UML
> From: Randy Dunlap <rdunlap@infradead.org>
>
> Fix build error on user-mode Linux, which does not set HAS_IOMEM,
> so devm_ioremap() is not available. Fixes this build error:
>
> ERROR: "devm_ioremap" [drivers/counter/ftm-quaddec.ko] undefined!
>
> Fixes: a3b9a99980d9 ("counter: add FlexTimer Module Quadrature decoder counter
> driver")
>
> Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
AFAICT Patrick fixed this already.
Thanks,
//richard
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] counter: fix ftm-quaddec build error on UML
2019-06-17 19:54 ` Richard Weinberger
@ 2019-06-18 5:21 ` William Breathitt Gray
0 siblings, 0 replies; 3+ messages in thread
From: William Breathitt Gray @ 2019-06-18 5:21 UTC (permalink / raw)
To: Richard Weinberger
Cc: Randy Dunlap, linux-kernel, linux-iio, Geert Uytterhoeven,
Kjeld Flarup, Patrick Havelange
On Mon, Jun 17, 2019 at 09:54:45PM +0200, Richard Weinberger wrote:
> Hi!
>
> ----- Ursprüngliche Mail -----
> > Von: "Randy Dunlap" <rdunlap@infradead.org>
> > An: "linux-kernel" <linux-kernel@vger.kernel.org>, linux-iio@vger.kernel.org
> > CC: "Geert Uytterhoeven" <geert@linux-m68k.org>, "Kjeld Flarup" <kfa@deif.com>, "Patrick Havelange"
> > <patrick.havelange@essensium.com>, "William Breathitt Gray" <vilhelm.gray@gmail.com>, "richard" <richard@nod.at>
> > Gesendet: Montag, 17. Juni 2019 18:21:40
> > Betreff: [PATCH] counter: fix ftm-quaddec build error on UML
>
> > From: Randy Dunlap <rdunlap@infradead.org>
> >
> > Fix build error on user-mode Linux, which does not set HAS_IOMEM,
> > so devm_ioremap() is not available. Fixes this build error:
> >
> > ERROR: "devm_ioremap" [drivers/counter/ftm-quaddec.ko] undefined!
> >
> > Fixes: a3b9a99980d9 ("counter: add FlexTimer Module Quadrature decoder counter
> > driver")
> >
> > Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
> > Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
>
> AFAICT Patrick fixed this already.
>
> Thanks,
> //richard
Yes, commit 0c75376fa395 ("counter/ftm-quaddec: Add missing dependencies
in Kconfig") in Greg KH's staging repository in the staging-linus
branch should address this issue.
William Breathitt Gray
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-06-18 7:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-17 16:21 [PATCH] counter: fix ftm-quaddec build error on UML Randy Dunlap
2019-06-17 19:54 ` Richard Weinberger
2019-06-18 5:21 ` William Breathitt Gray
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.