* [PATCH V5] mtd: spi-nor: winbond: Add support for winbond chip
@ 2022-02-08 19:58 ` Shaik Sajida Bhanu
0 siblings, 0 replies; 6+ messages in thread
From: Shaik Sajida Bhanu @ 2022-02-08 19:58 UTC (permalink / raw)
To: dianders, tudor.ambarus, michael, p.yadav, miquel.raynal,
richard, vigneshr, linux-mtd, linux-kernel
Cc: quic_stummala, quic_vbadigan, quic_rampraka, quic_pragalla,
quic_sartgarg, Shaik Sajida Bhanu
Add support for winbond W25Q512NW-IM chip.
Signed-off-by: Shaik Sajida Bhanu <quic_c_sbhanu@quicinc.com>
Reviewed-by: Doug Anderson <dianders@chromium.org>
---
Changes since V1:
- Added space before name of the flash part as suggested by Doug.
Changes since V2:
- Updated chip name as w25q512nwm as suggested by Doug.
Changes since V3:
- Updated flash_info flags passing according to below patch.
Changes since V4:
- Added OTP support for SPI card as suggested by Michael Walle.
- Updated SFDP flags passing as suggested by Pratyush Yadav.
---
drivers/mtd/spi-nor/winbond.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/mtd/spi-nor/winbond.c b/drivers/mtd/spi-nor/winbond.c
index 675f32c..315b9f6 100644
--- a/drivers/mtd/spi-nor/winbond.c
+++ b/drivers/mtd/spi-nor/winbond.c
@@ -124,6 +124,10 @@ static const struct flash_info winbond_parts[] = {
{ "w25m512jv", INFO(0xef7119, 0, 64 * 1024, 1024)
NO_SFDP_FLAGS(SECT_4K | SPI_NOR_QUAD_READ |
SPI_NOR_DUAL_READ) },
+ { "w25q512nwm", INFO(0xef8020, 0, 64 * 1024, 1024)
+ FLAGS(SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB)
+ PARSE_SFDP
+ OTP_INFO(256, 3, 0x1000, 0x1000) },
{ "w25q512jvq", INFO(0xef4020, 0, 64 * 1024, 1024)
NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ |
SPI_NOR_QUAD_READ) },
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH V5] mtd: spi-nor: winbond: Add support for winbond chip
@ 2022-02-08 19:58 ` Shaik Sajida Bhanu
0 siblings, 0 replies; 6+ messages in thread
From: Shaik Sajida Bhanu @ 2022-02-08 19:58 UTC (permalink / raw)
To: dianders, tudor.ambarus, michael, p.yadav, miquel.raynal,
richard, vigneshr, linux-mtd, linux-kernel
Cc: quic_stummala, quic_vbadigan, quic_rampraka, quic_pragalla,
quic_sartgarg, Shaik Sajida Bhanu
Add support for winbond W25Q512NW-IM chip.
Signed-off-by: Shaik Sajida Bhanu <quic_c_sbhanu@quicinc.com>
Reviewed-by: Doug Anderson <dianders@chromium.org>
---
Changes since V1:
- Added space before name of the flash part as suggested by Doug.
Changes since V2:
- Updated chip name as w25q512nwm as suggested by Doug.
Changes since V3:
- Updated flash_info flags passing according to below patch.
Changes since V4:
- Added OTP support for SPI card as suggested by Michael Walle.
- Updated SFDP flags passing as suggested by Pratyush Yadav.
---
drivers/mtd/spi-nor/winbond.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/mtd/spi-nor/winbond.c b/drivers/mtd/spi-nor/winbond.c
index 675f32c..315b9f6 100644
--- a/drivers/mtd/spi-nor/winbond.c
+++ b/drivers/mtd/spi-nor/winbond.c
@@ -124,6 +124,10 @@ static const struct flash_info winbond_parts[] = {
{ "w25m512jv", INFO(0xef7119, 0, 64 * 1024, 1024)
NO_SFDP_FLAGS(SECT_4K | SPI_NOR_QUAD_READ |
SPI_NOR_DUAL_READ) },
+ { "w25q512nwm", INFO(0xef8020, 0, 64 * 1024, 1024)
+ FLAGS(SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB)
+ PARSE_SFDP
+ OTP_INFO(256, 3, 0x1000, 0x1000) },
{ "w25q512jvq", INFO(0xef4020, 0, 64 * 1024, 1024)
NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ |
SPI_NOR_QUAD_READ) },
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH V5] mtd: spi-nor: winbond: Add support for winbond chip
2022-02-08 19:58 ` Shaik Sajida Bhanu
@ 2022-02-09 8:30 ` Michael Walle
-1 siblings, 0 replies; 6+ messages in thread
From: Michael Walle @ 2022-02-09 8:30 UTC (permalink / raw)
To: Shaik Sajida Bhanu
Cc: dianders, tudor.ambarus, p.yadav, miquel.raynal, richard,
vigneshr, linux-mtd, linux-kernel, quic_stummala, quic_vbadigan,
quic_rampraka, quic_pragalla, quic_sartgarg
Hi,
Am 2022-02-08 20:58, schrieb Shaik Sajida Bhanu:
> Add support for winbond W25Q512NW-IM chip.
Also please include that in the subject. Eg.
mtd: spi-nor: winbond: add support for W25Q512NW-IM
>
> Signed-off-by: Shaik Sajida Bhanu <quic_c_sbhanu@quicinc.com>
> Reviewed-by: Doug Anderson <dianders@chromium.org>
> ---
> Changes since V1:
> - Added space before name of the flash part as suggested by Doug.
>
> Changes since V2:
> - Updated chip name as w25q512nwm as suggested by Doug.
>
> Changes since V3:
> - Updated flash_info flags passing according to below patch.
>
> Changes since V4:
> - Added OTP support for SPI card as suggested by Michael Walle.
> - Updated SFDP flags passing as suggested by Pratyush Yadav.
> ---
> drivers/mtd/spi-nor/winbond.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/mtd/spi-nor/winbond.c
> b/drivers/mtd/spi-nor/winbond.c
> index 675f32c..315b9f6 100644
> --- a/drivers/mtd/spi-nor/winbond.c
> +++ b/drivers/mtd/spi-nor/winbond.c
> @@ -124,6 +124,10 @@ static const struct flash_info winbond_parts[] = {
> { "w25m512jv", INFO(0xef7119, 0, 64 * 1024, 1024)
> NO_SFDP_FLAGS(SECT_4K | SPI_NOR_QUAD_READ |
> SPI_NOR_DUAL_READ) },
> + { "w25q512nwm", INFO(0xef8020, 0, 64 * 1024, 1024)
> + FLAGS(SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB)
> + PARSE_SFDP
This usually goes first, eg.
PARSE_SFDP
FLAGS(SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB)
OTP_INFO(256, 3, 0x1000, 0x1000)
> + OTP_INFO(256, 3, 0x1000, 0x1000) },
> { "w25q512jvq", INFO(0xef4020, 0, 64 * 1024, 1024)
> NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ |
> SPI_NOR_QUAD_READ) },
Otherwise the SFDP dump is still missing as requested in my
comment in v4. Please make sure you put it in the comment
section of the patch, that is under the "---" line.
Then I think, this patch is good.
-michael
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH V5] mtd: spi-nor: winbond: Add support for winbond chip
@ 2022-02-09 8:30 ` Michael Walle
0 siblings, 0 replies; 6+ messages in thread
From: Michael Walle @ 2022-02-09 8:30 UTC (permalink / raw)
To: Shaik Sajida Bhanu
Cc: dianders, tudor.ambarus, p.yadav, miquel.raynal, richard,
vigneshr, linux-mtd, linux-kernel, quic_stummala, quic_vbadigan,
quic_rampraka, quic_pragalla, quic_sartgarg
Hi,
Am 2022-02-08 20:58, schrieb Shaik Sajida Bhanu:
> Add support for winbond W25Q512NW-IM chip.
Also please include that in the subject. Eg.
mtd: spi-nor: winbond: add support for W25Q512NW-IM
>
> Signed-off-by: Shaik Sajida Bhanu <quic_c_sbhanu@quicinc.com>
> Reviewed-by: Doug Anderson <dianders@chromium.org>
> ---
> Changes since V1:
> - Added space before name of the flash part as suggested by Doug.
>
> Changes since V2:
> - Updated chip name as w25q512nwm as suggested by Doug.
>
> Changes since V3:
> - Updated flash_info flags passing according to below patch.
>
> Changes since V4:
> - Added OTP support for SPI card as suggested by Michael Walle.
> - Updated SFDP flags passing as suggested by Pratyush Yadav.
> ---
> drivers/mtd/spi-nor/winbond.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/mtd/spi-nor/winbond.c
> b/drivers/mtd/spi-nor/winbond.c
> index 675f32c..315b9f6 100644
> --- a/drivers/mtd/spi-nor/winbond.c
> +++ b/drivers/mtd/spi-nor/winbond.c
> @@ -124,6 +124,10 @@ static const struct flash_info winbond_parts[] = {
> { "w25m512jv", INFO(0xef7119, 0, 64 * 1024, 1024)
> NO_SFDP_FLAGS(SECT_4K | SPI_NOR_QUAD_READ |
> SPI_NOR_DUAL_READ) },
> + { "w25q512nwm", INFO(0xef8020, 0, 64 * 1024, 1024)
> + FLAGS(SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB)
> + PARSE_SFDP
This usually goes first, eg.
PARSE_SFDP
FLAGS(SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB)
OTP_INFO(256, 3, 0x1000, 0x1000)
> + OTP_INFO(256, 3, 0x1000, 0x1000) },
> { "w25q512jvq", INFO(0xef4020, 0, 64 * 1024, 1024)
> NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ |
> SPI_NOR_QUAD_READ) },
Otherwise the SFDP dump is still missing as requested in my
comment in v4. Please make sure you put it in the comment
section of the patch, that is under the "---" line.
Then I think, this patch is good.
-michael
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH V5] mtd: spi-nor: winbond: Add support for winbond chip
2022-02-09 8:30 ` Michael Walle
@ 2022-02-09 10:23 ` Sajida Bhanu (Temp) (QUIC)
-1 siblings, 0 replies; 6+ messages in thread
From: Sajida Bhanu (Temp) (QUIC) @ 2022-02-09 10:23 UTC (permalink / raw)
To: Michael Walle, Sajida Bhanu (Temp) (QUIC)
Cc: dianders, tudor.ambarus, p.yadav, miquel.raynal, richard,
vigneshr, linux-mtd, linux-kernel, Sahitya Tummala (QUIC),
Veerabhadrarao Badiganti (QUIC), Ram Prakash Gupta (QUIC),
Pradeep Pragallapati (QUIC), Sarthak Garg (QUIC)
Hi,
Thanks for the review.
Please find the inline comments.
Thanks,
Sajida
-----Original Message-----
From: Michael Walle <michael@walle.cc>
Sent: Wednesday, February 9, 2022 2:01 PM
To: Sajida Bhanu (Temp) (QUIC) <quic_c_sbhanu@quicinc.com>
Cc: dianders@chromium.org; tudor.ambarus@microchip.com; p.yadav@ti.com; miquel.raynal@bootlin.com; richard@nod.at; vigneshr@ti.com; linux-mtd@lists.infradead.org; linux-kernel@vger.kernel.org; Sahitya Tummala (QUIC) <quic_stummala@quicinc.com>; Veerabhadrarao Badiganti (QUIC) <quic_vbadigan@quicinc.com>; Ram Prakash Gupta (QUIC) <quic_rampraka@quicinc.com>; Pradeep Pragallapati (QUIC) <quic_pragalla@quicinc.com>; Sarthak Garg (QUIC) <quic_sartgarg@quicinc.com>
Subject: Re: [PATCH V5] mtd: spi-nor: winbond: Add support for winbond chip
Hi,
Am 2022-02-08 20:58, schrieb Shaik Sajida Bhanu:
> Add support for winbond W25Q512NW-IM chip.
Also please include that in the subject. Eg.
mtd: spi-nor: winbond: add support for W25Q512NW-IM
>
> Signed-off-by: Shaik Sajida Bhanu <quic_c_sbhanu@quicinc.com>
> Reviewed-by: Doug Anderson <dianders@chromium.org>
> ---
> Changes since V1:
> - Added space before name of the flash part as suggested by Doug.
>
> Changes since V2:
> - Updated chip name as w25q512nwm as suggested by Doug.
>
> Changes since V3:
> - Updated flash_info flags passing according to below patch.
>
> Changes since V4:
> - Added OTP support for SPI card as suggested by Michael Walle.
> - Updated SFDP flags passing as suggested by Pratyush Yadav.
> ---
> drivers/mtd/spi-nor/winbond.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/mtd/spi-nor/winbond.c
> b/drivers/mtd/spi-nor/winbond.c index 675f32c..315b9f6 100644
> --- a/drivers/mtd/spi-nor/winbond.c
> +++ b/drivers/mtd/spi-nor/winbond.c
> @@ -124,6 +124,10 @@ static const struct flash_info winbond_parts[] = {
> { "w25m512jv", INFO(0xef7119, 0, 64 * 1024, 1024)
> NO_SFDP_FLAGS(SECT_4K | SPI_NOR_QUAD_READ |
> SPI_NOR_DUAL_READ) },
> + { "w25q512nwm", INFO(0xef8020, 0, 64 * 1024, 1024)
> + FLAGS(SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB)
> + PARSE_SFDP
This usually goes first, eg.
PARSE_SFDP
FLAGS(SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB) OTP_INFO(256, 3, 0x1000, 0x1000)
>>>> Sure will update.
> + OTP_INFO(256, 3, 0x1000, 0x1000) },
> { "w25q512jvq", INFO(0xef4020, 0, 64 * 1024, 1024)
> NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ |
> SPI_NOR_QUAD_READ) },
Otherwise the SFDP dump is still missing as requested in my comment in v4. Please make sure you put it in the comment section of the patch, that is under the "---" line.
Then I think, this patch is good.
>>>>> Sure will add SFDP dump.
-michael
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH V5] mtd: spi-nor: winbond: Add support for winbond chip
@ 2022-02-09 10:23 ` Sajida Bhanu (Temp) (QUIC)
0 siblings, 0 replies; 6+ messages in thread
From: Sajida Bhanu (Temp) (QUIC) @ 2022-02-09 10:23 UTC (permalink / raw)
To: Michael Walle, Sajida Bhanu (Temp) (QUIC)
Cc: dianders, tudor.ambarus, p.yadav, miquel.raynal, richard,
vigneshr, linux-mtd, linux-kernel, Sahitya Tummala (QUIC),
Veerabhadrarao Badiganti (QUIC), Ram Prakash Gupta (QUIC),
Pradeep Pragallapati (QUIC), Sarthak Garg (QUIC)
Hi,
Thanks for the review.
Please find the inline comments.
Thanks,
Sajida
-----Original Message-----
From: Michael Walle <michael@walle.cc>
Sent: Wednesday, February 9, 2022 2:01 PM
To: Sajida Bhanu (Temp) (QUIC) <quic_c_sbhanu@quicinc.com>
Cc: dianders@chromium.org; tudor.ambarus@microchip.com; p.yadav@ti.com; miquel.raynal@bootlin.com; richard@nod.at; vigneshr@ti.com; linux-mtd@lists.infradead.org; linux-kernel@vger.kernel.org; Sahitya Tummala (QUIC) <quic_stummala@quicinc.com>; Veerabhadrarao Badiganti (QUIC) <quic_vbadigan@quicinc.com>; Ram Prakash Gupta (QUIC) <quic_rampraka@quicinc.com>; Pradeep Pragallapati (QUIC) <quic_pragalla@quicinc.com>; Sarthak Garg (QUIC) <quic_sartgarg@quicinc.com>
Subject: Re: [PATCH V5] mtd: spi-nor: winbond: Add support for winbond chip
Hi,
Am 2022-02-08 20:58, schrieb Shaik Sajida Bhanu:
> Add support for winbond W25Q512NW-IM chip.
Also please include that in the subject. Eg.
mtd: spi-nor: winbond: add support for W25Q512NW-IM
>
> Signed-off-by: Shaik Sajida Bhanu <quic_c_sbhanu@quicinc.com>
> Reviewed-by: Doug Anderson <dianders@chromium.org>
> ---
> Changes since V1:
> - Added space before name of the flash part as suggested by Doug.
>
> Changes since V2:
> - Updated chip name as w25q512nwm as suggested by Doug.
>
> Changes since V3:
> - Updated flash_info flags passing according to below patch.
>
> Changes since V4:
> - Added OTP support for SPI card as suggested by Michael Walle.
> - Updated SFDP flags passing as suggested by Pratyush Yadav.
> ---
> drivers/mtd/spi-nor/winbond.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/mtd/spi-nor/winbond.c
> b/drivers/mtd/spi-nor/winbond.c index 675f32c..315b9f6 100644
> --- a/drivers/mtd/spi-nor/winbond.c
> +++ b/drivers/mtd/spi-nor/winbond.c
> @@ -124,6 +124,10 @@ static const struct flash_info winbond_parts[] = {
> { "w25m512jv", INFO(0xef7119, 0, 64 * 1024, 1024)
> NO_SFDP_FLAGS(SECT_4K | SPI_NOR_QUAD_READ |
> SPI_NOR_DUAL_READ) },
> + { "w25q512nwm", INFO(0xef8020, 0, 64 * 1024, 1024)
> + FLAGS(SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB)
> + PARSE_SFDP
This usually goes first, eg.
PARSE_SFDP
FLAGS(SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB) OTP_INFO(256, 3, 0x1000, 0x1000)
>>>> Sure will update.
> + OTP_INFO(256, 3, 0x1000, 0x1000) },
> { "w25q512jvq", INFO(0xef4020, 0, 64 * 1024, 1024)
> NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ |
> SPI_NOR_QUAD_READ) },
Otherwise the SFDP dump is still missing as requested in my comment in v4. Please make sure you put it in the comment section of the patch, that is under the "---" line.
Then I think, this patch is good.
>>>>> Sure will add SFDP dump.
-michael
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-02-09 10:34 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-08 19:58 [PATCH V5] mtd: spi-nor: winbond: Add support for winbond chip Shaik Sajida Bhanu
2022-02-08 19:58 ` Shaik Sajida Bhanu
2022-02-09 8:30 ` Michael Walle
2022-02-09 8:30 ` Michael Walle
2022-02-09 10:23 ` Sajida Bhanu (Temp) (QUIC)
2022-02-09 10:23 ` Sajida Bhanu (Temp) (QUIC)
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.