RE: [PATCH][sata_fsl] Defer non-ncq commands when ncq commands active - Kalra Ashish-B00888

From: "Kalra Ashish-B00888" <ashish.kalra@freescale.com>
To: Robert Hancock <hancockrwd@gmail.com>
Cc: linux-ide@vger.kernel.org, linuxppc-dev@ozlabs.org
Subject: RE: [PATCH][sata_fsl] Defer non-ncq commands when ncq commands active
Date: Thu, 30 Jul 2009 18:53:17 +0530	[thread overview]
Message-ID: <16444A0F3094A24C83EAB7836A12C63B032E5A@zin33exm20.fsl.freescale.net> (raw)
In-Reply-To: 4A70A78D.7070601@gmail.com

[-- Attachment #1.1: Type: text/plain, Size: 1012 bytes --]

Hello, 

>> Signed-off-by: Ashish Kalra <Ashish.Kalra@freescale.com>
>> ---
>> drivers/ata/sata_fsl.c | 1 +
>> 1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/drivers/ata/sata_fsl.c b/drivers/ata/sata_fsl.c
>> index 5a88b44..a33f130 100644
>> --- a/drivers/ata/sata_fsl.c
>> +++ b/drivers/ata/sata_fsl.c
>> @@ -1262,6 +1262,7 @@ static struct scsi_host_template sata_fsl_sht = {
>> static struct ata_port_operations sata_fsl_ops = {
>> .inherits = &sata_pmp_port_ops,
>>
>> + .qc_defer = ata_std_qc_defer;
>> .qc_prep = sata_fsl_qc_prep,
>> .qc_issue = sata_fsl_qc_issue,
>> .qc_fill_rtf = sata_fsl_qc_fill_rtf,

> This doesn't look like it should change anything. sata_fsl_ops inherits
> from sata_pmp_port_ops, which inherits from sata_port_ops, which already
> sets qc_defer to ata_std_qc_defer.

Oh, yes. Actually this patch was for older kernels where there inheritence was not there. As you mentioned, this patch is not required now.

Thanks,

Ashish

[-- Attachment #1.2: Type: text/html, Size: 1698 bytes --]

[-- Attachment #2: Type: text/plain, Size: 150 bytes --]

_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev