All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Stephen Boyd <swboyd@chromium.org>,
	Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc: alsa-devel@alsa-project.org, linux-arm-msm@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Srinivasa Rao Mandadapu <srivasam@codeaurora.org>
Subject: Re: [PATCH] ASoC: qcom: Actually clear DMA interrupt register for HDMI
Date: Thu, 10 Feb 2022 13:38:12 +0000	[thread overview]
Message-ID: <164450029256.1000223.6826935774856204278.b4-ty@kernel.org> (raw)
In-Reply-To: <20220209232520.4017634-1-swboyd@chromium.org>

On Wed, 9 Feb 2022 15:25:20 -0800, Stephen Boyd wrote:
> In commit da0363f7bfd3 ("ASoC: qcom: Fix for DMA interrupt clear reg
> overwriting") we changed regmap_write() to regmap_update_bits() so that
> we can avoid overwriting bits that we didn't intend to modify.
> Unfortunately this change breaks the case where a register is writable
> but not readable, which is exactly how the HDMI irq clear register is
> designed (grep around LPASS_HDMITX_APP_IRQCLEAR_REG to see how it's
> write only). That's because regmap_update_bits() tries to read the
> register from the hardware and if it isn't readable it looks in the
> regmap cache to see what was written there last time to compare against
> what we want to write there. Eventually, we're unable to modify this
> register at all because the bits that we're trying to set are already
> set in the cache.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-linus

Thanks!

[1/1] ASoC: qcom: Actually clear DMA interrupt register for HDMI
      commit: c8d251f51ee61df06ee0e419348d8c9160bbfb86

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Stephen Boyd <swboyd@chromium.org>,
	Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc: linux-arm-msm@vger.kernel.org, alsa-devel@alsa-project.org,
	Srinivasa Rao Mandadapu <srivasam@codeaurora.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: qcom: Actually clear DMA interrupt register for HDMI
Date: Thu, 10 Feb 2022 13:38:12 +0000	[thread overview]
Message-ID: <164450029256.1000223.6826935774856204278.b4-ty@kernel.org> (raw)
In-Reply-To: <20220209232520.4017634-1-swboyd@chromium.org>

On Wed, 9 Feb 2022 15:25:20 -0800, Stephen Boyd wrote:
> In commit da0363f7bfd3 ("ASoC: qcom: Fix for DMA interrupt clear reg
> overwriting") we changed regmap_write() to regmap_update_bits() so that
> we can avoid overwriting bits that we didn't intend to modify.
> Unfortunately this change breaks the case where a register is writable
> but not readable, which is exactly how the HDMI irq clear register is
> designed (grep around LPASS_HDMITX_APP_IRQCLEAR_REG to see how it's
> write only). That's because regmap_update_bits() tries to read the
> register from the hardware and if it isn't readable it looks in the
> regmap cache to see what was written there last time to compare against
> what we want to write there. Eventually, we're unable to modify this
> register at all because the bits that we're trying to set are already
> set in the cache.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-linus

Thanks!

[1/1] ASoC: qcom: Actually clear DMA interrupt register for HDMI
      commit: c8d251f51ee61df06ee0e419348d8c9160bbfb86

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

  reply	other threads:[~2022-02-10 13:38 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-09 23:25 [PATCH] ASoC: qcom: Actually clear DMA interrupt register for HDMI Stephen Boyd
2022-02-09 23:25 ` Stephen Boyd
2022-02-10 13:38 ` Mark Brown [this message]
2022-02-10 13:38   ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=164450029256.1000223.6826935774856204278.b4-ty@kernel.org \
    --to=broonie@kernel.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=srinivas.kandagatla@linaro.org \
    --cc=srivasam@codeaurora.org \
    --cc=swboyd@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.