* [PATCH v4] Bluetooth: btusb: Improve stability for QCA devices
@ 2022-02-14 10:43 Zijun Hu
2022-02-14 12:00 ` [v4] " bluez.test.bot
2022-02-14 14:16 ` [PATCH v4] " Marcel Holtmann
0 siblings, 2 replies; 3+ messages in thread
From: Zijun Hu @ 2022-02-14 10:43 UTC (permalink / raw)
To: marcel, johan.hedberg, luiz.dentz
Cc: linux-kernel, linux-bluetooth, linux-arm-msm, c-hbandi, hemantg,
rjliao, zijuhu, tjiang, Zijun Hu
From: Zijun Hu <quic_zijuhu@quicinc.com>
WCN6855 2.1 will reset to apply firmware downloaded, so wait
a moment for reset done then go ahead to improve stability.
Signed-off-by: Zijun Hu <quic_zijuhu@quicinc.com>
---
drivers/bluetooth/btusb.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
index ef5d52f0e123..9e0d59d4382a 100644
--- a/drivers/bluetooth/btusb.c
+++ b/drivers/bluetooth/btusb.c
@@ -2999,6 +2999,7 @@ static int btusb_set_bdaddr_wcn6855(struct hci_dev *hdev,
#define QCA_PATCH_UPDATED 0x80
#define QCA_DFU_TIMEOUT 3000
#define QCA_FLAG_MULTI_NVM 0x80
+#define QCA_BT_RESET_WAIT_MS 100
#define WCN6855_2_0_RAM_VERSION_GF 0x400c1200
#define WCN6855_2_1_RAM_VERSION_GF 0x400c1211
@@ -3325,6 +3326,13 @@ static int btusb_setup_qca(struct hci_dev *hdev)
err = btusb_setup_qca_load_nvm(hdev, &ver, info);
if (err < 0)
return err;
+
+ /* WCN6855 2.1 will reset to apply firmware downloaded here, so
+ * wait ~100ms for reset Done then go ahead, otherwise, it maybe
+ * cause potential enable failure.
+ */
+ if (info->rom_version == 0x00130201)
+ msleep(QCA_BT_RESET_WAIT_MS);
}
return 0;
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [v4] Bluetooth: btusb: Improve stability for QCA devices
2022-02-14 10:43 [PATCH v4] Bluetooth: btusb: Improve stability for QCA devices Zijun Hu
@ 2022-02-14 12:00 ` bluez.test.bot
2022-02-14 14:16 ` [PATCH v4] " Marcel Holtmann
1 sibling, 0 replies; 3+ messages in thread
From: bluez.test.bot @ 2022-02-14 12:00 UTC (permalink / raw)
To: linux-bluetooth, zijuhu
[-- Attachment #1: Type: text/plain, Size: 1097 bytes --]
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=614068
---Test result---
Test Summary:
CheckPatch PASS 1.61 seconds
GitLint PASS 1.05 seconds
SubjectPrefix PASS 0.88 seconds
BuildKernel PASS 36.37 seconds
BuildKernel32 PASS 31.22 seconds
Incremental Build with patchesPASS 43.51 seconds
TestRunner: Setup PASS 554.81 seconds
TestRunner: l2cap-tester PASS 15.77 seconds
TestRunner: bnep-tester PASS 7.42 seconds
TestRunner: mgmt-tester PASS 118.55 seconds
TestRunner: rfcomm-tester PASS 9.07 seconds
TestRunner: sco-tester PASS 9.27 seconds
TestRunner: smp-tester PASS 9.31 seconds
TestRunner: userchan-tester PASS 7.51 seconds
---
Regards,
Linux Bluetooth
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v4] Bluetooth: btusb: Improve stability for QCA devices
2022-02-14 10:43 [PATCH v4] Bluetooth: btusb: Improve stability for QCA devices Zijun Hu
2022-02-14 12:00 ` [v4] " bluez.test.bot
@ 2022-02-14 14:16 ` Marcel Holtmann
1 sibling, 0 replies; 3+ messages in thread
From: Marcel Holtmann @ 2022-02-14 14:16 UTC (permalink / raw)
To: Zijun Hu
Cc: Johan Hedberg, Luiz Augusto von Dentz, LKML, BlueZ, MSM,
c-hbandi, Hemantg, Rocky Liao, tjiang, Zijun Hu
Hi Zijun,
> WCN6855 2.1 will reset to apply firmware downloaded, so wait
> a moment for reset done then go ahead to improve stability.
>
> Signed-off-by: Zijun Hu <quic_zijuhu@quicinc.com>
> ---
> drivers/bluetooth/btusb.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
patch has been applied to bluetooth-next tree.
Regards
Marcel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-02-14 14:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-14 10:43 [PATCH v4] Bluetooth: btusb: Improve stability for QCA devices Zijun Hu
2022-02-14 12:00 ` [v4] " bluez.test.bot
2022-02-14 14:16 ` [PATCH v4] " Marcel Holtmann
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.