From: Kieran Bingham <kieran.bingham@ideasonboard.com>
To: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
linux-renesas-soc@vger.kernel.org
Cc: devicetree@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Magnus Damm <magnus.damm@gmail.com>
Subject: Re: [PATCH 1/2] arm64: dts: renesas: Remove empty lvds endpoints
Date: Mon, 21 Feb 2022 14:17:49 +0000 [thread overview]
Message-ID: <164545306949.2976960.4762784450294727405@Monstersaurus> (raw)
In-Reply-To: <20211229191838.27922-1-laurent.pinchart+renesas@ideasonboard.com>
Hi Laurent,
Quoting Laurent Pinchart (2021-12-29 19:18:37)
> Endpoints node must have a remote-endpoint property, as endpoints only
> exist to model a link between ports. Drop the empty lvds endpoints from
> SoC dtsi files, then should be instead declared in the board dts or in
> overlays.
Aha, I was hit by this recently(ish) too, as trying to declare things
that are not yet connected as placeholders was ending up generating
warnings for me.
It's a pain, as having the label placeholder makes it easier to connect
to the endpoint later. But this was failing validation otherwise for me,
so I presume it's the correct thing to do. Seems we're still hoping for
some feedback from Rob on this, but it's fine with me.
Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> ---
> arch/arm64/boot/dts/renesas/r8a774a1.dtsi | 2 --
> arch/arm64/boot/dts/renesas/r8a774b1.dtsi | 2 --
> arch/arm64/boot/dts/renesas/r8a774c0.dtsi | 4 ----
> arch/arm64/boot/dts/renesas/r8a774e1.dtsi | 2 --
> arch/arm64/boot/dts/renesas/r8a77951.dtsi | 2 --
> arch/arm64/boot/dts/renesas/r8a77960.dtsi | 2 --
> arch/arm64/boot/dts/renesas/r8a77965.dtsi | 2 --
> arch/arm64/boot/dts/renesas/r8a77970.dtsi | 2 --
> arch/arm64/boot/dts/renesas/r8a77980.dtsi | 2 --
> arch/arm64/boot/dts/renesas/r8a77990.dtsi | 4 ----
> arch/arm64/boot/dts/renesas/r8a77995.dtsi | 4 ----
> 11 files changed, 28 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/renesas/r8a774a1.dtsi b/arch/arm64/boot/dts/renesas/r8a774a1.dtsi
> index 6f4fffacfca2..9a8c1bd923af 100644
> --- a/arch/arm64/boot/dts/renesas/r8a774a1.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a774a1.dtsi
> @@ -2771,8 +2771,6 @@ lvds0_in: endpoint {
> };
> port@1 {
> reg = <1>;
> - lvds0_out: endpoint {
> - };
> };
> };
> };
> diff --git a/arch/arm64/boot/dts/renesas/r8a774b1.dtsi b/arch/arm64/boot/dts/renesas/r8a774b1.dtsi
> index 0f7bdfc90a0d..8912c1665ed9 100644
> --- a/arch/arm64/boot/dts/renesas/r8a774b1.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a774b1.dtsi
> @@ -2616,8 +2616,6 @@ lvds0_in: endpoint {
> };
> port@1 {
> reg = <1>;
> - lvds0_out: endpoint {
> - };
> };
> };
> };
> diff --git a/arch/arm64/boot/dts/renesas/r8a774c0.dtsi b/arch/arm64/boot/dts/renesas/r8a774c0.dtsi
> index d597772c4c37..263f39fb8ad9 100644
> --- a/arch/arm64/boot/dts/renesas/r8a774c0.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a774c0.dtsi
> @@ -1910,8 +1910,6 @@ lvds0_in: endpoint {
>
> port@1 {
> reg = <1>;
> - lvds0_out: endpoint {
> - };
> };
> };
> };
> @@ -1937,8 +1935,6 @@ lvds1_in: endpoint {
>
> port@1 {
> reg = <1>;
> - lvds1_out: endpoint {
> - };
> };
> };
> };
> diff --git a/arch/arm64/boot/dts/renesas/r8a774e1.dtsi b/arch/arm64/boot/dts/renesas/r8a774e1.dtsi
> index 379a1300272b..02b35e68a3fa 100644
> --- a/arch/arm64/boot/dts/renesas/r8a774e1.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a774e1.dtsi
> @@ -2891,8 +2891,6 @@ lvds0_in: endpoint {
> };
> port@1 {
> reg = <1>;
> - lvds0_out: endpoint {
> - };
> };
> };
> };
> diff --git a/arch/arm64/boot/dts/renesas/r8a77951.dtsi b/arch/arm64/boot/dts/renesas/r8a77951.dtsi
> index 1768a3e6bb8d..0919d8f540c4 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77951.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a77951.dtsi
> @@ -3362,8 +3362,6 @@ lvds0_in: endpoint {
> };
> port@1 {
> reg = <1>;
> - lvds0_out: endpoint {
> - };
> };
> };
> };
> diff --git a/arch/arm64/boot/dts/renesas/r8a77960.dtsi b/arch/arm64/boot/dts/renesas/r8a77960.dtsi
> index 2bd8169735d3..221ee1ec415d 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77960.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a77960.dtsi
> @@ -2959,8 +2959,6 @@ lvds0_in: endpoint {
> };
> port@1 {
> reg = <1>;
> - lvds0_out: endpoint {
> - };
> };
> };
> };
> diff --git a/arch/arm64/boot/dts/renesas/r8a77965.dtsi b/arch/arm64/boot/dts/renesas/r8a77965.dtsi
> index 08df75606430..5f3046eee365 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77965.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a77965.dtsi
> @@ -2771,8 +2771,6 @@ lvds0_in: endpoint {
> };
> port@1 {
> reg = <1>;
> - lvds0_out: endpoint {
> - };
> };
> };
> };
> diff --git a/arch/arm64/boot/dts/renesas/r8a77970.dtsi b/arch/arm64/boot/dts/renesas/r8a77970.dtsi
> index 517892cf6294..ad021b2703ab 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77970.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a77970.dtsi
> @@ -1190,8 +1190,6 @@ lvds0_in: endpoint {
> };
> port@1 {
> reg = <1>;
> - lvds0_out: endpoint {
> - };
> };
> };
> };
> diff --git a/arch/arm64/boot/dts/renesas/r8a77980.dtsi b/arch/arm64/boot/dts/renesas/r8a77980.dtsi
> index 6347d15e66b6..29f1161da957 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77980.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a77980.dtsi
> @@ -1567,8 +1567,6 @@ lvds0_in: endpoint {
>
> port@1 {
> reg = <1>;
> - lvds0_out: endpoint {
> - };
> };
> };
> };
> diff --git a/arch/arm64/boot/dts/renesas/r8a77990.dtsi b/arch/arm64/boot/dts/renesas/r8a77990.dtsi
> index 0ea300a8147d..735c46217835 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77990.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a77990.dtsi
> @@ -2059,8 +2059,6 @@ lvds0_in: endpoint {
>
> port@1 {
> reg = <1>;
> - lvds0_out: endpoint {
> - };
> };
> };
> };
> @@ -2086,8 +2084,6 @@ lvds1_in: endpoint {
>
> port@1 {
> reg = <1>;
> - lvds1_out: endpoint {
> - };
> };
> };
> };
> diff --git a/arch/arm64/boot/dts/renesas/r8a77995.dtsi b/arch/arm64/boot/dts/renesas/r8a77995.dtsi
> index 16ad5fc23a67..759505bd1a44 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77995.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a77995.dtsi
> @@ -1380,8 +1380,6 @@ lvds0_in: endpoint {
>
> port@1 {
> reg = <1>;
> - lvds0_out: endpoint {
> - };
> };
> };
> };
> @@ -1407,8 +1405,6 @@ lvds1_in: endpoint {
>
> port@1 {
> reg = <1>;
> - lvds1_out: endpoint {
> - };
> };
> };
> };
>
> base-commit: 2b534e90a1e31c7fc9536b512b72274cc3575f4c
> prerequisite-patch-id: 98434eb22c020924bc338316e54a7b42ea339e9f
> prerequisite-patch-id: ce261c9865255051f2c2107a930b0f15ce862703
> prerequisite-patch-id: 500ab746415c5421e41128c2b0db35987d8d7a49
> prerequisite-patch-id: ad2d5ad025f9cfa0dc453d7e0b2aa96b4514afd7
> prerequisite-patch-id: ac76bcc0f7b278863e362db083a7d64bbd0bd030
> prerequisite-patch-id: c7a7c3a6b9dbbae18a768160db70d7010ea71ca5
> --
> Regards,
>
> Laurent Pinchart
>
prev parent reply other threads:[~2022-02-21 14:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-29 19:18 [PATCH 1/2] arm64: dts: renesas: Remove empty lvds endpoints Laurent Pinchart
2021-12-29 19:18 ` [PATCH 2/2] arm64: dts: renesas: Remove empty rgb output endpoints Laurent Pinchart
2022-01-26 11:10 ` Geert Uytterhoeven
2022-02-21 14:26 ` Kieran Bingham
2022-01-10 10:10 ` [PATCH 1/2] arm64: dts: renesas: Remove empty lvds endpoints Geert Uytterhoeven
2022-01-10 11:24 ` Laurent Pinchart
2022-01-10 12:07 ` Geert Uytterhoeven
2022-02-21 14:10 ` Laurent Pinchart
2022-02-21 14:17 ` Kieran Bingham [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=164545306949.2976960.4762784450294727405@Monstersaurus \
--to=kieran.bingham@ideasonboard.com \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.