From: Kieran Bingham <kieran.bingham@ideasonboard.com>
To: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
linux-renesas-soc@vger.kernel.org
Cc: devicetree@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Magnus Damm <magnus.damm@gmail.com>
Subject: Re: [PATCH 2/2] arm64: dts: renesas: Remove empty rgb output endpoints
Date: Mon, 21 Feb 2022 14:26:28 +0000 [thread overview]
Message-ID: <164545358800.2976960.11557666107245014347@Monstersaurus> (raw)
In-Reply-To: <20211229191838.27922-2-laurent.pinchart+renesas@ideasonboard.com>
Quoting Laurent Pinchart (2021-12-29 19:18:38)
> Endpoints node must have a remote-endpoint property, as endpoints only
> exist to model a link between ports. Drop the empty rgb output endpoints
> from SoC dtsi files, and declare them in the board dts instead.
>
Ah yes, it was when I was adding the DSI output endpoints. I also ended
up ommitting any placeholders. So again, removing still seems the
consistent thing to do for now.
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> ---
> .../boot/dts/renesas/beacon-renesom-baseboard.dtsi | 10 ++++++++--
> arch/arm64/boot/dts/renesas/draak.dtsi | 2 +-
> arch/arm64/boot/dts/renesas/ebisu.dtsi | 2 +-
> arch/arm64/boot/dts/renesas/r8a774a1.dtsi | 2 --
> arch/arm64/boot/dts/renesas/r8a774b1.dtsi | 2 --
> arch/arm64/boot/dts/renesas/r8a774c0-cat874.dts | 2 +-
> arch/arm64/boot/dts/renesas/r8a774c0.dtsi | 2 --
> arch/arm64/boot/dts/renesas/r8a774e1.dtsi | 2 --
> arch/arm64/boot/dts/renesas/r8a77951.dtsi | 2 --
> arch/arm64/boot/dts/renesas/r8a77960.dtsi | 2 --
> arch/arm64/boot/dts/renesas/r8a77961.dtsi | 2 --
> arch/arm64/boot/dts/renesas/r8a77965.dtsi | 2 --
> arch/arm64/boot/dts/renesas/r8a77970.dtsi | 2 --
> arch/arm64/boot/dts/renesas/r8a77980.dtsi | 2 --
> arch/arm64/boot/dts/renesas/r8a77990.dtsi | 2 --
> arch/arm64/boot/dts/renesas/r8a77995.dtsi | 2 --
> arch/arm64/boot/dts/renesas/salvator-common.dtsi | 2 +-
> 17 files changed, 12 insertions(+), 30 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/renesas/beacon-renesom-baseboard.dtsi b/arch/arm64/boot/dts/renesas/beacon-renesom-baseboard.dtsi
> index 2692cc64bff6..1465adc43580 100644
> --- a/arch/arm64/boot/dts/renesas/beacon-renesom-baseboard.dtsi
> +++ b/arch/arm64/boot/dts/renesas/beacon-renesom-baseboard.dtsi
> @@ -272,8 +272,14 @@ &can1 {
> status = "okay";
> };
>
> -&du_out_rgb {
> - remote-endpoint = <&rgb_panel>;
> +&du {
> + ports {
> + port@0 {
Would there be any benefit to labelling the ports for convenience?
Probably not enough, and it would only be there as a shorthand to be
able to still get to the endpoint which would still need it's own label
I think... so I think this is fine as is anyway.
Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
> + du_out_rgb: endpoint {
> + remote-endpoint = <&rgb_panel>;
> + };
> + };
> + };
> };
>
> &ehci0 {
> diff --git a/arch/arm64/boot/dts/renesas/draak.dtsi b/arch/arm64/boot/dts/renesas/draak.dtsi
> index eb0327c0df48..b09f06086840 100644
> --- a/arch/arm64/boot/dts/renesas/draak.dtsi
> +++ b/arch/arm64/boot/dts/renesas/draak.dtsi
> @@ -285,7 +285,7 @@ &du {
>
> ports {
> port@0 {
> - endpoint {
> + du_out_rgb: endpoint {
> remote-endpoint = <&adv7123_in>;
> };
> };
> diff --git a/arch/arm64/boot/dts/renesas/ebisu.dtsi b/arch/arm64/boot/dts/renesas/ebisu.dtsi
> index 67231c8576c5..9e6093524682 100644
> --- a/arch/arm64/boot/dts/renesas/ebisu.dtsi
> +++ b/arch/arm64/boot/dts/renesas/ebisu.dtsi
> @@ -356,7 +356,7 @@ &du {
>
> ports {
> port@0 {
> - endpoint {
> + du_out_rgb: endpoint {
> remote-endpoint = <&adv7123_in>;
> };
> };
> diff --git a/arch/arm64/boot/dts/renesas/r8a774a1.dtsi b/arch/arm64/boot/dts/renesas/r8a774a1.dtsi
> index 9a8c1bd923af..6105316ccac2 100644
> --- a/arch/arm64/boot/dts/renesas/r8a774a1.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a774a1.dtsi
> @@ -2733,8 +2733,6 @@ ports {
>
> port@0 {
> reg = <0>;
> - du_out_rgb: endpoint {
> - };
> };
> port@1 {
> reg = <1>;
> diff --git a/arch/arm64/boot/dts/renesas/r8a774b1.dtsi b/arch/arm64/boot/dts/renesas/r8a774b1.dtsi
> index 8912c1665ed9..7cdf009b1ee6 100644
> --- a/arch/arm64/boot/dts/renesas/r8a774b1.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a774b1.dtsi
> @@ -2578,8 +2578,6 @@ ports {
>
> port@0 {
> reg = <0>;
> - du_out_rgb: endpoint {
> - };
> };
> port@1 {
> reg = <1>;
> diff --git a/arch/arm64/boot/dts/renesas/r8a774c0-cat874.dts b/arch/arm64/boot/dts/renesas/r8a774c0-cat874.dts
> index 4e72e4f2bab0..5a6ea08ffd2b 100644
> --- a/arch/arm64/boot/dts/renesas/r8a774c0-cat874.dts
> +++ b/arch/arm64/boot/dts/renesas/r8a774c0-cat874.dts
> @@ -172,7 +172,7 @@ &du {
>
> ports {
> port@0 {
> - endpoint {
> + du_out_rgb: endpoint {
> remote-endpoint = <&tda19988_in>;
> };
> };
> diff --git a/arch/arm64/boot/dts/renesas/r8a774c0.dtsi b/arch/arm64/boot/dts/renesas/r8a774c0.dtsi
> index 263f39fb8ad9..8b875b212a48 100644
> --- a/arch/arm64/boot/dts/renesas/r8a774c0.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a774c0.dtsi
> @@ -1867,8 +1867,6 @@ ports {
>
> port@0 {
> reg = <0>;
> - du_out_rgb: endpoint {
> - };
> };
>
> port@1 {
> diff --git a/arch/arm64/boot/dts/renesas/r8a774e1.dtsi b/arch/arm64/boot/dts/renesas/r8a774e1.dtsi
> index 02b35e68a3fa..b9ab5cb01419 100644
> --- a/arch/arm64/boot/dts/renesas/r8a774e1.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a774e1.dtsi
> @@ -2853,8 +2853,6 @@ ports {
>
> port@0 {
> reg = <0>;
> - du_out_rgb: endpoint {
> - };
> };
> port@1 {
> reg = <1>;
> diff --git a/arch/arm64/boot/dts/renesas/r8a77951.dtsi b/arch/arm64/boot/dts/renesas/r8a77951.dtsi
> index 0919d8f540c4..b88af4c90f33 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77951.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a77951.dtsi
> @@ -3318,8 +3318,6 @@ ports {
>
> port@0 {
> reg = <0>;
> - du_out_rgb: endpoint {
> - };
> };
> port@1 {
> reg = <1>;
> diff --git a/arch/arm64/boot/dts/renesas/r8a77960.dtsi b/arch/arm64/boot/dts/renesas/r8a77960.dtsi
> index 221ee1ec415d..5e12e80d115e 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77960.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a77960.dtsi
> @@ -2921,8 +2921,6 @@ ports {
>
> port@0 {
> reg = <0>;
> - du_out_rgb: endpoint {
> - };
> };
> port@1 {
> reg = <1>;
> diff --git a/arch/arm64/boot/dts/renesas/r8a77961.dtsi b/arch/arm64/boot/dts/renesas/r8a77961.dtsi
> index ba9358abebb2..4df8ffa84461 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77961.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a77961.dtsi
> @@ -2706,8 +2706,6 @@ ports {
>
> port@0 {
> reg = <0>;
> - du_out_rgb: endpoint {
> - };
> };
> port@1 {
> reg = <1>;
> diff --git a/arch/arm64/boot/dts/renesas/r8a77965.dtsi b/arch/arm64/boot/dts/renesas/r8a77965.dtsi
> index 5f3046eee365..454e95222acf 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77965.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a77965.dtsi
> @@ -2733,8 +2733,6 @@ ports {
>
> port@0 {
> reg = <0>;
> - du_out_rgb: endpoint {
> - };
> };
> port@1 {
> reg = <1>;
> diff --git a/arch/arm64/boot/dts/renesas/r8a77970.dtsi b/arch/arm64/boot/dts/renesas/r8a77970.dtsi
> index ad021b2703ab..dc11845625c4 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77970.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a77970.dtsi
> @@ -1156,8 +1156,6 @@ ports {
>
> port@0 {
> reg = <0>;
> - du_out_rgb: endpoint {
> - };
> };
>
> port@1 {
> diff --git a/arch/arm64/boot/dts/renesas/r8a77980.dtsi b/arch/arm64/boot/dts/renesas/r8a77980.dtsi
> index 29f1161da957..53d0e6b4b75e 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77980.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a77980.dtsi
> @@ -1532,8 +1532,6 @@ ports {
>
> port@0 {
> reg = <0>;
> - du_out_rgb: endpoint {
> - };
> };
>
> port@1 {
> diff --git a/arch/arm64/boot/dts/renesas/r8a77990.dtsi b/arch/arm64/boot/dts/renesas/r8a77990.dtsi
> index 735c46217835..f49173045232 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77990.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a77990.dtsi
> @@ -2016,8 +2016,6 @@ ports {
>
> port@0 {
> reg = <0>;
> - du_out_rgb: endpoint {
> - };
> };
>
> port@1 {
> diff --git a/arch/arm64/boot/dts/renesas/r8a77995.dtsi b/arch/arm64/boot/dts/renesas/r8a77995.dtsi
> index 759505bd1a44..3237ff4e5c77 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77995.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a77995.dtsi
> @@ -1337,8 +1337,6 @@ ports {
>
> port@0 {
> reg = <0>;
> - du_out_rgb: endpoint {
> - };
> };
>
> port@1 {
> diff --git a/arch/arm64/boot/dts/renesas/salvator-common.dtsi b/arch/arm64/boot/dts/renesas/salvator-common.dtsi
> index bf37777dca31..0b0b1fc3a270 100644
> --- a/arch/arm64/boot/dts/renesas/salvator-common.dtsi
> +++ b/arch/arm64/boot/dts/renesas/salvator-common.dtsi
> @@ -385,7 +385,7 @@ &du {
>
> ports {
> port@0 {
> - endpoint {
> + du_out_rgb: endpoint {
> remote-endpoint = <&adv7123_in>;
> };
> };
> --
> Regards,
>
> Laurent Pinchart
>
next prev parent reply other threads:[~2022-02-21 14:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-29 19:18 [PATCH 1/2] arm64: dts: renesas: Remove empty lvds endpoints Laurent Pinchart
2021-12-29 19:18 ` [PATCH 2/2] arm64: dts: renesas: Remove empty rgb output endpoints Laurent Pinchart
2022-01-26 11:10 ` Geert Uytterhoeven
2022-02-21 14:26 ` Kieran Bingham [this message]
2022-01-10 10:10 ` [PATCH 1/2] arm64: dts: renesas: Remove empty lvds endpoints Geert Uytterhoeven
2022-01-10 11:24 ` Laurent Pinchart
2022-01-10 12:07 ` Geert Uytterhoeven
2022-02-21 14:10 ` Laurent Pinchart
2022-02-21 14:17 ` Kieran Bingham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=164545358800.2976960.11557666107245014347@Monstersaurus \
--to=kieran.bingham@ideasonboard.com \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.