All of lore.kernel.org
 help / color / mirror / Atom feed
* [Intel-gfx] [PATCH] iommu/vt-d: Add RPLS to quirk list to skip TE disabling
@ 2022-03-02  4:32 ` Tejas Upadhyay
  0 siblings, 0 replies; 8+ messages in thread
From: Tejas Upadhyay @ 2022-03-02  4:32 UTC (permalink / raw)
  To: intel-gfx
  Cc: iommu, Tejas Upadhyay, Raviteja Goud Talla, Lu Baolu, Rodrigo Vivi

The VT-d spec requires (10.4.4 Global Command Register, TE
field) that:

Hardware implementations supporting DMA draining must drain
any in-flight DMA read/write requests queued within the
Root-Complex before completing the translation enable
command and reflecting the status of the command through
the TES field in the Global Status register.

Unfortunately, some integrated graphic devices fail to do
so after some kind of power state transition. As the
result, the system might stuck in iommu_disable_translati
on(), waiting for the completion of TE transition.

This adds RPLS to a quirk list for those devices and skips
TE disabling if the qurik hits.

Link: https://gitlab.freedesktop.org/drm/intel/-/issues/4898
Tested-by: Raviteja Goud Talla <ravitejax.goud.talla@intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Acked-by: Lu Baolu <baolu.lu@linux.intel.com>
Signed-off-by: Tejas Upadhyay <tejaskumarx.surendrakumar.upadhyay@intel.com>
---
 drivers/iommu/intel/iommu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iommu/intel/iommu.c b/drivers/iommu/intel/iommu.c
index 639e4438827e..bd6dac90a948 100644
--- a/drivers/iommu/intel/iommu.c
+++ b/drivers/iommu/intel/iommu.c
@@ -5741,7 +5741,7 @@ static void quirk_igfx_skip_te_disable(struct pci_dev *dev)
 	ver = (dev->device >> 8) & 0xff;
 	if (ver != 0x45 && ver != 0x46 && ver != 0x4c &&
 	    ver != 0x4e && ver != 0x8a && ver != 0x98 &&
-	    ver != 0x9a)
+	    ver != 0x9a && ver != 0xa7)
 		return;
 
 	if (risky_device(dev))
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2022-03-02 22:08 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-02  4:32 [Intel-gfx] [PATCH] iommu/vt-d: Add RPLS to quirk list to skip TE disabling Tejas Upadhyay
2022-03-02  4:32 ` Tejas Upadhyay
2022-03-02  5:38 ` [Intel-gfx] ✓ Fi.CI.BAT: success for iommu/vt-d: Add RPLS to quirk list to skip TE disabling (rev3) Patchwork
2022-03-02 12:25 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2022-03-02 13:20   ` Surendrakumar Upadhyay, TejaskumarX
2022-03-02 16:38     ` Vudum, Lakshminarayana
2022-03-02 22:08       ` Vivi, Rodrigo
2022-03-02 16:34 ` [Intel-gfx] ✓ Fi.CI.IGT: success " Patchwork

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.