* [PATCH v6 0/3] Add support for SoundWire1.6 audio cgcr register control
@ 2022-03-02 12:42 Srinivasa Rao Mandadapu
2022-03-02 12:43 ` Srinivasa Rao Mandadapu
` (2 more replies)
0 siblings, 3 replies; 19+ messages in thread
From: Srinivasa Rao Mandadapu @ 2022-03-02 12:42 UTC (permalink / raw)
To: agross, bjorn.andersson, lgirdwood, broonie, robh+dt, quic_plai,
bgoswami, perex, tiwai, srinivas.kandagatla, rohitkr,
linux-arm-msm, alsa-devel, devicetree, linux-kernel, swboyd,
judyhsiao, yung-chuan.liao, pierre-louis.bossart, sanyog.r.kale,
vkoul
Cc: Srinivasa Rao Mandadapu
This patch series is to add v1.6.0 compatible name for qcom soundwire
driver and corresponding dt bindings.
Changes Since V4:
-- Constify static struct qcom_swrm_data global variables.
-- Remove redundant swrm_v1_6_data variable.
Changes Since V4:
-- Dropped audio cgcr control patch due to dependency on clock patches.
-- Update dt-bindings as per new reset control properties.
Changes Since V3:
-- Add v1.6.0 compatible name and soundwire data structure.
-- Change macro define name properly.
-- Update bindings for new property.
-- Change commit message description.
-- Change signedoff by sequence.
Changes since v2:
-- Update error check after ioremap.
Changes since v1:
-- Add const name to mask value.
Srinivasa Rao Mandadapu (3):
soundwire: qcom: Add compatible name for v1.6.0
soundwire: qcom: constify static struct qcom_swrm_data global
variables
dt-bindings: soundwire: qcom: Add bindings for audio CSR reset control
property
Documentation/devicetree/bindings/soundwire/qcom,sdw.txt | 12 ++++++++++++
drivers/soundwire/qcom.c | 5 +++--
2 files changed, 15 insertions(+), 2 deletions(-)
--
2.7.4
^ permalink raw reply [flat|nested] 19+ messages in thread
* [PATCH v6 1/3] soundwire: qcom: Add compatible name for v1.6.0
2022-03-02 12:42 [PATCH v6 0/3] Add support for SoundWire1.6 audio cgcr register control Srinivasa Rao Mandadapu
@ 2022-03-02 12:43 ` Srinivasa Rao Mandadapu
2022-03-02 12:43 ` Srinivasa Rao Mandadapu
2022-03-02 12:43 ` Srinivasa Rao Mandadapu
2 siblings, 0 replies; 19+ messages in thread
From: Srinivasa Rao Mandadapu @ 2022-03-02 12:43 UTC (permalink / raw)
To: agross, bjorn.andersson, lgirdwood, broonie, robh+dt, quic_plai,
bgoswami, perex, tiwai, srinivas.kandagatla, rohitkr,
linux-arm-msm, alsa-devel, devicetree, linux-kernel, swboyd,
judyhsiao, yung-chuan.liao, pierre-louis.bossart, sanyog.r.kale,
vkoul
Cc: Srinivasa Rao Mandadapu, Venkata Prasad Potturu
Update compatible string and master data information in soundwire driver
to support v1.6.0 in lpass sc7280 based platform.
Signed-off-by: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com>
Co-developed-by: Venkata Prasad Potturu <quic_potturu@quicinc.com>
Signed-off-by: Venkata Prasad Potturu <quic_potturu@quicinc.com>
---
drivers/soundwire/qcom.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/soundwire/qcom.c b/drivers/soundwire/qcom.c
index 5481341..fc41210 100644
--- a/drivers/soundwire/qcom.c
+++ b/drivers/soundwire/qcom.c
@@ -1348,6 +1348,7 @@ static int qcom_swrm_remove(struct platform_device *pdev)
static const struct of_device_id qcom_swrm_of_match[] = {
{ .compatible = "qcom,soundwire-v1.3.0", .data = &swrm_v1_3_data },
{ .compatible = "qcom,soundwire-v1.5.1", .data = &swrm_v1_5_data },
+ { .compatible = "qcom,soundwire-v1.6.0", .data = &swrm_v1_5_data },
{/* sentinel */},
};
--
2.7.4
^ permalink raw reply related [flat|nested] 19+ messages in thread
* [PATCH v6 1/3] soundwire: qcom: Add compatible name for v1.6.0
@ 2022-03-02 12:43 ` Srinivasa Rao Mandadapu
0 siblings, 0 replies; 19+ messages in thread
From: Srinivasa Rao Mandadapu @ 2022-03-02 12:43 UTC (permalink / raw)
To: agross, bjorn.andersson, lgirdwood, broonie, robh+dt, quic_plai,
bgoswami, perex, tiwai, srinivas.kandagatla, rohitkr,
linux-arm-msm, alsa-devel, devicetree, linux-kernel, swboyd,
judyhsiao, yung-chuan.liao, pierre-louis.bossart, sanyog.r.kale,
vkoul
Cc: Venkata Prasad Potturu, Srinivasa Rao Mandadapu
Update compatible string and master data information in soundwire driver
to support v1.6.0 in lpass sc7280 based platform.
Signed-off-by: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com>
Co-developed-by: Venkata Prasad Potturu <quic_potturu@quicinc.com>
Signed-off-by: Venkata Prasad Potturu <quic_potturu@quicinc.com>
---
drivers/soundwire/qcom.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/soundwire/qcom.c b/drivers/soundwire/qcom.c
index 5481341..fc41210 100644
--- a/drivers/soundwire/qcom.c
+++ b/drivers/soundwire/qcom.c
@@ -1348,6 +1348,7 @@ static int qcom_swrm_remove(struct platform_device *pdev)
static const struct of_device_id qcom_swrm_of_match[] = {
{ .compatible = "qcom,soundwire-v1.3.0", .data = &swrm_v1_3_data },
{ .compatible = "qcom,soundwire-v1.5.1", .data = &swrm_v1_5_data },
+ { .compatible = "qcom,soundwire-v1.6.0", .data = &swrm_v1_5_data },
{/* sentinel */},
};
--
2.7.4
^ permalink raw reply related [flat|nested] 19+ messages in thread
* [PATCH v6 2/3] soundwire: qcom: constify static struct qcom_swrm_data global variables
2022-03-02 12:42 [PATCH v6 0/3] Add support for SoundWire1.6 audio cgcr register control Srinivasa Rao Mandadapu
@ 2022-03-02 12:43 ` Srinivasa Rao Mandadapu
2022-03-02 12:43 ` Srinivasa Rao Mandadapu
2022-03-02 12:43 ` Srinivasa Rao Mandadapu
2 siblings, 0 replies; 19+ messages in thread
From: Srinivasa Rao Mandadapu @ 2022-03-02 12:43 UTC (permalink / raw)
To: agross, bjorn.andersson, lgirdwood, broonie, robh+dt, quic_plai,
bgoswami, perex, tiwai, srinivas.kandagatla, rohitkr,
linux-arm-msm, alsa-devel, devicetree, linux-kernel, swboyd,
judyhsiao, yung-chuan.liao, pierre-louis.bossart, sanyog.r.kale,
vkoul
Cc: Srinivasa Rao Mandadapu, Venkata Prasad Potturu
The qcom_swrm_data structures is only required for setting soundwire params,
so make the qcom_swrm_data structure const to allow the compiler
to put it in read-only memory and avoid unintentional modifications.
Signed-off-by: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com>
Co-developed-by: Venkata Prasad Potturu <quic_potturu@quicinc.com>
Signed-off-by: Venkata Prasad Potturu <quic_potturu@quicinc.com>
---
drivers/soundwire/qcom.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/soundwire/qcom.c b/drivers/soundwire/qcom.c
index fc41210..2d955ca 100644
--- a/drivers/soundwire/qcom.c
+++ b/drivers/soundwire/qcom.c
@@ -166,12 +166,12 @@ struct qcom_swrm_data {
u32 default_rows;
};
-static struct qcom_swrm_data swrm_v1_3_data = {
+static const struct qcom_swrm_data swrm_v1_3_data = {
.default_rows = 48,
.default_cols = 16,
};
-static struct qcom_swrm_data swrm_v1_5_data = {
+static const struct qcom_swrm_data swrm_v1_5_data = {
.default_rows = 50,
.default_cols = 16,
};
--
2.7.4
^ permalink raw reply related [flat|nested] 19+ messages in thread
* [PATCH v6 2/3] soundwire: qcom: constify static struct qcom_swrm_data global variables
@ 2022-03-02 12:43 ` Srinivasa Rao Mandadapu
0 siblings, 0 replies; 19+ messages in thread
From: Srinivasa Rao Mandadapu @ 2022-03-02 12:43 UTC (permalink / raw)
To: agross, bjorn.andersson, lgirdwood, broonie, robh+dt, quic_plai,
bgoswami, perex, tiwai, srinivas.kandagatla, rohitkr,
linux-arm-msm, alsa-devel, devicetree, linux-kernel, swboyd,
judyhsiao, yung-chuan.liao, pierre-louis.bossart, sanyog.r.kale,
vkoul
Cc: Venkata Prasad Potturu, Srinivasa Rao Mandadapu
The qcom_swrm_data structures is only required for setting soundwire params,
so make the qcom_swrm_data structure const to allow the compiler
to put it in read-only memory and avoid unintentional modifications.
Signed-off-by: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com>
Co-developed-by: Venkata Prasad Potturu <quic_potturu@quicinc.com>
Signed-off-by: Venkata Prasad Potturu <quic_potturu@quicinc.com>
---
drivers/soundwire/qcom.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/soundwire/qcom.c b/drivers/soundwire/qcom.c
index fc41210..2d955ca 100644
--- a/drivers/soundwire/qcom.c
+++ b/drivers/soundwire/qcom.c
@@ -166,12 +166,12 @@ struct qcom_swrm_data {
u32 default_rows;
};
-static struct qcom_swrm_data swrm_v1_3_data = {
+static const struct qcom_swrm_data swrm_v1_3_data = {
.default_rows = 48,
.default_cols = 16,
};
-static struct qcom_swrm_data swrm_v1_5_data = {
+static const struct qcom_swrm_data swrm_v1_5_data = {
.default_rows = 50,
.default_cols = 16,
};
--
2.7.4
^ permalink raw reply related [flat|nested] 19+ messages in thread
* [PATCH v6 3/3] dt-bindings: soundwire: qcom: Add bindings for audio CSR reset control property
2022-03-02 12:42 [PATCH v6 0/3] Add support for SoundWire1.6 audio cgcr register control Srinivasa Rao Mandadapu
@ 2022-03-02 12:43 ` Srinivasa Rao Mandadapu
2022-03-02 12:43 ` Srinivasa Rao Mandadapu
2022-03-02 12:43 ` Srinivasa Rao Mandadapu
2 siblings, 0 replies; 19+ messages in thread
From: Srinivasa Rao Mandadapu @ 2022-03-02 12:43 UTC (permalink / raw)
To: agross, bjorn.andersson, lgirdwood, broonie, robh+dt, quic_plai,
bgoswami, perex, tiwai, srinivas.kandagatla, rohitkr,
linux-arm-msm, alsa-devel, devicetree, linux-kernel, swboyd,
judyhsiao, yung-chuan.liao, pierre-louis.bossart, sanyog.r.kale,
vkoul
Cc: Srinivasa Rao Mandadapu, Venkata Prasad Potturu
Update description for audio CSR reset control property, which is
required for latest chipsets to allow software enabling in CGCR HCLK register.
Signed-off-by: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com>
Co-developed-by: Venkata Prasad Potturu <quic_potturu@quicinc.com>
Signed-off-by: Venkata Prasad Potturu <quic_potturu@quicinc.com>
---
Documentation/devicetree/bindings/soundwire/qcom,sdw.txt | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/Documentation/devicetree/bindings/soundwire/qcom,sdw.txt b/Documentation/devicetree/bindings/soundwire/qcom,sdw.txt
index b93a2b3..84c8f54 100644
--- a/Documentation/devicetree/bindings/soundwire/qcom,sdw.txt
+++ b/Documentation/devicetree/bindings/soundwire/qcom,sdw.txt
@@ -150,6 +150,18 @@ board specific bus parameters.
or applicable for the respective data port.
More info in MIPI Alliance SoundWire 1.0 Specifications.
+- reset:
+ Usage: optional
+ Value type: <prop-encoded-array>
+ Definition: Should specify the SoundWire audio CSR reset controller interface,
+ which is required for SoundWire version 1.6.0 and above.
+
+- reset-names:
+ Usage: optional
+ Value type: <stringlist>
+ Definition: should be "swr_audio_cgcr" for SoundWire audio CSR reset
+ controller interface.
+
Note:
More Information on detail of encoding of these fields can be
found in MIPI Alliance SoundWire 1.0 Specifications.
--
2.7.4
^ permalink raw reply related [flat|nested] 19+ messages in thread
* [PATCH v6 3/3] dt-bindings: soundwire: qcom: Add bindings for audio CSR reset control property
@ 2022-03-02 12:43 ` Srinivasa Rao Mandadapu
0 siblings, 0 replies; 19+ messages in thread
From: Srinivasa Rao Mandadapu @ 2022-03-02 12:43 UTC (permalink / raw)
To: agross, bjorn.andersson, lgirdwood, broonie, robh+dt, quic_plai,
bgoswami, perex, tiwai, srinivas.kandagatla, rohitkr,
linux-arm-msm, alsa-devel, devicetree, linux-kernel, swboyd,
judyhsiao, yung-chuan.liao, pierre-louis.bossart, sanyog.r.kale,
vkoul
Cc: Venkata Prasad Potturu, Srinivasa Rao Mandadapu
Update description for audio CSR reset control property, which is
required for latest chipsets to allow software enabling in CGCR HCLK register.
Signed-off-by: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com>
Co-developed-by: Venkata Prasad Potturu <quic_potturu@quicinc.com>
Signed-off-by: Venkata Prasad Potturu <quic_potturu@quicinc.com>
---
Documentation/devicetree/bindings/soundwire/qcom,sdw.txt | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/Documentation/devicetree/bindings/soundwire/qcom,sdw.txt b/Documentation/devicetree/bindings/soundwire/qcom,sdw.txt
index b93a2b3..84c8f54 100644
--- a/Documentation/devicetree/bindings/soundwire/qcom,sdw.txt
+++ b/Documentation/devicetree/bindings/soundwire/qcom,sdw.txt
@@ -150,6 +150,18 @@ board specific bus parameters.
or applicable for the respective data port.
More info in MIPI Alliance SoundWire 1.0 Specifications.
+- reset:
+ Usage: optional
+ Value type: <prop-encoded-array>
+ Definition: Should specify the SoundWire audio CSR reset controller interface,
+ which is required for SoundWire version 1.6.0 and above.
+
+- reset-names:
+ Usage: optional
+ Value type: <stringlist>
+ Definition: should be "swr_audio_cgcr" for SoundWire audio CSR reset
+ controller interface.
+
Note:
More Information on detail of encoding of these fields can be
found in MIPI Alliance SoundWire 1.0 Specifications.
--
2.7.4
^ permalink raw reply related [flat|nested] 19+ messages in thread
* Re: [PATCH v6 1/3] soundwire: qcom: Add compatible name for v1.6.0
2022-03-02 12:43 ` Srinivasa Rao Mandadapu
@ 2022-03-02 15:43 ` Vinod Koul
-1 siblings, 0 replies; 19+ messages in thread
From: Vinod Koul @ 2022-03-02 15:43 UTC (permalink / raw)
To: Srinivasa Rao Mandadapu
Cc: agross, bjorn.andersson, lgirdwood, broonie, robh+dt, quic_plai,
bgoswami, perex, tiwai, srinivas.kandagatla, rohitkr,
linux-arm-msm, alsa-devel, devicetree, linux-kernel, swboyd,
judyhsiao, yung-chuan.liao, pierre-louis.bossart, sanyog.r.kale,
Venkata Prasad Potturu
On 02-03-22, 18:13, Srinivasa Rao Mandadapu wrote:
> Update compatible string and master data information in soundwire driver
> to support v1.6.0 in lpass sc7280 based platform.
Where is the documentation of this new compatible
>
> Signed-off-by: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com>
> Co-developed-by: Venkata Prasad Potturu <quic_potturu@quicinc.com>
> Signed-off-by: Venkata Prasad Potturu <quic_potturu@quicinc.com>
> ---
> drivers/soundwire/qcom.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/soundwire/qcom.c b/drivers/soundwire/qcom.c
> index 5481341..fc41210 100644
> --- a/drivers/soundwire/qcom.c
> +++ b/drivers/soundwire/qcom.c
> @@ -1348,6 +1348,7 @@ static int qcom_swrm_remove(struct platform_device *pdev)
> static const struct of_device_id qcom_swrm_of_match[] = {
> { .compatible = "qcom,soundwire-v1.3.0", .data = &swrm_v1_3_data },
> { .compatible = "qcom,soundwire-v1.5.1", .data = &swrm_v1_5_data },
> + { .compatible = "qcom,soundwire-v1.6.0", .data = &swrm_v1_5_data },
> {/* sentinel */},
> };
>
> --
> 2.7.4
--
~Vinod
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH v6 1/3] soundwire: qcom: Add compatible name for v1.6.0
@ 2022-03-02 15:43 ` Vinod Koul
0 siblings, 0 replies; 19+ messages in thread
From: Vinod Koul @ 2022-03-02 15:43 UTC (permalink / raw)
To: Srinivasa Rao Mandadapu
Cc: devicetree, alsa-devel, bgoswami, yung-chuan.liao, linux-arm-msm,
swboyd, tiwai, agross, robh+dt, lgirdwood, pierre-louis.bossart,
rohitkr, broonie, srinivas.kandagatla, quic_plai, sanyog.r.kale,
bjorn.andersson, judyhsiao, Venkata Prasad Potturu, linux-kernel
On 02-03-22, 18:13, Srinivasa Rao Mandadapu wrote:
> Update compatible string and master data information in soundwire driver
> to support v1.6.0 in lpass sc7280 based platform.
Where is the documentation of this new compatible
>
> Signed-off-by: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com>
> Co-developed-by: Venkata Prasad Potturu <quic_potturu@quicinc.com>
> Signed-off-by: Venkata Prasad Potturu <quic_potturu@quicinc.com>
> ---
> drivers/soundwire/qcom.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/soundwire/qcom.c b/drivers/soundwire/qcom.c
> index 5481341..fc41210 100644
> --- a/drivers/soundwire/qcom.c
> +++ b/drivers/soundwire/qcom.c
> @@ -1348,6 +1348,7 @@ static int qcom_swrm_remove(struct platform_device *pdev)
> static const struct of_device_id qcom_swrm_of_match[] = {
> { .compatible = "qcom,soundwire-v1.3.0", .data = &swrm_v1_3_data },
> { .compatible = "qcom,soundwire-v1.5.1", .data = &swrm_v1_5_data },
> + { .compatible = "qcom,soundwire-v1.6.0", .data = &swrm_v1_5_data },
> {/* sentinel */},
> };
>
> --
> 2.7.4
--
~Vinod
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH v6 3/3] dt-bindings: soundwire: qcom: Add bindings for audio CSR reset control property
2022-03-02 12:43 ` Srinivasa Rao Mandadapu
@ 2022-03-02 15:48 ` Vinod Koul
-1 siblings, 0 replies; 19+ messages in thread
From: Vinod Koul @ 2022-03-02 15:48 UTC (permalink / raw)
To: Srinivasa Rao Mandadapu
Cc: agross, bjorn.andersson, lgirdwood, broonie, robh+dt, quic_plai,
bgoswami, perex, tiwai, srinivas.kandagatla, rohitkr,
linux-arm-msm, alsa-devel, devicetree, linux-kernel, swboyd,
judyhsiao, yung-chuan.liao, pierre-louis.bossart, sanyog.r.kale,
Venkata Prasad Potturu
On 02-03-22, 18:13, Srinivasa Rao Mandadapu wrote:
> Update description for audio CSR reset control property, which is
> required for latest chipsets to allow software enabling in CGCR HCLK register.
too many acronyms pls explain!
>
> Signed-off-by: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com>
> Co-developed-by: Venkata Prasad Potturu <quic_potturu@quicinc.com>
> Signed-off-by: Venkata Prasad Potturu <quic_potturu@quicinc.com>
> ---
> Documentation/devicetree/bindings/soundwire/qcom,sdw.txt | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/soundwire/qcom,sdw.txt b/Documentation/devicetree/bindings/soundwire/qcom,sdw.txt
> index b93a2b3..84c8f54 100644
> --- a/Documentation/devicetree/bindings/soundwire/qcom,sdw.txt
> +++ b/Documentation/devicetree/bindings/soundwire/qcom,sdw.txt
> @@ -150,6 +150,18 @@ board specific bus parameters.
> or applicable for the respective data port.
> More info in MIPI Alliance SoundWire 1.0 Specifications.
>
> +- reset:
> + Usage: optional
> + Value type: <prop-encoded-array>
> + Definition: Should specify the SoundWire audio CSR reset controller interface,
> + which is required for SoundWire version 1.6.0 and above.
> +
> +- reset-names:
> + Usage: optional
> + Value type: <stringlist>
> + Definition: should be "swr_audio_cgcr" for SoundWire audio CSR reset
> + controller interface.
> +
We should add these in example as well...
> Note:
> More Information on detail of encoding of these fields can be
> found in MIPI Alliance SoundWire 1.0 Specifications.
> --
> 2.7.4
--
~Vinod
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH v6 3/3] dt-bindings: soundwire: qcom: Add bindings for audio CSR reset control property
@ 2022-03-02 15:48 ` Vinod Koul
0 siblings, 0 replies; 19+ messages in thread
From: Vinod Koul @ 2022-03-02 15:48 UTC (permalink / raw)
To: Srinivasa Rao Mandadapu
Cc: devicetree, alsa-devel, bgoswami, yung-chuan.liao, linux-arm-msm,
swboyd, tiwai, agross, robh+dt, lgirdwood, pierre-louis.bossart,
rohitkr, broonie, srinivas.kandagatla, quic_plai, sanyog.r.kale,
bjorn.andersson, judyhsiao, Venkata Prasad Potturu, linux-kernel
On 02-03-22, 18:13, Srinivasa Rao Mandadapu wrote:
> Update description for audio CSR reset control property, which is
> required for latest chipsets to allow software enabling in CGCR HCLK register.
too many acronyms pls explain!
>
> Signed-off-by: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com>
> Co-developed-by: Venkata Prasad Potturu <quic_potturu@quicinc.com>
> Signed-off-by: Venkata Prasad Potturu <quic_potturu@quicinc.com>
> ---
> Documentation/devicetree/bindings/soundwire/qcom,sdw.txt | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/soundwire/qcom,sdw.txt b/Documentation/devicetree/bindings/soundwire/qcom,sdw.txt
> index b93a2b3..84c8f54 100644
> --- a/Documentation/devicetree/bindings/soundwire/qcom,sdw.txt
> +++ b/Documentation/devicetree/bindings/soundwire/qcom,sdw.txt
> @@ -150,6 +150,18 @@ board specific bus parameters.
> or applicable for the respective data port.
> More info in MIPI Alliance SoundWire 1.0 Specifications.
>
> +- reset:
> + Usage: optional
> + Value type: <prop-encoded-array>
> + Definition: Should specify the SoundWire audio CSR reset controller interface,
> + which is required for SoundWire version 1.6.0 and above.
> +
> +- reset-names:
> + Usage: optional
> + Value type: <stringlist>
> + Definition: should be "swr_audio_cgcr" for SoundWire audio CSR reset
> + controller interface.
> +
We should add these in example as well...
> Note:
> More Information on detail of encoding of these fields can be
> found in MIPI Alliance SoundWire 1.0 Specifications.
> --
> 2.7.4
--
~Vinod
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH v6 2/3] soundwire: qcom: constify static struct qcom_swrm_data global variables
2022-03-02 12:43 ` Srinivasa Rao Mandadapu
@ 2022-03-02 15:49 ` Vinod Koul
-1 siblings, 0 replies; 19+ messages in thread
From: Vinod Koul @ 2022-03-02 15:49 UTC (permalink / raw)
To: Srinivasa Rao Mandadapu
Cc: agross, bjorn.andersson, lgirdwood, broonie, robh+dt, quic_plai,
bgoswami, perex, tiwai, srinivas.kandagatla, rohitkr,
linux-arm-msm, alsa-devel, devicetree, linux-kernel, swboyd,
judyhsiao, yung-chuan.liao, pierre-louis.bossart, sanyog.r.kale,
Venkata Prasad Potturu
On 02-03-22, 18:13, Srinivasa Rao Mandadapu wrote:
> The qcom_swrm_data structures is only required for setting soundwire params,
> so make the qcom_swrm_data structure const to allow the compiler
> to put it in read-only memory and avoid unintentional modifications.
Applied, thanks
--
~Vinod
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH v6 2/3] soundwire: qcom: constify static struct qcom_swrm_data global variables
@ 2022-03-02 15:49 ` Vinod Koul
0 siblings, 0 replies; 19+ messages in thread
From: Vinod Koul @ 2022-03-02 15:49 UTC (permalink / raw)
To: Srinivasa Rao Mandadapu
Cc: devicetree, alsa-devel, bgoswami, yung-chuan.liao, linux-arm-msm,
swboyd, tiwai, agross, robh+dt, lgirdwood, pierre-louis.bossart,
rohitkr, broonie, srinivas.kandagatla, quic_plai, sanyog.r.kale,
bjorn.andersson, judyhsiao, Venkata Prasad Potturu, linux-kernel
On 02-03-22, 18:13, Srinivasa Rao Mandadapu wrote:
> The qcom_swrm_data structures is only required for setting soundwire params,
> so make the qcom_swrm_data structure const to allow the compiler
> to put it in read-only memory and avoid unintentional modifications.
Applied, thanks
--
~Vinod
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH v6 3/3] dt-bindings: soundwire: qcom: Add bindings for audio CSR reset control property
2022-03-02 12:43 ` Srinivasa Rao Mandadapu
@ 2022-03-02 17:41 ` Rob Herring
-1 siblings, 0 replies; 19+ messages in thread
From: Rob Herring @ 2022-03-02 17:41 UTC (permalink / raw)
To: Srinivasa Rao Mandadapu
Cc: agross, bjorn.andersson, lgirdwood, broonie, quic_plai, bgoswami,
perex, tiwai, srinivas.kandagatla, rohitkr, linux-arm-msm,
alsa-devel, devicetree, linux-kernel, swboyd, judyhsiao,
yung-chuan.liao, pierre-louis.bossart, sanyog.r.kale, vkoul,
Venkata Prasad Potturu
On Wed, Mar 02, 2022 at 06:13:02PM +0530, Srinivasa Rao Mandadapu wrote:
> Update description for audio CSR reset control property, which is
> required for latest chipsets to allow software enabling in CGCR HCLK register.
>
> Signed-off-by: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com>
> Co-developed-by: Venkata Prasad Potturu <quic_potturu@quicinc.com>
> Signed-off-by: Venkata Prasad Potturu <quic_potturu@quicinc.com>
> ---
> Documentation/devicetree/bindings/soundwire/qcom,sdw.txt | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH v6 3/3] dt-bindings: soundwire: qcom: Add bindings for audio CSR reset control property
@ 2022-03-02 17:41 ` Rob Herring
0 siblings, 0 replies; 19+ messages in thread
From: Rob Herring @ 2022-03-02 17:41 UTC (permalink / raw)
To: Srinivasa Rao Mandadapu
Cc: devicetree, alsa-devel, bgoswami, yung-chuan.liao, vkoul,
linux-arm-msm, swboyd, tiwai, agross, lgirdwood,
pierre-louis.bossart, rohitkr, broonie, srinivas.kandagatla,
quic_plai, sanyog.r.kale, bjorn.andersson, judyhsiao,
Venkata Prasad Potturu, linux-kernel
On Wed, Mar 02, 2022 at 06:13:02PM +0530, Srinivasa Rao Mandadapu wrote:
> Update description for audio CSR reset control property, which is
> required for latest chipsets to allow software enabling in CGCR HCLK register.
>
> Signed-off-by: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com>
> Co-developed-by: Venkata Prasad Potturu <quic_potturu@quicinc.com>
> Signed-off-by: Venkata Prasad Potturu <quic_potturu@quicinc.com>
> ---
> Documentation/devicetree/bindings/soundwire/qcom,sdw.txt | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH v6 1/3] soundwire: qcom: Add compatible name for v1.6.0
2022-03-02 15:43 ` Vinod Koul
@ 2022-03-03 1:51 ` Srinivasa Rao Mandadapu
-1 siblings, 0 replies; 19+ messages in thread
From: Srinivasa Rao Mandadapu @ 2022-03-03 1:51 UTC (permalink / raw)
To: Vinod Koul
Cc: agross, bjorn.andersson, lgirdwood, broonie, robh+dt, quic_plai,
bgoswami, perex, tiwai, srinivas.kandagatla, rohitkr,
linux-arm-msm, alsa-devel, devicetree, linux-kernel, swboyd,
judyhsiao, yung-chuan.liao, pierre-louis.bossart, sanyog.r.kale,
Venkata Prasad Potturu
On 3/2/2022 9:13 PM, Vinod Koul wrote:
Thanks for Your time Vinod!!!
> On 02-03-22, 18:13, Srinivasa Rao Mandadapu wrote:
>> Update compatible string and master data information in soundwire driver
>> to support v1.6.0 in lpass sc7280 based platform.
> Where is the documentation of this new compatible
The compatible name already exists in
Documentation/devicetree/bindings/soundwire/qcom,sdw.txt
>> Signed-off-by: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com>
>> Co-developed-by: Venkata Prasad Potturu <quic_potturu@quicinc.com>
>> Signed-off-by: Venkata Prasad Potturu <quic_potturu@quicinc.com>
>> ---
>> drivers/soundwire/qcom.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/soundwire/qcom.c b/drivers/soundwire/qcom.c
>> index 5481341..fc41210 100644
>> --- a/drivers/soundwire/qcom.c
>> +++ b/drivers/soundwire/qcom.c
>> @@ -1348,6 +1348,7 @@ static int qcom_swrm_remove(struct platform_device *pdev)
>> static const struct of_device_id qcom_swrm_of_match[] = {
>> { .compatible = "qcom,soundwire-v1.3.0", .data = &swrm_v1_3_data },
>> { .compatible = "qcom,soundwire-v1.5.1", .data = &swrm_v1_5_data },
>> + { .compatible = "qcom,soundwire-v1.6.0", .data = &swrm_v1_5_data },
>> {/* sentinel */},
>> };
>>
>> --
>> 2.7.4
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH v6 1/3] soundwire: qcom: Add compatible name for v1.6.0
@ 2022-03-03 1:51 ` Srinivasa Rao Mandadapu
0 siblings, 0 replies; 19+ messages in thread
From: Srinivasa Rao Mandadapu @ 2022-03-03 1:51 UTC (permalink / raw)
To: Vinod Koul
Cc: devicetree, alsa-devel, bgoswami, yung-chuan.liao, linux-arm-msm,
swboyd, tiwai, agross, robh+dt, lgirdwood, pierre-louis.bossart,
rohitkr, broonie, srinivas.kandagatla, quic_plai, sanyog.r.kale,
bjorn.andersson, judyhsiao, Venkata Prasad Potturu, linux-kernel
On 3/2/2022 9:13 PM, Vinod Koul wrote:
Thanks for Your time Vinod!!!
> On 02-03-22, 18:13, Srinivasa Rao Mandadapu wrote:
>> Update compatible string and master data information in soundwire driver
>> to support v1.6.0 in lpass sc7280 based platform.
> Where is the documentation of this new compatible
The compatible name already exists in
Documentation/devicetree/bindings/soundwire/qcom,sdw.txt
>> Signed-off-by: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com>
>> Co-developed-by: Venkata Prasad Potturu <quic_potturu@quicinc.com>
>> Signed-off-by: Venkata Prasad Potturu <quic_potturu@quicinc.com>
>> ---
>> drivers/soundwire/qcom.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/soundwire/qcom.c b/drivers/soundwire/qcom.c
>> index 5481341..fc41210 100644
>> --- a/drivers/soundwire/qcom.c
>> +++ b/drivers/soundwire/qcom.c
>> @@ -1348,6 +1348,7 @@ static int qcom_swrm_remove(struct platform_device *pdev)
>> static const struct of_device_id qcom_swrm_of_match[] = {
>> { .compatible = "qcom,soundwire-v1.3.0", .data = &swrm_v1_3_data },
>> { .compatible = "qcom,soundwire-v1.5.1", .data = &swrm_v1_5_data },
>> + { .compatible = "qcom,soundwire-v1.6.0", .data = &swrm_v1_5_data },
>> {/* sentinel */},
>> };
>>
>> --
>> 2.7.4
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH v6 3/3] dt-bindings: soundwire: qcom: Add bindings for audio CSR reset control property
2022-03-02 15:48 ` Vinod Koul
@ 2022-03-03 1:56 ` Srinivasa Rao Mandadapu
-1 siblings, 0 replies; 19+ messages in thread
From: Srinivasa Rao Mandadapu @ 2022-03-03 1:56 UTC (permalink / raw)
To: Vinod Koul
Cc: agross, bjorn.andersson, lgirdwood, broonie, robh+dt, quic_plai,
bgoswami, perex, tiwai, srinivas.kandagatla, rohitkr,
linux-arm-msm, alsa-devel, devicetree, linux-kernel, swboyd,
judyhsiao, yung-chuan.liao, pierre-louis.bossart, sanyog.r.kale,
Venkata Prasad Potturu
On 3/2/2022 9:18 PM, Vinod Koul wrote:
Thanks for your time Vinod!!!
> On 02-03-22, 18:13, Srinivasa Rao Mandadapu wrote:
>> Update description for audio CSR reset control property, which is
>> required for latest chipsets to allow software enabling in CGCR HCLK register.
> too many acronyms pls explain!
Okay. Will expand and re post the patch.
>
>> Signed-off-by: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com>
>> Co-developed-by: Venkata Prasad Potturu <quic_potturu@quicinc.com>
>> Signed-off-by: Venkata Prasad Potturu <quic_potturu@quicinc.com>
>> ---
>> Documentation/devicetree/bindings/soundwire/qcom,sdw.txt | 12 ++++++++++++
>> 1 file changed, 12 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/soundwire/qcom,sdw.txt b/Documentation/devicetree/bindings/soundwire/qcom,sdw.txt
>> index b93a2b3..84c8f54 100644
>> --- a/Documentation/devicetree/bindings/soundwire/qcom,sdw.txt
>> +++ b/Documentation/devicetree/bindings/soundwire/qcom,sdw.txt
>> @@ -150,6 +150,18 @@ board specific bus parameters.
>> or applicable for the respective data port.
>> More info in MIPI Alliance SoundWire 1.0 Specifications.
>>
>> +- reset:
>> + Usage: optional
>> + Value type: <prop-encoded-array>
>> + Definition: Should specify the SoundWire audio CSR reset controller interface,
>> + which is required for SoundWire version 1.6.0 and above.
>> +
>> +- reset-names:
>> + Usage: optional
>> + Value type: <stringlist>
>> + Definition: should be "swr_audio_cgcr" for SoundWire audio CSR reset
>> + controller interface.
>> +
> We should add these in example as well...
Okay. Will add in Example.
>
>> Note:
>> More Information on detail of encoding of these fields can be
>> found in MIPI Alliance SoundWire 1.0 Specifications.
>> --
>> 2.7.4
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH v6 3/3] dt-bindings: soundwire: qcom: Add bindings for audio CSR reset control property
@ 2022-03-03 1:56 ` Srinivasa Rao Mandadapu
0 siblings, 0 replies; 19+ messages in thread
From: Srinivasa Rao Mandadapu @ 2022-03-03 1:56 UTC (permalink / raw)
To: Vinod Koul
Cc: devicetree, alsa-devel, bgoswami, yung-chuan.liao, linux-arm-msm,
swboyd, tiwai, agross, robh+dt, lgirdwood, pierre-louis.bossart,
rohitkr, broonie, srinivas.kandagatla, quic_plai, sanyog.r.kale,
bjorn.andersson, judyhsiao, Venkata Prasad Potturu, linux-kernel
On 3/2/2022 9:18 PM, Vinod Koul wrote:
Thanks for your time Vinod!!!
> On 02-03-22, 18:13, Srinivasa Rao Mandadapu wrote:
>> Update description for audio CSR reset control property, which is
>> required for latest chipsets to allow software enabling in CGCR HCLK register.
> too many acronyms pls explain!
Okay. Will expand and re post the patch.
>
>> Signed-off-by: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com>
>> Co-developed-by: Venkata Prasad Potturu <quic_potturu@quicinc.com>
>> Signed-off-by: Venkata Prasad Potturu <quic_potturu@quicinc.com>
>> ---
>> Documentation/devicetree/bindings/soundwire/qcom,sdw.txt | 12 ++++++++++++
>> 1 file changed, 12 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/soundwire/qcom,sdw.txt b/Documentation/devicetree/bindings/soundwire/qcom,sdw.txt
>> index b93a2b3..84c8f54 100644
>> --- a/Documentation/devicetree/bindings/soundwire/qcom,sdw.txt
>> +++ b/Documentation/devicetree/bindings/soundwire/qcom,sdw.txt
>> @@ -150,6 +150,18 @@ board specific bus parameters.
>> or applicable for the respective data port.
>> More info in MIPI Alliance SoundWire 1.0 Specifications.
>>
>> +- reset:
>> + Usage: optional
>> + Value type: <prop-encoded-array>
>> + Definition: Should specify the SoundWire audio CSR reset controller interface,
>> + which is required for SoundWire version 1.6.0 and above.
>> +
>> +- reset-names:
>> + Usage: optional
>> + Value type: <stringlist>
>> + Definition: should be "swr_audio_cgcr" for SoundWire audio CSR reset
>> + controller interface.
>> +
> We should add these in example as well...
Okay. Will add in Example.
>
>> Note:
>> More Information on detail of encoding of these fields can be
>> found in MIPI Alliance SoundWire 1.0 Specifications.
>> --
>> 2.7.4
^ permalink raw reply [flat|nested] 19+ messages in thread
end of thread, other threads:[~2022-03-03 1:57 UTC | newest]
Thread overview: 19+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-02 12:42 [PATCH v6 0/3] Add support for SoundWire1.6 audio cgcr register control Srinivasa Rao Mandadapu
2022-03-02 12:43 ` [PATCH v6 1/3] soundwire: qcom: Add compatible name for v1.6.0 Srinivasa Rao Mandadapu
2022-03-02 12:43 ` Srinivasa Rao Mandadapu
2022-03-02 15:43 ` Vinod Koul
2022-03-02 15:43 ` Vinod Koul
2022-03-03 1:51 ` Srinivasa Rao Mandadapu
2022-03-03 1:51 ` Srinivasa Rao Mandadapu
2022-03-02 12:43 ` [PATCH v6 2/3] soundwire: qcom: constify static struct qcom_swrm_data global variables Srinivasa Rao Mandadapu
2022-03-02 12:43 ` Srinivasa Rao Mandadapu
2022-03-02 15:49 ` Vinod Koul
2022-03-02 15:49 ` Vinod Koul
2022-03-02 12:43 ` [PATCH v6 3/3] dt-bindings: soundwire: qcom: Add bindings for audio CSR reset control property Srinivasa Rao Mandadapu
2022-03-02 12:43 ` Srinivasa Rao Mandadapu
2022-03-02 15:48 ` Vinod Koul
2022-03-02 15:48 ` Vinod Koul
2022-03-03 1:56 ` Srinivasa Rao Mandadapu
2022-03-03 1:56 ` Srinivasa Rao Mandadapu
2022-03-02 17:41 ` Rob Herring
2022-03-02 17:41 ` Rob Herring
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.