All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/i915/gtt: reduce overzealous alignment constraints for GGTT
@ 2022-03-03 10:02 ` Matthew Auld
  0 siblings, 0 replies; 12+ messages in thread
From: Matthew Auld @ 2022-03-03 10:02 UTC (permalink / raw)
  To: intel-gfx; +Cc: Robert Beckett, Thomas Hellström, dri-devel

Currently this will enforce both 2M alignment and padding for any LMEM
pages inserted into the GGTT. However, this was only meant to be applied
to the compact-pt layout with the ppGTT. For the GGTT we can reduce the
alignment and padding to 64K.

Bspec: 45015
Fixes: 87bd701ee268 ("drm/i915: enforce min GTT alignment for discrete cards")
Signed-off-by: Matthew Auld <matthew.auld@intel.com>
Cc: Thomas Hellström <thomas.hellstrom@linux.intel.com>
Cc: Robert Beckett <bob.beckett@collabora.com>
Cc: Ramalingam C <ramalingam.c@intel.com>
---
 drivers/gpu/drm/i915/gt/intel_gtt.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/gt/intel_gtt.c b/drivers/gpu/drm/i915/gt/intel_gtt.c
index 4bcdfcab3642..a5f5b2dda332 100644
--- a/drivers/gpu/drm/i915/gt/intel_gtt.c
+++ b/drivers/gpu/drm/i915/gt/intel_gtt.c
@@ -234,7 +234,8 @@ void i915_address_space_init(struct i915_address_space *vm, int subclass)
 	memset64(vm->min_alignment, I915_GTT_MIN_ALIGNMENT,
 		 ARRAY_SIZE(vm->min_alignment));
 
-	if (HAS_64K_PAGES(vm->i915) && NEEDS_COMPACT_PT(vm->i915)) {
+	if (HAS_64K_PAGES(vm->i915) && NEEDS_COMPACT_PT(vm->i915) &&
+	    subclass == VM_CLASS_PPGTT) {
 		vm->min_alignment[INTEL_MEMORY_LOCAL] = I915_GTT_PAGE_SIZE_2M;
 		vm->min_alignment[INTEL_MEMORY_STOLEN_LOCAL] = I915_GTT_PAGE_SIZE_2M;
 	} else if (HAS_64K_PAGES(vm->i915)) {
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 12+ messages in thread

end of thread, other threads:[~2022-03-09  7:40 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-03 10:02 [PATCH] drm/i915/gtt: reduce overzealous alignment constraints for GGTT Matthew Auld
2022-03-03 10:02 ` [Intel-gfx] " Matthew Auld
2022-03-03 10:52 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2022-03-03 14:32 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2022-03-03 18:45 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gtt: reduce overzealous alignment constraints for GGTT (rev2) Patchwork
2022-03-04  5:31 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2022-03-04 17:25 ` [Intel-gfx] [PATCH] drm/i915/gtt: reduce overzealous alignment constraints for GGTT Thomas Hellström (Intel)
2022-03-07 13:52 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gtt: reduce overzealous alignment constraints for GGTT (rev3) Patchwork
2022-03-07 16:56 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2022-03-08 12:27   ` Matthew Auld
2022-03-08 13:02 ` [Intel-gfx] [PATCH] drm/i915/gtt: reduce overzealous alignment constraints for GGTT Das, Nirmoy
2022-03-08 17:17 ` [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/gtt: reduce overzealous alignment constraints for GGTT (rev3) Patchwork

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.