* [PATCH v1 0/2] Add phy driver for ehci in Sunplus SP7021 @ 2022-03-04 11:30 ` Vincent Shih 0 siblings, 0 replies; 12+ messages in thread From: Vincent Shih @ 2022-03-04 11:30 UTC (permalink / raw) To: kishon, vkoul, p.zabel, linux-kernel, linux-phy, linux-usb, robh+dt, devicetree, wells.lu Cc: Vincent Shih This is a patch series for ehci driver for Sunplus SP7021 SoC. Sunplus SP7021 is an ARM Coretex A7 (4 cores) based SoC. It integrates many peripherals (ex: UART, I2C, SPI, SDIO, eMMC, USB, SD Card and etc.) into a single chip. It is designed for industrial control. Refer to: https://sunplus-tibbo.atlassian.net/wiki/spaces/doc/overview https://tibbo.com/store/plus1.html Vincent Shih (2): phy: usb: Add USB2.0 phy driver for Sunplus SP7021 dt-bindings: phy: Add bindings doc for Sunplus USB2 PHY driver .../bindings/phy/sunplus,sp7021-usb2-phy.yaml | 73 ++++++ MAINTAINERS | 9 + drivers/phy/Kconfig | 1 + drivers/phy/Makefile | 1 + drivers/phy/sunplus/Kconfig | 12 + drivers/phy/sunplus/Makefile | 2 + drivers/phy/sunplus/phy-sunplus-usb2.c | 248 +++++++++++++++++++++ 7 files changed, 346 insertions(+) create mode 100644 Documentation/devicetree/bindings/phy/sunplus,sp7021-usb2-phy.yaml create mode 100644 drivers/phy/sunplus/Kconfig create mode 100644 drivers/phy/sunplus/Makefile create mode 100644 drivers/phy/sunplus/phy-sunplus-usb2.c -- 2.7.4 ^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH v1 0/2] Add phy driver for ehci in Sunplus SP7021 @ 2022-03-04 11:30 ` Vincent Shih 0 siblings, 0 replies; 12+ messages in thread From: Vincent Shih @ 2022-03-04 11:30 UTC (permalink / raw) To: kishon, vkoul, p.zabel, linux-kernel, linux-phy, linux-usb, robh+dt, devicetree, wells.lu Cc: Vincent Shih This is a patch series for ehci driver for Sunplus SP7021 SoC. Sunplus SP7021 is an ARM Coretex A7 (4 cores) based SoC. It integrates many peripherals (ex: UART, I2C, SPI, SDIO, eMMC, USB, SD Card and etc.) into a single chip. It is designed for industrial control. Refer to: https://sunplus-tibbo.atlassian.net/wiki/spaces/doc/overview https://tibbo.com/store/plus1.html Vincent Shih (2): phy: usb: Add USB2.0 phy driver for Sunplus SP7021 dt-bindings: phy: Add bindings doc for Sunplus USB2 PHY driver .../bindings/phy/sunplus,sp7021-usb2-phy.yaml | 73 ++++++ MAINTAINERS | 9 + drivers/phy/Kconfig | 1 + drivers/phy/Makefile | 1 + drivers/phy/sunplus/Kconfig | 12 + drivers/phy/sunplus/Makefile | 2 + drivers/phy/sunplus/phy-sunplus-usb2.c | 248 +++++++++++++++++++++ 7 files changed, 346 insertions(+) create mode 100644 Documentation/devicetree/bindings/phy/sunplus,sp7021-usb2-phy.yaml create mode 100644 drivers/phy/sunplus/Kconfig create mode 100644 drivers/phy/sunplus/Makefile create mode 100644 drivers/phy/sunplus/phy-sunplus-usb2.c -- 2.7.4 -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy ^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH v1 1/2] phy: usb: Add USB2.0 phy driver for Sunplus SP7021 2022-03-04 11:30 ` Vincent Shih @ 2022-03-04 11:30 ` Vincent Shih -1 siblings, 0 replies; 12+ messages in thread From: Vincent Shih @ 2022-03-04 11:30 UTC (permalink / raw) To: kishon, vkoul, p.zabel, linux-kernel, linux-phy, linux-usb, robh+dt, devicetree, wells.lu Cc: Vincent Shih Add USB2.0 phy driver for Sunplus SP7021 Signed-off-by: Vincent Shih <vincent.sunplus@gmail.com> --- MAINTAINERS | 8 ++ drivers/phy/Kconfig | 1 + drivers/phy/Makefile | 1 + drivers/phy/sunplus/Kconfig | 12 ++ drivers/phy/sunplus/Makefile | 2 + drivers/phy/sunplus/phy-sunplus-usb2.c | 248 +++++++++++++++++++++++++++++++++ 6 files changed, 272 insertions(+) create mode 100644 drivers/phy/sunplus/Kconfig create mode 100644 drivers/phy/sunplus/Makefile create mode 100644 drivers/phy/sunplus/phy-sunplus-usb2.c diff --git a/MAINTAINERS b/MAINTAINERS index 80eebc1..a3bb35e 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -17947,6 +17947,14 @@ L: netdev@vger.kernel.org S: Maintained F: drivers/net/ethernet/dlink/sundance.c +SUNPLUS USB2 PHY DRIVER +M: Vincent Shih <vincent.sunplus@gmail.com> +L: linux-usb@vger.kernel.org +S: Maintained +F: drivers/phy/sunplus/Kconfig +F: drivers/phy/sunplus/Makefile +F: drivers/phy/sunplus/phy-sunplus-usb2.c + SUPERH M: Yoshinori Sato <ysato@users.sourceforge.jp> M: Rich Felker <dalias@libc.org> diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig index 82b63e6..d97e22e 100644 --- a/drivers/phy/Kconfig +++ b/drivers/phy/Kconfig @@ -90,6 +90,7 @@ source "drivers/phy/rockchip/Kconfig" source "drivers/phy/samsung/Kconfig" source "drivers/phy/socionext/Kconfig" source "drivers/phy/st/Kconfig" +source "drivers/phy/sunplus/Kconfig" source "drivers/phy/tegra/Kconfig" source "drivers/phy/ti/Kconfig" source "drivers/phy/intel/Kconfig" diff --git a/drivers/phy/Makefile b/drivers/phy/Makefile index 01e9eff..ed88b6f 100644 --- a/drivers/phy/Makefile +++ b/drivers/phy/Makefile @@ -31,6 +31,7 @@ obj-y += allwinner/ \ samsung/ \ socionext/ \ st/ \ + sunplus/ \ tegra/ \ ti/ \ xilinx/ diff --git a/drivers/phy/sunplus/Kconfig b/drivers/phy/sunplus/Kconfig new file mode 100644 index 0000000..beb85f4 --- /dev/null +++ b/drivers/phy/sunplus/Kconfig @@ -0,0 +1,12 @@ +# SPDX-License-Identifier: GPL-2.0-only + +config PHY_SUNPLUS_USB + tristate "Sunplus USB2 PHY driver" + depends on OF && (SOC_SP7021 || COMPILE_TEST) + select GENERIC_PHY + help + Enable this to support the USB 2.0 PHY on Sunplus SP7021 + SoC. The USB 2.0 PHY controller supports battery charger + and synchronous signals, various power down modes including + operating, partial and suspend modes, and high-speed, + full-speed and low-speed data transfer. diff --git a/drivers/phy/sunplus/Makefile b/drivers/phy/sunplus/Makefile new file mode 100644 index 0000000..71754d5 --- /dev/null +++ b/drivers/phy/sunplus/Makefile @@ -0,0 +1,2 @@ +# SPDX-License-Identifier: GPL-2.0-only +obj-$(CONFIG_PHY_SUNPLUS_USB) += phy-sunplus-usb2.o diff --git a/drivers/phy/sunplus/phy-sunplus-usb2.c b/drivers/phy/sunplus/phy-sunplus-usb2.c new file mode 100644 index 0000000..a2c17ca --- /dev/null +++ b/drivers/phy/sunplus/phy-sunplus-usb2.c @@ -0,0 +1,248 @@ +// SPDX-License-Identifier: GPL-2.0 + +/* + * Sunplus SP7021 USB 2.0 phy driver + * + * Copyright (C) 2021 Sunplus Technology Inc., All rights reserved. + * + * Note 1 : non-posted write command for the registers accesses of + * Sunplus SP7021. + * + */ + +#include <linux/bitfield.h> +#include <linux/clk.h> +#include <linux/delay.h> +#include <linux/io.h> +#include <linux/module.h> +#include <linux/nvmem-consumer.h> +#include <linux/of_platform.h> +#include <linux/phy/phy.h> +#include <linux/platform_device.h> +#include <linux/reset.h> + +#define RF_MASK_V(_mask, _val) (((_mask) << 16) | (_val)) +#define RF_MASK_V_CLR(_mask) (((_mask) << 16) | 0) + +#define MASK_BITS 0xffff +#define OTP_DISC_LEVEL_DEFAULT 0xd + +// GROUP UPHY +#define CONFIG1 0x4 +#define J_HS_TX_PWRSAV BIT(5) +#define CONFIG3 0xc +#define J_FORCE_DISC_ON BIT(5) +#define J_DEBUG_CTRL_ADDR_MACRO BIT(0) +#define CONFIG7 0x1c +#define J_DISC 0X1f +#define CONFIG9 0x24 +#define J_ECO_PATH BIT(6) +#define CONFIG16 0x40 +#define J_TBCWAIT_MASK GENMASK(6, 5) +#define J_TBCWAIT_1P1_MS FIELD_PREP(J_TBCWAIT_MASK, 0) +#define J_TVDM_SRC_DIS_MASK GENMASK(4, 3) +#define J_TVDM_SRC_DIS_8P2_MS FIELD_PREP(J_TVDM_SRC_DIS_MASK, 3) +#define J_TVDM_SRC_EN_MASK GENMASK(2, 1) +#define J_TVDM_SRC_EN_1P6_MS FIELD_PREP(J_TVDM_SRC_EN_MASK, 0) +#define J_BC_EN BIT(0) +#define CONFIG17 0x44 +#define IBG_TRIM0_MASK GENMASK(7, 5) +#define IBG_TRIM0_SSLVHT FIELD_PREP(IBG_TRIM0_MASK, 4) +#define J_VDATREE_TRIM_MASK GENMASK(4, 1) +#define J_VDATREE_TRIM_DEFAULT FIELD_PREP(J_VDATREE_TRIM_MASK, 9) +#define CONFIG23 0x5c +#define PROB_MASK GENMASK(5, 3) +#define PROB FIELD_PREP(PROB_MASK, 7) + +// GROUP MOON4 +#define UPHY_CONTROL0 0x0 +#define UPHY_CONTROL1 0x4 +#define UPHY_CONTROL2 0x8 +#define MO1_UPHY_RX_CLK_SEL BIT(6) +#define UPHY_CONTROL3 0xc +#define MO1_UPHY_PLL_POWER_OFF_SEL BIT(7) +#define MO1_UPHY_PLL_POWER_OFF BIT(3) + +struct sp_usbphy { + struct device *dev; + struct resource *phy_res_mem; + struct resource *moon4_res_mem; + struct reset_control *rstc; + struct clk *phy_clk; + void __iomem *phy_regs; + void __iomem *moon4_regs; + u32 disc_vol_addr_off; +}; + +static int sp_uphy_init(struct phy *phy) +{ + struct sp_usbphy *usbphy = phy_get_drvdata(phy); + struct nvmem_cell *cell; + char *disc_name = "disc_vol"; + ssize_t otp_l = 0; + char *otp_v; + u32 val, set, pll_pwr_on, pll_pwr_off; + + /* Default value modification */ + writel(RF_MASK_V(MASK_BITS, 0x4002), usbphy->moon4_regs + UPHY_CONTROL0); + writel(RF_MASK_V(MASK_BITS, 0x8747), usbphy->moon4_regs + UPHY_CONTROL1); + + /* PLL power off/on twice */ + pll_pwr_off = (readl(usbphy->moon4_regs + UPHY_CONTROL3) & ~MASK_BITS) + | MO1_UPHY_PLL_POWER_OFF_SEL | MO1_UPHY_PLL_POWER_OFF; + pll_pwr_on = (readl(usbphy->moon4_regs + UPHY_CONTROL3) & ~MASK_BITS) + | MO1_UPHY_PLL_POWER_OFF_SEL; + + writel(RF_MASK_V(MASK_BITS, pll_pwr_off), usbphy->moon4_regs + UPHY_CONTROL3); + mdelay(1); + writel(RF_MASK_V(MASK_BITS, pll_pwr_on), usbphy->moon4_regs + UPHY_CONTROL3); + mdelay(1); + writel(RF_MASK_V(MASK_BITS, pll_pwr_off), usbphy->moon4_regs + UPHY_CONTROL3); + mdelay(1); + writel(RF_MASK_V(MASK_BITS, pll_pwr_on), usbphy->moon4_regs + UPHY_CONTROL3); + mdelay(1); + writel(RF_MASK_V(MASK_BITS, 0x0), usbphy->moon4_regs + UPHY_CONTROL3); + + /* board uphy 0 internal register modification for tid certification */ + cell = nvmem_cell_get(usbphy->dev, disc_name); + if (IS_ERR_OR_NULL(cell)) { + if (PTR_ERR(cell) == -EPROBE_DEFER) + return -EPROBE_DEFER; + } + + otp_v = nvmem_cell_read(cell, &otp_l); + nvmem_cell_put(cell); + + if (otp_v) { + set = *(otp_v + 1); + set = (set << (sizeof(char) * 8)) | *otp_v; + set = (set >> usbphy->disc_vol_addr_off) & J_DISC; + } + + if (!otp_v || set == 0) + set = OTP_DISC_LEVEL_DEFAULT; + + val = readl(usbphy->phy_regs + CONFIG7); + val = (val & ~J_DISC) | set; + writel(val, usbphy->phy_regs + CONFIG7); + + val = readl(usbphy->phy_regs + CONFIG9); + val &= ~(J_ECO_PATH); + writel(val, usbphy->phy_regs + CONFIG9); + + val = readl(usbphy->phy_regs + CONFIG1); + val &= ~(J_HS_TX_PWRSAV); + writel(val, usbphy->phy_regs + CONFIG1); + + val = readl(usbphy->phy_regs + CONFIG23); + val = (val & ~PROB) | PROB; + writel(val, usbphy->phy_regs + CONFIG23); + + /* port 0 uphy clk fix */ + writel(RF_MASK_V(MO1_UPHY_RX_CLK_SEL, MO1_UPHY_RX_CLK_SEL), + usbphy->moon4_regs + UPHY_CONTROL2); + + /* battery charger */ + writel(J_TBCWAIT_1P1_MS | J_TVDM_SRC_DIS_8P2_MS | J_TVDM_SRC_EN_1P6_MS | J_BC_EN, + usbphy->phy_regs + CONFIG16); + writel(IBG_TRIM0_SSLVHT | J_VDATREE_TRIM_DEFAULT, usbphy->phy_regs + CONFIG17); + + /* chirp mode */ + writel(J_FORCE_DISC_ON | J_DEBUG_CTRL_ADDR_MACRO, usbphy->phy_regs + CONFIG3); + + return 0; +} + +static const struct phy_ops sp_uphy_ops = { + .init = sp_uphy_init, +}; + +static const struct of_device_id sp_uphy_dt_ids[] = { + {.compatible = "sunplus,sp7021-usb2-phy", + .data = &sp_uphy_ops,}, + { } +}; +MODULE_DEVICE_TABLE(of, sp_uphy_dt_ids); + +static int sp_usb_phy_probe(struct platform_device *pdev) +{ + struct sp_usbphy *usbphy; + const struct phy_ops *phy_ops; + struct phy_provider *phy_provider; + struct phy *phy; + int ret; + + usbphy = devm_kzalloc(&pdev->dev, sizeof(*usbphy), GFP_KERNEL); + if (!usbphy) + return -ENOMEM; + + usbphy->dev = &pdev->dev; + + usbphy->phy_res_mem = platform_get_resource_byname(pdev, IORESOURCE_MEM, "phy"); + usbphy->phy_regs = devm_ioremap_resource(&pdev->dev, usbphy->phy_res_mem); + if (IS_ERR(usbphy->phy_regs)) + return PTR_ERR(usbphy->phy_regs); + + usbphy->moon4_res_mem = platform_get_resource_byname(pdev, IORESOURCE_MEM, "moon4"); + usbphy->moon4_regs = devm_ioremap(&pdev->dev, usbphy->moon4_res_mem->start, + resource_size(usbphy->moon4_res_mem)); + if (IS_ERR(usbphy->moon4_regs)) + return PTR_ERR(usbphy->moon4_regs); + + usbphy->phy_clk = devm_clk_get(&pdev->dev, NULL); + if (IS_ERR(usbphy->phy_clk)) + return PTR_ERR(usbphy->phy_clk); + + usbphy->rstc = devm_reset_control_get_exclusive(&pdev->dev, NULL); + if (IS_ERR(usbphy->rstc)) + return PTR_ERR(usbphy->rstc); + + ret = clk_prepare_enable(usbphy->phy_clk); + if (ret) + goto err_clk; + + ret = reset_control_deassert(usbphy->rstc); + if (ret) + goto err_reset; + + of_property_read_u32(pdev->dev.of_node, "sunplus,disc-vol-addr-off", + &usbphy->disc_vol_addr_off); + + phy_ops = of_device_get_match_data(&pdev->dev); + if (!phy_ops) { + ret = -EINVAL; + goto err_reset; + } + + phy = devm_phy_create(&pdev->dev, NULL, phy_ops); + if (IS_ERR(phy)) { + ret = -PTR_ERR(phy); + goto err_reset; + } + + phy_set_drvdata(phy, usbphy); + phy_provider = devm_of_phy_provider_register(&pdev->dev, of_phy_simple_xlate); + + return PTR_ERR_OR_ZERO(phy_provider); + +err_reset: + reset_control_assert(usbphy->rstc); +err_clk: + clk_disable_unprepare(usbphy->phy_clk); + + return ret; +} + +static struct platform_driver sunplus_usb_phy_driver = { + .probe = sp_usb_phy_probe, + .driver = { + .name = "sunplus-usb2-phy", + .of_match_table = sp_uphy_dt_ids, + }, +}; +module_platform_driver(sunplus_usb_phy_driver); + +MODULE_AUTHOR("Vincent Shih <vincent.shih@sunplus.com>"); +MODULE_DESCRIPTION("Sunplus USB 2.0 phy driver"); +MODULE_LICENSE("GPL v2"); + -- 2.7.4 ^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH v1 1/2] phy: usb: Add USB2.0 phy driver for Sunplus SP7021 @ 2022-03-04 11:30 ` Vincent Shih 0 siblings, 0 replies; 12+ messages in thread From: Vincent Shih @ 2022-03-04 11:30 UTC (permalink / raw) To: kishon, vkoul, p.zabel, linux-kernel, linux-phy, linux-usb, robh+dt, devicetree, wells.lu Cc: Vincent Shih Add USB2.0 phy driver for Sunplus SP7021 Signed-off-by: Vincent Shih <vincent.sunplus@gmail.com> --- MAINTAINERS | 8 ++ drivers/phy/Kconfig | 1 + drivers/phy/Makefile | 1 + drivers/phy/sunplus/Kconfig | 12 ++ drivers/phy/sunplus/Makefile | 2 + drivers/phy/sunplus/phy-sunplus-usb2.c | 248 +++++++++++++++++++++++++++++++++ 6 files changed, 272 insertions(+) create mode 100644 drivers/phy/sunplus/Kconfig create mode 100644 drivers/phy/sunplus/Makefile create mode 100644 drivers/phy/sunplus/phy-sunplus-usb2.c diff --git a/MAINTAINERS b/MAINTAINERS index 80eebc1..a3bb35e 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -17947,6 +17947,14 @@ L: netdev@vger.kernel.org S: Maintained F: drivers/net/ethernet/dlink/sundance.c +SUNPLUS USB2 PHY DRIVER +M: Vincent Shih <vincent.sunplus@gmail.com> +L: linux-usb@vger.kernel.org +S: Maintained +F: drivers/phy/sunplus/Kconfig +F: drivers/phy/sunplus/Makefile +F: drivers/phy/sunplus/phy-sunplus-usb2.c + SUPERH M: Yoshinori Sato <ysato@users.sourceforge.jp> M: Rich Felker <dalias@libc.org> diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig index 82b63e6..d97e22e 100644 --- a/drivers/phy/Kconfig +++ b/drivers/phy/Kconfig @@ -90,6 +90,7 @@ source "drivers/phy/rockchip/Kconfig" source "drivers/phy/samsung/Kconfig" source "drivers/phy/socionext/Kconfig" source "drivers/phy/st/Kconfig" +source "drivers/phy/sunplus/Kconfig" source "drivers/phy/tegra/Kconfig" source "drivers/phy/ti/Kconfig" source "drivers/phy/intel/Kconfig" diff --git a/drivers/phy/Makefile b/drivers/phy/Makefile index 01e9eff..ed88b6f 100644 --- a/drivers/phy/Makefile +++ b/drivers/phy/Makefile @@ -31,6 +31,7 @@ obj-y += allwinner/ \ samsung/ \ socionext/ \ st/ \ + sunplus/ \ tegra/ \ ti/ \ xilinx/ diff --git a/drivers/phy/sunplus/Kconfig b/drivers/phy/sunplus/Kconfig new file mode 100644 index 0000000..beb85f4 --- /dev/null +++ b/drivers/phy/sunplus/Kconfig @@ -0,0 +1,12 @@ +# SPDX-License-Identifier: GPL-2.0-only + +config PHY_SUNPLUS_USB + tristate "Sunplus USB2 PHY driver" + depends on OF && (SOC_SP7021 || COMPILE_TEST) + select GENERIC_PHY + help + Enable this to support the USB 2.0 PHY on Sunplus SP7021 + SoC. The USB 2.0 PHY controller supports battery charger + and synchronous signals, various power down modes including + operating, partial and suspend modes, and high-speed, + full-speed and low-speed data transfer. diff --git a/drivers/phy/sunplus/Makefile b/drivers/phy/sunplus/Makefile new file mode 100644 index 0000000..71754d5 --- /dev/null +++ b/drivers/phy/sunplus/Makefile @@ -0,0 +1,2 @@ +# SPDX-License-Identifier: GPL-2.0-only +obj-$(CONFIG_PHY_SUNPLUS_USB) += phy-sunplus-usb2.o diff --git a/drivers/phy/sunplus/phy-sunplus-usb2.c b/drivers/phy/sunplus/phy-sunplus-usb2.c new file mode 100644 index 0000000..a2c17ca --- /dev/null +++ b/drivers/phy/sunplus/phy-sunplus-usb2.c @@ -0,0 +1,248 @@ +// SPDX-License-Identifier: GPL-2.0 + +/* + * Sunplus SP7021 USB 2.0 phy driver + * + * Copyright (C) 2021 Sunplus Technology Inc., All rights reserved. + * + * Note 1 : non-posted write command for the registers accesses of + * Sunplus SP7021. + * + */ + +#include <linux/bitfield.h> +#include <linux/clk.h> +#include <linux/delay.h> +#include <linux/io.h> +#include <linux/module.h> +#include <linux/nvmem-consumer.h> +#include <linux/of_platform.h> +#include <linux/phy/phy.h> +#include <linux/platform_device.h> +#include <linux/reset.h> + +#define RF_MASK_V(_mask, _val) (((_mask) << 16) | (_val)) +#define RF_MASK_V_CLR(_mask) (((_mask) << 16) | 0) + +#define MASK_BITS 0xffff +#define OTP_DISC_LEVEL_DEFAULT 0xd + +// GROUP UPHY +#define CONFIG1 0x4 +#define J_HS_TX_PWRSAV BIT(5) +#define CONFIG3 0xc +#define J_FORCE_DISC_ON BIT(5) +#define J_DEBUG_CTRL_ADDR_MACRO BIT(0) +#define CONFIG7 0x1c +#define J_DISC 0X1f +#define CONFIG9 0x24 +#define J_ECO_PATH BIT(6) +#define CONFIG16 0x40 +#define J_TBCWAIT_MASK GENMASK(6, 5) +#define J_TBCWAIT_1P1_MS FIELD_PREP(J_TBCWAIT_MASK, 0) +#define J_TVDM_SRC_DIS_MASK GENMASK(4, 3) +#define J_TVDM_SRC_DIS_8P2_MS FIELD_PREP(J_TVDM_SRC_DIS_MASK, 3) +#define J_TVDM_SRC_EN_MASK GENMASK(2, 1) +#define J_TVDM_SRC_EN_1P6_MS FIELD_PREP(J_TVDM_SRC_EN_MASK, 0) +#define J_BC_EN BIT(0) +#define CONFIG17 0x44 +#define IBG_TRIM0_MASK GENMASK(7, 5) +#define IBG_TRIM0_SSLVHT FIELD_PREP(IBG_TRIM0_MASK, 4) +#define J_VDATREE_TRIM_MASK GENMASK(4, 1) +#define J_VDATREE_TRIM_DEFAULT FIELD_PREP(J_VDATREE_TRIM_MASK, 9) +#define CONFIG23 0x5c +#define PROB_MASK GENMASK(5, 3) +#define PROB FIELD_PREP(PROB_MASK, 7) + +// GROUP MOON4 +#define UPHY_CONTROL0 0x0 +#define UPHY_CONTROL1 0x4 +#define UPHY_CONTROL2 0x8 +#define MO1_UPHY_RX_CLK_SEL BIT(6) +#define UPHY_CONTROL3 0xc +#define MO1_UPHY_PLL_POWER_OFF_SEL BIT(7) +#define MO1_UPHY_PLL_POWER_OFF BIT(3) + +struct sp_usbphy { + struct device *dev; + struct resource *phy_res_mem; + struct resource *moon4_res_mem; + struct reset_control *rstc; + struct clk *phy_clk; + void __iomem *phy_regs; + void __iomem *moon4_regs; + u32 disc_vol_addr_off; +}; + +static int sp_uphy_init(struct phy *phy) +{ + struct sp_usbphy *usbphy = phy_get_drvdata(phy); + struct nvmem_cell *cell; + char *disc_name = "disc_vol"; + ssize_t otp_l = 0; + char *otp_v; + u32 val, set, pll_pwr_on, pll_pwr_off; + + /* Default value modification */ + writel(RF_MASK_V(MASK_BITS, 0x4002), usbphy->moon4_regs + UPHY_CONTROL0); + writel(RF_MASK_V(MASK_BITS, 0x8747), usbphy->moon4_regs + UPHY_CONTROL1); + + /* PLL power off/on twice */ + pll_pwr_off = (readl(usbphy->moon4_regs + UPHY_CONTROL3) & ~MASK_BITS) + | MO1_UPHY_PLL_POWER_OFF_SEL | MO1_UPHY_PLL_POWER_OFF; + pll_pwr_on = (readl(usbphy->moon4_regs + UPHY_CONTROL3) & ~MASK_BITS) + | MO1_UPHY_PLL_POWER_OFF_SEL; + + writel(RF_MASK_V(MASK_BITS, pll_pwr_off), usbphy->moon4_regs + UPHY_CONTROL3); + mdelay(1); + writel(RF_MASK_V(MASK_BITS, pll_pwr_on), usbphy->moon4_regs + UPHY_CONTROL3); + mdelay(1); + writel(RF_MASK_V(MASK_BITS, pll_pwr_off), usbphy->moon4_regs + UPHY_CONTROL3); + mdelay(1); + writel(RF_MASK_V(MASK_BITS, pll_pwr_on), usbphy->moon4_regs + UPHY_CONTROL3); + mdelay(1); + writel(RF_MASK_V(MASK_BITS, 0x0), usbphy->moon4_regs + UPHY_CONTROL3); + + /* board uphy 0 internal register modification for tid certification */ + cell = nvmem_cell_get(usbphy->dev, disc_name); + if (IS_ERR_OR_NULL(cell)) { + if (PTR_ERR(cell) == -EPROBE_DEFER) + return -EPROBE_DEFER; + } + + otp_v = nvmem_cell_read(cell, &otp_l); + nvmem_cell_put(cell); + + if (otp_v) { + set = *(otp_v + 1); + set = (set << (sizeof(char) * 8)) | *otp_v; + set = (set >> usbphy->disc_vol_addr_off) & J_DISC; + } + + if (!otp_v || set == 0) + set = OTP_DISC_LEVEL_DEFAULT; + + val = readl(usbphy->phy_regs + CONFIG7); + val = (val & ~J_DISC) | set; + writel(val, usbphy->phy_regs + CONFIG7); + + val = readl(usbphy->phy_regs + CONFIG9); + val &= ~(J_ECO_PATH); + writel(val, usbphy->phy_regs + CONFIG9); + + val = readl(usbphy->phy_regs + CONFIG1); + val &= ~(J_HS_TX_PWRSAV); + writel(val, usbphy->phy_regs + CONFIG1); + + val = readl(usbphy->phy_regs + CONFIG23); + val = (val & ~PROB) | PROB; + writel(val, usbphy->phy_regs + CONFIG23); + + /* port 0 uphy clk fix */ + writel(RF_MASK_V(MO1_UPHY_RX_CLK_SEL, MO1_UPHY_RX_CLK_SEL), + usbphy->moon4_regs + UPHY_CONTROL2); + + /* battery charger */ + writel(J_TBCWAIT_1P1_MS | J_TVDM_SRC_DIS_8P2_MS | J_TVDM_SRC_EN_1P6_MS | J_BC_EN, + usbphy->phy_regs + CONFIG16); + writel(IBG_TRIM0_SSLVHT | J_VDATREE_TRIM_DEFAULT, usbphy->phy_regs + CONFIG17); + + /* chirp mode */ + writel(J_FORCE_DISC_ON | J_DEBUG_CTRL_ADDR_MACRO, usbphy->phy_regs + CONFIG3); + + return 0; +} + +static const struct phy_ops sp_uphy_ops = { + .init = sp_uphy_init, +}; + +static const struct of_device_id sp_uphy_dt_ids[] = { + {.compatible = "sunplus,sp7021-usb2-phy", + .data = &sp_uphy_ops,}, + { } +}; +MODULE_DEVICE_TABLE(of, sp_uphy_dt_ids); + +static int sp_usb_phy_probe(struct platform_device *pdev) +{ + struct sp_usbphy *usbphy; + const struct phy_ops *phy_ops; + struct phy_provider *phy_provider; + struct phy *phy; + int ret; + + usbphy = devm_kzalloc(&pdev->dev, sizeof(*usbphy), GFP_KERNEL); + if (!usbphy) + return -ENOMEM; + + usbphy->dev = &pdev->dev; + + usbphy->phy_res_mem = platform_get_resource_byname(pdev, IORESOURCE_MEM, "phy"); + usbphy->phy_regs = devm_ioremap_resource(&pdev->dev, usbphy->phy_res_mem); + if (IS_ERR(usbphy->phy_regs)) + return PTR_ERR(usbphy->phy_regs); + + usbphy->moon4_res_mem = platform_get_resource_byname(pdev, IORESOURCE_MEM, "moon4"); + usbphy->moon4_regs = devm_ioremap(&pdev->dev, usbphy->moon4_res_mem->start, + resource_size(usbphy->moon4_res_mem)); + if (IS_ERR(usbphy->moon4_regs)) + return PTR_ERR(usbphy->moon4_regs); + + usbphy->phy_clk = devm_clk_get(&pdev->dev, NULL); + if (IS_ERR(usbphy->phy_clk)) + return PTR_ERR(usbphy->phy_clk); + + usbphy->rstc = devm_reset_control_get_exclusive(&pdev->dev, NULL); + if (IS_ERR(usbphy->rstc)) + return PTR_ERR(usbphy->rstc); + + ret = clk_prepare_enable(usbphy->phy_clk); + if (ret) + goto err_clk; + + ret = reset_control_deassert(usbphy->rstc); + if (ret) + goto err_reset; + + of_property_read_u32(pdev->dev.of_node, "sunplus,disc-vol-addr-off", + &usbphy->disc_vol_addr_off); + + phy_ops = of_device_get_match_data(&pdev->dev); + if (!phy_ops) { + ret = -EINVAL; + goto err_reset; + } + + phy = devm_phy_create(&pdev->dev, NULL, phy_ops); + if (IS_ERR(phy)) { + ret = -PTR_ERR(phy); + goto err_reset; + } + + phy_set_drvdata(phy, usbphy); + phy_provider = devm_of_phy_provider_register(&pdev->dev, of_phy_simple_xlate); + + return PTR_ERR_OR_ZERO(phy_provider); + +err_reset: + reset_control_assert(usbphy->rstc); +err_clk: + clk_disable_unprepare(usbphy->phy_clk); + + return ret; +} + +static struct platform_driver sunplus_usb_phy_driver = { + .probe = sp_usb_phy_probe, + .driver = { + .name = "sunplus-usb2-phy", + .of_match_table = sp_uphy_dt_ids, + }, +}; +module_platform_driver(sunplus_usb_phy_driver); + +MODULE_AUTHOR("Vincent Shih <vincent.shih@sunplus.com>"); +MODULE_DESCRIPTION("Sunplus USB 2.0 phy driver"); +MODULE_LICENSE("GPL v2"); + -- 2.7.4 -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy ^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH v1 1/2] phy: usb: Add USB2.0 phy driver for Sunplus SP7021 2022-03-04 11:30 ` Vincent Shih @ 2022-04-13 9:49 ` Vinod Koul -1 siblings, 0 replies; 12+ messages in thread From: Vinod Koul @ 2022-04-13 9:49 UTC (permalink / raw) To: Vincent Shih Cc: kishon, p.zabel, linux-kernel, linux-phy, linux-usb, robh+dt, devicetree, wells.lu On 04-03-22, 19:30, Vincent Shih wrote: > Add USB2.0 phy driver for Sunplus SP7021 > > Signed-off-by: Vincent Shih <vincent.sunplus@gmail.com> > --- > MAINTAINERS | 8 ++ > drivers/phy/Kconfig | 1 + > drivers/phy/Makefile | 1 + > drivers/phy/sunplus/Kconfig | 12 ++ > drivers/phy/sunplus/Makefile | 2 + > drivers/phy/sunplus/phy-sunplus-usb2.c | 248 +++++++++++++++++++++++++++++++++ > 6 files changed, 272 insertions(+) > create mode 100644 drivers/phy/sunplus/Kconfig > create mode 100644 drivers/phy/sunplus/Makefile > create mode 100644 drivers/phy/sunplus/phy-sunplus-usb2.c > > diff --git a/MAINTAINERS b/MAINTAINERS > index 80eebc1..a3bb35e 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -17947,6 +17947,14 @@ L: netdev@vger.kernel.org > S: Maintained > F: drivers/net/ethernet/dlink/sundance.c > > +SUNPLUS USB2 PHY DRIVER > +M: Vincent Shih <vincent.sunplus@gmail.com> > +L: linux-usb@vger.kernel.org > +S: Maintained > +F: drivers/phy/sunplus/Kconfig > +F: drivers/phy/sunplus/Makefile > +F: drivers/phy/sunplus/phy-sunplus-usb2.c > + > SUPERH > M: Yoshinori Sato <ysato@users.sourceforge.jp> > M: Rich Felker <dalias@libc.org> > diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig > index 82b63e6..d97e22e 100644 > --- a/drivers/phy/Kconfig > +++ b/drivers/phy/Kconfig > @@ -90,6 +90,7 @@ source "drivers/phy/rockchip/Kconfig" > source "drivers/phy/samsung/Kconfig" > source "drivers/phy/socionext/Kconfig" > source "drivers/phy/st/Kconfig" > +source "drivers/phy/sunplus/Kconfig" > source "drivers/phy/tegra/Kconfig" > source "drivers/phy/ti/Kconfig" > source "drivers/phy/intel/Kconfig" > diff --git a/drivers/phy/Makefile b/drivers/phy/Makefile > index 01e9eff..ed88b6f 100644 > --- a/drivers/phy/Makefile > +++ b/drivers/phy/Makefile > @@ -31,6 +31,7 @@ obj-y += allwinner/ \ > samsung/ \ > socionext/ \ > st/ \ > + sunplus/ \ > tegra/ \ > ti/ \ > xilinx/ > diff --git a/drivers/phy/sunplus/Kconfig b/drivers/phy/sunplus/Kconfig > new file mode 100644 > index 0000000..beb85f4 > --- /dev/null > +++ b/drivers/phy/sunplus/Kconfig > @@ -0,0 +1,12 @@ > +# SPDX-License-Identifier: GPL-2.0-only > + > +config PHY_SUNPLUS_USB > + tristate "Sunplus USB2 PHY driver" > + depends on OF && (SOC_SP7021 || COMPILE_TEST) > + select GENERIC_PHY > + help > + Enable this to support the USB 2.0 PHY on Sunplus SP7021 > + SoC. The USB 2.0 PHY controller supports battery charger > + and synchronous signals, various power down modes including > + operating, partial and suspend modes, and high-speed, > + full-speed and low-speed data transfer. > diff --git a/drivers/phy/sunplus/Makefile b/drivers/phy/sunplus/Makefile > new file mode 100644 > index 0000000..71754d5 > --- /dev/null > +++ b/drivers/phy/sunplus/Makefile > @@ -0,0 +1,2 @@ > +# SPDX-License-Identifier: GPL-2.0-only > +obj-$(CONFIG_PHY_SUNPLUS_USB) += phy-sunplus-usb2.o > diff --git a/drivers/phy/sunplus/phy-sunplus-usb2.c b/drivers/phy/sunplus/phy-sunplus-usb2.c > new file mode 100644 > index 0000000..a2c17ca > --- /dev/null > +++ b/drivers/phy/sunplus/phy-sunplus-usb2.c > @@ -0,0 +1,248 @@ > +// SPDX-License-Identifier: GPL-2.0 > + > +/* > + * Sunplus SP7021 USB 2.0 phy driver > + * > + * Copyright (C) 2021 Sunplus Technology Inc., All rights reserved. 2022 > + * > + * Note 1 : non-posted write command for the registers accesses of > + * Sunplus SP7021. > + * > + */ > + > +#include <linux/bitfield.h> > +#include <linux/clk.h> > +#include <linux/delay.h> > +#include <linux/io.h> > +#include <linux/module.h> > +#include <linux/nvmem-consumer.h> > +#include <linux/of_platform.h> > +#include <linux/phy/phy.h> > +#include <linux/platform_device.h> > +#include <linux/reset.h> > + > +#define RF_MASK_V(_mask, _val) (((_mask) << 16) | (_val)) > +#define RF_MASK_V_CLR(_mask) (((_mask) << 16) | 0) Please use FIELD_PREP and FIELD_GET macros for these > + > +#define MASK_BITS 0xffff > +#define OTP_DISC_LEVEL_DEFAULT 0xd > + > +// GROUP UPHY > +#define CONFIG1 0x4 > +#define J_HS_TX_PWRSAV BIT(5) > +#define CONFIG3 0xc GENAMSK() ? > +#define J_FORCE_DISC_ON BIT(5) > +#define J_DEBUG_CTRL_ADDR_MACRO BIT(0) > +#define CONFIG7 0x1c > +#define J_DISC 0X1f > +#define CONFIG9 0x24 > +#define J_ECO_PATH BIT(6) > +#define CONFIG16 0x40 > +#define J_TBCWAIT_MASK GENMASK(6, 5) > +#define J_TBCWAIT_1P1_MS FIELD_PREP(J_TBCWAIT_MASK, 0) > +#define J_TVDM_SRC_DIS_MASK GENMASK(4, 3) > +#define J_TVDM_SRC_DIS_8P2_MS FIELD_PREP(J_TVDM_SRC_DIS_MASK, 3) > +#define J_TVDM_SRC_EN_MASK GENMASK(2, 1) > +#define J_TVDM_SRC_EN_1P6_MS FIELD_PREP(J_TVDM_SRC_EN_MASK, 0) > +#define J_BC_EN BIT(0) > +#define CONFIG17 0x44 > +#define IBG_TRIM0_MASK GENMASK(7, 5) > +#define IBG_TRIM0_SSLVHT FIELD_PREP(IBG_TRIM0_MASK, 4) > +#define J_VDATREE_TRIM_MASK GENMASK(4, 1) > +#define J_VDATREE_TRIM_DEFAULT FIELD_PREP(J_VDATREE_TRIM_MASK, 9) > +#define CONFIG23 0x5c > +#define PROB_MASK GENMASK(5, 3) > +#define PROB FIELD_PREP(PROB_MASK, 7) > + > +// GROUP MOON4 wrong comments style > +static int sp_uphy_init(struct phy *phy) > +{ > + struct sp_usbphy *usbphy = phy_get_drvdata(phy); > + struct nvmem_cell *cell; > + char *disc_name = "disc_vol"; > + ssize_t otp_l = 0; > + char *otp_v; > + u32 val, set, pll_pwr_on, pll_pwr_off; > + > + /* Default value modification */ > + writel(RF_MASK_V(MASK_BITS, 0x4002), usbphy->moon4_regs + UPHY_CONTROL0); > + writel(RF_MASK_V(MASK_BITS, 0x8747), usbphy->moon4_regs + UPHY_CONTROL1); > + > + /* PLL power off/on twice */ > + pll_pwr_off = (readl(usbphy->moon4_regs + UPHY_CONTROL3) & ~MASK_BITS) > + | MO1_UPHY_PLL_POWER_OFF_SEL | MO1_UPHY_PLL_POWER_OFF; > + pll_pwr_on = (readl(usbphy->moon4_regs + UPHY_CONTROL3) & ~MASK_BITS) > + | MO1_UPHY_PLL_POWER_OFF_SEL; > + > + writel(RF_MASK_V(MASK_BITS, pll_pwr_off), usbphy->moon4_regs + UPHY_CONTROL3); > + mdelay(1); > + writel(RF_MASK_V(MASK_BITS, pll_pwr_on), usbphy->moon4_regs + UPHY_CONTROL3); > + mdelay(1); > + writel(RF_MASK_V(MASK_BITS, pll_pwr_off), usbphy->moon4_regs + UPHY_CONTROL3); > + mdelay(1); > + writel(RF_MASK_V(MASK_BITS, pll_pwr_on), usbphy->moon4_regs + UPHY_CONTROL3); > + mdelay(1); why delay on each register write? > + writel(RF_MASK_V(MASK_BITS, 0x0), usbphy->moon4_regs + UPHY_CONTROL3); > + > + /* board uphy 0 internal register modification for tid certification */ > + cell = nvmem_cell_get(usbphy->dev, disc_name); > + if (IS_ERR_OR_NULL(cell)) { > + if (PTR_ERR(cell) == -EPROBE_DEFER) > + return -EPROBE_DEFER; > + } > + > + otp_v = nvmem_cell_read(cell, &otp_l); > + nvmem_cell_put(cell); > + > + if (otp_v) { > + set = *(otp_v + 1); > + set = (set << (sizeof(char) * 8)) | *otp_v; > + set = (set >> usbphy->disc_vol_addr_off) & J_DISC; > + } > + > + if (!otp_v || set == 0) > + set = OTP_DISC_LEVEL_DEFAULT; > + > + val = readl(usbphy->phy_regs + CONFIG7); > + val = (val & ~J_DISC) | set; > + writel(val, usbphy->phy_regs + CONFIG7); maybe add a updatel() macro > +static const struct phy_ops sp_uphy_ops = { > + .init = sp_uphy_init, no power_on/off/exit routines?? > +static const struct of_device_id sp_uphy_dt_ids[] = { > + {.compatible = "sunplus,sp7021-usb2-phy", > + .data = &sp_uphy_ops,}, why should the ops be in driver data? -- ~Vinod ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v1 1/2] phy: usb: Add USB2.0 phy driver for Sunplus SP7021 @ 2022-04-13 9:49 ` Vinod Koul 0 siblings, 0 replies; 12+ messages in thread From: Vinod Koul @ 2022-04-13 9:49 UTC (permalink / raw) To: Vincent Shih Cc: kishon, p.zabel, linux-kernel, linux-phy, linux-usb, robh+dt, devicetree, wells.lu On 04-03-22, 19:30, Vincent Shih wrote: > Add USB2.0 phy driver for Sunplus SP7021 > > Signed-off-by: Vincent Shih <vincent.sunplus@gmail.com> > --- > MAINTAINERS | 8 ++ > drivers/phy/Kconfig | 1 + > drivers/phy/Makefile | 1 + > drivers/phy/sunplus/Kconfig | 12 ++ > drivers/phy/sunplus/Makefile | 2 + > drivers/phy/sunplus/phy-sunplus-usb2.c | 248 +++++++++++++++++++++++++++++++++ > 6 files changed, 272 insertions(+) > create mode 100644 drivers/phy/sunplus/Kconfig > create mode 100644 drivers/phy/sunplus/Makefile > create mode 100644 drivers/phy/sunplus/phy-sunplus-usb2.c > > diff --git a/MAINTAINERS b/MAINTAINERS > index 80eebc1..a3bb35e 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -17947,6 +17947,14 @@ L: netdev@vger.kernel.org > S: Maintained > F: drivers/net/ethernet/dlink/sundance.c > > +SUNPLUS USB2 PHY DRIVER > +M: Vincent Shih <vincent.sunplus@gmail.com> > +L: linux-usb@vger.kernel.org > +S: Maintained > +F: drivers/phy/sunplus/Kconfig > +F: drivers/phy/sunplus/Makefile > +F: drivers/phy/sunplus/phy-sunplus-usb2.c > + > SUPERH > M: Yoshinori Sato <ysato@users.sourceforge.jp> > M: Rich Felker <dalias@libc.org> > diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig > index 82b63e6..d97e22e 100644 > --- a/drivers/phy/Kconfig > +++ b/drivers/phy/Kconfig > @@ -90,6 +90,7 @@ source "drivers/phy/rockchip/Kconfig" > source "drivers/phy/samsung/Kconfig" > source "drivers/phy/socionext/Kconfig" > source "drivers/phy/st/Kconfig" > +source "drivers/phy/sunplus/Kconfig" > source "drivers/phy/tegra/Kconfig" > source "drivers/phy/ti/Kconfig" > source "drivers/phy/intel/Kconfig" > diff --git a/drivers/phy/Makefile b/drivers/phy/Makefile > index 01e9eff..ed88b6f 100644 > --- a/drivers/phy/Makefile > +++ b/drivers/phy/Makefile > @@ -31,6 +31,7 @@ obj-y += allwinner/ \ > samsung/ \ > socionext/ \ > st/ \ > + sunplus/ \ > tegra/ \ > ti/ \ > xilinx/ > diff --git a/drivers/phy/sunplus/Kconfig b/drivers/phy/sunplus/Kconfig > new file mode 100644 > index 0000000..beb85f4 > --- /dev/null > +++ b/drivers/phy/sunplus/Kconfig > @@ -0,0 +1,12 @@ > +# SPDX-License-Identifier: GPL-2.0-only > + > +config PHY_SUNPLUS_USB > + tristate "Sunplus USB2 PHY driver" > + depends on OF && (SOC_SP7021 || COMPILE_TEST) > + select GENERIC_PHY > + help > + Enable this to support the USB 2.0 PHY on Sunplus SP7021 > + SoC. The USB 2.0 PHY controller supports battery charger > + and synchronous signals, various power down modes including > + operating, partial and suspend modes, and high-speed, > + full-speed and low-speed data transfer. > diff --git a/drivers/phy/sunplus/Makefile b/drivers/phy/sunplus/Makefile > new file mode 100644 > index 0000000..71754d5 > --- /dev/null > +++ b/drivers/phy/sunplus/Makefile > @@ -0,0 +1,2 @@ > +# SPDX-License-Identifier: GPL-2.0-only > +obj-$(CONFIG_PHY_SUNPLUS_USB) += phy-sunplus-usb2.o > diff --git a/drivers/phy/sunplus/phy-sunplus-usb2.c b/drivers/phy/sunplus/phy-sunplus-usb2.c > new file mode 100644 > index 0000000..a2c17ca > --- /dev/null > +++ b/drivers/phy/sunplus/phy-sunplus-usb2.c > @@ -0,0 +1,248 @@ > +// SPDX-License-Identifier: GPL-2.0 > + > +/* > + * Sunplus SP7021 USB 2.0 phy driver > + * > + * Copyright (C) 2021 Sunplus Technology Inc., All rights reserved. 2022 > + * > + * Note 1 : non-posted write command for the registers accesses of > + * Sunplus SP7021. > + * > + */ > + > +#include <linux/bitfield.h> > +#include <linux/clk.h> > +#include <linux/delay.h> > +#include <linux/io.h> > +#include <linux/module.h> > +#include <linux/nvmem-consumer.h> > +#include <linux/of_platform.h> > +#include <linux/phy/phy.h> > +#include <linux/platform_device.h> > +#include <linux/reset.h> > + > +#define RF_MASK_V(_mask, _val) (((_mask) << 16) | (_val)) > +#define RF_MASK_V_CLR(_mask) (((_mask) << 16) | 0) Please use FIELD_PREP and FIELD_GET macros for these > + > +#define MASK_BITS 0xffff > +#define OTP_DISC_LEVEL_DEFAULT 0xd > + > +// GROUP UPHY > +#define CONFIG1 0x4 > +#define J_HS_TX_PWRSAV BIT(5) > +#define CONFIG3 0xc GENAMSK() ? > +#define J_FORCE_DISC_ON BIT(5) > +#define J_DEBUG_CTRL_ADDR_MACRO BIT(0) > +#define CONFIG7 0x1c > +#define J_DISC 0X1f > +#define CONFIG9 0x24 > +#define J_ECO_PATH BIT(6) > +#define CONFIG16 0x40 > +#define J_TBCWAIT_MASK GENMASK(6, 5) > +#define J_TBCWAIT_1P1_MS FIELD_PREP(J_TBCWAIT_MASK, 0) > +#define J_TVDM_SRC_DIS_MASK GENMASK(4, 3) > +#define J_TVDM_SRC_DIS_8P2_MS FIELD_PREP(J_TVDM_SRC_DIS_MASK, 3) > +#define J_TVDM_SRC_EN_MASK GENMASK(2, 1) > +#define J_TVDM_SRC_EN_1P6_MS FIELD_PREP(J_TVDM_SRC_EN_MASK, 0) > +#define J_BC_EN BIT(0) > +#define CONFIG17 0x44 > +#define IBG_TRIM0_MASK GENMASK(7, 5) > +#define IBG_TRIM0_SSLVHT FIELD_PREP(IBG_TRIM0_MASK, 4) > +#define J_VDATREE_TRIM_MASK GENMASK(4, 1) > +#define J_VDATREE_TRIM_DEFAULT FIELD_PREP(J_VDATREE_TRIM_MASK, 9) > +#define CONFIG23 0x5c > +#define PROB_MASK GENMASK(5, 3) > +#define PROB FIELD_PREP(PROB_MASK, 7) > + > +// GROUP MOON4 wrong comments style > +static int sp_uphy_init(struct phy *phy) > +{ > + struct sp_usbphy *usbphy = phy_get_drvdata(phy); > + struct nvmem_cell *cell; > + char *disc_name = "disc_vol"; > + ssize_t otp_l = 0; > + char *otp_v; > + u32 val, set, pll_pwr_on, pll_pwr_off; > + > + /* Default value modification */ > + writel(RF_MASK_V(MASK_BITS, 0x4002), usbphy->moon4_regs + UPHY_CONTROL0); > + writel(RF_MASK_V(MASK_BITS, 0x8747), usbphy->moon4_regs + UPHY_CONTROL1); > + > + /* PLL power off/on twice */ > + pll_pwr_off = (readl(usbphy->moon4_regs + UPHY_CONTROL3) & ~MASK_BITS) > + | MO1_UPHY_PLL_POWER_OFF_SEL | MO1_UPHY_PLL_POWER_OFF; > + pll_pwr_on = (readl(usbphy->moon4_regs + UPHY_CONTROL3) & ~MASK_BITS) > + | MO1_UPHY_PLL_POWER_OFF_SEL; > + > + writel(RF_MASK_V(MASK_BITS, pll_pwr_off), usbphy->moon4_regs + UPHY_CONTROL3); > + mdelay(1); > + writel(RF_MASK_V(MASK_BITS, pll_pwr_on), usbphy->moon4_regs + UPHY_CONTROL3); > + mdelay(1); > + writel(RF_MASK_V(MASK_BITS, pll_pwr_off), usbphy->moon4_regs + UPHY_CONTROL3); > + mdelay(1); > + writel(RF_MASK_V(MASK_BITS, pll_pwr_on), usbphy->moon4_regs + UPHY_CONTROL3); > + mdelay(1); why delay on each register write? > + writel(RF_MASK_V(MASK_BITS, 0x0), usbphy->moon4_regs + UPHY_CONTROL3); > + > + /* board uphy 0 internal register modification for tid certification */ > + cell = nvmem_cell_get(usbphy->dev, disc_name); > + if (IS_ERR_OR_NULL(cell)) { > + if (PTR_ERR(cell) == -EPROBE_DEFER) > + return -EPROBE_DEFER; > + } > + > + otp_v = nvmem_cell_read(cell, &otp_l); > + nvmem_cell_put(cell); > + > + if (otp_v) { > + set = *(otp_v + 1); > + set = (set << (sizeof(char) * 8)) | *otp_v; > + set = (set >> usbphy->disc_vol_addr_off) & J_DISC; > + } > + > + if (!otp_v || set == 0) > + set = OTP_DISC_LEVEL_DEFAULT; > + > + val = readl(usbphy->phy_regs + CONFIG7); > + val = (val & ~J_DISC) | set; > + writel(val, usbphy->phy_regs + CONFIG7); maybe add a updatel() macro > +static const struct phy_ops sp_uphy_ops = { > + .init = sp_uphy_init, no power_on/off/exit routines?? > +static const struct of_device_id sp_uphy_dt_ids[] = { > + {.compatible = "sunplus,sp7021-usb2-phy", > + .data = &sp_uphy_ops,}, why should the ops be in driver data? -- ~Vinod -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v1 1/2] phy: usb: Add USB2.0 phy driver for Sunplus SP7021 2022-04-13 9:49 ` Vinod Koul @ 2022-04-26 8:37 ` 施錕鴻 -1 siblings, 0 replies; 12+ messages in thread From: 施錕鴻 @ 2022-04-26 8:37 UTC (permalink / raw) To: Vinod Koul Cc: kishon, p.zabel, linux-kernel, linux-phy, linux-usb, robh+dt, devicetree, wells.lu Vinod Koul <vkoul@kernel.org> 於 2022年4月13日 週三 下午5:49寫道： > > On 04-03-22, 19:30, Vincent Shih wrote: > > Add USB2.0 phy driver for Sunplus SP7021 > > > > Signed-off-by: Vincent Shih <vincent.sunplus@gmail.com> > > --- > > MAINTAINERS | 8 ++ > > drivers/phy/Kconfig | 1 + > > drivers/phy/Makefile | 1 + > > drivers/phy/sunplus/Kconfig | 12 ++ > > drivers/phy/sunplus/Makefile | 2 + > > drivers/phy/sunplus/phy-sunplus-usb2.c | 248 +++++++++++++++++++++++++++++++++ > > 6 files changed, 272 insertions(+) > > create mode 100644 drivers/phy/sunplus/Kconfig > > create mode 100644 drivers/phy/sunplus/Makefile > > create mode 100644 drivers/phy/sunplus/phy-sunplus-usb2.c > > > > diff --git a/MAINTAINERS b/MAINTAINERS > > index 80eebc1..a3bb35e 100644 > > --- a/MAINTAINERS > > +++ b/MAINTAINERS > > @@ -17947,6 +17947,14 @@ L: netdev@vger.kernel.org > > S: Maintained > > F: drivers/net/ethernet/dlink/sundance.c > > > > +SUNPLUS USB2 PHY DRIVER > > +M: Vincent Shih <vincent.sunplus@gmail.com> > > +L: linux-usb@vger.kernel.org > > +S: Maintained > > +F: drivers/phy/sunplus/Kconfig > > +F: drivers/phy/sunplus/Makefile > > +F: drivers/phy/sunplus/phy-sunplus-usb2.c > > + > > SUPERH > > M: Yoshinori Sato <ysato@users.sourceforge.jp> > > M: Rich Felker <dalias@libc.org> > > diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig > > index 82b63e6..d97e22e 100644 > > --- a/drivers/phy/Kconfig > > +++ b/drivers/phy/Kconfig > > @@ -90,6 +90,7 @@ source "drivers/phy/rockchip/Kconfig" > > source "drivers/phy/samsung/Kconfig" > > source "drivers/phy/socionext/Kconfig" > > source "drivers/phy/st/Kconfig" > > +source "drivers/phy/sunplus/Kconfig" > > source "drivers/phy/tegra/Kconfig" > > source "drivers/phy/ti/Kconfig" > > source "drivers/phy/intel/Kconfig" > > diff --git a/drivers/phy/Makefile b/drivers/phy/Makefile > > index 01e9eff..ed88b6f 100644 > > --- a/drivers/phy/Makefile > > +++ b/drivers/phy/Makefile > > @@ -31,6 +31,7 @@ obj-y += allwinner/ \ > > samsung/ \ > > socionext/ \ > > st/ \ > > + sunplus/ \ > > tegra/ \ > > ti/ \ > > xilinx/ > > diff --git a/drivers/phy/sunplus/Kconfig b/drivers/phy/sunplus/Kconfig > > new file mode 100644 > > index 0000000..beb85f4 > > --- /dev/null > > +++ b/drivers/phy/sunplus/Kconfig > > @@ -0,0 +1,12 @@ > > +# SPDX-License-Identifier: GPL-2.0-only > > + > > +config PHY_SUNPLUS_USB > > + tristate "Sunplus USB2 PHY driver" > > + depends on OF && (SOC_SP7021 || COMPILE_TEST) > > + select GENERIC_PHY > > + help > > + Enable this to support the USB 2.0 PHY on Sunplus SP7021 > > + SoC. The USB 2.0 PHY controller supports battery charger > > + and synchronous signals, various power down modes including > > + operating, partial and suspend modes, and high-speed, > > + full-speed and low-speed data transfer. > > diff --git a/drivers/phy/sunplus/Makefile b/drivers/phy/sunplus/Makefile > > new file mode 100644 > > index 0000000..71754d5 > > --- /dev/null > > +++ b/drivers/phy/sunplus/Makefile > > @@ -0,0 +1,2 @@ > > +# SPDX-License-Identifier: GPL-2.0-only > > +obj-$(CONFIG_PHY_SUNPLUS_USB) += phy-sunplus-usb2.o > > diff --git a/drivers/phy/sunplus/phy-sunplus-usb2.c b/drivers/phy/sunplus/phy-sunplus-usb2.c > > new file mode 100644 > > index 0000000..a2c17ca > > --- /dev/null > > +++ b/drivers/phy/sunplus/phy-sunplus-usb2.c > > @@ -0,0 +1,248 @@ > > +// SPDX-License-Identifier: GPL-2.0 > > + > > +/* > > + * Sunplus SP7021 USB 2.0 phy driver > > + * > > + * Copyright (C) 2021 Sunplus Technology Inc., All rights reserved. > > 2022 > I will modify it. > > + * > > + * Note 1 : non-posted write command for the registers accesses of > > + * Sunplus SP7021. > > + * > > + */ > > + > > +#include <linux/bitfield.h> > > +#include <linux/clk.h> > > +#include <linux/delay.h> > > +#include <linux/io.h> > > +#include <linux/module.h> > > +#include <linux/nvmem-consumer.h> > > +#include <linux/of_platform.h> > > +#include <linux/phy/phy.h> > > +#include <linux/platform_device.h> > > +#include <linux/reset.h> > > + > > +#define RF_MASK_V(_mask, _val) (((_mask) << 16) | (_val)) > > +#define RF_MASK_V_CLR(_mask) (((_mask) << 16) | 0) > > Please use FIELD_PREP and FIELD_GET macros for these > I will modify it. > > + > > +#define MASK_BITS 0xffff > > +#define OTP_DISC_LEVEL_DEFAULT 0xd > > + > > +// GROUP UPHY > > +#define CONFIG1 0x4 > > +#define J_HS_TX_PWRSAV BIT(5) > > +#define CONFIG3 0xc > > GENAMSK() ? > I will modify it. > > > +#define J_FORCE_DISC_ON BIT(5) > > +#define J_DEBUG_CTRL_ADDR_MACRO BIT(0) > > +#define CONFIG7 0x1c > > +#define J_DISC 0X1f > > +#define CONFIG9 0x24 > > +#define J_ECO_PATH BIT(6) > > +#define CONFIG16 0x40 > > +#define J_TBCWAIT_MASK GENMASK(6, 5) > > +#define J_TBCWAIT_1P1_MS FIELD_PREP(J_TBCWAIT_MASK, 0) > > +#define J_TVDM_SRC_DIS_MASK GENMASK(4, 3) > > +#define J_TVDM_SRC_DIS_8P2_MS FIELD_PREP(J_TVDM_SRC_DIS_MASK, 3) > > +#define J_TVDM_SRC_EN_MASK GENMASK(2, 1) > > +#define J_TVDM_SRC_EN_1P6_MS FIELD_PREP(J_TVDM_SRC_EN_MASK, 0) > > +#define J_BC_EN BIT(0) > > +#define CONFIG17 0x44 > > +#define IBG_TRIM0_MASK GENMASK(7, 5) > > +#define IBG_TRIM0_SSLVHT FIELD_PREP(IBG_TRIM0_MASK, 4) > > +#define J_VDATREE_TRIM_MASK GENMASK(4, 1) > > +#define J_VDATREE_TRIM_DEFAULT FIELD_PREP(J_VDATREE_TRIM_MASK, 9) > > +#define CONFIG23 0x5c > > +#define PROB_MASK GENMASK(5, 3) > > +#define PROB FIELD_PREP(PROB_MASK, 7) > > + > > +// GROUP MOON4 > > wrong comments style > I will modify it. > > +static int sp_uphy_init(struct phy *phy) > > +{ > > + struct sp_usbphy *usbphy = phy_get_drvdata(phy); > > + struct nvmem_cell *cell; > > + char *disc_name = "disc_vol"; > > + ssize_t otp_l = 0; > > + char *otp_v; > > + u32 val, set, pll_pwr_on, pll_pwr_off; > > + > > + /* Default value modification */ > > + writel(RF_MASK_V(MASK_BITS, 0x4002), usbphy->moon4_regs + UPHY_CONTROL0); > > + writel(RF_MASK_V(MASK_BITS, 0x8747), usbphy->moon4_regs + UPHY_CONTROL1); > > + > > + /* PLL power off/on twice */ > > + pll_pwr_off = (readl(usbphy->moon4_regs + UPHY_CONTROL3) & ~MASK_BITS) > > + | MO1_UPHY_PLL_POWER_OFF_SEL | MO1_UPHY_PLL_POWER_OFF; > > + pll_pwr_on = (readl(usbphy->moon4_regs + UPHY_CONTROL3) & ~MASK_BITS) > > + | MO1_UPHY_PLL_POWER_OFF_SEL; > > + > > + writel(RF_MASK_V(MASK_BITS, pll_pwr_off), usbphy->moon4_regs + UPHY_CONTROL3); > > + mdelay(1); > > + writel(RF_MASK_V(MASK_BITS, pll_pwr_on), usbphy->moon4_regs + UPHY_CONTROL3); > > + mdelay(1); > > + writel(RF_MASK_V(MASK_BITS, pll_pwr_off), usbphy->moon4_regs + UPHY_CONTROL3); > > + mdelay(1); > > + writel(RF_MASK_V(MASK_BITS, pll_pwr_on), usbphy->moon4_regs + UPHY_CONTROL3); > > + mdelay(1); > > why delay on each register write? > They are for the stabilities of capacitors charge/discharge in the PCB board. > > + writel(RF_MASK_V(MASK_BITS, 0x0), usbphy->moon4_regs + UPHY_CONTROL3); > > + > > + /* board uphy 0 internal register modification for tid certification */ > > + cell = nvmem_cell_get(usbphy->dev, disc_name); > > + if (IS_ERR_OR_NULL(cell)) { > > + if (PTR_ERR(cell) == -EPROBE_DEFER) > > + return -EPROBE_DEFER; > > + } > > + > > + otp_v = nvmem_cell_read(cell, &otp_l); > > + nvmem_cell_put(cell); > > + > > + if (otp_v) { > > + set = *(otp_v + 1); > > + set = (set << (sizeof(char) * 8)) | *otp_v; > > + set = (set >> usbphy->disc_vol_addr_off) & J_DISC; > > + } > > + > > + if (!otp_v || set == 0) > > + set = OTP_DISC_LEVEL_DEFAULT; > > + > > + val = readl(usbphy->phy_regs + CONFIG7); > > + val = (val & ~J_DISC) | set; > > + writel(val, usbphy->phy_regs + CONFIG7); > > maybe add a updatel() macro I will add it. > > > +static const struct phy_ops sp_uphy_ops = { > > + .init = sp_uphy_init, > > no power_on/off/exit routines?? I will implement them. > > > +static const struct of_device_id sp_uphy_dt_ids[] = { > > + {.compatible = "sunplus,sp7021-usb2-phy", > > + .data = &sp_uphy_ops,}, > > why should the ops be in driver data? I will modify it. > > -- > ~Vinod Thanks for your review. -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v1 1/2] phy: usb: Add USB2.0 phy driver for Sunplus SP7021 @ 2022-04-26 8:37 ` 施錕鴻 0 siblings, 0 replies; 12+ messages in thread From: 施錕鴻 @ 2022-04-26 8:37 UTC (permalink / raw) To: Vinod Koul Cc: kishon, p.zabel, linux-kernel, linux-phy, linux-usb, robh+dt, devicetree, wells.lu Vinod Koul <vkoul@kernel.org> 於 2022年4月13日 週三 下午5:49寫道： > > On 04-03-22, 19:30, Vincent Shih wrote: > > Add USB2.0 phy driver for Sunplus SP7021 > > > > Signed-off-by: Vincent Shih <vincent.sunplus@gmail.com> > > --- > > MAINTAINERS | 8 ++ > > drivers/phy/Kconfig | 1 + > > drivers/phy/Makefile | 1 + > > drivers/phy/sunplus/Kconfig | 12 ++ > > drivers/phy/sunplus/Makefile | 2 + > > drivers/phy/sunplus/phy-sunplus-usb2.c | 248 +++++++++++++++++++++++++++++++++ > > 6 files changed, 272 insertions(+) > > create mode 100644 drivers/phy/sunplus/Kconfig > > create mode 100644 drivers/phy/sunplus/Makefile > > create mode 100644 drivers/phy/sunplus/phy-sunplus-usb2.c > > > > diff --git a/MAINTAINERS b/MAINTAINERS > > index 80eebc1..a3bb35e 100644 > > --- a/MAINTAINERS > > +++ b/MAINTAINERS > > @@ -17947,6 +17947,14 @@ L: netdev@vger.kernel.org > > S: Maintained > > F: drivers/net/ethernet/dlink/sundance.c > > > > +SUNPLUS USB2 PHY DRIVER > > +M: Vincent Shih <vincent.sunplus@gmail.com> > > +L: linux-usb@vger.kernel.org > > +S: Maintained > > +F: drivers/phy/sunplus/Kconfig > > +F: drivers/phy/sunplus/Makefile > > +F: drivers/phy/sunplus/phy-sunplus-usb2.c > > + > > SUPERH > > M: Yoshinori Sato <ysato@users.sourceforge.jp> > > M: Rich Felker <dalias@libc.org> > > diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig > > index 82b63e6..d97e22e 100644 > > --- a/drivers/phy/Kconfig > > +++ b/drivers/phy/Kconfig > > @@ -90,6 +90,7 @@ source "drivers/phy/rockchip/Kconfig" > > source "drivers/phy/samsung/Kconfig" > > source "drivers/phy/socionext/Kconfig" > > source "drivers/phy/st/Kconfig" > > +source "drivers/phy/sunplus/Kconfig" > > source "drivers/phy/tegra/Kconfig" > > source "drivers/phy/ti/Kconfig" > > source "drivers/phy/intel/Kconfig" > > diff --git a/drivers/phy/Makefile b/drivers/phy/Makefile > > index 01e9eff..ed88b6f 100644 > > --- a/drivers/phy/Makefile > > +++ b/drivers/phy/Makefile > > @@ -31,6 +31,7 @@ obj-y += allwinner/ \ > > samsung/ \ > > socionext/ \ > > st/ \ > > + sunplus/ \ > > tegra/ \ > > ti/ \ > > xilinx/ > > diff --git a/drivers/phy/sunplus/Kconfig b/drivers/phy/sunplus/Kconfig > > new file mode 100644 > > index 0000000..beb85f4 > > --- /dev/null > > +++ b/drivers/phy/sunplus/Kconfig > > @@ -0,0 +1,12 @@ > > +# SPDX-License-Identifier: GPL-2.0-only > > + > > +config PHY_SUNPLUS_USB > > + tristate "Sunplus USB2 PHY driver" > > + depends on OF && (SOC_SP7021 || COMPILE_TEST) > > + select GENERIC_PHY > > + help > > + Enable this to support the USB 2.0 PHY on Sunplus SP7021 > > + SoC. The USB 2.0 PHY controller supports battery charger > > + and synchronous signals, various power down modes including > > + operating, partial and suspend modes, and high-speed, > > + full-speed and low-speed data transfer. > > diff --git a/drivers/phy/sunplus/Makefile b/drivers/phy/sunplus/Makefile > > new file mode 100644 > > index 0000000..71754d5 > > --- /dev/null > > +++ b/drivers/phy/sunplus/Makefile > > @@ -0,0 +1,2 @@ > > +# SPDX-License-Identifier: GPL-2.0-only > > +obj-$(CONFIG_PHY_SUNPLUS_USB) += phy-sunplus-usb2.o > > diff --git a/drivers/phy/sunplus/phy-sunplus-usb2.c b/drivers/phy/sunplus/phy-sunplus-usb2.c > > new file mode 100644 > > index 0000000..a2c17ca > > --- /dev/null > > +++ b/drivers/phy/sunplus/phy-sunplus-usb2.c > > @@ -0,0 +1,248 @@ > > +// SPDX-License-Identifier: GPL-2.0 > > + > > +/* > > + * Sunplus SP7021 USB 2.0 phy driver > > + * > > + * Copyright (C) 2021 Sunplus Technology Inc., All rights reserved. > > 2022 > I will modify it. > > + * > > + * Note 1 : non-posted write command for the registers accesses of > > + * Sunplus SP7021. > > + * > > + */ > > + > > +#include <linux/bitfield.h> > > +#include <linux/clk.h> > > +#include <linux/delay.h> > > +#include <linux/io.h> > > +#include <linux/module.h> > > +#include <linux/nvmem-consumer.h> > > +#include <linux/of_platform.h> > > +#include <linux/phy/phy.h> > > +#include <linux/platform_device.h> > > +#include <linux/reset.h> > > + > > +#define RF_MASK_V(_mask, _val) (((_mask) << 16) | (_val)) > > +#define RF_MASK_V_CLR(_mask) (((_mask) << 16) | 0) > > Please use FIELD_PREP and FIELD_GET macros for these > I will modify it. > > + > > +#define MASK_BITS 0xffff > > +#define OTP_DISC_LEVEL_DEFAULT 0xd > > + > > +// GROUP UPHY > > +#define CONFIG1 0x4 > > +#define J_HS_TX_PWRSAV BIT(5) > > +#define CONFIG3 0xc > > GENAMSK() ? > I will modify it. > > > +#define J_FORCE_DISC_ON BIT(5) > > +#define J_DEBUG_CTRL_ADDR_MACRO BIT(0) > > +#define CONFIG7 0x1c > > +#define J_DISC 0X1f > > +#define CONFIG9 0x24 > > +#define J_ECO_PATH BIT(6) > > +#define CONFIG16 0x40 > > +#define J_TBCWAIT_MASK GENMASK(6, 5) > > +#define J_TBCWAIT_1P1_MS FIELD_PREP(J_TBCWAIT_MASK, 0) > > +#define J_TVDM_SRC_DIS_MASK GENMASK(4, 3) > > +#define J_TVDM_SRC_DIS_8P2_MS FIELD_PREP(J_TVDM_SRC_DIS_MASK, 3) > > +#define J_TVDM_SRC_EN_MASK GENMASK(2, 1) > > +#define J_TVDM_SRC_EN_1P6_MS FIELD_PREP(J_TVDM_SRC_EN_MASK, 0) > > +#define J_BC_EN BIT(0) > > +#define CONFIG17 0x44 > > +#define IBG_TRIM0_MASK GENMASK(7, 5) > > +#define IBG_TRIM0_SSLVHT FIELD_PREP(IBG_TRIM0_MASK, 4) > > +#define J_VDATREE_TRIM_MASK GENMASK(4, 1) > > +#define J_VDATREE_TRIM_DEFAULT FIELD_PREP(J_VDATREE_TRIM_MASK, 9) > > +#define CONFIG23 0x5c > > +#define PROB_MASK GENMASK(5, 3) > > +#define PROB FIELD_PREP(PROB_MASK, 7) > > + > > +// GROUP MOON4 > > wrong comments style > I will modify it. > > +static int sp_uphy_init(struct phy *phy) > > +{ > > + struct sp_usbphy *usbphy = phy_get_drvdata(phy); > > + struct nvmem_cell *cell; > > + char *disc_name = "disc_vol"; > > + ssize_t otp_l = 0; > > + char *otp_v; > > + u32 val, set, pll_pwr_on, pll_pwr_off; > > + > > + /* Default value modification */ > > + writel(RF_MASK_V(MASK_BITS, 0x4002), usbphy->moon4_regs + UPHY_CONTROL0); > > + writel(RF_MASK_V(MASK_BITS, 0x8747), usbphy->moon4_regs + UPHY_CONTROL1); > > + > > + /* PLL power off/on twice */ > > + pll_pwr_off = (readl(usbphy->moon4_regs + UPHY_CONTROL3) & ~MASK_BITS) > > + | MO1_UPHY_PLL_POWER_OFF_SEL | MO1_UPHY_PLL_POWER_OFF; > > + pll_pwr_on = (readl(usbphy->moon4_regs + UPHY_CONTROL3) & ~MASK_BITS) > > + | MO1_UPHY_PLL_POWER_OFF_SEL; > > + > > + writel(RF_MASK_V(MASK_BITS, pll_pwr_off), usbphy->moon4_regs + UPHY_CONTROL3); > > + mdelay(1); > > + writel(RF_MASK_V(MASK_BITS, pll_pwr_on), usbphy->moon4_regs + UPHY_CONTROL3); > > + mdelay(1); > > + writel(RF_MASK_V(MASK_BITS, pll_pwr_off), usbphy->moon4_regs + UPHY_CONTROL3); > > + mdelay(1); > > + writel(RF_MASK_V(MASK_BITS, pll_pwr_on), usbphy->moon4_regs + UPHY_CONTROL3); > > + mdelay(1); > > why delay on each register write? > They are for the stabilities of capacitors charge/discharge in the PCB board. > > + writel(RF_MASK_V(MASK_BITS, 0x0), usbphy->moon4_regs + UPHY_CONTROL3); > > + > > + /* board uphy 0 internal register modification for tid certification */ > > + cell = nvmem_cell_get(usbphy->dev, disc_name); > > + if (IS_ERR_OR_NULL(cell)) { > > + if (PTR_ERR(cell) == -EPROBE_DEFER) > > + return -EPROBE_DEFER; > > + } > > + > > + otp_v = nvmem_cell_read(cell, &otp_l); > > + nvmem_cell_put(cell); > > + > > + if (otp_v) { > > + set = *(otp_v + 1); > > + set = (set << (sizeof(char) * 8)) | *otp_v; > > + set = (set >> usbphy->disc_vol_addr_off) & J_DISC; > > + } > > + > > + if (!otp_v || set == 0) > > + set = OTP_DISC_LEVEL_DEFAULT; > > + > > + val = readl(usbphy->phy_regs + CONFIG7); > > + val = (val & ~J_DISC) | set; > > + writel(val, usbphy->phy_regs + CONFIG7); > > maybe add a updatel() macro I will add it. > > > +static const struct phy_ops sp_uphy_ops = { > > + .init = sp_uphy_init, > > no power_on/off/exit routines?? I will implement them. > > > +static const struct of_device_id sp_uphy_dt_ids[] = { > > + {.compatible = "sunplus,sp7021-usb2-phy", > > + .data = &sp_uphy_ops,}, > > why should the ops be in driver data? I will modify it. > > -- > ~Vinod Thanks for your review. ^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH v1 2/2] dt-bindings: phy: Add bindings doc for Sunplus USB2 PHY driver 2022-03-04 11:30 ` Vincent Shih @ 2022-03-04 11:30 ` Vincent Shih -1 siblings, 0 replies; 12+ messages in thread From: Vincent Shih @ 2022-03-04 11:30 UTC (permalink / raw) To: kishon, vkoul, p.zabel, linux-kernel, linux-phy, linux-usb, robh+dt, devicetree, wells.lu Cc: Vincent Shih Add bindings doc for Sunplus USB2 PHY driver Signed-off-by: Vincent Shih <vincent.sunplus@gmail.com> --- .../bindings/phy/sunplus,sp7021-usb2-phy.yaml | 73 ++++++++++++++++++++++ MAINTAINERS | 1 + 2 files changed, 74 insertions(+) create mode 100644 Documentation/devicetree/bindings/phy/sunplus,sp7021-usb2-phy.yaml diff --git a/Documentation/devicetree/bindings/phy/sunplus,sp7021-usb2-phy.yaml b/Documentation/devicetree/bindings/phy/sunplus,sp7021-usb2-phy.yaml new file mode 100644 index 0000000..52cf20e --- /dev/null +++ b/Documentation/devicetree/bindings/phy/sunplus,sp7021-usb2-phy.yaml @@ -0,0 +1,73 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +# Copyright (C) Sunplus Co., Ltd. 2021 +%YAML 1.2 +--- +$id: "http://devicetree.org/schemas/phy/sunplus,sp7021-usb2-phy.yaml#" +$schema: "http://devicetree.org/meta-schemas/core.yaml#" + +title: Sunplus SP7021 USB 2.0 PHY Controller Device Tree bindings + +maintainers: + - Vincent Shih <vincent.sunplus@gmail.com> + +properties: + compatible: + const: sunplus,sp7021-usb2-phy + + reg: + items: + - description: UPHY register region + - description: MOON4 register region + + reg-names: + items: + - const: phy + - const: moon4 + + clocks: + maxItems: 1 + + resets: + maxItems: 1 + + "#phy-cells": + const: 0 + + nvmem-cell-names: + description: names corresponding to the nvmem cells of disconnect voltage + const: disc_vol + + nvmem-cells: + description: nvmem cell address of disconnect voltage + maxItems: 1 + + sunplus,disc-vol-addr-off: + $ref: /schemas/types.yaml#/definitions/uint32 + description: the otp address offset of disconnect voltage + +required: + - compatible + - reg + - reg-names + - clocks + - resets + - "#phy-cells" + - nvmem-cell-names + - nvmem-cells + - sunplus,disc-vol-addr-off + +additionalProperties: false + +examples: + - | + sp_uphy0: uphy@9c004a80 { + compatible = "sunplus,sp7021-usb2-phy"; + reg = <0x9c004a80 0x80>, <0x9c000248 0x10>; + reg-names = "phy", "moon4"; + clocks = <&clkc 0x3d>; + resets = <&rstc 0x2d>; + #phy-cells = <0>; + nvmem-cell-names = "disc_vol"; + nvmem-cells = <&disc_vol>; + sunplus,disc-vol-addr-off = <0>; + }; diff --git a/MAINTAINERS b/MAINTAINERS index a3bb35e..ec6beb3 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -17951,6 +17951,7 @@ SUNPLUS USB2 PHY DRIVER M: Vincent Shih <vincent.sunplus@gmail.com> L: linux-usb@vger.kernel.org S: Maintained +F: Documentation/devicetree/bindings/phy/sunplus,sp7021-usb2-phy.yaml F: drivers/phy/sunplus/Kconfig F: drivers/phy/sunplus/Makefile F: drivers/phy/sunplus/phy-sunplus-usb2.c -- 2.7.4 ^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH v1 2/2] dt-bindings: phy: Add bindings doc for Sunplus USB2 PHY driver @ 2022-03-04 11:30 ` Vincent Shih 0 siblings, 0 replies; 12+ messages in thread From: Vincent Shih @ 2022-03-04 11:30 UTC (permalink / raw) To: kishon, vkoul, p.zabel, linux-kernel, linux-phy, linux-usb, robh+dt, devicetree, wells.lu Cc: Vincent Shih Add bindings doc for Sunplus USB2 PHY driver Signed-off-by: Vincent Shih <vincent.sunplus@gmail.com> --- .../bindings/phy/sunplus,sp7021-usb2-phy.yaml | 73 ++++++++++++++++++++++ MAINTAINERS | 1 + 2 files changed, 74 insertions(+) create mode 100644 Documentation/devicetree/bindings/phy/sunplus,sp7021-usb2-phy.yaml diff --git a/Documentation/devicetree/bindings/phy/sunplus,sp7021-usb2-phy.yaml b/Documentation/devicetree/bindings/phy/sunplus,sp7021-usb2-phy.yaml new file mode 100644 index 0000000..52cf20e --- /dev/null +++ b/Documentation/devicetree/bindings/phy/sunplus,sp7021-usb2-phy.yaml @@ -0,0 +1,73 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +# Copyright (C) Sunplus Co., Ltd. 2021 +%YAML 1.2 +--- +$id: "http://devicetree.org/schemas/phy/sunplus,sp7021-usb2-phy.yaml#" +$schema: "http://devicetree.org/meta-schemas/core.yaml#" + +title: Sunplus SP7021 USB 2.0 PHY Controller Device Tree bindings + +maintainers: + - Vincent Shih <vincent.sunplus@gmail.com> + +properties: + compatible: + const: sunplus,sp7021-usb2-phy + + reg: + items: + - description: UPHY register region + - description: MOON4 register region + + reg-names: + items: + - const: phy + - const: moon4 + + clocks: + maxItems: 1 + + resets: + maxItems: 1 + + "#phy-cells": + const: 0 + + nvmem-cell-names: + description: names corresponding to the nvmem cells of disconnect voltage + const: disc_vol + + nvmem-cells: + description: nvmem cell address of disconnect voltage + maxItems: 1 + + sunplus,disc-vol-addr-off: + $ref: /schemas/types.yaml#/definitions/uint32 + description: the otp address offset of disconnect voltage + +required: + - compatible + - reg + - reg-names + - clocks + - resets + - "#phy-cells" + - nvmem-cell-names + - nvmem-cells + - sunplus,disc-vol-addr-off + +additionalProperties: false + +examples: + - | + sp_uphy0: uphy@9c004a80 { + compatible = "sunplus,sp7021-usb2-phy"; + reg = <0x9c004a80 0x80>, <0x9c000248 0x10>; + reg-names = "phy", "moon4"; + clocks = <&clkc 0x3d>; + resets = <&rstc 0x2d>; + #phy-cells = <0>; + nvmem-cell-names = "disc_vol"; + nvmem-cells = <&disc_vol>; + sunplus,disc-vol-addr-off = <0>; + }; diff --git a/MAINTAINERS b/MAINTAINERS index a3bb35e..ec6beb3 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -17951,6 +17951,7 @@ SUNPLUS USB2 PHY DRIVER M: Vincent Shih <vincent.sunplus@gmail.com> L: linux-usb@vger.kernel.org S: Maintained +F: Documentation/devicetree/bindings/phy/sunplus,sp7021-usb2-phy.yaml F: drivers/phy/sunplus/Kconfig F: drivers/phy/sunplus/Makefile F: drivers/phy/sunplus/phy-sunplus-usb2.c -- 2.7.4 -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy ^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH v1 2/2] dt-bindings: phy: Add bindings doc for Sunplus USB2 PHY driver 2022-03-04 11:30 ` Vincent Shih @ 2022-03-10 19:57 ` Rob Herring -1 siblings, 0 replies; 12+ messages in thread From: Rob Herring @ 2022-03-10 19:57 UTC (permalink / raw) To: Vincent Shih Cc: linux-kernel, kishon, p.zabel, linux-phy, vkoul, wells.lu, linux-usb, robh+dt, devicetree On Fri, 04 Mar 2022 19:30:18 +0800, Vincent Shih wrote: > Add bindings doc for Sunplus USB2 PHY driver > > Signed-off-by: Vincent Shih <vincent.sunplus@gmail.com> > --- > .../bindings/phy/sunplus,sp7021-usb2-phy.yaml | 73 ++++++++++++++++++++++ > MAINTAINERS | 1 + > 2 files changed, 74 insertions(+) > create mode 100644 Documentation/devicetree/bindings/phy/sunplus,sp7021-usb2-phy.yaml > Reviewed-by: Rob Herring <robh@kernel.org> ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v1 2/2] dt-bindings: phy: Add bindings doc for Sunplus USB2 PHY driver @ 2022-03-10 19:57 ` Rob Herring 0 siblings, 0 replies; 12+ messages in thread From: Rob Herring @ 2022-03-10 19:57 UTC (permalink / raw) To: Vincent Shih Cc: linux-kernel, kishon, p.zabel, linux-phy, vkoul, wells.lu, linux-usb, robh+dt, devicetree On Fri, 04 Mar 2022 19:30:18 +0800, Vincent Shih wrote: > Add bindings doc for Sunplus USB2 PHY driver > > Signed-off-by: Vincent Shih <vincent.sunplus@gmail.com> > --- > .../bindings/phy/sunplus,sp7021-usb2-phy.yaml | 73 ++++++++++++++++++++++ > MAINTAINERS | 1 + > 2 files changed, 74 insertions(+) > create mode 100644 Documentation/devicetree/bindings/phy/sunplus,sp7021-usb2-phy.yaml > Reviewed-by: Rob Herring <robh@kernel.org> -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy ^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2022-04-26 9:05 UTC | newest] Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2022-03-04 11:30 [PATCH v1 0/2] Add phy driver for ehci in Sunplus SP7021 Vincent Shih 2022-03-04 11:30 ` Vincent Shih 2022-03-04 11:30 ` [PATCH v1 1/2] phy: usb: Add USB2.0 phy driver for " Vincent Shih 2022-03-04 11:30 ` Vincent Shih 2022-04-13 9:49 ` Vinod Koul 2022-04-13 9:49 ` Vinod Koul 2022-04-26 8:37 ` 施錕鴻 2022-04-26 8:37 ` 施錕鴻 2022-03-04 11:30 ` [PATCH v1 2/2] dt-bindings: phy: Add bindings doc for Sunplus USB2 PHY driver Vincent Shih 2022-03-04 11:30 ` Vincent Shih 2022-03-10 19:57 ` Rob Herring 2022-03-10 19:57 ` Rob Herring
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.