* [PATCH net-next] net: mdio-mux: add bus name to bus id
@ 2022-03-06 14:22 Heiner Kallweit
2022-03-06 15:17 ` Andrew Lunn
2022-03-08 9:40 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Heiner Kallweit @ 2022-03-06 14:22 UTC (permalink / raw)
To: Andrew Lunn, Russell King - ARM Linux, Jakub Kicinski, David Miller
Cc: netdev
In case of DT-configured systems it may be hard to identify the PHY
interrupt in the /proc/interrupts output. Therefore add the name to
the id to make clearer that it's about a device on a muxed mdio bus.
In my case:
Now: mdio_mux-0.e40908ff:08
Before: 0.e40908ff:08
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
drivers/net/mdio/mdio-mux.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/mdio/mdio-mux.c b/drivers/net/mdio/mdio-mux.c
index ebd001f0e..a881e3523 100644
--- a/drivers/net/mdio/mdio-mux.c
+++ b/drivers/net/mdio/mdio-mux.c
@@ -168,8 +168,8 @@ int mdio_mux_init(struct device *dev,
cb->mii_bus->priv = cb;
cb->mii_bus->name = "mdio_mux";
- snprintf(cb->mii_bus->id, MII_BUS_ID_SIZE, "%x.%x",
- pb->parent_id, v);
+ snprintf(cb->mii_bus->id, MII_BUS_ID_SIZE, "%s-%x.%x",
+ cb->mii_bus->name, pb->parent_id, v);
cb->mii_bus->parent = dev;
cb->mii_bus->read = mdio_mux_read;
cb->mii_bus->write = mdio_mux_write;
--
2.35.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] net: mdio-mux: add bus name to bus id
2022-03-06 14:22 [PATCH net-next] net: mdio-mux: add bus name to bus id Heiner Kallweit
@ 2022-03-06 15:17 ` Andrew Lunn
2022-03-08 9:40 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Andrew Lunn @ 2022-03-06 15:17 UTC (permalink / raw)
To: Heiner Kallweit
Cc: Russell King - ARM Linux, Jakub Kicinski, David Miller, netdev
On Sun, Mar 06, 2022 at 03:22:34PM +0100, Heiner Kallweit wrote:
> In case of DT-configured systems it may be hard to identify the PHY
> interrupt in the /proc/interrupts output. Therefore add the name to
> the id to make clearer that it's about a device on a muxed mdio bus.
> In my case:
>
> Now: mdio_mux-0.e40908ff:08
> Before: 0.e40908ff:08
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] net: mdio-mux: add bus name to bus id
2022-03-06 14:22 [PATCH net-next] net: mdio-mux: add bus name to bus id Heiner Kallweit
2022-03-06 15:17 ` Andrew Lunn
@ 2022-03-08 9:40 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-03-08 9:40 UTC (permalink / raw)
To: Heiner Kallweit; +Cc: andrew, linux, kuba, davem, netdev
Hello:
This patch was applied to netdev/net-next.git (master)
by Paolo Abeni <pabeni@redhat.com>:
On Sun, 6 Mar 2022 15:22:34 +0100 you wrote:
> In case of DT-configured systems it may be hard to identify the PHY
> interrupt in the /proc/interrupts output. Therefore add the name to
> the id to make clearer that it's about a device on a muxed mdio bus.
> In my case:
>
> Now: mdio_mux-0.e40908ff:08
> Before: 0.e40908ff:08
>
> [...]
Here is the summary with links:
- [net-next] net: mdio-mux: add bus name to bus id
https://git.kernel.org/netdev/net-next/c/1416ea0ddc14
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-03-08 9:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-06 14:22 [PATCH net-next] net: mdio-mux: add bus name to bus id Heiner Kallweit
2022-03-06 15:17 ` Andrew Lunn
2022-03-08 9:40 ` patchwork-bot+netdevbpf
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.