From: Alec Brown <alec.r.brown@oracle.com>
To: grub-devel@gnu.org
Cc: daniel.kiper@oracle.com, darren.kenny@oracle.com,
alec.r.brown@oracle.com
Subject: [PATCH 6/7] grub-core/loader/i386/xnu.c: Fix uninitialized scalar variable
Date: Tue, 15 Mar 2022 16:24:08 -0400 [thread overview]
Message-ID: <1647375849-24164-7-git-send-email-alec.r.brown@oracle.com> (raw)
In-Reply-To: <1647375849-24164-1-git-send-email-alec.r.brown@oracle.com>
In the function grub_xnu_boot(), struct grub_relocator32_state state is called
but isn't being initialized. To prevent contents of this structure from being
filled with junk data from the stack, we can initialize it to 0 by setting state
to {}.
Fixes: CID 375035
Signed-off-by: Alec Brown <alec.r.brown@oracle.com>
---
grub-core/loader/i386/xnu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/grub-core/loader/i386/xnu.c b/grub-core/loader/i386/xnu.c
index caab5cfa6..c956942a2 100644
--- a/grub-core/loader/i386/xnu.c
+++ b/grub-core/loader/i386/xnu.c
@@ -960,7 +960,7 @@ grub_xnu_boot (void)
grub_addr_t devtree_target;
grub_size_t devtreelen;
int i;
- struct grub_relocator32_state state;
+ struct grub_relocator32_state state = {};
grub_uint64_t fsbfreq = 100000000;
int v2 = (grub_xnu_darwin_version >= 11);
grub_uint32_t efi_system_table = 0;
--
2.27.0
next prev parent reply other threads:[~2022-03-15 20:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-15 20:24 [PATCH 0/7] Fix coverity uninitialized scalar variable bugs in grub-core Alec Brown
2022-03-15 20:24 ` [PATCH 1/7] grub-core/loader/i386/bsd.c: Fix uninitialized scalar variable Alec Brown
2022-03-15 20:24 ` [PATCH 2/7] grub-core/loader/i386/pc/linux.c: " Alec Brown
2022-03-15 20:24 ` [PATCH 3/7] grub-core/net/arp.c: " Alec Brown
2022-03-15 20:24 ` [PATCH 4/7] grub-core/loader/i386/xnu.c: " Alec Brown
2022-03-15 20:24 ` [PATCH 5/7] grub-core/net/net.c: " Alec Brown
2022-03-16 1:16 ` Glenn Washburn
2022-03-17 21:20 ` Daniel Kiper
2022-03-15 20:24 ` Alec Brown [this message]
2022-03-15 20:24 ` [PATCH 7/7] grub-core/net/bootp.c: " Alec Brown
2022-03-15 20:32 ` [PATCH 0/7] Fix coverity uninitialized scalar variable bugs in grub-core Darren Kenny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1647375849-24164-7-git-send-email-alec.r.brown@oracle.com \
--to=alec.r.brown@oracle.com \
--cc=daniel.kiper@oracle.com \
--cc=darren.kenny@oracle.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.