All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alec Brown <alec.r.brown@oracle.com>
To: grub-devel@gnu.org
Cc: daniel.kiper@oracle.com, darren.kenny@oracle.com,
	alec.r.brown@oracle.com
Subject: [PATCH 5/7] grub-core/net/net.c: Fix uninitialized scalar variable
Date: Tue, 15 Mar 2022 16:24:07 -0400	[thread overview]
Message-ID: <1647375849-24164-6-git-send-email-alec.r.brown@oracle.com> (raw)
In-Reply-To: <1647375849-24164-1-git-send-email-alec.r.brown@oracle.com>

In the function grub_net_ipv6_get_link_local(), grub_net_network_level_address_t
addr is called but isn't being initialized. To prevent contents of this
structure from being filled with junk data from the stack, we can initialize it
to 0 by setting addr to {};

Fixes: CID 375033

Signed-off-by: Alec Brown <alec.r.brown@oracle.com>
---
 grub-core/net/net.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/grub-core/net/net.c b/grub-core/net/net.c
index 4d3eb5c1a..4e93365a7 100644
--- a/grub-core/net/net.c
+++ b/grub-core/net/net.c
@@ -287,7 +287,7 @@ grub_net_ipv6_get_link_local (struct grub_net_card *card,
   struct grub_net_network_level_interface *inf;
   char *name;
   char *ptr;
-  grub_net_network_level_address_t addr;
+  grub_net_network_level_address_t addr = {};
 
   addr.type = GRUB_NET_NETWORK_LEVEL_PROTOCOL_IPV6;
   addr.ipv6[0] = grub_cpu_to_be64_compile_time (0xfe80ULL << 48);
-- 
2.27.0



  parent reply	other threads:[~2022-03-15 20:24 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-15 20:24 [PATCH 0/7] Fix coverity uninitialized scalar variable bugs in grub-core Alec Brown
2022-03-15 20:24 ` [PATCH 1/7] grub-core/loader/i386/bsd.c: Fix uninitialized scalar variable Alec Brown
2022-03-15 20:24 ` [PATCH 2/7] grub-core/loader/i386/pc/linux.c: " Alec Brown
2022-03-15 20:24 ` [PATCH 3/7] grub-core/net/arp.c: " Alec Brown
2022-03-15 20:24 ` [PATCH 4/7] grub-core/loader/i386/xnu.c: " Alec Brown
2022-03-15 20:24 ` Alec Brown [this message]
2022-03-16  1:16   ` [PATCH 5/7] grub-core/net/net.c: " Glenn Washburn
2022-03-17 21:20     ` Daniel Kiper
2022-03-15 20:24 ` [PATCH 6/7] grub-core/loader/i386/xnu.c: " Alec Brown
2022-03-15 20:24 ` [PATCH 7/7] grub-core/net/bootp.c: " Alec Brown
2022-03-15 20:32 ` [PATCH 0/7] Fix coverity uninitialized scalar variable bugs in grub-core Darren Kenny

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1647375849-24164-6-git-send-email-alec.r.brown@oracle.com \
    --to=alec.r.brown@oracle.com \
    --cc=daniel.kiper@oracle.com \
    --cc=darren.kenny@oracle.com \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.