* [PATCH] Bluetooth: btmtkuart: fix error handling in mtk_hci_wmt_sync()
@ 2022-03-17 7:57 ` Dan Carpenter
0 siblings, 0 replies; 7+ messages in thread
From: Dan Carpenter @ 2022-03-17 7:57 UTC (permalink / raw)
To: Sean Wang
Cc: Marcel Holtmann, Johan Hedberg, Luiz Augusto von Dentz,
Matthias Brugger, linux-bluetooth, linux-mediatek,
kernel-janitors
This code has an uninitialized variable warning:
drivers/bluetooth/btmtkuart.c:184 mtk_hci_wmt_sync()
error: uninitialized symbol 'wc'.
But it also has error paths which have memory leaks.
Fixes: 8f550f55b155 ("Bluetooth: btmtkuart: rely on BT_MTK module")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/bluetooth/btmtkuart.c | 12 +++++++-----
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/drivers/bluetooth/btmtkuart.c b/drivers/bluetooth/btmtkuart.c
index 695e1225b08c..c98691cdbbd5 100644
--- a/drivers/bluetooth/btmtkuart.c
+++ b/drivers/bluetooth/btmtkuart.c
@@ -105,8 +105,10 @@ static int mtk_hci_wmt_sync(struct hci_dev *hdev,
}
wc = kzalloc(hlen, GFP_KERNEL);
- if (!wc)
- return -ENOMEM;
+ if (!wc) {
+ err = -ENOMEM;
+ goto err_free_skb;
+ }
hdr = &wc->hdr;
hdr->dir = 1;
@@ -153,7 +155,7 @@ static int mtk_hci_wmt_sync(struct hci_dev *hdev,
bt_dev_err(hdev, "Wrong op received %d expected %d",
wmt_evt->whdr.op, hdr->op);
err = -EIO;
- goto err_free_skb;
+ goto err_free_wc;
}
switch (wmt_evt->whdr.op) {
@@ -177,11 +179,11 @@ static int mtk_hci_wmt_sync(struct hci_dev *hdev,
if (wmt_params->status)
*wmt_params->status = status;
+err_free_wc:
+ kfree(wc);
err_free_skb:
kfree_skb(bdev->evt_skb);
bdev->evt_skb = NULL;
-err_free_wc:
- kfree(wc);
return err;
}
--
2.20.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH] Bluetooth: btmtkuart: fix error handling in mtk_hci_wmt_sync()
@ 2022-03-17 7:57 ` Dan Carpenter
0 siblings, 0 replies; 7+ messages in thread
From: Dan Carpenter @ 2022-03-17 7:57 UTC (permalink / raw)
To: Sean Wang
Cc: Marcel Holtmann, Johan Hedberg, Luiz Augusto von Dentz,
Matthias Brugger, linux-bluetooth, linux-mediatek,
kernel-janitors
This code has an uninitialized variable warning:
drivers/bluetooth/btmtkuart.c:184 mtk_hci_wmt_sync()
error: uninitialized symbol 'wc'.
But it also has error paths which have memory leaks.
Fixes: 8f550f55b155 ("Bluetooth: btmtkuart: rely on BT_MTK module")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/bluetooth/btmtkuart.c | 12 +++++++-----
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/drivers/bluetooth/btmtkuart.c b/drivers/bluetooth/btmtkuart.c
index 695e1225b08c..c98691cdbbd5 100644
--- a/drivers/bluetooth/btmtkuart.c
+++ b/drivers/bluetooth/btmtkuart.c
@@ -105,8 +105,10 @@ static int mtk_hci_wmt_sync(struct hci_dev *hdev,
}
wc = kzalloc(hlen, GFP_KERNEL);
- if (!wc)
- return -ENOMEM;
+ if (!wc) {
+ err = -ENOMEM;
+ goto err_free_skb;
+ }
hdr = &wc->hdr;
hdr->dir = 1;
@@ -153,7 +155,7 @@ static int mtk_hci_wmt_sync(struct hci_dev *hdev,
bt_dev_err(hdev, "Wrong op received %d expected %d",
wmt_evt->whdr.op, hdr->op);
err = -EIO;
- goto err_free_skb;
+ goto err_free_wc;
}
switch (wmt_evt->whdr.op) {
@@ -177,11 +179,11 @@ static int mtk_hci_wmt_sync(struct hci_dev *hdev,
if (wmt_params->status)
*wmt_params->status = status;
+err_free_wc:
+ kfree(wc);
err_free_skb:
kfree_skb(bdev->evt_skb);
bdev->evt_skb = NULL;
-err_free_wc:
- kfree(wc);
return err;
}
--
2.20.1
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply related [flat|nested] 7+ messages in thread
* RE: Bluetooth: btmtkuart: fix error handling in mtk_hci_wmt_sync()
2022-03-17 7:57 ` Dan Carpenter
(?)
@ 2022-03-17 9:02 ` bluez.test.bot
-1 siblings, 0 replies; 7+ messages in thread
From: bluez.test.bot @ 2022-03-17 9:02 UTC (permalink / raw)
To: linux-bluetooth, dan.carpenter
[-- Attachment #1: Type: text/plain, Size: 1097 bytes --]
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=624166
---Test result---
Test Summary:
CheckPatch PASS 1.65 seconds
GitLint PASS 1.00 seconds
SubjectPrefix PASS 0.86 seconds
BuildKernel PASS 30.48 seconds
BuildKernel32 PASS 26.77 seconds
Incremental Build with patchesPASS 36.74 seconds
TestRunner: Setup PASS 472.88 seconds
TestRunner: l2cap-tester PASS 15.42 seconds
TestRunner: bnep-tester PASS 6.11 seconds
TestRunner: mgmt-tester PASS 101.58 seconds
TestRunner: rfcomm-tester PASS 7.87 seconds
TestRunner: sco-tester PASS 7.70 seconds
TestRunner: smp-tester PASS 7.63 seconds
TestRunner: userchan-tester PASS 6.42 seconds
---
Regards,
Linux Bluetooth
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] Bluetooth: btmtkuart: fix error handling in mtk_hci_wmt_sync()
2022-03-17 7:57 ` Dan Carpenter
@ 2022-03-17 11:12 ` Marcel Holtmann
-1 siblings, 0 replies; 7+ messages in thread
From: Marcel Holtmann @ 2022-03-17 11:12 UTC (permalink / raw)
To: Dan Carpenter
Cc: Sean Wang, Johan Hedberg, Luiz Augusto von Dentz,
Matthias Brugger, BlueZ, linux-mediatek, kernel-janitors
Hi Dan,
> This code has an uninitialized variable warning:
>
> drivers/bluetooth/btmtkuart.c:184 mtk_hci_wmt_sync()
> error: uninitialized symbol 'wc'.
>
> But it also has error paths which have memory leaks.
>
> Fixes: 8f550f55b155 ("Bluetooth: btmtkuart: rely on BT_MTK module")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> drivers/bluetooth/btmtkuart.c | 12 +++++++-----
> 1 file changed, 7 insertions(+), 5 deletions(-)
patch has been applied to bluetooth-next tree.
Regards
Marcel
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] Bluetooth: btmtkuart: fix error handling in mtk_hci_wmt_sync()
@ 2022-03-17 11:12 ` Marcel Holtmann
0 siblings, 0 replies; 7+ messages in thread
From: Marcel Holtmann @ 2022-03-17 11:12 UTC (permalink / raw)
To: Dan Carpenter
Cc: Sean Wang, Johan Hedberg, Luiz Augusto von Dentz,
Matthias Brugger, BlueZ, linux-mediatek, kernel-janitors
Hi Dan,
> This code has an uninitialized variable warning:
>
> drivers/bluetooth/btmtkuart.c:184 mtk_hci_wmt_sync()
> error: uninitialized symbol 'wc'.
>
> But it also has error paths which have memory leaks.
>
> Fixes: 8f550f55b155 ("Bluetooth: btmtkuart: rely on BT_MTK module")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> drivers/bluetooth/btmtkuart.c | 12 +++++++-----
> 1 file changed, 7 insertions(+), 5 deletions(-)
patch has been applied to bluetooth-next tree.
Regards
Marcel
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] Bluetooth: btmtkuart: fix error handling in mtk_hci_wmt_sync()
2022-03-17 7:57 ` Dan Carpenter
@ 2022-03-17 11:20 ` patchwork-bot+bluetooth
-1 siblings, 0 replies; 7+ messages in thread
From: patchwork-bot+bluetooth @ 2022-03-17 11:20 UTC (permalink / raw)
To: Dan Carpenter
Cc: sean.wang, marcel, johan.hedberg, luiz.dentz, matthias.bgg,
linux-bluetooth, linux-mediatek, kernel-janitors
Hello:
This patch was applied to bluetooth/bluetooth-next.git (master)
by Marcel Holtmann <marcel@holtmann.org>:
On Thu, 17 Mar 2022 10:57:40 +0300 you wrote:
> This code has an uninitialized variable warning:
>
> drivers/bluetooth/btmtkuart.c:184 mtk_hci_wmt_sync()
> error: uninitialized symbol 'wc'.
>
> But it also has error paths which have memory leaks.
>
> [...]
Here is the summary with links:
- Bluetooth: btmtkuart: fix error handling in mtk_hci_wmt_sync()
https://git.kernel.org/bluetooth/bluetooth-next/c/65d6602f6334
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] Bluetooth: btmtkuart: fix error handling in mtk_hci_wmt_sync()
@ 2022-03-17 11:20 ` patchwork-bot+bluetooth
0 siblings, 0 replies; 7+ messages in thread
From: patchwork-bot+bluetooth @ 2022-03-17 11:20 UTC (permalink / raw)
To: Dan Carpenter
Cc: sean.wang, marcel, johan.hedberg, luiz.dentz, matthias.bgg,
linux-bluetooth, linux-mediatek, kernel-janitors
Hello:
This patch was applied to bluetooth/bluetooth-next.git (master)
by Marcel Holtmann <marcel@holtmann.org>:
On Thu, 17 Mar 2022 10:57:40 +0300 you wrote:
> This code has an uninitialized variable warning:
>
> drivers/bluetooth/btmtkuart.c:184 mtk_hci_wmt_sync()
> error: uninitialized symbol 'wc'.
>
> But it also has error paths which have memory leaks.
>
> [...]
Here is the summary with links:
- Bluetooth: btmtkuart: fix error handling in mtk_hci_wmt_sync()
https://git.kernel.org/bluetooth/bluetooth-next/c/65d6602f6334
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2022-03-17 11:20 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-17 7:57 [PATCH] Bluetooth: btmtkuart: fix error handling in mtk_hci_wmt_sync() Dan Carpenter
2022-03-17 7:57 ` Dan Carpenter
2022-03-17 9:02 ` bluez.test.bot
2022-03-17 11:12 ` [PATCH] " Marcel Holtmann
2022-03-17 11:12 ` Marcel Holtmann
2022-03-17 11:20 ` patchwork-bot+bluetooth
2022-03-17 11:20 ` patchwork-bot+bluetooth
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.