[PATCH net-next] net: dsa: felix: allow PHY_INTERFACE_MODE_INTERNAL on port 5

[PATCH net-next] net: dsa: felix: allow PHY_INTERFACE_MODE_INTERNAL on port 5

[Vladimir Oltean]

The Felix switch has 6 ports, 2 of which are internal.
Due to some misunderstanding, my initial suggestion for
vsc9959_port_modes[]:
https://patchwork.kernel.org/project/netdevbpf/patch/20220129220221.2823127-10-colin.foster@in-advantage.com/#24718277

got translated by Colin into a 5-port array, leading to an all-zero port
mode mask for port 5.

Fixes: acf242fc739e ("net: dsa: felix: remove prevalidate_phy_mode interface")
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
---
 drivers/net/dsa/ocelot/felix_vsc9959.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/dsa/ocelot/felix_vsc9959.c b/drivers/net/dsa/ocelot/felix_vsc9959.c
index ead3316742f6..62d52e0874e9 100644
--- a/drivers/net/dsa/ocelot/felix_vsc9959.c
+++ b/drivers/net/dsa/ocelot/felix_vsc9959.c
@@ -37,6 +37,7 @@ static const u32 vsc9959_port_modes[VSC9959_NUM_PORTS] = {
 	VSC9959_PORT_MODE_SERDES,
 	VSC9959_PORT_MODE_SERDES,
 	OCELOT_PORT_MODE_INTERNAL,
+	OCELOT_PORT_MODE_INTERNAL,
 };
 
 static const u32 vsc9959_ana_regmap[] = {
-- 
2.25.1

Re: [PATCH net-next] net: dsa: felix: allow PHY_INTERFACE_MODE_INTERNAL on port 5

[Florian Fainelli]

On 3/18/22 12:58 PM, Vladimir Oltean wrote:
> The Felix switch has 6 ports, 2 of which are internal.
> Due to some misunderstanding, my initial suggestion for
> vsc9959_port_modes[]:
> https://patchwork.kernel.org/project/netdevbpf/patch/20220129220221.2823127-10-colin.foster@in-advantage.com/#24718277
> 
> got translated by Colin into a 5-port array, leading to an all-zero port
> mode mask for port 5.
> 
> Fixes: acf242fc739e ("net: dsa: felix: remove prevalidate_phy_mode interface")
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>

Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
-- 
Florian

Re: [PATCH net-next] net: dsa: felix: allow PHY_INTERFACE_MODE_INTERNAL on port 5

[Colin Foster]

On Fri, Mar 18, 2022 at 09:58:12PM +0200, Vladimir Oltean wrote:
> The Felix switch has 6 ports, 2 of which are internal.
> Due to some misunderstanding, my initial suggestion for
> vsc9959_port_modes[]:
> https://patchwork.kernel.org/project/netdevbpf/patch/20220129220221.2823127-10-colin.foster@in-advantage.com/#24718277
> 
> got translated by Colin into a 5-port array, leading to an all-zero port
> mode mask for port 5.

My apologies. Thanks for finding and fixing!

> 
> Fixes: acf242fc739e ("net: dsa: felix: remove prevalidate_phy_mode interface")
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
> ---
>  drivers/net/dsa/ocelot/felix_vsc9959.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/dsa/ocelot/felix_vsc9959.c b/drivers/net/dsa/ocelot/felix_vsc9959.c
> index ead3316742f6..62d52e0874e9 100644
> --- a/drivers/net/dsa/ocelot/felix_vsc9959.c
> +++ b/drivers/net/dsa/ocelot/felix_vsc9959.c
> @@ -37,6 +37,7 @@ static const u32 vsc9959_port_modes[VSC9959_NUM_PORTS] = {
>  	VSC9959_PORT_MODE_SERDES,
>  	VSC9959_PORT_MODE_SERDES,
>  	OCELOT_PORT_MODE_INTERNAL,
> +	OCELOT_PORT_MODE_INTERNAL,
>  };
>  
>  static const u32 vsc9959_ana_regmap[] = {
> -- 
> 2.25.1
> 

Re: [PATCH net-next] net: dsa: felix: allow PHY_INTERFACE_MODE_INTERNAL on port 5

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net-next.git (master)
by Jakub Kicinski <kuba@kernel.org>:

On Fri, 18 Mar 2022 21:58:12 +0200 you wrote:
> The Felix switch has 6 ports, 2 of which are internal.
> Due to some misunderstanding, my initial suggestion for
> vsc9959_port_modes[]:
> https://patchwork.kernel.org/project/netdevbpf/patch/20220129220221.2823127-10-colin.foster@in-advantage.com/#24718277
> 
> got translated by Colin into a 5-port array, leading to an all-zero port
> mode mask for port 5.
> 
> [...]

Here is the summary with links:
  - [net-next] net: dsa: felix: allow PHY_INTERFACE_MODE_INTERNAL on port 5
    https://git.kernel.org/netdev/net-next/c/a53cbe5d628c

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html