* arm64 pci_iomap, was: Re: next build: 258 warnings 9 failures (next/next-20141119)
[not found] <546c75d7.6336460a.14b5.474d@mx.google.com>
@ 2014-11-19 11:15 ` Arnd Bergmann
2014-11-19 13:56 ` Thierry Reding
0 siblings, 1 reply; 4+ messages in thread
From: Arnd Bergmann @ 2014-11-19 11:15 UTC (permalink / raw)
To: linux-arm-kernel
On Wednesday 19 November 2014 02:49:59 Olof's autobuilder wrote:
>
> arm64.allmodconfig:
> drivers/net/ethernet/dec/tulip/winbond-840.c:910:2: warning: #warning Processor architecture undefined [-Wcpp]
> #warning Processor architecture undefined
> drivers/net/ethernet/dec/tulip/tulip_core.c:101:2: warning: #warning Processor architecture undefined! [-Wcpp]
> #warning Processor architecture undefined!
> :(.text+0x42344): undefined reference to `pci_iomap'
> :(.text+0x42ca0): undefined reference to `pci_iomap'
> :(.text+0x11c10): undefined reference to `pci_iomap'
>
> arm64.defconfig:
> drivers/pci/quirks.c:2965: undefined reference to `pci_iomap'
> drivers/pci/quirks.c:3328: undefined reference to `pci_iomap'
> drivers/tty/serial/8250/8250_pci.c:1044: undefined reference to `pci_iomap'
> drivers/tty/serial/8250/8250_pci.c:1012: undefined reference to `pci_iomap'
> lib/devres.c:273: undefined reference to `pci_iomap'
>
Hi Thierry,
This is another regression from your asm-generic change in arm64. We
are now lacking a working pci_iomap function after you removed the
'select GENERIC_IOMAP' statement.
For all I can tell, this is the correct solution (note GENERIC_PCI_IOMAP
instead of GENERIC_IOMAP):
diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
index 37cd23625708..bc8879c283b9 100644
--- a/arch/arm64/Kconfig
+++ b/arch/arm64/Kconfig
@@ -25,6 +25,7 @@ config ARM64
select GENERIC_EARLY_IOREMAP
select GENERIC_IRQ_PROBE
select GENERIC_IRQ_SHOW
+ select GENERIC_PCI_IOMAP
select GENERIC_SCHED_CLOCK
select GENERIC_SMP_IDLE_THREAD
select GENERIC_STRNCPY_FROM_USER
Any comments?
Arnd
^ permalink raw reply related [flat|nested] 4+ messages in thread
* arm64 pci_iomap, was: Re: next build: 258 warnings 9 failures (next/next-20141119)
2014-11-19 11:15 ` arm64 pci_iomap, was: Re: next build: 258 warnings 9 failures (next/next-20141119) Arnd Bergmann
@ 2014-11-19 13:56 ` Thierry Reding
2014-11-19 14:11 ` Arnd Bergmann
0 siblings, 1 reply; 4+ messages in thread
From: Thierry Reding @ 2014-11-19 13:56 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Nov 19, 2014 at 12:15:45PM +0100, Arnd Bergmann wrote:
> On Wednesday 19 November 2014 02:49:59 Olof's autobuilder wrote:
> >
> > arm64.allmodconfig:
> > drivers/net/ethernet/dec/tulip/winbond-840.c:910:2: warning: #warning Processor architecture undefined [-Wcpp]
> > #warning Processor architecture undefined
> > drivers/net/ethernet/dec/tulip/tulip_core.c:101:2: warning: #warning Processor architecture undefined! [-Wcpp]
> > #warning Processor architecture undefined!
> > :(.text+0x42344): undefined reference to `pci_iomap'
> > :(.text+0x42ca0): undefined reference to `pci_iomap'
> > :(.text+0x11c10): undefined reference to `pci_iomap'
> >
> > arm64.defconfig:
> > drivers/pci/quirks.c:2965: undefined reference to `pci_iomap'
> > drivers/pci/quirks.c:3328: undefined reference to `pci_iomap'
> > drivers/tty/serial/8250/8250_pci.c:1044: undefined reference to `pci_iomap'
> > drivers/tty/serial/8250/8250_pci.c:1012: undefined reference to `pci_iomap'
> > lib/devres.c:273: undefined reference to `pci_iomap'
> >
>
> Hi Thierry,
>
> This is another regression from your asm-generic change in arm64. We
> are now lacking a working pci_iomap function after you removed the
> 'select GENERIC_IOMAP' statement.
>
> For all I can tell, this is the correct solution (note GENERIC_PCI_IOMAP
> instead of GENERIC_IOMAP):
>
> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
> index 37cd23625708..bc8879c283b9 100644
> --- a/arch/arm64/Kconfig
> +++ b/arch/arm64/Kconfig
> @@ -25,6 +25,7 @@ config ARM64
> select GENERIC_EARLY_IOREMAP
> select GENERIC_IRQ_PROBE
> select GENERIC_IRQ_SHOW
> + select GENERIC_PCI_IOMAP
> select GENERIC_SCHED_CLOCK
> select GENERIC_SMP_IDLE_THREAD
> select GENERIC_STRNCPY_FROM_USER
>
>
> Any comments?
Oops, I just looked at that file on my system and I already have the
select GENERIC_PCI_IOMAP exactly where you have it. Turns out I have
that same patch, albeit with a somewhat obfuscated name in my tree
but never got around to clean up the commit message or sending it out.
Do you want to apply that patch on top or shall I redo the pull request
with that patch folded in so we can keep bisectability across the
series?
Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20141119/fa6d8060/attachment-0001.sig>
^ permalink raw reply [flat|nested] 4+ messages in thread
* arm64 pci_iomap, was: Re: next build: 258 warnings 9 failures (next/next-20141119)
2014-11-19 13:56 ` Thierry Reding
@ 2014-11-19 14:11 ` Arnd Bergmann
2014-11-19 14:20 ` Thierry Reding
0 siblings, 1 reply; 4+ messages in thread
From: Arnd Bergmann @ 2014-11-19 14:11 UTC (permalink / raw)
To: linux-arm-kernel
On Wednesday 19 November 2014 14:56:42 Thierry Reding wrote:
>
> Oops, I just looked at that file on my system and I already have the
> select GENERIC_PCI_IOMAP exactly where you have it. Turns out I have
> that same patch, albeit with a somewhat obfuscated name in my tree
> but never got around to clean up the commit message or sending it out.
>
> Do you want to apply that patch on top or shall I redo the pull request
> with that patch folded in so we can keep bisectability across the
> series?
I would prefer to have my patch applied on top so I don't have to redo
the merge between your patches and Will's patches.
Can you confirm that you have no further patches that I might need?
Arnd
^ permalink raw reply [flat|nested] 4+ messages in thread
* arm64 pci_iomap, was: Re: next build: 258 warnings 9 failures (next/next-20141119)
2014-11-19 14:11 ` Arnd Bergmann
@ 2014-11-19 14:20 ` Thierry Reding
0 siblings, 0 replies; 4+ messages in thread
From: Thierry Reding @ 2014-11-19 14:20 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Nov 19, 2014 at 03:11:03PM +0100, Arnd Bergmann wrote:
> On Wednesday 19 November 2014 14:56:42 Thierry Reding wrote:
> >
> > Oops, I just looked at that file on my system and I already have the
> > select GENERIC_PCI_IOMAP exactly where you have it. Turns out I have
> > that same patch, albeit with a somewhat obfuscated name in my tree
> > but never got around to clean up the commit message or sending it out.
> >
> > Do you want to apply that patch on top or shall I redo the pull request
> > with that patch folded in so we can keep bisectability across the
> > series?
>
> I would prefer to have my patch applied on top so I don't have to redo
> the merge between your patches and Will's patches.
Okay.
> Can you confirm that you have no further patches that I might need?
Yes, I have no other patches asm-generic related patches.
Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20141119/422f7251/attachment.sig>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-11-19 14:20 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <546c75d7.6336460a.14b5.474d@mx.google.com>
2014-11-19 11:15 ` arm64 pci_iomap, was: Re: next build: 258 warnings 9 failures (next/next-20141119) Arnd Bergmann
2014-11-19 13:56 ` Thierry Reding
2014-11-19 14:11 ` Arnd Bergmann
2014-11-19 14:20 ` Thierry Reding
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.