* [Intel-gfx] [PATCH 1/2] drm/i915/audio: unify audio codec enable/disable debug logging
@ 2022-03-30 9:41 Jani Nikula
2022-03-30 9:41 ` [Intel-gfx] [PATCH 2/2] drm/i915/audio: move has_audio checks to within codec enable/disable Jani Nikula
` (4 more replies)
0 siblings, 5 replies; 8+ messages in thread
From: Jani Nikula @ 2022-03-30 9:41 UTC (permalink / raw)
To: intel-gfx; +Cc: jani.nikula
The audio codec enable/disable debug logging is spread around in callers
and the platform specific hooks. Put them all together in one place on
both the enable and disable paths.
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
drivers/gpu/drm/i915/display/g4x_dp.c | 7 +---
drivers/gpu/drm/i915/display/g4x_hdmi.c | 3 --
drivers/gpu/drm/i915/display/intel_audio.c | 39 ++++++----------------
3 files changed, 11 insertions(+), 38 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/g4x_dp.c b/drivers/gpu/drm/i915/display/g4x_dp.c
index 8e1338678d91..55fefc950f41 100644
--- a/drivers/gpu/drm/i915/display/g4x_dp.c
+++ b/drivers/gpu/drm/i915/display/g4x_dp.c
@@ -658,9 +658,7 @@ static void intel_enable_dp(struct intel_atomic_state *state,
{
struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
struct intel_dp *intel_dp = enc_to_intel_dp(encoder);
- struct intel_crtc *crtc = to_intel_crtc(pipe_config->uapi.crtc);
u32 dp_reg = intel_de_read(dev_priv, intel_dp->output_reg);
- enum pipe pipe = crtc->pipe;
intel_wakeref_t wakeref;
if (drm_WARN_ON(&dev_priv->drm, dp_reg & DP_PORT_EN))
@@ -694,11 +692,8 @@ static void intel_enable_dp(struct intel_atomic_state *state,
intel_dp_start_link_train(intel_dp, pipe_config);
intel_dp_stop_link_train(intel_dp, pipe_config);
- if (pipe_config->has_audio) {
- drm_dbg(&dev_priv->drm, "Enabling DP audio on pipe %c\n",
- pipe_name(pipe));
+ if (pipe_config->has_audio)
intel_audio_codec_enable(encoder, pipe_config, conn_state);
- }
}
static void g4x_enable_dp(struct intel_atomic_state *state,
diff --git a/drivers/gpu/drm/i915/display/g4x_hdmi.c b/drivers/gpu/drm/i915/display/g4x_hdmi.c
index 06e00b1eaa7c..39ba5dc51f8e 100644
--- a/drivers/gpu/drm/i915/display/g4x_hdmi.c
+++ b/drivers/gpu/drm/i915/display/g4x_hdmi.c
@@ -148,11 +148,8 @@ static void intel_enable_hdmi_audio(struct intel_encoder *encoder,
const struct drm_connector_state *conn_state)
{
struct drm_i915_private *i915 = to_i915(encoder->base.dev);
- struct intel_crtc *crtc = to_intel_crtc(pipe_config->uapi.crtc);
drm_WARN_ON(&i915->drm, !pipe_config->has_hdmi_sink);
- drm_dbg_kms(&i915->drm, "Enabling HDMI audio on pipe %c\n",
- pipe_name(crtc->pipe));
intel_audio_codec_enable(encoder, pipe_config, conn_state);
}
diff --git a/drivers/gpu/drm/i915/display/intel_audio.c b/drivers/gpu/drm/i915/display/intel_audio.c
index 3bdca0fe2cee..24d20817a5e5 100644
--- a/drivers/gpu/drm/i915/display/intel_audio.c
+++ b/drivers/gpu/drm/i915/display/intel_audio.c
@@ -337,8 +337,6 @@ static void g4x_audio_codec_disable(struct intel_encoder *encoder,
struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
u32 eldv, tmp;
- drm_dbg_kms(&dev_priv->drm, "Disable audio codec\n");
-
tmp = intel_de_read(dev_priv, G4X_AUD_VID_DID);
if (tmp == INTEL_AUDIO_DEVBLC || tmp == INTEL_AUDIO_DEVCL)
eldv = G4X_ELDV_DEVCL_DEVBLC;
@@ -362,9 +360,6 @@ static void g4x_audio_codec_enable(struct intel_encoder *encoder,
u32 tmp;
int len, i;
- drm_dbg_kms(&dev_priv->drm, "Enable audio codec, %u bytes ELD\n",
- drm_eld_size(eld));
-
tmp = intel_de_read(dev_priv, G4X_AUD_VID_DID);
if (tmp == INTEL_AUDIO_DEVBLC || tmp == INTEL_AUDIO_DEVCL)
eldv = G4X_ELDV_DEVCL_DEVBLC;
@@ -383,7 +378,6 @@ static void g4x_audio_codec_enable(struct intel_encoder *encoder,
intel_de_write(dev_priv, G4X_AUD_CNTL_ST, tmp);
len = min(drm_eld_size(eld) / 4, len);
- drm_dbg(&dev_priv->drm, "ELD size %d\n", len);
for (i = 0; i < len; i++)
intel_de_write(dev_priv, G4X_HDMIW_HDMIEDID,
*((const u32 *)eld + i));
@@ -501,9 +495,6 @@ static void hsw_audio_codec_disable(struct intel_encoder *encoder,
enum transcoder cpu_transcoder = old_crtc_state->cpu_transcoder;
u32 tmp;
- drm_dbg_kms(&dev_priv->drm, "Disable audio codec on transcoder %s\n",
- transcoder_name(cpu_transcoder));
-
mutex_lock(&dev_priv->audio.mutex);
/* Disable timestamps */
@@ -647,10 +638,6 @@ static void hsw_audio_codec_enable(struct intel_encoder *encoder,
u32 tmp;
int len, i;
- drm_dbg_kms(&dev_priv->drm,
- "Enable audio codec on transcoder %s, %u bytes ELD\n",
- transcoder_name(cpu_transcoder), drm_eld_size(eld));
-
mutex_lock(&dev_priv->audio.mutex);
/* Enable Audio WA for 4k DSC usecases */
@@ -703,11 +690,6 @@ static void ilk_audio_codec_disable(struct intel_encoder *encoder,
u32 tmp, eldv;
i915_reg_t aud_config, aud_cntrl_st2;
- drm_dbg_kms(&dev_priv->drm,
- "Disable audio codec on [ENCODER:%d:%s], pipe %c\n",
- encoder->base.base.id, encoder->base.name,
- pipe_name(pipe));
-
if (drm_WARN_ON(&dev_priv->drm, port == PORT_A))
return;
@@ -754,11 +736,6 @@ static void ilk_audio_codec_enable(struct intel_encoder *encoder,
int len, i;
i915_reg_t hdmiw_hdmiedid, aud_config, aud_cntl_st, aud_cntrl_st2;
- drm_dbg_kms(&dev_priv->drm,
- "Enable audio codec on [ENCODER:%d:%s], pipe %c, %u bytes ELD\n",
- encoder->base.base.id, encoder->base.name,
- pipe_name(pipe), drm_eld_size(eld));
-
if (drm_WARN_ON(&dev_priv->drm, port == PORT_A))
return;
@@ -844,18 +821,17 @@ void intel_audio_codec_enable(struct intel_encoder *encoder,
enum port port = encoder->port;
enum pipe pipe = crtc->pipe;
+ drm_dbg_kms(&dev_priv->drm, "[CONNECTOR:%d:%s][ENCODER:%d:%s] Enable audio codec on pipe %c, %u bytes ELD\n",
+ connector->base.id, connector->name,
+ encoder->base.base.id, encoder->base.name,
+ pipe, drm_eld_size(connector->eld));
+
/* FIXME precompute the ELD in .compute_config() */
if (!connector->eld[0])
drm_dbg_kms(&dev_priv->drm,
"Bogus ELD on [CONNECTOR:%d:%s]\n",
connector->base.id, connector->name);
- drm_dbg(&dev_priv->drm, "ELD on [CONNECTOR:%d:%s], [ENCODER:%d:%s]\n",
- connector->base.id,
- connector->name,
- encoder->base.base.id,
- encoder->base.name);
-
connector->eld[6] = drm_av_sync_delay(connector, adjusted_mode) / 2;
if (dev_priv->audio.funcs)
@@ -900,9 +876,14 @@ void intel_audio_codec_disable(struct intel_encoder *encoder,
struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
struct i915_audio_component *acomp = dev_priv->audio.component;
struct intel_crtc *crtc = to_intel_crtc(old_crtc_state->uapi.crtc);
+ struct drm_connector *connector = old_conn_state->connector;
enum port port = encoder->port;
enum pipe pipe = crtc->pipe;
+ drm_dbg_kms(&dev_priv->drm, "[CONNECTOR:%d:%s][ENCODER:%d:%s] Disable audio codec on pipe %c\n",
+ connector->base.id, connector->name,
+ encoder->base.base.id, encoder->base.name, pipe);
+
if (dev_priv->audio.funcs)
dev_priv->audio.funcs->audio_codec_disable(encoder,
old_crtc_state,
--
2.30.2
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [Intel-gfx] [PATCH 2/2] drm/i915/audio: move has_audio checks to within codec enable/disable
2022-03-30 9:41 [Intel-gfx] [PATCH 1/2] drm/i915/audio: unify audio codec enable/disable debug logging Jani Nikula
@ 2022-03-30 9:41 ` Jani Nikula
2022-03-30 11:15 ` Ville Syrjälä
2022-03-30 11:12 ` [Intel-gfx] [PATCH 1/2] drm/i915/audio: unify audio codec enable/disable debug logging Ville Syrjälä
` (3 subsequent siblings)
4 siblings, 1 reply; 8+ messages in thread
From: Jani Nikula @ 2022-03-30 9:41 UTC (permalink / raw)
To: intel-gfx; +Cc: jani.nikula
Reduce duplication.
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
drivers/gpu/drm/i915/display/g4x_dp.c | 7 ++---
drivers/gpu/drm/i915/display/g4x_hdmi.c | 33 +++++++--------------
drivers/gpu/drm/i915/display/intel_audio.c | 6 ++++
drivers/gpu/drm/i915/display/intel_ddi.c | 14 +++------
drivers/gpu/drm/i915/display/intel_dp_mst.c | 8 ++---
5 files changed, 26 insertions(+), 42 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/g4x_dp.c b/drivers/gpu/drm/i915/display/g4x_dp.c
index 55fefc950f41..16bb21ad898b 100644
--- a/drivers/gpu/drm/i915/display/g4x_dp.c
+++ b/drivers/gpu/drm/i915/display/g4x_dp.c
@@ -495,9 +495,7 @@ static void intel_disable_dp(struct intel_atomic_state *state,
intel_dp->link_trained = false;
- if (old_crtc_state->has_audio)
- intel_audio_codec_disable(encoder,
- old_crtc_state, old_conn_state);
+ intel_audio_codec_disable(encoder, old_crtc_state, old_conn_state);
/*
* Make sure the panel is off before trying to change the mode.
@@ -692,8 +690,7 @@ static void intel_enable_dp(struct intel_atomic_state *state,
intel_dp_start_link_train(intel_dp, pipe_config);
intel_dp_stop_link_train(intel_dp, pipe_config);
- if (pipe_config->has_audio)
- intel_audio_codec_enable(encoder, pipe_config, conn_state);
+ intel_audio_codec_enable(encoder, pipe_config, conn_state);
}
static void g4x_enable_dp(struct intel_atomic_state *state,
diff --git a/drivers/gpu/drm/i915/display/g4x_hdmi.c b/drivers/gpu/drm/i915/display/g4x_hdmi.c
index 39ba5dc51f8e..8bfef08b7c43 100644
--- a/drivers/gpu/drm/i915/display/g4x_hdmi.c
+++ b/drivers/gpu/drm/i915/display/g4x_hdmi.c
@@ -143,16 +143,6 @@ static void intel_hdmi_get_config(struct intel_encoder *encoder,
&pipe_config->infoframes.hdmi);
}
-static void intel_enable_hdmi_audio(struct intel_encoder *encoder,
- const struct intel_crtc_state *pipe_config,
- const struct drm_connector_state *conn_state)
-{
- struct drm_i915_private *i915 = to_i915(encoder->base.dev);
-
- drm_WARN_ON(&i915->drm, !pipe_config->has_hdmi_sink);
- intel_audio_codec_enable(encoder, pipe_config, conn_state);
-}
-
static void g4x_enable_hdmi(struct intel_atomic_state *state,
struct intel_encoder *encoder,
const struct intel_crtc_state *pipe_config,
@@ -172,8 +162,9 @@ static void g4x_enable_hdmi(struct intel_atomic_state *state,
intel_de_write(dev_priv, intel_hdmi->hdmi_reg, temp);
intel_de_posting_read(dev_priv, intel_hdmi->hdmi_reg);
- if (pipe_config->has_audio)
- intel_enable_hdmi_audio(encoder, pipe_config, conn_state);
+ drm_WARN_ON(&dev_priv->drm, pipe_config->has_audio &&
+ !pipe_config->has_hdmi_sink);
+ intel_audio_codec_enable(encoder, pipe_config, conn_state);
}
static void ibx_enable_hdmi(struct intel_atomic_state *state,
@@ -224,8 +215,9 @@ static void ibx_enable_hdmi(struct intel_atomic_state *state,
intel_de_posting_read(dev_priv, intel_hdmi->hdmi_reg);
}
- if (pipe_config->has_audio)
- intel_enable_hdmi_audio(encoder, pipe_config, conn_state);
+ drm_WARN_ON(&dev_priv->drm, pipe_config->has_audio &&
+ !pipe_config->has_hdmi_sink);
+ intel_audio_codec_enable(encoder, pipe_config, conn_state);
}
static void cpt_enable_hdmi(struct intel_atomic_state *state,
@@ -278,8 +270,9 @@ static void cpt_enable_hdmi(struct intel_atomic_state *state,
intel_de_read(dev_priv, TRANS_CHICKEN1(pipe)) & ~TRANS_CHICKEN1_HDMIUNIT_GC_DISABLE);
}
- if (pipe_config->has_audio)
- intel_enable_hdmi_audio(encoder, pipe_config, conn_state);
+ drm_WARN_ON(&dev_priv->drm, pipe_config->has_audio &&
+ !pipe_config->has_hdmi_sink);
+ intel_audio_codec_enable(encoder, pipe_config, conn_state);
}
static void vlv_enable_hdmi(struct intel_atomic_state *state,
@@ -353,9 +346,7 @@ static void g4x_disable_hdmi(struct intel_atomic_state *state,
const struct intel_crtc_state *old_crtc_state,
const struct drm_connector_state *old_conn_state)
{
- if (old_crtc_state->has_audio)
- intel_audio_codec_disable(encoder,
- old_crtc_state, old_conn_state);
+ intel_audio_codec_disable(encoder, old_crtc_state, old_conn_state);
intel_disable_hdmi(state, encoder, old_crtc_state, old_conn_state);
}
@@ -365,9 +356,7 @@ static void pch_disable_hdmi(struct intel_atomic_state *state,
const struct intel_crtc_state *old_crtc_state,
const struct drm_connector_state *old_conn_state)
{
- if (old_crtc_state->has_audio)
- intel_audio_codec_disable(encoder,
- old_crtc_state, old_conn_state);
+ intel_audio_codec_disable(encoder, old_crtc_state, old_conn_state);
}
static void pch_post_disable_hdmi(struct intel_atomic_state *state,
diff --git a/drivers/gpu/drm/i915/display/intel_audio.c b/drivers/gpu/drm/i915/display/intel_audio.c
index 24d20817a5e5..1c87bf66b092 100644
--- a/drivers/gpu/drm/i915/display/intel_audio.c
+++ b/drivers/gpu/drm/i915/display/intel_audio.c
@@ -821,6 +821,9 @@ void intel_audio_codec_enable(struct intel_encoder *encoder,
enum port port = encoder->port;
enum pipe pipe = crtc->pipe;
+ if (!crtc_state->has_audio)
+ return;
+
drm_dbg_kms(&dev_priv->drm, "[CONNECTOR:%d:%s][ENCODER:%d:%s] Enable audio codec on pipe %c, %u bytes ELD\n",
connector->base.id, connector->name,
encoder->base.base.id, encoder->base.name,
@@ -880,6 +883,9 @@ void intel_audio_codec_disable(struct intel_encoder *encoder,
enum port port = encoder->port;
enum pipe pipe = crtc->pipe;
+ if (!old_crtc_state->has_audio)
+ return;
+
drm_dbg_kms(&dev_priv->drm, "[CONNECTOR:%d:%s][ENCODER:%d:%s] Disable audio codec on pipe %c\n",
connector->base.id, connector->name,
encoder->base.base.id, encoder->base.name, pipe);
diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c
index dc208df829f1..cec578efc4bd 100644
--- a/drivers/gpu/drm/i915/display/intel_ddi.c
+++ b/drivers/gpu/drm/i915/display/intel_ddi.c
@@ -2819,8 +2819,7 @@ static void intel_enable_ddi_dp(struct intel_atomic_state *state,
if (!dig_port->lspcon.active || dig_port->dp.has_hdmi_sink)
intel_dp_set_infoframes(encoder, true, crtc_state, conn_state);
- if (crtc_state->has_audio)
- intel_audio_codec_enable(encoder, crtc_state, conn_state);
+ intel_audio_codec_enable(encoder, crtc_state, conn_state);
trans_port_sync_stop_link_train(state, encoder, crtc_state);
}
@@ -2914,8 +2913,7 @@ static void intel_enable_ddi_hdmi(struct intel_atomic_state *state,
intel_de_write(dev_priv, DDI_BUF_CTL(port),
dig_port->saved_port_bits | DDI_BUF_CTL_ENABLE);
- if (crtc_state->has_audio)
- intel_audio_codec_enable(encoder, crtc_state, conn_state);
+ intel_audio_codec_enable(encoder, crtc_state, conn_state);
}
static void intel_enable_ddi(struct intel_atomic_state *state,
@@ -2956,9 +2954,7 @@ static void intel_disable_ddi_dp(struct intel_atomic_state *state,
intel_dp->link_trained = false;
- if (old_crtc_state->has_audio)
- intel_audio_codec_disable(encoder,
- old_crtc_state, old_conn_state);
+ intel_audio_codec_disable(encoder, old_crtc_state, old_conn_state);
intel_psr_disable(intel_dp, old_crtc_state);
intel_edp_backlight_off(old_conn_state);
@@ -2978,9 +2974,7 @@ static void intel_disable_ddi_hdmi(struct intel_atomic_state *state,
struct drm_i915_private *i915 = to_i915(encoder->base.dev);
struct drm_connector *connector = old_conn_state->connector;
- if (old_crtc_state->has_audio)
- intel_audio_codec_disable(encoder,
- old_crtc_state, old_conn_state);
+ intel_audio_codec_disable(encoder, old_crtc_state, old_conn_state);
if (!intel_hdmi_handle_sink_scrambling(encoder, connector,
false, false))
diff --git a/drivers/gpu/drm/i915/display/intel_dp_mst.c b/drivers/gpu/drm/i915/display/intel_dp_mst.c
index e30e698aa684..061b277e5ce7 100644
--- a/drivers/gpu/drm/i915/display/intel_dp_mst.c
+++ b/drivers/gpu/drm/i915/display/intel_dp_mst.c
@@ -398,9 +398,8 @@ static void intel_mst_disable_dp(struct intel_atomic_state *state,
if (ret) {
drm_dbg_kms(&i915->drm, "failed to update payload %d\n", ret);
}
- if (old_crtc_state->has_audio)
- intel_audio_codec_disable(encoder,
- old_crtc_state, old_conn_state);
+
+ intel_audio_codec_disable(encoder, old_crtc_state, old_conn_state);
}
static void intel_mst_post_disable_dp(struct intel_atomic_state *state,
@@ -599,8 +598,7 @@ static void intel_mst_enable_dp(struct intel_atomic_state *state,
intel_crtc_vblank_on(pipe_config);
- if (pipe_config->has_audio)
- intel_audio_codec_enable(encoder, pipe_config, conn_state);
+ intel_audio_codec_enable(encoder, pipe_config, conn_state);
/* Enable hdcp if it's desired */
if (conn_state->content_protection ==
--
2.30.2
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [Intel-gfx] [PATCH 1/2] drm/i915/audio: unify audio codec enable/disable debug logging
2022-03-30 9:41 [Intel-gfx] [PATCH 1/2] drm/i915/audio: unify audio codec enable/disable debug logging Jani Nikula
2022-03-30 9:41 ` [Intel-gfx] [PATCH 2/2] drm/i915/audio: move has_audio checks to within codec enable/disable Jani Nikula
@ 2022-03-30 11:12 ` Ville Syrjälä
2022-03-30 16:37 ` Jani Nikula
2022-03-30 11:51 ` [Intel-gfx] ✗ Fi.CI.DOCS: warning for series starting with [1/2] " Patchwork
` (2 subsequent siblings)
4 siblings, 1 reply; 8+ messages in thread
From: Ville Syrjälä @ 2022-03-30 11:12 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx
On Wed, Mar 30, 2022 at 12:41:08PM +0300, Jani Nikula wrote:
> The audio codec enable/disable debug logging is spread around in callers
> and the platform specific hooks. Put them all together in one place on
> both the enable and disable paths.
>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> ---
> drivers/gpu/drm/i915/display/g4x_dp.c | 7 +---
> drivers/gpu/drm/i915/display/g4x_hdmi.c | 3 --
> drivers/gpu/drm/i915/display/intel_audio.c | 39 ++++++----------------
> 3 files changed, 11 insertions(+), 38 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/g4x_dp.c b/drivers/gpu/drm/i915/display/g4x_dp.c
> index 8e1338678d91..55fefc950f41 100644
> --- a/drivers/gpu/drm/i915/display/g4x_dp.c
> +++ b/drivers/gpu/drm/i915/display/g4x_dp.c
> @@ -658,9 +658,7 @@ static void intel_enable_dp(struct intel_atomic_state *state,
> {
> struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
> struct intel_dp *intel_dp = enc_to_intel_dp(encoder);
> - struct intel_crtc *crtc = to_intel_crtc(pipe_config->uapi.crtc);
> u32 dp_reg = intel_de_read(dev_priv, intel_dp->output_reg);
> - enum pipe pipe = crtc->pipe;
> intel_wakeref_t wakeref;
>
> if (drm_WARN_ON(&dev_priv->drm, dp_reg & DP_PORT_EN))
> @@ -694,11 +692,8 @@ static void intel_enable_dp(struct intel_atomic_state *state,
> intel_dp_start_link_train(intel_dp, pipe_config);
> intel_dp_stop_link_train(intel_dp, pipe_config);
>
> - if (pipe_config->has_audio) {
> - drm_dbg(&dev_priv->drm, "Enabling DP audio on pipe %c\n",
> - pipe_name(pipe));
> + if (pipe_config->has_audio)
> intel_audio_codec_enable(encoder, pipe_config, conn_state);
> - }
> }
>
> static void g4x_enable_dp(struct intel_atomic_state *state,
> diff --git a/drivers/gpu/drm/i915/display/g4x_hdmi.c b/drivers/gpu/drm/i915/display/g4x_hdmi.c
> index 06e00b1eaa7c..39ba5dc51f8e 100644
> --- a/drivers/gpu/drm/i915/display/g4x_hdmi.c
> +++ b/drivers/gpu/drm/i915/display/g4x_hdmi.c
> @@ -148,11 +148,8 @@ static void intel_enable_hdmi_audio(struct intel_encoder *encoder,
> const struct drm_connector_state *conn_state)
> {
> struct drm_i915_private *i915 = to_i915(encoder->base.dev);
> - struct intel_crtc *crtc = to_intel_crtc(pipe_config->uapi.crtc);
>
> drm_WARN_ON(&i915->drm, !pipe_config->has_hdmi_sink);
> - drm_dbg_kms(&i915->drm, "Enabling HDMI audio on pipe %c\n",
> - pipe_name(crtc->pipe));
> intel_audio_codec_enable(encoder, pipe_config, conn_state);
> }
>
> diff --git a/drivers/gpu/drm/i915/display/intel_audio.c b/drivers/gpu/drm/i915/display/intel_audio.c
> index 3bdca0fe2cee..24d20817a5e5 100644
> --- a/drivers/gpu/drm/i915/display/intel_audio.c
> +++ b/drivers/gpu/drm/i915/display/intel_audio.c
> @@ -337,8 +337,6 @@ static void g4x_audio_codec_disable(struct intel_encoder *encoder,
> struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
> u32 eldv, tmp;
>
> - drm_dbg_kms(&dev_priv->drm, "Disable audio codec\n");
> -
> tmp = intel_de_read(dev_priv, G4X_AUD_VID_DID);
> if (tmp == INTEL_AUDIO_DEVBLC || tmp == INTEL_AUDIO_DEVCL)
> eldv = G4X_ELDV_DEVCL_DEVBLC;
> @@ -362,9 +360,6 @@ static void g4x_audio_codec_enable(struct intel_encoder *encoder,
> u32 tmp;
> int len, i;
>
> - drm_dbg_kms(&dev_priv->drm, "Enable audio codec, %u bytes ELD\n",
> - drm_eld_size(eld));
> -
> tmp = intel_de_read(dev_priv, G4X_AUD_VID_DID);
> if (tmp == INTEL_AUDIO_DEVBLC || tmp == INTEL_AUDIO_DEVCL)
> eldv = G4X_ELDV_DEVCL_DEVBLC;
> @@ -383,7 +378,6 @@ static void g4x_audio_codec_enable(struct intel_encoder *encoder,
> intel_de_write(dev_priv, G4X_AUD_CNTL_ST, tmp);
>
> len = min(drm_eld_size(eld) / 4, len);
> - drm_dbg(&dev_priv->drm, "ELD size %d\n", len);
> for (i = 0; i < len; i++)
> intel_de_write(dev_priv, G4X_HDMIW_HDMIEDID,
> *((const u32 *)eld + i));
> @@ -501,9 +495,6 @@ static void hsw_audio_codec_disable(struct intel_encoder *encoder,
> enum transcoder cpu_transcoder = old_crtc_state->cpu_transcoder;
> u32 tmp;
>
> - drm_dbg_kms(&dev_priv->drm, "Disable audio codec on transcoder %s\n",
> - transcoder_name(cpu_transcoder));
> -
> mutex_lock(&dev_priv->audio.mutex);
>
> /* Disable timestamps */
> @@ -647,10 +638,6 @@ static void hsw_audio_codec_enable(struct intel_encoder *encoder,
> u32 tmp;
> int len, i;
>
> - drm_dbg_kms(&dev_priv->drm,
> - "Enable audio codec on transcoder %s, %u bytes ELD\n",
> - transcoder_name(cpu_transcoder), drm_eld_size(eld));
> -
> mutex_lock(&dev_priv->audio.mutex);
>
> /* Enable Audio WA for 4k DSC usecases */
> @@ -703,11 +690,6 @@ static void ilk_audio_codec_disable(struct intel_encoder *encoder,
> u32 tmp, eldv;
> i915_reg_t aud_config, aud_cntrl_st2;
>
> - drm_dbg_kms(&dev_priv->drm,
> - "Disable audio codec on [ENCODER:%d:%s], pipe %c\n",
> - encoder->base.base.id, encoder->base.name,
> - pipe_name(pipe));
> -
> if (drm_WARN_ON(&dev_priv->drm, port == PORT_A))
> return;
>
> @@ -754,11 +736,6 @@ static void ilk_audio_codec_enable(struct intel_encoder *encoder,
> int len, i;
> i915_reg_t hdmiw_hdmiedid, aud_config, aud_cntl_st, aud_cntrl_st2;
>
> - drm_dbg_kms(&dev_priv->drm,
> - "Enable audio codec on [ENCODER:%d:%s], pipe %c, %u bytes ELD\n",
> - encoder->base.base.id, encoder->base.name,
> - pipe_name(pipe), drm_eld_size(eld));
> -
> if (drm_WARN_ON(&dev_priv->drm, port == PORT_A))
> return;
>
> @@ -844,18 +821,17 @@ void intel_audio_codec_enable(struct intel_encoder *encoder,
> enum port port = encoder->port;
> enum pipe pipe = crtc->pipe;
>
> + drm_dbg_kms(&dev_priv->drm, "[CONNECTOR:%d:%s][ENCODER:%d:%s] Enable audio codec on pipe %c, %u bytes ELD\n",
> + connector->base.id, connector->name,
> + encoder->base.base.id, encoder->base.name,
> + pipe, drm_eld_size(connector->eld));
Could also use the [CRTC:%d:%s] format for the pipe.
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> +
> /* FIXME precompute the ELD in .compute_config() */
> if (!connector->eld[0])
> drm_dbg_kms(&dev_priv->drm,
> "Bogus ELD on [CONNECTOR:%d:%s]\n",
> connector->base.id, connector->name);
>
> - drm_dbg(&dev_priv->drm, "ELD on [CONNECTOR:%d:%s], [ENCODER:%d:%s]\n",
> - connector->base.id,
> - connector->name,
> - encoder->base.base.id,
> - encoder->base.name);
> -
> connector->eld[6] = drm_av_sync_delay(connector, adjusted_mode) / 2;
>
> if (dev_priv->audio.funcs)
> @@ -900,9 +876,14 @@ void intel_audio_codec_disable(struct intel_encoder *encoder,
> struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
> struct i915_audio_component *acomp = dev_priv->audio.component;
> struct intel_crtc *crtc = to_intel_crtc(old_crtc_state->uapi.crtc);
> + struct drm_connector *connector = old_conn_state->connector;
> enum port port = encoder->port;
> enum pipe pipe = crtc->pipe;
>
> + drm_dbg_kms(&dev_priv->drm, "[CONNECTOR:%d:%s][ENCODER:%d:%s] Disable audio codec on pipe %c\n",
> + connector->base.id, connector->name,
> + encoder->base.base.id, encoder->base.name, pipe);
> +
> if (dev_priv->audio.funcs)
> dev_priv->audio.funcs->audio_codec_disable(encoder,
> old_crtc_state,
> --
> 2.30.2
--
Ville Syrjälä
Intel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Intel-gfx] [PATCH 2/2] drm/i915/audio: move has_audio checks to within codec enable/disable
2022-03-30 9:41 ` [Intel-gfx] [PATCH 2/2] drm/i915/audio: move has_audio checks to within codec enable/disable Jani Nikula
@ 2022-03-30 11:15 ` Ville Syrjälä
0 siblings, 0 replies; 8+ messages in thread
From: Ville Syrjälä @ 2022-03-30 11:15 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx
On Wed, Mar 30, 2022 at 12:41:09PM +0300, Jani Nikula wrote:
> Reduce duplication.
>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> ---
> drivers/gpu/drm/i915/display/g4x_dp.c | 7 ++---
> drivers/gpu/drm/i915/display/g4x_hdmi.c | 33 +++++++--------------
> drivers/gpu/drm/i915/display/intel_audio.c | 6 ++++
> drivers/gpu/drm/i915/display/intel_ddi.c | 14 +++------
> drivers/gpu/drm/i915/display/intel_dp_mst.c | 8 ++---
> 5 files changed, 26 insertions(+), 42 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/g4x_dp.c b/drivers/gpu/drm/i915/display/g4x_dp.c
> index 55fefc950f41..16bb21ad898b 100644
> --- a/drivers/gpu/drm/i915/display/g4x_dp.c
> +++ b/drivers/gpu/drm/i915/display/g4x_dp.c
> @@ -495,9 +495,7 @@ static void intel_disable_dp(struct intel_atomic_state *state,
>
> intel_dp->link_trained = false;
>
> - if (old_crtc_state->has_audio)
> - intel_audio_codec_disable(encoder,
> - old_crtc_state, old_conn_state);
> + intel_audio_codec_disable(encoder, old_crtc_state, old_conn_state);
>
> /*
> * Make sure the panel is off before trying to change the mode.
> @@ -692,8 +690,7 @@ static void intel_enable_dp(struct intel_atomic_state *state,
> intel_dp_start_link_train(intel_dp, pipe_config);
> intel_dp_stop_link_train(intel_dp, pipe_config);
>
> - if (pipe_config->has_audio)
> - intel_audio_codec_enable(encoder, pipe_config, conn_state);
> + intel_audio_codec_enable(encoder, pipe_config, conn_state);
> }
>
> static void g4x_enable_dp(struct intel_atomic_state *state,
> diff --git a/drivers/gpu/drm/i915/display/g4x_hdmi.c b/drivers/gpu/drm/i915/display/g4x_hdmi.c
> index 39ba5dc51f8e..8bfef08b7c43 100644
> --- a/drivers/gpu/drm/i915/display/g4x_hdmi.c
> +++ b/drivers/gpu/drm/i915/display/g4x_hdmi.c
> @@ -143,16 +143,6 @@ static void intel_hdmi_get_config(struct intel_encoder *encoder,
> &pipe_config->infoframes.hdmi);
> }
>
> -static void intel_enable_hdmi_audio(struct intel_encoder *encoder,
> - const struct intel_crtc_state *pipe_config,
> - const struct drm_connector_state *conn_state)
> -{
> - struct drm_i915_private *i915 = to_i915(encoder->base.dev);
> -
> - drm_WARN_ON(&i915->drm, !pipe_config->has_hdmi_sink);
> - intel_audio_codec_enable(encoder, pipe_config, conn_state);
> -}
> -
> static void g4x_enable_hdmi(struct intel_atomic_state *state,
> struct intel_encoder *encoder,
> const struct intel_crtc_state *pipe_config,
> @@ -172,8 +162,9 @@ static void g4x_enable_hdmi(struct intel_atomic_state *state,
> intel_de_write(dev_priv, intel_hdmi->hdmi_reg, temp);
> intel_de_posting_read(dev_priv, intel_hdmi->hdmi_reg);
>
> - if (pipe_config->has_audio)
> - intel_enable_hdmi_audio(encoder, pipe_config, conn_state);
> + drm_WARN_ON(&dev_priv->drm, pipe_config->has_audio &&
> + !pipe_config->has_hdmi_sink);
I'd probably just drop these warns. We don't have them for hsw+ either.
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> + intel_audio_codec_enable(encoder, pipe_config, conn_state);
> }
>
> static void ibx_enable_hdmi(struct intel_atomic_state *state,
> @@ -224,8 +215,9 @@ static void ibx_enable_hdmi(struct intel_atomic_state *state,
> intel_de_posting_read(dev_priv, intel_hdmi->hdmi_reg);
> }
>
> - if (pipe_config->has_audio)
> - intel_enable_hdmi_audio(encoder, pipe_config, conn_state);
> + drm_WARN_ON(&dev_priv->drm, pipe_config->has_audio &&
> + !pipe_config->has_hdmi_sink);
> + intel_audio_codec_enable(encoder, pipe_config, conn_state);
> }
>
> static void cpt_enable_hdmi(struct intel_atomic_state *state,
> @@ -278,8 +270,9 @@ static void cpt_enable_hdmi(struct intel_atomic_state *state,
> intel_de_read(dev_priv, TRANS_CHICKEN1(pipe)) & ~TRANS_CHICKEN1_HDMIUNIT_GC_DISABLE);
> }
>
> - if (pipe_config->has_audio)
> - intel_enable_hdmi_audio(encoder, pipe_config, conn_state);
> + drm_WARN_ON(&dev_priv->drm, pipe_config->has_audio &&
> + !pipe_config->has_hdmi_sink);
> + intel_audio_codec_enable(encoder, pipe_config, conn_state);
> }
>
> static void vlv_enable_hdmi(struct intel_atomic_state *state,
> @@ -353,9 +346,7 @@ static void g4x_disable_hdmi(struct intel_atomic_state *state,
> const struct intel_crtc_state *old_crtc_state,
> const struct drm_connector_state *old_conn_state)
> {
> - if (old_crtc_state->has_audio)
> - intel_audio_codec_disable(encoder,
> - old_crtc_state, old_conn_state);
> + intel_audio_codec_disable(encoder, old_crtc_state, old_conn_state);
>
> intel_disable_hdmi(state, encoder, old_crtc_state, old_conn_state);
> }
> @@ -365,9 +356,7 @@ static void pch_disable_hdmi(struct intel_atomic_state *state,
> const struct intel_crtc_state *old_crtc_state,
> const struct drm_connector_state *old_conn_state)
> {
> - if (old_crtc_state->has_audio)
> - intel_audio_codec_disable(encoder,
> - old_crtc_state, old_conn_state);
> + intel_audio_codec_disable(encoder, old_crtc_state, old_conn_state);
> }
>
> static void pch_post_disable_hdmi(struct intel_atomic_state *state,
> diff --git a/drivers/gpu/drm/i915/display/intel_audio.c b/drivers/gpu/drm/i915/display/intel_audio.c
> index 24d20817a5e5..1c87bf66b092 100644
> --- a/drivers/gpu/drm/i915/display/intel_audio.c
> +++ b/drivers/gpu/drm/i915/display/intel_audio.c
> @@ -821,6 +821,9 @@ void intel_audio_codec_enable(struct intel_encoder *encoder,
> enum port port = encoder->port;
> enum pipe pipe = crtc->pipe;
>
> + if (!crtc_state->has_audio)
> + return;
> +
> drm_dbg_kms(&dev_priv->drm, "[CONNECTOR:%d:%s][ENCODER:%d:%s] Enable audio codec on pipe %c, %u bytes ELD\n",
> connector->base.id, connector->name,
> encoder->base.base.id, encoder->base.name,
> @@ -880,6 +883,9 @@ void intel_audio_codec_disable(struct intel_encoder *encoder,
> enum port port = encoder->port;
> enum pipe pipe = crtc->pipe;
>
> + if (!old_crtc_state->has_audio)
> + return;
> +
> drm_dbg_kms(&dev_priv->drm, "[CONNECTOR:%d:%s][ENCODER:%d:%s] Disable audio codec on pipe %c\n",
> connector->base.id, connector->name,
> encoder->base.base.id, encoder->base.name, pipe);
> diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c
> index dc208df829f1..cec578efc4bd 100644
> --- a/drivers/gpu/drm/i915/display/intel_ddi.c
> +++ b/drivers/gpu/drm/i915/display/intel_ddi.c
> @@ -2819,8 +2819,7 @@ static void intel_enable_ddi_dp(struct intel_atomic_state *state,
> if (!dig_port->lspcon.active || dig_port->dp.has_hdmi_sink)
> intel_dp_set_infoframes(encoder, true, crtc_state, conn_state);
>
> - if (crtc_state->has_audio)
> - intel_audio_codec_enable(encoder, crtc_state, conn_state);
> + intel_audio_codec_enable(encoder, crtc_state, conn_state);
>
> trans_port_sync_stop_link_train(state, encoder, crtc_state);
> }
> @@ -2914,8 +2913,7 @@ static void intel_enable_ddi_hdmi(struct intel_atomic_state *state,
> intel_de_write(dev_priv, DDI_BUF_CTL(port),
> dig_port->saved_port_bits | DDI_BUF_CTL_ENABLE);
>
> - if (crtc_state->has_audio)
> - intel_audio_codec_enable(encoder, crtc_state, conn_state);
> + intel_audio_codec_enable(encoder, crtc_state, conn_state);
> }
>
> static void intel_enable_ddi(struct intel_atomic_state *state,
> @@ -2956,9 +2954,7 @@ static void intel_disable_ddi_dp(struct intel_atomic_state *state,
>
> intel_dp->link_trained = false;
>
> - if (old_crtc_state->has_audio)
> - intel_audio_codec_disable(encoder,
> - old_crtc_state, old_conn_state);
> + intel_audio_codec_disable(encoder, old_crtc_state, old_conn_state);
>
> intel_psr_disable(intel_dp, old_crtc_state);
> intel_edp_backlight_off(old_conn_state);
> @@ -2978,9 +2974,7 @@ static void intel_disable_ddi_hdmi(struct intel_atomic_state *state,
> struct drm_i915_private *i915 = to_i915(encoder->base.dev);
> struct drm_connector *connector = old_conn_state->connector;
>
> - if (old_crtc_state->has_audio)
> - intel_audio_codec_disable(encoder,
> - old_crtc_state, old_conn_state);
> + intel_audio_codec_disable(encoder, old_crtc_state, old_conn_state);
>
> if (!intel_hdmi_handle_sink_scrambling(encoder, connector,
> false, false))
> diff --git a/drivers/gpu/drm/i915/display/intel_dp_mst.c b/drivers/gpu/drm/i915/display/intel_dp_mst.c
> index e30e698aa684..061b277e5ce7 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp_mst.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp_mst.c
> @@ -398,9 +398,8 @@ static void intel_mst_disable_dp(struct intel_atomic_state *state,
> if (ret) {
> drm_dbg_kms(&i915->drm, "failed to update payload %d\n", ret);
> }
> - if (old_crtc_state->has_audio)
> - intel_audio_codec_disable(encoder,
> - old_crtc_state, old_conn_state);
> +
> + intel_audio_codec_disable(encoder, old_crtc_state, old_conn_state);
> }
>
> static void intel_mst_post_disable_dp(struct intel_atomic_state *state,
> @@ -599,8 +598,7 @@ static void intel_mst_enable_dp(struct intel_atomic_state *state,
>
> intel_crtc_vblank_on(pipe_config);
>
> - if (pipe_config->has_audio)
> - intel_audio_codec_enable(encoder, pipe_config, conn_state);
> + intel_audio_codec_enable(encoder, pipe_config, conn_state);
>
> /* Enable hdcp if it's desired */
> if (conn_state->content_protection ==
> --
> 2.30.2
--
Ville Syrjälä
Intel
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Intel-gfx] ✗ Fi.CI.DOCS: warning for series starting with [1/2] drm/i915/audio: unify audio codec enable/disable debug logging
2022-03-30 9:41 [Intel-gfx] [PATCH 1/2] drm/i915/audio: unify audio codec enable/disable debug logging Jani Nikula
2022-03-30 9:41 ` [Intel-gfx] [PATCH 2/2] drm/i915/audio: move has_audio checks to within codec enable/disable Jani Nikula
2022-03-30 11:12 ` [Intel-gfx] [PATCH 1/2] drm/i915/audio: unify audio codec enable/disable debug logging Ville Syrjälä
@ 2022-03-30 11:51 ` Patchwork
2022-03-30 12:27 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-03-30 15:22 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
4 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2022-03-30 11:51 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx
== Series Details ==
Series: series starting with [1/2] drm/i915/audio: unify audio codec enable/disable debug logging
URL : https://patchwork.freedesktop.org/series/101953/
State : warning
== Summary ==
$ make htmldocs 2>&1 > /dev/null | grep i915
./drivers/gpu/drm/i915/display/intel_drrs.c:1: warning: 'intel_drrs_enable' not found
./drivers/gpu/drm/i915/display/intel_drrs.c:1: warning: 'intel_drrs_disable' not found
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915/audio: unify audio codec enable/disable debug logging
2022-03-30 9:41 [Intel-gfx] [PATCH 1/2] drm/i915/audio: unify audio codec enable/disable debug logging Jani Nikula
` (2 preceding siblings ...)
2022-03-30 11:51 ` [Intel-gfx] ✗ Fi.CI.DOCS: warning for series starting with [1/2] " Patchwork
@ 2022-03-30 12:27 ` Patchwork
2022-03-30 15:22 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
4 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2022-03-30 12:27 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 11151 bytes --]
== Series Details ==
Series: series starting with [1/2] drm/i915/audio: unify audio codec enable/disable debug logging
URL : https://patchwork.freedesktop.org/series/101953/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11416 -> Patchwork_22732
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22732/index.html
Participating hosts (44 -> 40)
------------------------------
Additional (5): fi-tgl-u2 fi-skl-guc bat-adlm-1 fi-cfl-8700k fi-ivb-3770
Missing (9): fi-kbl-soraka shard-tglu shard-rkl fi-bsw-cyan bat-rpls-1 bat-rpls-2 shard-dg1 bat-jsl-2 fi-bdw-samus
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_22732:
### IGT changes ###
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* igt@kms_addfb_basic@tile-pitch-mismatch:
- {bat-adlm-1}: NOTRUN -> [INCOMPLETE][1]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22732/bat-adlm-1/igt@kms_addfb_basic@tile-pitch-mismatch.html
Known issues
------------
Here are the changes found in Patchwork_22732 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@amdgpu/amd_basic@query-info:
- fi-bsw-kefka: NOTRUN -> [SKIP][2] ([fdo#109271]) +17 similar issues
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22732/fi-bsw-kefka/igt@amdgpu/amd_basic@query-info.html
* igt@amdgpu/amd_basic@semaphore:
- fi-hsw-4770: NOTRUN -> [SKIP][3] ([fdo#109271] / [fdo#109315]) +17 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22732/fi-hsw-4770/igt@amdgpu/amd_basic@semaphore.html
* igt@amdgpu/amd_basic@userptr:
- fi-cfl-8700k: NOTRUN -> [SKIP][4] ([fdo#109271]) +29 similar issues
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22732/fi-cfl-8700k/igt@amdgpu/amd_basic@userptr.html
* igt@gem_huc_copy@huc-copy:
- fi-tgl-u2: NOTRUN -> [SKIP][5] ([i915#2190])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22732/fi-tgl-u2/igt@gem_huc_copy@huc-copy.html
- fi-cfl-8700k: NOTRUN -> [SKIP][6] ([fdo#109271] / [i915#2190])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22732/fi-cfl-8700k/igt@gem_huc_copy@huc-copy.html
* igt@gem_lmem_swapping@random-engines:
- fi-skl-guc: NOTRUN -> [SKIP][7] ([fdo#109271] / [i915#4613]) +3 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22732/fi-skl-guc/igt@gem_lmem_swapping@random-engines.html
- fi-ivb-3770: NOTRUN -> [SKIP][8] ([fdo#109271]) +36 similar issues
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22732/fi-ivb-3770/igt@gem_lmem_swapping@random-engines.html
- fi-cfl-8700k: NOTRUN -> [SKIP][9] ([fdo#109271] / [i915#4613]) +3 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22732/fi-cfl-8700k/igt@gem_lmem_swapping@random-engines.html
* igt@gem_lmem_swapping@verify-random:
- fi-tgl-u2: NOTRUN -> [SKIP][10] ([i915#4613]) +3 similar issues
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22732/fi-tgl-u2/igt@gem_lmem_swapping@verify-random.html
* igt@kms_chamelium@common-hpd-after-suspend:
- fi-tgl-u2: NOTRUN -> [SKIP][11] ([fdo#109284] / [fdo#111827]) +8 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22732/fi-tgl-u2/igt@kms_chamelium@common-hpd-after-suspend.html
- fi-skl-guc: NOTRUN -> [SKIP][12] ([fdo#109271] / [fdo#111827]) +8 similar issues
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22732/fi-skl-guc/igt@kms_chamelium@common-hpd-after-suspend.html
* igt@kms_chamelium@dp-crc-fast:
- fi-cfl-8700k: NOTRUN -> [SKIP][13] ([fdo#109271] / [fdo#111827]) +8 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22732/fi-cfl-8700k/igt@kms_chamelium@dp-crc-fast.html
* igt@kms_chamelium@dp-hpd-fast:
- fi-ivb-3770: NOTRUN -> [SKIP][14] ([fdo#109271] / [fdo#111827]) +8 similar issues
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22732/fi-ivb-3770/igt@kms_chamelium@dp-hpd-fast.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic:
- fi-tgl-u2: NOTRUN -> [SKIP][15] ([i915#4103]) +1 similar issue
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22732/fi-tgl-u2/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html
* igt@kms_flip@basic-plain-flip@a-edp1:
- fi-tgl-u2: NOTRUN -> [DMESG-WARN][16] ([i915#402])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22732/fi-tgl-u2/igt@kms_flip@basic-plain-flip@a-edp1.html
* igt@kms_force_connector_basic@force-load-detect:
- fi-tgl-u2: NOTRUN -> [SKIP][17] ([fdo#109285])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22732/fi-tgl-u2/igt@kms_force_connector_basic@force-load-detect.html
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d:
- fi-skl-guc: NOTRUN -> [SKIP][18] ([fdo#109271] / [i915#533])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22732/fi-skl-guc/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d.html
- fi-cfl-8700k: NOTRUN -> [SKIP][19] ([fdo#109271] / [i915#533])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22732/fi-cfl-8700k/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d.html
* igt@kms_psr@primary_mmap_gtt:
- fi-skl-guc: NOTRUN -> [SKIP][20] ([fdo#109271]) +29 similar issues
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22732/fi-skl-guc/igt@kms_psr@primary_mmap_gtt.html
* igt@kms_setmode@basic-clone-single-crtc:
- fi-tgl-u2: NOTRUN -> [SKIP][21] ([i915#3555])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22732/fi-tgl-u2/igt@kms_setmode@basic-clone-single-crtc.html
#### Possible fixes ####
* igt@i915_selftest@live@execlists:
- fi-bsw-kefka: [INCOMPLETE][22] ([i915#2940]) -> [PASS][23]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11416/fi-bsw-kefka/igt@i915_selftest@live@execlists.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22732/fi-bsw-kefka/igt@i915_selftest@live@execlists.html
* igt@i915_selftest@live@gt_lrc:
- {bat-adlp-6}: [INCOMPLETE][24] -> [PASS][25]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11416/bat-adlp-6/igt@i915_selftest@live@gt_lrc.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22732/bat-adlp-6/igt@i915_selftest@live@gt_lrc.html
* igt@i915_selftest@live@hangcheck:
- fi-hsw-4770: [INCOMPLETE][26] ([i915#4785]) -> [PASS][27]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11416/fi-hsw-4770/igt@i915_selftest@live@hangcheck.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22732/fi-hsw-4770/igt@i915_selftest@live@hangcheck.html
- {fi-hsw-g3258}: [INCOMPLETE][28] ([i915#3303] / [i915#4785]) -> [PASS][29]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11416/fi-hsw-g3258/igt@i915_selftest@live@hangcheck.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22732/fi-hsw-g3258/igt@i915_selftest@live@hangcheck.html
- {fi-ehl-2}: [INCOMPLETE][30] -> [PASS][31]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11416/fi-ehl-2/igt@i915_selftest@live@hangcheck.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22732/fi-ehl-2/igt@i915_selftest@live@hangcheck.html
* igt@i915_selftest@live@workarounds:
- {bat-adlp-6}: [DMESG-WARN][32] ([i915#5068]) -> [PASS][33]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11416/bat-adlp-6/igt@i915_selftest@live@workarounds.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22732/bat-adlp-6/igt@i915_selftest@live@workarounds.html
* igt@kms_busy@basic@flip:
- {bat-dg2-9}: [DMESG-WARN][34] ([i915#5291]) -> [PASS][35]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11416/bat-dg2-9/igt@kms_busy@basic@flip.html
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22732/bat-dg2-9/igt@kms_busy@basic@flip.html
* igt@kms_flip@basic-flip-vs-modeset@a-edp1:
- {bat-adlp-6}: [DMESG-WARN][36] ([i915#3576]) -> [PASS][37]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11416/bat-adlp-6/igt@kms_flip@basic-flip-vs-modeset@a-edp1.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22732/bat-adlp-6/igt@kms_flip@basic-flip-vs-modeset@a-edp1.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2940]: https://gitlab.freedesktop.org/drm/intel/issues/2940
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3303]: https://gitlab.freedesktop.org/drm/intel/issues/3303
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3576]: https://gitlab.freedesktop.org/drm/intel/issues/3576
[i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4213]: https://gitlab.freedesktop.org/drm/intel/issues/4213
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4785]: https://gitlab.freedesktop.org/drm/intel/issues/4785
[i915#5068]: https://gitlab.freedesktop.org/drm/intel/issues/5068
[i915#5127]: https://gitlab.freedesktop.org/drm/intel/issues/5127
[i915#5195]: https://gitlab.freedesktop.org/drm/intel/issues/5195
[i915#5270]: https://gitlab.freedesktop.org/drm/intel/issues/5270
[i915#5274]: https://gitlab.freedesktop.org/drm/intel/issues/5274
[i915#5291]: https://gitlab.freedesktop.org/drm/intel/issues/5291
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#5356]: https://gitlab.freedesktop.org/drm/intel/issues/5356
Build changes
-------------
* Linux: CI_DRM_11416 -> Patchwork_22732
CI-20190529: 20190529
CI_DRM_11416: 1dc2c6953e2689a0e5b7cca8450da14059d35f03 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6399: 9ba6cb16f04319226383b57975db203561c75781 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_22732: d024a22e1b8072bf253c2519e8a8e1ca9cc5d399 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
d024a22e1b80 drm/i915/audio: move has_audio checks to within codec enable/disable
31c294760298 drm/i915/audio: unify audio codec enable/disable debug logging
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22732/index.html
[-- Attachment #2: Type: text/html, Size: 13297 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/2] drm/i915/audio: unify audio codec enable/disable debug logging
2022-03-30 9:41 [Intel-gfx] [PATCH 1/2] drm/i915/audio: unify audio codec enable/disable debug logging Jani Nikula
` (3 preceding siblings ...)
2022-03-30 12:27 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
@ 2022-03-30 15:22 ` Patchwork
4 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2022-03-30 15:22 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 30313 bytes --]
== Series Details ==
Series: series starting with [1/2] drm/i915/audio: unify audio codec enable/disable debug logging
URL : https://patchwork.freedesktop.org/series/101953/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_11416_full -> Patchwork_22732_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_22732_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_22732_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
Participating hosts (11 -> 12)
------------------------------
Additional (1): shard-rkl
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_22732_full:
### IGT changes ###
#### Possible regressions ####
* igt@i915_module_load@reload-with-fault-injection:
- shard-snb: [PASS][1] -> [INCOMPLETE][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11416/shard-snb5/igt@i915_module_load@reload-with-fault-injection.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22732/shard-snb2/igt@i915_module_load@reload-with-fault-injection.html
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* igt@gem_pipe_control_store_loop@fresh-buffer:
- {shard-rkl}: NOTRUN -> [DMESG-WARN][3]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22732/shard-rkl-5/igt@gem_pipe_control_store_loop@fresh-buffer.html
* igt@i915_pm_rpm@modeset-non-lpsp-stress-no-wait:
- {shard-rkl}: NOTRUN -> [INCOMPLETE][4]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22732/shard-rkl-5/igt@i915_pm_rpm@modeset-non-lpsp-stress-no-wait.html
Known issues
------------
Here are the changes found in Patchwork_22732_full that come from known issues:
### CI changes ###
### IGT changes ###
#### Issues hit ####
* igt@gem_ccs@ctrl-surf-copy:
- shard-iclb: NOTRUN -> [SKIP][5] ([i915#5327])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22732/shard-iclb7/igt@gem_ccs@ctrl-surf-copy.html
* igt@gem_ctx_isolation@preservation-s3@rcs0:
- shard-apl: [PASS][6] -> [DMESG-WARN][7] ([i915#180]) +3 similar issues
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11416/shard-apl2/igt@gem_ctx_isolation@preservation-s3@rcs0.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22732/shard-apl8/igt@gem_ctx_isolation@preservation-s3@rcs0.html
- shard-iclb: [PASS][8] -> [INCOMPLETE][9] ([i915#1373])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11416/shard-iclb3/igt@gem_ctx_isolation@preservation-s3@rcs0.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22732/shard-iclb4/igt@gem_ctx_isolation@preservation-s3@rcs0.html
* igt@gem_ctx_persistence@legacy-engines-queued:
- shard-snb: NOTRUN -> [SKIP][10] ([fdo#109271] / [i915#1099]) +1 similar issue
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22732/shard-snb4/igt@gem_ctx_persistence@legacy-engines-queued.html
* igt@gem_ctx_sseu@invalid-sseu:
- shard-tglb: NOTRUN -> [SKIP][11] ([i915#280])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22732/shard-tglb6/igt@gem_ctx_sseu@invalid-sseu.html
* igt@gem_eio@in-flight-contexts-10ms:
- shard-skl: [PASS][12] -> [TIMEOUT][13] ([i915#3063]) +1 similar issue
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11416/shard-skl9/igt@gem_eio@in-flight-contexts-10ms.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22732/shard-skl9/igt@gem_eio@in-flight-contexts-10ms.html
* igt@gem_eio@unwedge-stress:
- shard-tglb: [PASS][14] -> [TIMEOUT][15] ([i915#3063] / [i915#3648])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11416/shard-tglb7/igt@gem_eio@unwedge-stress.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22732/shard-tglb6/igt@gem_eio@unwedge-stress.html
* igt@gem_exec_capture@pi@rcs0:
- shard-skl: [PASS][16] -> [INCOMPLETE][17] ([i915#4547])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11416/shard-skl2/igt@gem_exec_capture@pi@rcs0.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22732/shard-skl8/igt@gem_exec_capture@pi@rcs0.html
* igt@gem_exec_fair@basic-none-rrul@rcs0:
- shard-kbl: [PASS][18] -> [FAIL][19] ([i915#2842])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11416/shard-kbl3/igt@gem_exec_fair@basic-none-rrul@rcs0.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22732/shard-kbl1/igt@gem_exec_fair@basic-none-rrul@rcs0.html
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-tglb: [PASS][20] -> [FAIL][21] ([i915#2842])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11416/shard-tglb6/igt@gem_exec_fair@basic-pace-share@rcs0.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22732/shard-tglb1/igt@gem_exec_fair@basic-pace-share@rcs0.html
* igt@gem_exec_fair@basic-pace-solo@rcs0:
- shard-iclb: [PASS][22] -> [FAIL][23] ([i915#2842])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11416/shard-iclb7/igt@gem_exec_fair@basic-pace-solo@rcs0.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22732/shard-iclb6/igt@gem_exec_fair@basic-pace-solo@rcs0.html
- shard-glk: [PASS][24] -> [FAIL][25] ([i915#2842])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11416/shard-glk8/igt@gem_exec_fair@basic-pace-solo@rcs0.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22732/shard-glk9/igt@gem_exec_fair@basic-pace-solo@rcs0.html
- shard-apl: NOTRUN -> [FAIL][26] ([i915#2842])
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22732/shard-apl1/igt@gem_exec_fair@basic-pace-solo@rcs0.html
* igt@gem_exec_schedule@submit-early-slice@vcs0:
- shard-skl: NOTRUN -> [INCOMPLETE][27] ([i915#3797])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22732/shard-skl1/igt@gem_exec_schedule@submit-early-slice@vcs0.html
* igt@gem_lmem_swapping@heavy-random:
- shard-iclb: NOTRUN -> [SKIP][28] ([i915#4613])
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22732/shard-iclb7/igt@gem_lmem_swapping@heavy-random.html
* igt@gem_lmem_swapping@parallel-random:
- shard-tglb: NOTRUN -> [SKIP][29] ([i915#4613])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22732/shard-tglb6/igt@gem_lmem_swapping@parallel-random.html
* igt@gem_lmem_swapping@smem-oom:
- shard-apl: NOTRUN -> [SKIP][30] ([fdo#109271] / [i915#4613])
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22732/shard-apl6/igt@gem_lmem_swapping@smem-oom.html
- shard-skl: NOTRUN -> [SKIP][31] ([fdo#109271] / [i915#4613])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22732/shard-skl1/igt@gem_lmem_swapping@smem-oom.html
* igt@gem_pread@exhaustion:
- shard-snb: NOTRUN -> [WARN][32] ([i915#2658])
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22732/shard-snb4/igt@gem_pread@exhaustion.html
* igt@gem_pxp@reject-modify-context-protection-off-2:
- shard-iclb: NOTRUN -> [SKIP][33] ([i915#4270])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22732/shard-iclb5/igt@gem_pxp@reject-modify-context-protection-off-2.html
* igt@gem_pxp@verify-pxp-stale-buf-optout-execution:
- shard-tglb: NOTRUN -> [SKIP][34] ([i915#4270])
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22732/shard-tglb6/igt@gem_pxp@verify-pxp-stale-buf-optout-execution.html
* igt@gem_render_copy@linear-to-vebox-y-tiled:
- shard-iclb: NOTRUN -> [SKIP][35] ([i915#768]) +1 similar issue
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22732/shard-iclb5/igt@gem_render_copy@linear-to-vebox-y-tiled.html
* igt@gem_userptr_blits@create-destroy-unsync:
- shard-iclb: NOTRUN -> [SKIP][36] ([i915#3297])
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22732/shard-iclb7/igt@gem_userptr_blits@create-destroy-unsync.html
* igt@gem_userptr_blits@dmabuf-sync:
- shard-skl: NOTRUN -> [SKIP][37] ([fdo#109271] / [i915#3323])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22732/shard-skl3/igt@gem_userptr_blits@dmabuf-sync.html
* igt@gen7_exec_parse@basic-allocation:
- shard-iclb: NOTRUN -> [SKIP][38] ([fdo#109289])
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22732/shard-iclb7/igt@gen7_exec_parse@basic-allocation.html
* igt@gen7_exec_parse@basic-allowed:
- shard-tglb: NOTRUN -> [SKIP][39] ([fdo#109289]) +1 similar issue
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22732/shard-tglb6/igt@gen7_exec_parse@basic-allowed.html
* igt@gen9_exec_parse@basic-rejected-ctx-param:
- shard-iclb: NOTRUN -> [SKIP][40] ([i915#2856])
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22732/shard-iclb5/igt@gen9_exec_parse@basic-rejected-ctx-param.html
* igt@gen9_exec_parse@cmd-crossing-page:
- shard-tglb: NOTRUN -> [SKIP][41] ([i915#2527] / [i915#2856])
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22732/shard-tglb6/igt@gen9_exec_parse@cmd-crossing-page.html
* igt@i915_pm_dc@dc6-dpms:
- shard-iclb: [PASS][42] -> [FAIL][43] ([i915#454])
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11416/shard-iclb8/igt@i915_pm_dc@dc6-dpms.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22732/shard-iclb3/igt@i915_pm_dc@dc6-dpms.html
* igt@i915_pm_rpm@dpms-non-lpsp:
- shard-iclb: NOTRUN -> [SKIP][44] ([fdo#110892])
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22732/shard-iclb7/igt@i915_pm_rpm@dpms-non-lpsp.html
* igt@i915_selftest@live@gt_lrc:
- shard-tglb: NOTRUN -> [DMESG-FAIL][45] ([i915#2373])
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22732/shard-tglb6/igt@i915_selftest@live@gt_lrc.html
* igt@i915_selftest@live@gt_pm:
- shard-tglb: NOTRUN -> [DMESG-FAIL][46] ([i915#1759])
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22732/shard-tglb6/igt@i915_selftest@live@gt_pm.html
* igt@kms_async_flips@crc:
- shard-skl: NOTRUN -> [FAIL][47] ([i915#4272])
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22732/shard-skl4/igt@kms_async_flips@crc.html
* igt@kms_atomic_transition@plane-all-modeset-transition:
- shard-iclb: NOTRUN -> [SKIP][48] ([i915#1769])
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22732/shard-iclb7/igt@kms_atomic_transition@plane-all-modeset-transition.html
* igt@kms_big_fb@4-tiled-8bpp-rotate-180:
- shard-tglb: NOTRUN -> [SKIP][49] ([i915#5286])
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22732/shard-tglb6/igt@kms_big_fb@4-tiled-8bpp-rotate-180.html
* igt@kms_big_fb@4-tiled-addfb-size-offset-overflow:
- shard-iclb: NOTRUN -> [SKIP][50] ([i915#5286])
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22732/shard-iclb7/igt@kms_big_fb@4-tiled-addfb-size-offset-overflow.html
* igt@kms_big_fb@linear-32bpp-rotate-270:
- shard-tglb: NOTRUN -> [SKIP][51] ([fdo#111614])
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22732/shard-tglb6/igt@kms_big_fb@linear-32bpp-rotate-270.html
* igt@kms_big_fb@linear-8bpp-rotate-270:
- shard-iclb: NOTRUN -> [SKIP][52] ([fdo#110725] / [fdo#111614])
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22732/shard-iclb5/igt@kms_big_fb@linear-8bpp-rotate-270.html
* igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-0-async-flip:
- shard-skl: NOTRUN -> [FAIL][53] ([i915#3743]) +1 similar issue
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22732/shard-skl4/igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-0-async-flip.html
* igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-180-hflip-async-flip:
- shard-apl: NOTRUN -> [SKIP][54] ([fdo#109271] / [i915#3777])
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22732/shard-apl6/igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-180-hflip-async-flip.html
* igt@kms_big_fb@yf-tiled-addfb-size-offset-overflow:
- shard-tglb: NOTRUN -> [SKIP][55] ([fdo#111615])
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22732/shard-tglb6/igt@kms_big_fb@yf-tiled-addfb-size-offset-overflow.html
* igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-0-hflip-async-flip:
- shard-skl: NOTRUN -> [SKIP][56] ([fdo#109271] / [i915#3777]) +4 similar issues
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22732/shard-skl6/igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-0-hflip-async-flip.html
* igt@kms_ccs@pipe-a-ccs-on-another-bo-y_tiled_gen12_rc_ccs:
- shard-iclb: NOTRUN -> [SKIP][57] ([fdo#109278]) +13 similar issues
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22732/shard-iclb5/igt@kms_ccs@pipe-a-ccs-on-another-bo-y_tiled_gen12_rc_ccs.html
* igt@kms_ccs@pipe-a-crc-sprite-planes-basic-y_tiled_gen12_mc_ccs:
- shard-tglb: NOTRUN -> [SKIP][58] ([i915#3689] / [i915#3886])
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22732/shard-tglb6/igt@kms_ccs@pipe-a-crc-sprite-planes-basic-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-b-bad-aux-stride-y_tiled_gen12_mc_ccs:
- shard-skl: NOTRUN -> [SKIP][59] ([fdo#109271] / [i915#3886]) +7 similar issues
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22732/shard-skl6/igt@kms_ccs@pipe-b-bad-aux-stride-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-b-bad-rotation-90-yf_tiled_ccs:
- shard-tglb: NOTRUN -> [SKIP][60] ([fdo#111615] / [i915#3689])
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22732/shard-tglb6/igt@kms_ccs@pipe-b-bad-rotation-90-yf_tiled_ccs.html
* igt@kms_ccs@pipe-b-ccs-on-another-bo-y_tiled_gen12_mc_ccs:
- shard-iclb: NOTRUN -> [SKIP][61] ([fdo#109278] / [i915#3886])
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22732/shard-iclb7/igt@kms_ccs@pipe-b-ccs-on-another-bo-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-c-random-ccs-data-y_tiled_gen12_mc_ccs:
- shard-apl: NOTRUN -> [SKIP][62] ([fdo#109271] / [i915#3886])
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22732/shard-apl3/igt@kms_ccs@pipe-c-random-ccs-data-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-d-bad-aux-stride-y_tiled_ccs:
- shard-tglb: NOTRUN -> [SKIP][63] ([i915#3689]) +1 similar issue
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22732/shard-tglb6/igt@kms_ccs@pipe-d-bad-aux-stride-y_tiled_ccs.html
* igt@kms_chamelium@hdmi-hpd-storm-disable:
- shard-skl: NOTRUN -> [SKIP][64] ([fdo#109271] / [fdo#111827]) +17 similar issues
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22732/shard-skl3/igt@kms_chamelium@hdmi-hpd-storm-disable.html
* igt@kms_color@pipe-d-ctm-0-5:
- shard-skl: NOTRUN -> [SKIP][65] ([fdo#109271]) +212 similar issues
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22732/shard-skl3/igt@kms_color@pipe-d-ctm-0-5.html
* igt@kms_color_chamelium@pipe-c-ctm-0-25:
- shard-tglb: NOTRUN -> [SKIP][66] ([fdo#109284] / [fdo#111827]) +3 similar issues
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22732/shard-tglb6/igt@kms_color_chamelium@pipe-c-ctm-0-25.html
* igt@kms_color_chamelium@pipe-c-ctm-max:
- shard-iclb: NOTRUN -> [SKIP][67] ([fdo#109284] / [fdo#111827]) +1 similar issue
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22732/shard-iclb7/igt@kms_color_chamelium@pipe-c-ctm-max.html
* igt@kms_color_chamelium@pipe-d-ctm-limited-range:
- shard-apl: NOTRUN -> [SKIP][68] ([fdo#109271] / [fdo#111827]) +3 similar issues
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22732/shard-apl6/igt@kms_color_chamelium@pipe-d-ctm-limited-range.html
* igt@kms_color_chamelium@pipe-d-ctm-negative:
- shard-iclb: NOTRUN -> [SKIP][69] ([fdo#109278] / [fdo#109284] / [fdo#111827]) +1 similar issue
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22732/shard-iclb5/igt@kms_color_chamelium@pipe-d-ctm-negative.html
* igt@kms_content_protection@dp-mst-lic-type-1:
- shard-tglb: NOTRUN -> [SKIP][70] ([i915#3116] / [i915#3299])
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22732/shard-tglb6/igt@kms_content_protection@dp-mst-lic-type-1.html
* igt@kms_content_protection@mei_interface:
- shard-iclb: NOTRUN -> [SKIP][71] ([fdo#109300] / [fdo#111066])
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22732/shard-iclb7/igt@kms_content_protection@mei_interface.html
* igt@kms_cursor_crc@pipe-b-cursor-32x10-sliding:
- shard-tglb: NOTRUN -> [SKIP][72] ([i915#3359]) +1 similar issue
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22732/shard-tglb6/igt@kms_cursor_crc@pipe-b-cursor-32x10-sliding.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-varying-size:
- shard-tglb: NOTRUN -> [SKIP][73] ([i915#4103])
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22732/shard-tglb6/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-varying-size.html
* igt@kms_draw_crc@draw-method-rgb565-render-4tiled:
- shard-iclb: NOTRUN -> [SKIP][74] ([i915#5287])
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22732/shard-iclb7/igt@kms_draw_crc@draw-method-rgb565-render-4tiled.html
* igt@kms_draw_crc@draw-method-xrgb2101010-mmap-wc-4tiled:
- shard-tglb: NOTRUN -> [SKIP][75] ([i915#5287])
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22732/shard-tglb6/igt@kms_draw_crc@draw-method-xrgb2101010-mmap-wc-4tiled.html
* igt@kms_flip@2x-dpms-vs-vblank-race-interruptible:
- shard-tglb: NOTRUN -> [SKIP][76] ([fdo#109274] / [fdo#111825]) +2 similar issues
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22732/shard-tglb6/igt@kms_flip@2x-dpms-vs-vblank-race-interruptible.html
* igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@ab-hdmi-a1-hdmi-a2:
- shard-glk: [PASS][77] -> [FAIL][78] ([i915#2122])
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11416/shard-glk2/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@ab-hdmi-a1-hdmi-a2.html
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22732/shard-glk7/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@ab-hdmi-a1-hdmi-a2.html
* igt@kms_flip@2x-flip-vs-wf_vblank:
- shard-iclb: NOTRUN -> [SKIP][79] ([fdo#109274]) +2 similar issues
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22732/shard-iclb7/igt@kms_flip@2x-flip-vs-wf_vblank.html
* igt@kms_flip@flip-vs-expired-vblank@c-hdmi-a1:
- shard-glk: [PASS][80] -> [FAIL][81] ([i915#79]) +1 similar issue
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11416/shard-glk8/igt@kms_flip@flip-vs-expired-vblank@c-hdmi-a1.html
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22732/shard-glk9/igt@kms_flip@flip-vs-expired-vblank@c-hdmi-a1.html
* igt@kms_flip@flip-vs-fences-interruptible@b-vga1:
- shard-snb: [PASS][82] -> [INCOMPLETE][83] ([i915#5204])
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11416/shard-snb2/igt@kms_flip@flip-vs-fences-interruptible@b-vga1.html
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22732/shard-snb5/igt@kms_flip@flip-vs-fences-interruptible@b-vga1.html
* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-spr-indfb-onoff:
- shard-iclb: NOTRUN -> [SKIP][84] ([fdo#109280]) +6 similar issues
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22732/shard-iclb7/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-spr-indfb-onoff.html
* igt@kms_frontbuffer_tracking@fbc-suspend:
- shard-kbl: [PASS][85] -> [DMESG-WARN][86] ([i915#180]) +3 similar issues
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11416/shard-kbl1/igt@kms_frontbuffer_tracking@fbc-suspend.html
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22732/shard-kbl1/igt@kms_frontbuffer_tracking@fbc-suspend.html
* igt@kms_frontbuffer_tracking@psr-2p-primscrn-cur-indfb-draw-mmap-cpu:
- shard-tglb: NOTRUN -> [SKIP][87] ([fdo#109280] / [fdo#111825]) +6 similar issues
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22732/shard-tglb6/igt@kms_frontbuffer_tracking@psr-2p-primscrn-cur-indfb-draw-mmap-cpu.html
* igt@kms_pipe_crc_basic@hang-read-crc-pipe-d:
- shard-skl: NOTRUN -> [SKIP][88] ([fdo#109271] / [i915#533]) +2 similar issues
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22732/shard-skl1/igt@kms_pipe_crc_basic@hang-read-crc-pipe-d.html
- shard-apl: NOTRUN -> [SKIP][89] ([fdo#109271] / [i915#533])
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22732/shard-apl6/igt@kms_pipe_crc_basic@hang-read-crc-pipe-d.html
* igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min:
- shard-skl: NOTRUN -> [FAIL][90] ([fdo#108145] / [i915#265]) +1 similar issue
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22732/shard-skl3/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min.html
* igt@kms_plane_alpha_blend@pipe-b-alpha-transparent-fb:
- shard-skl: NOTRUN -> [FAIL][91] ([i915#265])
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22732/shard-skl4/igt@kms_plane_alpha_blend@pipe-b-alpha-transparent-fb.html
* igt@kms_plane_alpha_blend@pipe-b-coverage-7efc:
- shard-skl: [PASS][92] -> [FAIL][93] ([fdo#108145] / [i915#265])
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11416/shard-skl6/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22732/shard-skl2/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html
* igt@kms_plane_cursor@pipe-d-overlay-size-64:
- shard-apl: NOTRUN -> [SKIP][94] ([fdo#109271]) +61 similar issues
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22732/shard-apl1/igt@kms_plane_cursor@pipe-d-overlay-size-64.html
* igt@kms_plane_lowres@pipe-a-tiling-4:
- shard-tglb: NOTRUN -> [SKIP][95] ([i915#5288])
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22732/shard-tglb6/igt@kms_plane_lowres@pipe-a-tiling-4.html
* igt@kms_plane_lowres@pipe-b-tiling-y:
- shard-iclb: NOTRUN -> [SKIP][96] ([i915#3536])
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22732/shard-iclb5/igt@kms_plane_lowres@pipe-b-tiling-y.html
* igt@kms_psr2_sf@plane-move-sf-dmg-area:
- shard-skl: NOTRUN -> [SKIP][97] ([fdo#109271] / [i915#658])
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22732/shard-skl3/igt@kms_psr2_sf@plane-move-sf-dmg-area.html
* igt@kms_psr2_su@frontbuffer-xrgb8888:
- shard-iclb: NOTRUN -> [SKIP][98] ([fdo#109642] / [fdo#111068] / [i915#658])
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22732/shard-iclb5/igt@kms_psr2_su@frontbuffer-xrgb8888.html
* igt@kms_psr@psr2_cursor_plane_move:
- shard-iclb: NOTRUN -> [SKIP][99] ([fdo#109441])
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22732/shard-iclb7/igt@kms_psr@psr2_cursor_plane_move.html
* igt@kms_psr@psr2_primary_mmap_gtt:
- shard-tglb: NOTRUN -> [FAIL][100] ([i915#132] / [i915#3467])
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22732/shard-tglb6/igt@kms_psr@psr2_primary_mmap_gtt.html
* igt@kms_psr@psr2_sprite_render:
- shard-iclb: [PASS][101] -> [SKIP][102] ([fdo#109441]) +1 similar issue
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11416/shard-iclb2/igt@kms_psr@psr2_sprite_render.html
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22732/shard-iclb1/igt@kms_psr@psr2_sprite_render.html
* igt@kms_rotation_crc@primary-y-tiled-reflect-x-0:
- shard-snb: NOTRUN -> [SKIP][103] ([fdo#109271]) +76 similar issues
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22732/shard-snb4/igt@kms_rotation_crc@primary-y-tiled-reflect-x-0.html
* igt@kms_writeback@writeback-pixel-formats:
- shard-tglb: NOTRUN -> [SKIP][104] ([i915#2437])
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22732/shard-tglb6/igt@kms_writeback@writeback-pixel-formats.html
* igt@nouveau_crc@pipe-a-ctx-flip-detection:
- shard-iclb: NOTRUN -> [SKIP][105] ([i915#2530]) +1 similar issue
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22732/shard-iclb7/igt@nouveau_crc@pipe-a-ctx-flip-detection.html
* igt@nouveau_crc@pipe-d-source-outp-complete:
- shard-iclb: NOTRUN -> [SKIP][106] ([fdo#109278] / [i915#2530])
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22732/shard-iclb7/igt@nouveau_crc@pipe-d-source-outp-complete.html
* igt@perf@polling-parameterized:
- shard-skl: [PASS][107] -> [FAIL][108] ([i915#1542])
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11416/shard-skl9/igt@perf@polling-parameterized.html
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22732/shard-skl6/igt@perf@polling-parameterized.html
* igt@prime_nv_api@i915_nv_import_twice:
- shard-iclb: NOTRUN -> [SKIP][109] ([fdo#109291])
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22732/shard-iclb5/igt@prime_nv_api@i915_nv_import_twice.html
* igt@prime_nv_pcopy@test3_2:
- shard-tglb: NOTRUN -> [SKIP][110] ([fdo#109291])
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22732/shard-tglb6/igt@prime_nv_pcopy@test3_2.html
* igt@syncobj_timeline@wait-all-for-submit-snapshot:
- shard-skl: [PASS][111] -> [FAIL][112] ([i915#5196])
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11416/shard-skl7/igt@syncobj_timeline@wait-all-for-submit-snapshot.html
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22732/shard-skl7/igt@syncobj_timeline@wait-all-for-submit-snapshot.html
* igt@sysfs_clients@fair-7:
- shard-iclb: NOTRUN -> [SKIP][113] ([i915#2994])
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22732/shard-iclb5/igt@sysfs_clients@fair-7.html
* igt@sysfs_clients@sema-10:
- shard-skl: NOTRUN -> [SKIP][114] ([fdo#109271] / [i915#2994]) +2 similar issues
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22732/shard-skl1/igt@sysfs_clients@sema-10.html
* igt@sysfs_clients@split-25:
- shard-tglb: NOTRUN -> [SKIP][115] ([i915#2994])
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22732/shard-tglb6/igt@sysfs_clients@split-25.html
* igt@tools_test@sysfs_l3_parity:
- shard-tglb: NOTRUN -> [SKIP][116] ([fdo#109307])
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22732/shard-tglb6/igt@tools_test@sysfs_l3_parity.html
#### Possible fixes ####
* igt@feature_discovery@psr2:
- shard-iclb: [SKIP][117] ([i915#658]) -> [PASS][118]
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11416/shard-iclb5/igt@feature_discovery@psr2.html
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22732/shard-iclb2/igt@feature_discovery@psr2.html
* igt@gem_caching@reads:
- shard-glk: [DMESG-WARN][119] ([i915#118]) -> [PASS][120]
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11416/shard-glk5/igt@gem_caching@reads.html
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22732/shard-glk8/igt@gem_caching@reads.html
* igt@gem_ctx_isolation@preservation-s3@vcs1:
- shard-kbl: [DMESG-WARN][121] ([i915#180]) -> [PASS][122]
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11416/shard-kbl6/igt@gem_ctx_isolation@preservation-s3@vcs1.html
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22732/shard-kbl7/igt@gem_ctx_isolation@preservation-s3@vcs1.html
* igt@gem_exec_balancer@parallel-balancer:
- shard-iclb: [SKIP][123] ([i915#4525]) -> [PASS][124]
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11416/shard-iclb5/igt@gem_exec_balancer@parallel-balancer.html
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22732/shard-iclb2/igt@gem_exec_balancer@parallel-balancer.html
* igt@gem_exec_fair@basic-deadline:
- shard-kbl: [FAIL][125] ([i915#2846]) -> [PASS][126]
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11416/shard-kbl1/igt@gem_exec_fair@basic-deadline.html
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22732/shard-kbl6/igt@gem_exec_fair@basic-deadline.html
* igt@gem_exec_fair@basic-pace-share@rcs0:
- {shard-tglu}: [FAIL][127] ([i915#2842]) -> [PASS][128]
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11416/shard-tglu-6/igt@gem_exec_fair@basic-pace-share@rcs0.html
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22732/shard-tglu-6/igt@gem_exec_fair@basic-pace-share@rcs0.html
* igt@gem_exec_fair@basic-pace@rcs0:
- shard-glk: [FAIL][129] ([i915#2842]) -> [PASS][130]
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11416/shard-glk5/igt@gem_exec_fair@basic-pace@rcs0.html
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22732/shard-glk8/igt@gem_exec_fair@basic-pace@rcs0.html
* igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-hdmi-a:
- {shard-tglu}: [FAIL][131] ([i915#3825]) -> [PASS][132]
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11416/shard-tglu-2/igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-hdmi-a.html
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22732/shard-tglu-1/igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-hdmi-a.html
* igt@i915_selftest@live@gt_pm:
- {shard-tglu}: [DMESG-FAIL][133] ([i915#3987]) -> [PASS][134]
[133]: https:/
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22732/index.html
[-- Attachment #2: Type: text/html, Size: 33827 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Intel-gfx] [PATCH 1/2] drm/i915/audio: unify audio codec enable/disable debug logging
2022-03-30 11:12 ` [Intel-gfx] [PATCH 1/2] drm/i915/audio: unify audio codec enable/disable debug logging Ville Syrjälä
@ 2022-03-30 16:37 ` Jani Nikula
0 siblings, 0 replies; 8+ messages in thread
From: Jani Nikula @ 2022-03-30 16:37 UTC (permalink / raw)
To: Ville Syrjälä; +Cc: intel-gfx
On Wed, 30 Mar 2022, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote:
> On Wed, Mar 30, 2022 at 12:41:08PM +0300, Jani Nikula wrote:
>> The audio codec enable/disable debug logging is spread around in callers
>> and the platform specific hooks. Put them all together in one place on
>> both the enable and disable paths.
>>
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>> ---
>> drivers/gpu/drm/i915/display/g4x_dp.c | 7 +---
>> drivers/gpu/drm/i915/display/g4x_hdmi.c | 3 --
>> drivers/gpu/drm/i915/display/intel_audio.c | 39 ++++++----------------
>> 3 files changed, 11 insertions(+), 38 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/display/g4x_dp.c b/drivers/gpu/drm/i915/display/g4x_dp.c
>> index 8e1338678d91..55fefc950f41 100644
>> --- a/drivers/gpu/drm/i915/display/g4x_dp.c
>> +++ b/drivers/gpu/drm/i915/display/g4x_dp.c
>> @@ -658,9 +658,7 @@ static void intel_enable_dp(struct intel_atomic_state *state,
>> {
>> struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
>> struct intel_dp *intel_dp = enc_to_intel_dp(encoder);
>> - struct intel_crtc *crtc = to_intel_crtc(pipe_config->uapi.crtc);
>> u32 dp_reg = intel_de_read(dev_priv, intel_dp->output_reg);
>> - enum pipe pipe = crtc->pipe;
>> intel_wakeref_t wakeref;
>>
>> if (drm_WARN_ON(&dev_priv->drm, dp_reg & DP_PORT_EN))
>> @@ -694,11 +692,8 @@ static void intel_enable_dp(struct intel_atomic_state *state,
>> intel_dp_start_link_train(intel_dp, pipe_config);
>> intel_dp_stop_link_train(intel_dp, pipe_config);
>>
>> - if (pipe_config->has_audio) {
>> - drm_dbg(&dev_priv->drm, "Enabling DP audio on pipe %c\n",
>> - pipe_name(pipe));
>> + if (pipe_config->has_audio)
>> intel_audio_codec_enable(encoder, pipe_config, conn_state);
>> - }
>> }
>>
>> static void g4x_enable_dp(struct intel_atomic_state *state,
>> diff --git a/drivers/gpu/drm/i915/display/g4x_hdmi.c b/drivers/gpu/drm/i915/display/g4x_hdmi.c
>> index 06e00b1eaa7c..39ba5dc51f8e 100644
>> --- a/drivers/gpu/drm/i915/display/g4x_hdmi.c
>> +++ b/drivers/gpu/drm/i915/display/g4x_hdmi.c
>> @@ -148,11 +148,8 @@ static void intel_enable_hdmi_audio(struct intel_encoder *encoder,
>> const struct drm_connector_state *conn_state)
>> {
>> struct drm_i915_private *i915 = to_i915(encoder->base.dev);
>> - struct intel_crtc *crtc = to_intel_crtc(pipe_config->uapi.crtc);
>>
>> drm_WARN_ON(&i915->drm, !pipe_config->has_hdmi_sink);
>> - drm_dbg_kms(&i915->drm, "Enabling HDMI audio on pipe %c\n",
>> - pipe_name(crtc->pipe));
>> intel_audio_codec_enable(encoder, pipe_config, conn_state);
>> }
>>
>> diff --git a/drivers/gpu/drm/i915/display/intel_audio.c b/drivers/gpu/drm/i915/display/intel_audio.c
>> index 3bdca0fe2cee..24d20817a5e5 100644
>> --- a/drivers/gpu/drm/i915/display/intel_audio.c
>> +++ b/drivers/gpu/drm/i915/display/intel_audio.c
>> @@ -337,8 +337,6 @@ static void g4x_audio_codec_disable(struct intel_encoder *encoder,
>> struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
>> u32 eldv, tmp;
>>
>> - drm_dbg_kms(&dev_priv->drm, "Disable audio codec\n");
>> -
>> tmp = intel_de_read(dev_priv, G4X_AUD_VID_DID);
>> if (tmp == INTEL_AUDIO_DEVBLC || tmp == INTEL_AUDIO_DEVCL)
>> eldv = G4X_ELDV_DEVCL_DEVBLC;
>> @@ -362,9 +360,6 @@ static void g4x_audio_codec_enable(struct intel_encoder *encoder,
>> u32 tmp;
>> int len, i;
>>
>> - drm_dbg_kms(&dev_priv->drm, "Enable audio codec, %u bytes ELD\n",
>> - drm_eld_size(eld));
>> -
>> tmp = intel_de_read(dev_priv, G4X_AUD_VID_DID);
>> if (tmp == INTEL_AUDIO_DEVBLC || tmp == INTEL_AUDIO_DEVCL)
>> eldv = G4X_ELDV_DEVCL_DEVBLC;
>> @@ -383,7 +378,6 @@ static void g4x_audio_codec_enable(struct intel_encoder *encoder,
>> intel_de_write(dev_priv, G4X_AUD_CNTL_ST, tmp);
>>
>> len = min(drm_eld_size(eld) / 4, len);
>> - drm_dbg(&dev_priv->drm, "ELD size %d\n", len);
>> for (i = 0; i < len; i++)
>> intel_de_write(dev_priv, G4X_HDMIW_HDMIEDID,
>> *((const u32 *)eld + i));
>> @@ -501,9 +495,6 @@ static void hsw_audio_codec_disable(struct intel_encoder *encoder,
>> enum transcoder cpu_transcoder = old_crtc_state->cpu_transcoder;
>> u32 tmp;
>>
>> - drm_dbg_kms(&dev_priv->drm, "Disable audio codec on transcoder %s\n",
>> - transcoder_name(cpu_transcoder));
>> -
>> mutex_lock(&dev_priv->audio.mutex);
>>
>> /* Disable timestamps */
>> @@ -647,10 +638,6 @@ static void hsw_audio_codec_enable(struct intel_encoder *encoder,
>> u32 tmp;
>> int len, i;
>>
>> - drm_dbg_kms(&dev_priv->drm,
>> - "Enable audio codec on transcoder %s, %u bytes ELD\n",
>> - transcoder_name(cpu_transcoder), drm_eld_size(eld));
>> -
>> mutex_lock(&dev_priv->audio.mutex);
>>
>> /* Enable Audio WA for 4k DSC usecases */
>> @@ -703,11 +690,6 @@ static void ilk_audio_codec_disable(struct intel_encoder *encoder,
>> u32 tmp, eldv;
>> i915_reg_t aud_config, aud_cntrl_st2;
>>
>> - drm_dbg_kms(&dev_priv->drm,
>> - "Disable audio codec on [ENCODER:%d:%s], pipe %c\n",
>> - encoder->base.base.id, encoder->base.name,
>> - pipe_name(pipe));
>> -
>> if (drm_WARN_ON(&dev_priv->drm, port == PORT_A))
>> return;
>>
>> @@ -754,11 +736,6 @@ static void ilk_audio_codec_enable(struct intel_encoder *encoder,
>> int len, i;
>> i915_reg_t hdmiw_hdmiedid, aud_config, aud_cntl_st, aud_cntrl_st2;
>>
>> - drm_dbg_kms(&dev_priv->drm,
>> - "Enable audio codec on [ENCODER:%d:%s], pipe %c, %u bytes ELD\n",
>> - encoder->base.base.id, encoder->base.name,
>> - pipe_name(pipe), drm_eld_size(eld));
>> -
>> if (drm_WARN_ON(&dev_priv->drm, port == PORT_A))
>> return;
>>
>> @@ -844,18 +821,17 @@ void intel_audio_codec_enable(struct intel_encoder *encoder,
>> enum port port = encoder->port;
>> enum pipe pipe = crtc->pipe;
>>
>> + drm_dbg_kms(&dev_priv->drm, "[CONNECTOR:%d:%s][ENCODER:%d:%s] Enable audio codec on pipe %c, %u bytes ELD\n",
>> + connector->base.id, connector->name,
>> + encoder->base.base.id, encoder->base.name,
>> + pipe, drm_eld_size(connector->eld));
>
> Could also use the [CRTC:%d:%s] format for the pipe.
>
> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Pushed to din, left the nitpicks for another time, thanks,
BR,
Jani.
>
>> +
>> /* FIXME precompute the ELD in .compute_config() */
>> if (!connector->eld[0])
>> drm_dbg_kms(&dev_priv->drm,
>> "Bogus ELD on [CONNECTOR:%d:%s]\n",
>> connector->base.id, connector->name);
>>
>> - drm_dbg(&dev_priv->drm, "ELD on [CONNECTOR:%d:%s], [ENCODER:%d:%s]\n",
>> - connector->base.id,
>> - connector->name,
>> - encoder->base.base.id,
>> - encoder->base.name);
>> -
>> connector->eld[6] = drm_av_sync_delay(connector, adjusted_mode) / 2;
>>
>> if (dev_priv->audio.funcs)
>> @@ -900,9 +876,14 @@ void intel_audio_codec_disable(struct intel_encoder *encoder,
>> struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
>> struct i915_audio_component *acomp = dev_priv->audio.component;
>> struct intel_crtc *crtc = to_intel_crtc(old_crtc_state->uapi.crtc);
>> + struct drm_connector *connector = old_conn_state->connector;
>> enum port port = encoder->port;
>> enum pipe pipe = crtc->pipe;
>>
>> + drm_dbg_kms(&dev_priv->drm, "[CONNECTOR:%d:%s][ENCODER:%d:%s] Disable audio codec on pipe %c\n",
>> + connector->base.id, connector->name,
>> + encoder->base.base.id, encoder->base.name, pipe);
>> +
>> if (dev_priv->audio.funcs)
>> dev_priv->audio.funcs->audio_codec_disable(encoder,
>> old_crtc_state,
>> --
>> 2.30.2
--
Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2022-03-30 16:37 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-30 9:41 [Intel-gfx] [PATCH 1/2] drm/i915/audio: unify audio codec enable/disable debug logging Jani Nikula
2022-03-30 9:41 ` [Intel-gfx] [PATCH 2/2] drm/i915/audio: move has_audio checks to within codec enable/disable Jani Nikula
2022-03-30 11:15 ` Ville Syrjälä
2022-03-30 11:12 ` [Intel-gfx] [PATCH 1/2] drm/i915/audio: unify audio codec enable/disable debug logging Ville Syrjälä
2022-03-30 16:37 ` Jani Nikula
2022-03-30 11:51 ` [Intel-gfx] ✗ Fi.CI.DOCS: warning for series starting with [1/2] " Patchwork
2022-03-30 12:27 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-03-30 15:22 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.