All of lore.kernel.org
 help / color / mirror / Atom feed
* [igt-dev] [PATCH i-g-t] Add dynamic subtests
@ 2022-03-31  6:24 Nidhi Gupta
  2022-03-31  6:38 ` [igt-dev] ✗ GitLab.Pipeline: warning for " Patchwork
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Nidhi Gupta @ 2022-03-31  6:24 UTC (permalink / raw)
  To: igt-dev; +Cc: Nidhi Gupta

Modified kms_sequence and kms_concurrent to include
dynamic subtests.

Signed-off-by: Nidhi Gupta <nidhi1.gupta@intel.com>
---
 tests/kms_concurrent.c | 6 ++++--
 tests/kms_sequence.c   | 6 ++++--
 2 files changed, 8 insertions(+), 4 deletions(-)

diff --git a/tests/kms_concurrent.c b/tests/kms_concurrent.c
index dc1e36f2..5536a369 100644
--- a/tests/kms_concurrent.c
+++ b/tests/kms_concurrent.c
@@ -339,9 +339,11 @@ run_tests_for_pipe(data_t *data, enum pipe pipe)
 
 	igt_describe("Test atomic mode setting concurrently with multiple planes and screen "
 		     "resolution.");
-	igt_subtest_f("pipe-%s", kmstest_pipe_name(pipe))
+	igt_subtest_with_dynamic_f("pipe-%s", kmstest_pipe_name(pipe)) {
 		for_each_valid_output_on_pipe(&data->display, pipe, output)
-			run_test(data, pipe, output);
+			igt_dynamic_f("%s", igt_output_name(output))
+				run_test(data, pipe, output);
+	}
 }
 
 static int opt_handler(int option, int option_index, void *input)
diff --git a/tests/kms_sequence.c b/tests/kms_sequence.c
index 9c287480..d33669a7 100644
--- a/tests/kms_sequence.c
+++ b/tests/kms_sequence.c
@@ -278,6 +278,7 @@ igt_main
 		fd = drm_open_driver_master(DRIVER_ANY);
 		kmstest_set_vt_graphics_mode();
 		igt_display_require(&data.display, fd);
+		igt_display_require_output(&data.display);
 	}
 
 	for (f = funcs; f->name; f++) {
@@ -287,9 +288,10 @@ igt_main
 
 			igt_describe("This is a test of drmCrtcGetSequence and "
 				     "drmCrtcQueueSequence");
-			igt_subtest_f("%s-%s", f->name, m->name) {
+			igt_subtest_with_dynamic_f("%s-%s", f->name, m->name) {
 				data.flags = m->flags;
-				run_test(&data, fd, f->func);
+				igt_dynamic_f("%s", igt_output_name(data.output))
+					run_test(&data, fd, f->func);
 			}
 		}
 	}
-- 
2.25.1

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [igt-dev] ✗ GitLab.Pipeline: warning for Add dynamic subtests
  2022-03-31  6:24 [igt-dev] [PATCH i-g-t] Add dynamic subtests Nidhi Gupta
@ 2022-03-31  6:38 ` Patchwork
  2022-03-31  7:08 ` [igt-dev] ✗ Fi.CI.BAT: failure " Patchwork
  2022-04-06  3:08 ` [igt-dev] [PATCH i-g-t] " Modem, Bhanuprakash
  2 siblings, 0 replies; 4+ messages in thread
From: Patchwork @ 2022-03-31  6:38 UTC (permalink / raw)
  To: Nidhi Gupta; +Cc: igt-dev

== Series Details ==

Series: Add dynamic subtests
URL   : https://patchwork.freedesktop.org/series/102000/
State : warning

== Summary ==

Pipeline status: FAILED.

see https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/pipelines/546518 for the overview.

test:ninja-test-armhf has failed (https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/jobs/20531627):
  Ok:                   22
  Expected Fail:         3
  Fail:                287
  Unexpected Pass:       0
  Skipped:               0
  Timeout:               0
  
  Full log written to /builds/gfx-ci/igt-ci-tags/build/meson-logs/testlog.txt
  section_end:1648708554:step_script
  section_start:1648708554:upload_artifacts_on_failure
  Uploading artifacts for failed job
  Uploading artifacts...
  build: found 1713 matching files and directories   
  Uploading artifacts as "archive" to coordinator... 201 Created  id=20531627 responseStatus=201 Created token=KMm2Pou_
  section_end:1648708563:upload_artifacts_on_failure
  section_start:1648708563:cleanup_file_variables
  Cleaning up project directory and file based variables
  section_end:1648708563:cleanup_file_variables
  ERROR: Job failed: exit code 1

== Logs ==

For more details see: https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/pipelines/546518

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [igt-dev] ✗ Fi.CI.BAT: failure for Add dynamic subtests
  2022-03-31  6:24 [igt-dev] [PATCH i-g-t] Add dynamic subtests Nidhi Gupta
  2022-03-31  6:38 ` [igt-dev] ✗ GitLab.Pipeline: warning for " Patchwork
@ 2022-03-31  7:08 ` Patchwork
  2022-04-06  3:08 ` [igt-dev] [PATCH i-g-t] " Modem, Bhanuprakash
  2 siblings, 0 replies; 4+ messages in thread
From: Patchwork @ 2022-03-31  7:08 UTC (permalink / raw)
  To: Nidhi Gupta; +Cc: igt-dev

[-- Attachment #1: Type: text/plain, Size: 5277 bytes --]

== Series Details ==

Series: Add dynamic subtests
URL   : https://patchwork.freedesktop.org/series/102000/
State : failure

== Summary ==

CI Bug Log - changes from IGT_6401 -> IGTPW_6848
====================================================

Summary
-------

  **FAILURE**

  Serious unknown changes coming with IGTPW_6848 absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in IGTPW_6848, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6848/index.html

Participating hosts (44 -> 41)
------------------------------

  Additional (1): bat-adlm-1 
  Missing    (4): bat-rpls-1 fi-bsw-cyan fi-bdw-samus fi-pnv-d510 

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in IGTPW_6848:

### IGT changes ###

#### Possible regressions ####

  * igt@dmabuf@all@dma_fence_chain:
    - bat-dg1-6:          [PASS][1] -> [INCOMPLETE][2]
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6401/bat-dg1-6/igt@dmabuf@all@dma_fence_chain.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6848/bat-dg1-6/igt@dmabuf@all@dma_fence_chain.html

  
#### Suppressed ####

  The following results come from untrusted machines, tests, or statuses.
  They do not affect the overall result.

  * igt@kms_addfb_basic@invalid-set-prop-any:
    - {bat-adlm-1}:       NOTRUN -> [INCOMPLETE][3]
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6848/bat-adlm-1/igt@kms_addfb_basic@invalid-set-prop-any.html

  
Known issues
------------

  Here are the changes found in IGTPW_6848 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@amdgpu/amd_basic@cs-gfx:
    - fi-hsw-4770:        NOTRUN -> [SKIP][4] ([fdo#109271] / [fdo#109315]) +17 similar issues
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6848/fi-hsw-4770/igt@amdgpu/amd_basic@cs-gfx.html

  * igt@kms_flip@basic-plain-flip@a-edp1:
    - fi-tgl-u2:          [PASS][5] -> [DMESG-WARN][6] ([i915#402])
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6401/fi-tgl-u2/igt@kms_flip@basic-plain-flip@a-edp1.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6848/fi-tgl-u2/igt@kms_flip@basic-plain-flip@a-edp1.html

  
#### Possible fixes ####

  * igt@i915_selftest@live@execlists:
    - {bat-jsl-2}:        [INCOMPLETE][7] -> [PASS][8]
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6401/bat-jsl-2/igt@i915_selftest@live@execlists.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6848/bat-jsl-2/igt@i915_selftest@live@execlists.html

  * igt@i915_selftest@live@hangcheck:
    - fi-hsw-4770:        [INCOMPLETE][9] ([i915#4785]) -> [PASS][10]
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6401/fi-hsw-4770/igt@i915_selftest@live@hangcheck.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6848/fi-hsw-4770/igt@i915_selftest@live@hangcheck.html

  * igt@i915_selftest@live@perf:
    - {bat-jsl-1}:        [INCOMPLETE][11] -> [PASS][12]
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6401/bat-jsl-1/igt@i915_selftest@live@perf.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6848/bat-jsl-1/igt@i915_selftest@live@perf.html

  * igt@kms_busy@basic@flip:
    - fi-tgl-u2:          [DMESG-WARN][13] ([i915#402]) -> [PASS][14]
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6401/fi-tgl-u2/igt@kms_busy@basic@flip.html
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6848/fi-tgl-u2/igt@kms_busy@basic@flip.html

  * igt@kms_busy@basic@modeset:
    - {bat-adlp-6}:       [DMESG-WARN][15] ([i915#3576]) -> [PASS][16]
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6401/bat-adlp-6/igt@kms_busy@basic@modeset.html
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6848/bat-adlp-6/igt@kms_busy@basic@modeset.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
  [i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436
  [i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
  [i915#3576]: https://gitlab.freedesktop.org/drm/intel/issues/3576
  [i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402
  [i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
  [i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
  [i915#4785]: https://gitlab.freedesktop.org/drm/intel/issues/4785
  [i915#5482]: https://gitlab.freedesktop.org/drm/intel/issues/5482


Build changes
-------------

  * CI: CI-20190529 -> None
  * IGT: IGT_6401 -> IGTPW_6848

  CI-20190529: 20190529
  CI_DRM_11416: 1dc2c6953e2689a0e5b7cca8450da14059d35f03 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_6848: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6848/index.html
  IGT_6401: 7ee1289c5b3d3e02ec86f59f60fe304dce550be1 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6848/index.html

[-- Attachment #2: Type: text/html, Size: 5861 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [igt-dev] [PATCH i-g-t] Add dynamic subtests
  2022-03-31  6:24 [igt-dev] [PATCH i-g-t] Add dynamic subtests Nidhi Gupta
  2022-03-31  6:38 ` [igt-dev] ✗ GitLab.Pipeline: warning for " Patchwork
  2022-03-31  7:08 ` [igt-dev] ✗ Fi.CI.BAT: failure " Patchwork
@ 2022-04-06  3:08 ` Modem, Bhanuprakash
  2 siblings, 0 replies; 4+ messages in thread
From: Modem, Bhanuprakash @ 2022-04-06  3:08 UTC (permalink / raw)
  To: Nidhi Gupta, igt-dev

On Thu-31-03-2022 11:54 am, Nidhi Gupta wrote:
> Modified kms_sequence and kms_concurrent to include
> dynamic subtests.
> 
> Signed-off-by: Nidhi Gupta <nidhi1.gupta@intel.com>
> ---
>   tests/kms_concurrent.c | 6 ++++--
>   tests/kms_sequence.c   | 6 ++++--
>   2 files changed, 8 insertions(+), 4 deletions(-)
> 
> diff --git a/tests/kms_concurrent.c b/tests/kms_concurrent.c
> index dc1e36f2..5536a369 100644
> --- a/tests/kms_concurrent.c
> +++ b/tests/kms_concurrent.c
> @@ -339,9 +339,11 @@ run_tests_for_pipe(data_t *data, enum pipe pipe)
>   
>   	igt_describe("Test atomic mode setting concurrently with multiple planes and screen "
>   		     "resolution.");
> -	igt_subtest_f("pipe-%s", kmstest_pipe_name(pipe))
> +	igt_subtest_with_dynamic_f("pipe-%s", kmstest_pipe_name(pipe)) {
>   		for_each_valid_output_on_pipe(&data->display, pipe, output)
> -			run_test(data, pipe, output);
> +			igt_dynamic_f("%s", igt_output_name(output))
> +				run_test(data, pipe, output);
> +	}
>   }
>   
>   static int opt_handler(int option, int option_index, void *input)
> diff --git a/tests/kms_sequence.c b/tests/kms_sequence.c
> index 9c287480..d33669a7 100644
> --- a/tests/kms_sequence.c
> +++ b/tests/kms_sequence.c
> @@ -278,6 +278,7 @@ igt_main
>   		fd = drm_open_driver_master(DRIVER_ANY);
>   		kmstest_set_vt_graphics_mode();
>   		igt_display_require(&data.display, fd);
> +		igt_display_require_output(&data.display);
>   	}
>   
>   	for (f = funcs; f->name; f++) {
> @@ -287,9 +288,10 @@ igt_main
>   
>   			igt_describe("This is a test of drmCrtcGetSequence and "
>   				     "drmCrtcQueueSequence");
> -			igt_subtest_f("%s-%s", f->name, m->name) {
> +			igt_subtest_with_dynamic_f("%s-%s", f->name, m->name) {
>   				data.flags = m->flags;
> -				run_test(&data, fd, f->func);
> +				igt_dynamic_f("%s", igt_output_name(data.output))

This is wrong, data.output is not initialized.

- Bhanu
> +					run_test(&data, fd, f->func);
>   			}
>   		}
>   	}

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2022-04-06  3:08 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-31  6:24 [igt-dev] [PATCH i-g-t] Add dynamic subtests Nidhi Gupta
2022-03-31  6:38 ` [igt-dev] ✗ GitLab.Pipeline: warning for " Patchwork
2022-03-31  7:08 ` [igt-dev] ✗ Fi.CI.BAT: failure " Patchwork
2022-04-06  3:08 ` [igt-dev] [PATCH i-g-t] " Modem, Bhanuprakash

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.