* [PATCH] blk-wbt: remove wbt_track stub
@ 2022-03-31 18:54 trix
2022-03-31 18:56 ` Jens Axboe
2022-03-31 18:59 ` Jens Axboe
0 siblings, 2 replies; 4+ messages in thread
From: trix @ 2022-03-31 18:54 UTC (permalink / raw)
To: axboe; +Cc: linux-block, linux-kernel, Tom Rix
From: Tom Rix <trix@redhat.com>
cppcheck returns this warning
[block/blk-wbt.h:104] -> [block/blk-wbt.c:592]:
(warning) Function 'wbt_track' argument order different:
declaration 'rq, flags, ' definition 'rqos, rq, bio'
In commit c1c80384c8f4 ("block: remove external dependency on wbt_flags")
wbt_track was removed for the real declaration, its stub should
have been as well.
Signed-off-by: Tom Rix <trix@redhat.com>
---
block/blk-wbt.h | 3 ---
1 file changed, 3 deletions(-)
diff --git a/block/blk-wbt.h b/block/blk-wbt.h
index 2eb01becde8c..7e44eccc676d 100644
--- a/block/blk-wbt.h
+++ b/block/blk-wbt.h
@@ -101,9 +101,6 @@ u64 wbt_default_latency_nsec(struct request_queue *);
#else
-static inline void wbt_track(struct request *rq, enum wbt_flags flags)
-{
-}
static inline int wbt_init(struct request_queue *q)
{
return -EINVAL;
--
2.26.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] blk-wbt: remove wbt_track stub
2022-03-31 18:54 [PATCH] blk-wbt: remove wbt_track stub trix
@ 2022-03-31 18:56 ` Jens Axboe
2022-03-31 18:59 ` Jens Axboe
2022-03-31 18:59 ` Jens Axboe
1 sibling, 1 reply; 4+ messages in thread
From: Jens Axboe @ 2022-03-31 18:56 UTC (permalink / raw)
To: trix; +Cc: linux-block, linux-kernel
On 3/31/22 12:54 PM, trix@redhat.com wrote:
Not sure how you sent this patch, but there's no body, just an
attachment. Regular tooling doesn't like that.
--
Jens Axboe
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] blk-wbt: remove wbt_track stub
2022-03-31 18:56 ` Jens Axboe
@ 2022-03-31 18:59 ` Jens Axboe
0 siblings, 0 replies; 4+ messages in thread
From: Jens Axboe @ 2022-03-31 18:59 UTC (permalink / raw)
To: trix; +Cc: linux-block, linux-kernel
On 3/31/22 12:56 PM, Jens Axboe wrote:
> On 3/31/22 12:54 PM, trix@redhat.com wrote:
>
> Not sure how you sent this patch, but there's no body, just an
> attachment. Regular tooling doesn't like that.
Actually b4 likes it just fine, it just wasn't on lore yet. But
for future patches, please do send with git send-email or similar.
I could not view the patch without first saving the attachment
and opening it separately.
--
Jens Axboe
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] blk-wbt: remove wbt_track stub
2022-03-31 18:54 [PATCH] blk-wbt: remove wbt_track stub trix
2022-03-31 18:56 ` Jens Axboe
@ 2022-03-31 18:59 ` Jens Axboe
1 sibling, 0 replies; 4+ messages in thread
From: Jens Axboe @ 2022-03-31 18:59 UTC (permalink / raw)
To: trix; +Cc: linux-kernel, linux-block
On Thu, 31 Mar 2022 11:54:58 -0700, trix@redhat.com wrote:
> From: Tom Rix <trix@redhat.com>
>
> cppcheck returns this warning
> [block/blk-wbt.h:104] -> [block/blk-wbt.c:592]:
> (warning) Function 'wbt_track' argument order different:
> declaration 'rq, flags, ' definition 'rqos, rq, bio'
>
> [...]
Applied, thanks!
[1/1] blk-wbt: remove wbt_track stub
commit: 8d7829ebc1e48208b3c02c2a10c5f8856246033c
Best regards,
--
Jens Axboe
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-03-31 18:59 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-31 18:54 [PATCH] blk-wbt: remove wbt_track stub trix
2022-03-31 18:56 ` Jens Axboe
2022-03-31 18:59 ` Jens Axboe
2022-03-31 18:59 ` Jens Axboe
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.