* [PATCH] bpf: Use swap() instead of open coding it
@ 2022-03-22 6:21 Jiapeng Chong
2022-04-01 20:40 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Jiapeng Chong @ 2022-03-22 6:21 UTC (permalink / raw)
To: rostedt
Cc: mingo, ast, daniel, andrii, kafai, songliubraving, yhs,
john.fastabend, kpsingh, davem, kuba, hawk, netdev, bpf,
linux-kernel, Jiapeng Chong, Abaci Robot
Clean the following coccicheck warning:
./kernel/trace/bpf_trace.c:2263:34-35: WARNING opportunity for swap().
./kernel/trace/bpf_trace.c:2264:40-41: WARNING opportunity for swap().
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
kernel/trace/bpf_trace.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/kernel/trace/bpf_trace.c b/kernel/trace/bpf_trace.c
index 0009104dca82..36e0f459d152 100644
--- a/kernel/trace/bpf_trace.c
+++ b/kernel/trace/bpf_trace.c
@@ -2253,15 +2253,13 @@ static void bpf_kprobe_multi_cookie_swap(void *a, void *b, int size, const void
const struct bpf_kprobe_multi_link *link = priv;
unsigned long *addr_a = a, *addr_b = b;
u64 *cookie_a, *cookie_b;
- unsigned long tmp1;
- u64 tmp2;
cookie_a = link->cookies + (addr_a - link->addrs);
cookie_b = link->cookies + (addr_b - link->addrs);
/* swap addr_a/addr_b and cookie_a/cookie_b values */
- tmp1 = *addr_a; *addr_a = *addr_b; *addr_b = tmp1;
- tmp2 = *cookie_a; *cookie_a = *cookie_b; *cookie_b = tmp2;
+ swap(*addr_a, *addr_b);
+ swap(*cookie_a, *cookie_b);
}
static int __bpf_kprobe_multi_cookie_cmp(const void *a, const void *b)
--
2.20.1.7.g153144c
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] bpf: Use swap() instead of open coding it
2022-03-22 6:21 [PATCH] bpf: Use swap() instead of open coding it Jiapeng Chong
@ 2022-04-01 20:40 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-04-01 20:40 UTC (permalink / raw)
To: Jiapeng Chong
Cc: rostedt, mingo, ast, daniel, andrii, kafai, songliubraving, yhs,
john.fastabend, kpsingh, davem, kuba, hawk, netdev, bpf,
linux-kernel, abaci
Hello:
This patch was applied to bpf/bpf-next.git (master)
by Daniel Borkmann <daniel@iogearbox.net>:
On Tue, 22 Mar 2022 14:21:49 +0800 you wrote:
> Clean the following coccicheck warning:
>
> ./kernel/trace/bpf_trace.c:2263:34-35: WARNING opportunity for swap().
> ./kernel/trace/bpf_trace.c:2264:40-41: WARNING opportunity for swap().
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
>
> [...]
Here is the summary with links:
- bpf: Use swap() instead of open coding it
https://git.kernel.org/bpf/bpf-next/c/11e17ae42377
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-04-01 20:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-22 6:21 [PATCH] bpf: Use swap() instead of open coding it Jiapeng Chong
2022-04-01 20:40 ` patchwork-bot+netdevbpf
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.