* [PATCH] sched/fair: Return true/false (not 1/0) from bool functions
@ 2022-04-06 9:14 Haowen Bai
0 siblings, 0 replies; 2+ messages in thread
From: Haowen Bai @ 2022-04-06 9:14 UTC (permalink / raw)
To: Ingo Molnar, Peter Zijlstra, Juri Lelli, Vincent Guittot,
Dietmar Eggemann, Steven Rostedt, Ben Segall, Mel Gorman,
Daniel Bristot de Oliveira
Cc: Haowen Bai, linux-kernel
Return boolean values ("true" or "false") instead of 1 or 0 from bool
functions. This fixes the following warnings from coccicheck:
kernel/sched/fair.c:9846:9-10: WARNING: return of 0/1 in function
'imbalanced_active_balance' with return type bool
Signed-off-by: Haowen Bai <baihaowen@meizu.com>
---
kernel/sched/fair.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index 265bf7a75a37..deb143916cdd 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -9843,9 +9843,9 @@ imbalanced_active_balance(struct lb_env *env)
*/
if ((env->migration_type == migrate_task) &&
(sd->nr_balance_failed > sd->cache_nice_tries+2))
- return 1;
+ return true;
- return 0;
+ return false;
}
static int need_active_balance(struct lb_env *env)
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH] sched/fair: Return true/false (not 1/0) from bool functions
@ 2022-04-29 7:52 Jiapeng Chong
0 siblings, 0 replies; 2+ messages in thread
From: Jiapeng Chong @ 2022-04-29 7:52 UTC (permalink / raw)
To: mingo
Cc: peterz, juri.lelli, vincent.guittot, dietmar.eggemann, rostedt,
bsegall, mgorman, bristot, linux-kernel, Jiapeng Chong,
Abaci Robot
Return statements in functions returning bool should use true/false
instead of 1/0.
./kernel/sched/fair.c:9850:9-10: WARNING: return of 0/1 in function
'imbalanced_active_balance' with return type bool.
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
kernel/sched/fair.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index b0cd242373ec..6f3113e26d26 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -9847,9 +9847,9 @@ imbalanced_active_balance(struct lb_env *env)
*/
if ((env->migration_type == migrate_task) &&
(sd->nr_balance_failed > sd->cache_nice_tries+2))
- return 1;
+ return true;
- return 0;
+ return false;
}
static int need_active_balance(struct lb_env *env)
--
2.20.1.7.g153144c
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-04-29 7:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-06 9:14 [PATCH] sched/fair: Return true/false (not 1/0) from bool functions Haowen Bai
2022-04-29 7:52 Jiapeng Chong
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.