* [PATCH v3 0/2] Skip phy initialization for DWC3 USB Controllers
@ 2022-04-07 9:31 Sandeep Maheswaram
2022-04-07 9:31 ` [PATCH v3 1/2] usb: host: xhci-plat: Add device property to set XHCI_SKIP_PHY_INIT quirk Sandeep Maheswaram
` (2 more replies)
0 siblings, 3 replies; 11+ messages in thread
From: Sandeep Maheswaram @ 2022-04-07 9:31 UTC (permalink / raw)
To: Greg Kroah-Hartman, Felipe Balbi, Stephen Boyd, Doug Anderson,
Matthias Kaehlcke, Mathias Nyman
Cc: linux-arm-msm, linux-usb, linux-kernel, quic_pkondeti,
quic_ppratap, quic_kriskura, quic_vpulyala, Sandeep Maheswaram
Runtime suspend of phy drivers was failing from DWC3 driver as
runtime usage value is 2 because the phy is initialized from
DWC3 core and HCD core.
Some controllers like DWC3 and CDNS3 manage phy in their core drivers.
This property can be set to avoid phy initialization in HCD core.
v3:
Coming back to this series based on discussion at below thread
https://patchwork.kernel.org/project/linux-arm-msm/patch/1648103831-12347-4-git-send-email-quic_c_sanm@quicinc.com/
Dropped the dt bindings PATCH 1/3 in v2
https://patchwork.kernel.org/project/linux-arm-msm/cover/1636353710-25582-1-git-send-email-quic_c_sanm@quicinc.com/
v2:
Updated the commit descriptions.
Changed subject prefix from dwc to dwc3.
Increased props array size.
Sandeep Maheswaram (2):
usb: host: xhci-plat: Add device property to set XHCI_SKIP_PHY_INIT
quirk
usb: dwc3: host: Set the property usb-skip-phy-init
drivers/usb/dwc3/host.c | 4 +++-
drivers/usb/host/xhci-plat.c | 3 +++
2 files changed, 6 insertions(+), 1 deletion(-)
--
2.7.4
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH v3 1/2] usb: host: xhci-plat: Add device property to set XHCI_SKIP_PHY_INIT quirk
2022-04-07 9:31 [PATCH v3 0/2] Skip phy initialization for DWC3 USB Controllers Sandeep Maheswaram
@ 2022-04-07 9:31 ` Sandeep Maheswaram
2022-04-20 15:36 ` Greg Kroah-Hartman
2022-04-07 9:31 ` [PATCH v3 2/2] usb: dwc3: host: Set the property usb-skip-phy-init Sandeep Maheswaram
2022-04-19 10:17 ` [PATCH v3 0/2] Skip phy initialization for DWC3 USB Controllers Sandeep Maheswaram (Temp) (QUIC)
2 siblings, 1 reply; 11+ messages in thread
From: Sandeep Maheswaram @ 2022-04-07 9:31 UTC (permalink / raw)
To: Greg Kroah-Hartman, Felipe Balbi, Stephen Boyd, Doug Anderson,
Matthias Kaehlcke, Mathias Nyman
Cc: linux-arm-msm, linux-usb, linux-kernel, quic_pkondeti,
quic_ppratap, quic_kriskura, quic_vpulyala, Sandeep Maheswaram
Add device property usb-skip-phy-init to check and set XHCI_SKIP_PHY_INIT
quirk.
Runtime suspend of phy drivers was failing from DWC3 driver as
runtime usage value is 2 because the phy is initialized from
DWC3 core and HCD core.
Some controllers like DWC3 and CDNS3 manage phy in their core drivers.
This property can be set to avoid phy initialization in HCD core.
Signed-off-by: Sandeep Maheswaram <quic_c_sanm@quicinc.com>
---
drivers/usb/host/xhci-plat.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci-plat.c
index 649ffd8..7624ed9 100644
--- a/drivers/usb/host/xhci-plat.c
+++ b/drivers/usb/host/xhci-plat.c
@@ -305,6 +305,9 @@ static int xhci_plat_probe(struct platform_device *pdev)
if (device_property_read_bool(tmpdev, "quirk-broken-port-ped"))
xhci->quirks |= XHCI_BROKEN_PORT_PED;
+ if (device_property_read_bool(tmpdev, "usb-skip-phy-init"))
+ xhci->quirks |= XHCI_SKIP_PHY_INIT;
+
device_property_read_u32(tmpdev, "imod-interval-ns",
&xhci->imod_interval);
}
--
2.7.4
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH v3 2/2] usb: dwc3: host: Set the property usb-skip-phy-init
2022-04-07 9:31 [PATCH v3 0/2] Skip phy initialization for DWC3 USB Controllers Sandeep Maheswaram
2022-04-07 9:31 ` [PATCH v3 1/2] usb: host: xhci-plat: Add device property to set XHCI_SKIP_PHY_INIT quirk Sandeep Maheswaram
@ 2022-04-07 9:31 ` Sandeep Maheswaram
2022-04-19 10:17 ` [PATCH v3 0/2] Skip phy initialization for DWC3 USB Controllers Sandeep Maheswaram (Temp) (QUIC)
2 siblings, 0 replies; 11+ messages in thread
From: Sandeep Maheswaram @ 2022-04-07 9:31 UTC (permalink / raw)
To: Greg Kroah-Hartman, Felipe Balbi, Stephen Boyd, Doug Anderson,
Matthias Kaehlcke, Mathias Nyman
Cc: linux-arm-msm, linux-usb, linux-kernel, quic_pkondeti,
quic_ppratap, quic_kriskura, quic_vpulyala, Sandeep Maheswaram
Runtime suspend of phy drivers was failing from DWC3 driver as
runtime usage value is 2 because the phy is initialized from
DWC3 core and HCD core.
Some controllers like DWC3 and CDNS3 manage phy in their core drivers.
This property can be set to avoid phy initialization in HCD core.
Signed-off-by: Sandeep Maheswaram <quic_c_sanm@quicinc.com>
---
drivers/usb/dwc3/host.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/dwc3/host.c b/drivers/usb/dwc3/host.c
index eda8719..fe810ff 100644
--- a/drivers/usb/dwc3/host.c
+++ b/drivers/usb/dwc3/host.c
@@ -67,7 +67,7 @@ static int dwc3_host_get_irq(struct dwc3 *dwc)
int dwc3_host_init(struct dwc3 *dwc)
{
- struct property_entry props[4];
+ struct property_entry props[5];
struct platform_device *xhci;
int ret, irq;
int prop_idx = 0;
@@ -114,6 +114,8 @@ int dwc3_host_init(struct dwc3 *dwc)
if (DWC3_VER_IS_WITHIN(DWC3, ANY, 300A))
props[prop_idx++] = PROPERTY_ENTRY_BOOL("quirk-broken-port-ped");
+ props[prop_idx++] = PROPERTY_ENTRY_BOOL("usb-skip-phy-init");
+
if (prop_idx) {
ret = device_create_managed_software_node(&xhci->dev, props, NULL);
if (ret) {
--
2.7.4
^ permalink raw reply related [flat|nested] 11+ messages in thread
* RE: [PATCH v3 0/2] Skip phy initialization for DWC3 USB Controllers
2022-04-07 9:31 [PATCH v3 0/2] Skip phy initialization for DWC3 USB Controllers Sandeep Maheswaram
2022-04-07 9:31 ` [PATCH v3 1/2] usb: host: xhci-plat: Add device property to set XHCI_SKIP_PHY_INIT quirk Sandeep Maheswaram
2022-04-07 9:31 ` [PATCH v3 2/2] usb: dwc3: host: Set the property usb-skip-phy-init Sandeep Maheswaram
@ 2022-04-19 10:17 ` Sandeep Maheswaram (Temp) (QUIC)
2022-04-20 13:20 ` Mathias Nyman
2 siblings, 1 reply; 11+ messages in thread
From: Sandeep Maheswaram (Temp) (QUIC) @ 2022-04-19 10:17 UTC (permalink / raw)
To: Sandeep Maheswaram (Temp) (QUIC),
Greg Kroah-Hartman, Felipe Balbi, Stephen Boyd, Doug Anderson,
Matthias Kaehlcke, Mathias Nyman
Cc: linux-arm-msm, linux-usb, linux-kernel,
Pavan Kumar Kondeti (QUIC), Pratham Pratap (QUIC),
Krishna Kurapati PSSNV (QUIC), Vidya Sagar Pulyala (Temp) (QUIC)
Hi Mathias, Felipe,
> -----Original Message-----
> From: Sandeep Maheswaram (Temp) (QUIC) <quic_c_sanm@quicinc.com>
> Sent: Thursday, April 7, 2022 3:01 PM
> To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>; Felipe Balbi
> <balbi@kernel.org>; Stephen Boyd <swboyd@chromium.org>; Doug
> Anderson <dianders@chromium.org>; Matthias Kaehlcke
> <mka@chromium.org>; Mathias Nyman <mathias.nyman@intel.com>
> Cc: linux-arm-msm@vger.kernel.org; linux-usb@vger.kernel.org; linux-
> kernel@vger.kernel.org; Pavan Kumar Kondeti (QUIC)
> <quic_pkondeti@quicinc.com>; Pratham Pratap (QUIC)
> <quic_ppratap@quicinc.com>; Krishna Kurapati PSSNV (QUIC)
> <quic_kriskura@quicinc.com>; Vidya Sagar Pulyala (Temp) (QUIC)
> <quic_vpulyala@quicinc.com>; Sandeep Maheswaram (Temp) (QUIC)
> <quic_c_sanm@quicinc.com>
> Subject: [PATCH v3 0/2] Skip phy initialization for DWC3 USB Controllers
>
> Runtime suspend of phy drivers was failing from DWC3 driver as runtime
> usage value is 2 because the phy is initialized from
> DWC3 core and HCD core.
> Some controllers like DWC3 and CDNS3 manage phy in their core drivers.
> This property can be set to avoid phy initialization in HCD core.
>
> v3:
> Coming back to this series based on discussion at below thread
> https://patchwork.kernel.org/project/linux-arm-msm/patch/1648103831-
> 12347-4-git-send-email-quic_c_sanm@quicinc.com/
> Dropped the dt bindings PATCH 1/3 in v2
> https://patchwork.kernel.org/project/linux-arm-msm/cover/1636353710-
> 25582-1-git-send-email-quic_c_sanm@quicinc.com/
>
> v2:
> Updated the commit descriptions.
> Changed subject prefix from dwc to dwc3.
> Increased props array size.
>
> Sandeep Maheswaram (2):
> usb: host: xhci-plat: Add device property to set XHCI_SKIP_PHY_INIT
> quirk
> usb: dwc3: host: Set the property usb-skip-phy-init
>
> drivers/usb/dwc3/host.c | 4 +++-
> drivers/usb/host/xhci-plat.c | 3 +++
> 2 files changed, 6 insertions(+), 1 deletion(-)
>
> --
> 2.7.4
Please let me know your opinion about this series.
Regards
Sandeep
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v3 0/2] Skip phy initialization for DWC3 USB Controllers
2022-04-19 10:17 ` [PATCH v3 0/2] Skip phy initialization for DWC3 USB Controllers Sandeep Maheswaram (Temp) (QUIC)
@ 2022-04-20 13:20 ` Mathias Nyman
2022-04-21 7:46 ` Heikki Krogerus
0 siblings, 1 reply; 11+ messages in thread
From: Mathias Nyman @ 2022-04-20 13:20 UTC (permalink / raw)
To: Sandeep Maheswaram (Temp) (QUIC),
Greg Kroah-Hartman, Felipe Balbi, Stephen Boyd, Doug Anderson,
Matthias Kaehlcke, Mathias Nyman, Heikki Krogerus
Cc: linux-arm-msm, linux-usb, linux-kernel,
Pavan Kumar Kondeti (QUIC), Pratham Pratap (QUIC),
Krishna Kurapati PSSNV (QUIC), Vidya Sagar Pulyala (Temp) (QUIC)
On 19.4.2022 13.17, Sandeep Maheswaram (Temp) (QUIC) wrote:
> Hi Mathias, Felipe,
>
>> -----Original Message-----
>> From: Sandeep Maheswaram (Temp) (QUIC) <quic_c_sanm@quicinc.com>
>> Sent: Thursday, April 7, 2022 3:01 PM
>> To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>; Felipe Balbi
>> <balbi@kernel.org>; Stephen Boyd <swboyd@chromium.org>; Doug
>> Anderson <dianders@chromium.org>; Matthias Kaehlcke
>> <mka@chromium.org>; Mathias Nyman <mathias.nyman@intel.com>
>> Cc: linux-arm-msm@vger.kernel.org; linux-usb@vger.kernel.org; linux-
>> kernel@vger.kernel.org; Pavan Kumar Kondeti (QUIC)
>> <quic_pkondeti@quicinc.com>; Pratham Pratap (QUIC)
>> <quic_ppratap@quicinc.com>; Krishna Kurapati PSSNV (QUIC)
>> <quic_kriskura@quicinc.com>; Vidya Sagar Pulyala (Temp) (QUIC)
>> <quic_vpulyala@quicinc.com>; Sandeep Maheswaram (Temp) (QUIC)
>> <quic_c_sanm@quicinc.com>
>> Subject: [PATCH v3 0/2] Skip phy initialization for DWC3 USB Controllers
>>
>> Runtime suspend of phy drivers was failing from DWC3 driver as runtime
>> usage value is 2 because the phy is initialized from
>> DWC3 core and HCD core.
>> Some controllers like DWC3 and CDNS3 manage phy in their core drivers.
>> This property can be set to avoid phy initialization in HCD core.
>>
>> v3:
>> Coming back to this series based on discussion at below thread
>> https://patchwork.kernel.org/project/linux-arm-msm/patch/1648103831-
>> 12347-4-git-send-email-quic_c_sanm@quicinc.com/
>> Dropped the dt bindings PATCH 1/3 in v2
>> https://patchwork.kernel.org/project/linux-arm-msm/cover/1636353710-
>> 25582-1-git-send-email-quic_c_sanm@quicinc.com/
>>
>> v2:
>> Updated the commit descriptions.
>> Changed subject prefix from dwc to dwc3.
>> Increased props array size.
>>
>> Sandeep Maheswaram (2):
>> usb: host: xhci-plat: Add device property to set XHCI_SKIP_PHY_INIT
>> quirk
>> usb: dwc3: host: Set the property usb-skip-phy-init
>>
>> drivers/usb/dwc3/host.c | 4 +++-
>> drivers/usb/host/xhci-plat.c | 3 +++
>> 2 files changed, 6 insertions(+), 1 deletion(-)
>>
>> --
>> 2.7.4
>
> Please let me know your opinion about this series.
Otherwise looks good but wondering if we should document that new device
property somewhere.
Couldn't find a standard way how those device properties excluded from
Documentation/devicetree/binding are documented
Thanks
-Mathias
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v3 1/2] usb: host: xhci-plat: Add device property to set XHCI_SKIP_PHY_INIT quirk
2022-04-07 9:31 ` [PATCH v3 1/2] usb: host: xhci-plat: Add device property to set XHCI_SKIP_PHY_INIT quirk Sandeep Maheswaram
@ 2022-04-20 15:36 ` Greg Kroah-Hartman
2022-04-21 4:11 ` Pavan Kondeti
0 siblings, 1 reply; 11+ messages in thread
From: Greg Kroah-Hartman @ 2022-04-20 15:36 UTC (permalink / raw)
To: Sandeep Maheswaram
Cc: Felipe Balbi, Stephen Boyd, Doug Anderson, Matthias Kaehlcke,
Mathias Nyman, linux-arm-msm, linux-usb, linux-kernel,
quic_pkondeti, quic_ppratap, quic_kriskura, quic_vpulyala
On Thu, Apr 07, 2022 at 03:01:27PM +0530, Sandeep Maheswaram wrote:
> Add device property usb-skip-phy-init to check and set XHCI_SKIP_PHY_INIT
> quirk.
> Runtime suspend of phy drivers was failing from DWC3 driver as
> runtime usage value is 2 because the phy is initialized from
> DWC3 core and HCD core.
> Some controllers like DWC3 and CDNS3 manage phy in their core drivers.
> This property can be set to avoid phy initialization in HCD core.
>
> Signed-off-by: Sandeep Maheswaram <quic_c_sanm@quicinc.com>
> ---
> drivers/usb/host/xhci-plat.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci-plat.c
> index 649ffd8..7624ed9 100644
> --- a/drivers/usb/host/xhci-plat.c
> +++ b/drivers/usb/host/xhci-plat.c
> @@ -305,6 +305,9 @@ static int xhci_plat_probe(struct platform_device *pdev)
> if (device_property_read_bool(tmpdev, "quirk-broken-port-ped"))
> xhci->quirks |= XHCI_BROKEN_PORT_PED;
>
> + if (device_property_read_bool(tmpdev, "usb-skip-phy-init"))
> + xhci->quirks |= XHCI_SKIP_PHY_INIT;
You forgot to document this new property. Without that, we can not
accept this :(
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v3 1/2] usb: host: xhci-plat: Add device property to set XHCI_SKIP_PHY_INIT quirk
2022-04-20 15:36 ` Greg Kroah-Hartman
@ 2022-04-21 4:11 ` Pavan Kondeti
0 siblings, 0 replies; 11+ messages in thread
From: Pavan Kondeti @ 2022-04-21 4:11 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Sandeep Maheswaram, Felipe Balbi, Stephen Boyd, Doug Anderson,
Matthias Kaehlcke, Mathias Nyman, linux-arm-msm, linux-usb,
linux-kernel, quic_pkondeti, quic_ppratap, quic_kriskura,
quic_vpulyala
+Rob Herring
On Wed, Apr 20, 2022 at 05:36:57PM +0200, Greg Kroah-Hartman wrote:
> On Thu, Apr 07, 2022 at 03:01:27PM +0530, Sandeep Maheswaram wrote:
> > Add device property usb-skip-phy-init to check and set XHCI_SKIP_PHY_INIT
> > quirk.
> > Runtime suspend of phy drivers was failing from DWC3 driver as
> > runtime usage value is 2 because the phy is initialized from
> > DWC3 core and HCD core.
> > Some controllers like DWC3 and CDNS3 manage phy in their core drivers.
> > This property can be set to avoid phy initialization in HCD core.
> >
> > Signed-off-by: Sandeep Maheswaram <quic_c_sanm@quicinc.com>
> > ---
> > drivers/usb/host/xhci-plat.c | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci-plat.c
> > index 649ffd8..7624ed9 100644
> > --- a/drivers/usb/host/xhci-plat.c
> > +++ b/drivers/usb/host/xhci-plat.c
> > @@ -305,6 +305,9 @@ static int xhci_plat_probe(struct platform_device *pdev)
> > if (device_property_read_bool(tmpdev, "quirk-broken-port-ped"))
> > xhci->quirks |= XHCI_BROKEN_PORT_PED;
> >
> > + if (device_property_read_bool(tmpdev, "usb-skip-phy-init"))
> > + xhci->quirks |= XHCI_SKIP_PHY_INIT;
>
> You forgot to document this new property. Without that, we can not
> accept this :(
>
Thanks Greg for taking a look. This series has a device tree binding doc
update but got dropped after Rob's comment here.
https://lore.kernel.org/linux-usb/YY7vAzxj9aR%2FzBSB@robh.at.kernel.org/
Sandeep,
Since, we could not come up with a way to limit this to only dwc3/cdns3
controllers, please include the device tree binding doc and re-send the
series.
https://lore.kernel.org/linux-usb/f578947c-fb10-11b7-abe8-28b6b3f6bb0c@linux.intel.com/#t
has all the different options we dicussed and why we went with a dT param
for this.
Thanks,
Pavan
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v3 0/2] Skip phy initialization for DWC3 USB Controllers
2022-04-20 13:20 ` Mathias Nyman
@ 2022-04-21 7:46 ` Heikki Krogerus
2022-04-21 8:36 ` Greg Kroah-Hartman
0 siblings, 1 reply; 11+ messages in thread
From: Heikki Krogerus @ 2022-04-21 7:46 UTC (permalink / raw)
To: Mathias Nyman
Cc: Sandeep Maheswaram (Temp) (QUIC),
Greg Kroah-Hartman, Felipe Balbi, Stephen Boyd, Doug Anderson,
Matthias Kaehlcke, Mathias Nyman, linux-arm-msm, linux-usb,
linux-kernel, Pavan Kumar Kondeti (QUIC), Pratham Pratap (QUIC),
Krishna Kurapati PSSNV (QUIC), Vidya Sagar Pulyala (Temp) (QUIC)
On Wed, Apr 20, 2022 at 04:20:52PM +0300, Mathias Nyman wrote:
> On 19.4.2022 13.17, Sandeep Maheswaram (Temp) (QUIC) wrote:
> > Hi Mathias, Felipe,
> >
> >> -----Original Message-----
> >> From: Sandeep Maheswaram (Temp) (QUIC) <quic_c_sanm@quicinc.com>
> >> Sent: Thursday, April 7, 2022 3:01 PM
> >> To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>; Felipe Balbi
> >> <balbi@kernel.org>; Stephen Boyd <swboyd@chromium.org>; Doug
> >> Anderson <dianders@chromium.org>; Matthias Kaehlcke
> >> <mka@chromium.org>; Mathias Nyman <mathias.nyman@intel.com>
> >> Cc: linux-arm-msm@vger.kernel.org; linux-usb@vger.kernel.org; linux-
> >> kernel@vger.kernel.org; Pavan Kumar Kondeti (QUIC)
> >> <quic_pkondeti@quicinc.com>; Pratham Pratap (QUIC)
> >> <quic_ppratap@quicinc.com>; Krishna Kurapati PSSNV (QUIC)
> >> <quic_kriskura@quicinc.com>; Vidya Sagar Pulyala (Temp) (QUIC)
> >> <quic_vpulyala@quicinc.com>; Sandeep Maheswaram (Temp) (QUIC)
> >> <quic_c_sanm@quicinc.com>
> >> Subject: [PATCH v3 0/2] Skip phy initialization for DWC3 USB Controllers
> >>
> >> Runtime suspend of phy drivers was failing from DWC3 driver as runtime
> >> usage value is 2 because the phy is initialized from
> >> DWC3 core and HCD core.
> >> Some controllers like DWC3 and CDNS3 manage phy in their core drivers.
> >> This property can be set to avoid phy initialization in HCD core.
> >>
> >> v3:
> >> Coming back to this series based on discussion at below thread
> >> https://patchwork.kernel.org/project/linux-arm-msm/patch/1648103831-
> >> 12347-4-git-send-email-quic_c_sanm@quicinc.com/
> >> Dropped the dt bindings PATCH 1/3 in v2
> >> https://patchwork.kernel.org/project/linux-arm-msm/cover/1636353710-
> >> 25582-1-git-send-email-quic_c_sanm@quicinc.com/
> >>
> >> v2:
> >> Updated the commit descriptions.
> >> Changed subject prefix from dwc to dwc3.
> >> Increased props array size.
> >>
> >> Sandeep Maheswaram (2):
> >> usb: host: xhci-plat: Add device property to set XHCI_SKIP_PHY_INIT
> >> quirk
> >> usb: dwc3: host: Set the property usb-skip-phy-init
> >>
> >> drivers/usb/dwc3/host.c | 4 +++-
> >> drivers/usb/host/xhci-plat.c | 3 +++
> >> 2 files changed, 6 insertions(+), 1 deletion(-)
> >>
> >> --
> >> 2.7.4
> >
> > Please let me know your opinion about this series.
>
> Otherwise looks good but wondering if we should document that new device
> property somewhere.
>
> Couldn't find a standard way how those device properties excluded from
> Documentation/devicetree/binding are documented
Couldn't it be just documented in drivers/usb/host/xhci-plat.c for now?
thanks,
--
heikki
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v3 0/2] Skip phy initialization for DWC3 USB Controllers
2022-04-21 7:46 ` Heikki Krogerus
@ 2022-04-21 8:36 ` Greg Kroah-Hartman
2022-04-21 8:41 ` Heikki Krogerus
0 siblings, 1 reply; 11+ messages in thread
From: Greg Kroah-Hartman @ 2022-04-21 8:36 UTC (permalink / raw)
To: Heikki Krogerus
Cc: Mathias Nyman, Sandeep Maheswaram (Temp) (QUIC),
Felipe Balbi, Stephen Boyd, Doug Anderson, Matthias Kaehlcke,
Mathias Nyman, linux-arm-msm, linux-usb, linux-kernel,
Pavan Kumar Kondeti (QUIC), Pratham Pratap (QUIC),
Krishna Kurapati PSSNV (QUIC), Vidya Sagar Pulyala (Temp) (QUIC)
On Thu, Apr 21, 2022 at 10:46:37AM +0300, Heikki Krogerus wrote:
> On Wed, Apr 20, 2022 at 04:20:52PM +0300, Mathias Nyman wrote:
> > On 19.4.2022 13.17, Sandeep Maheswaram (Temp) (QUIC) wrote:
> > > Hi Mathias, Felipe,
> > >
> > >> -----Original Message-----
> > >> From: Sandeep Maheswaram (Temp) (QUIC) <quic_c_sanm@quicinc.com>
> > >> Sent: Thursday, April 7, 2022 3:01 PM
> > >> To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>; Felipe Balbi
> > >> <balbi@kernel.org>; Stephen Boyd <swboyd@chromium.org>; Doug
> > >> Anderson <dianders@chromium.org>; Matthias Kaehlcke
> > >> <mka@chromium.org>; Mathias Nyman <mathias.nyman@intel.com>
> > >> Cc: linux-arm-msm@vger.kernel.org; linux-usb@vger.kernel.org; linux-
> > >> kernel@vger.kernel.org; Pavan Kumar Kondeti (QUIC)
> > >> <quic_pkondeti@quicinc.com>; Pratham Pratap (QUIC)
> > >> <quic_ppratap@quicinc.com>; Krishna Kurapati PSSNV (QUIC)
> > >> <quic_kriskura@quicinc.com>; Vidya Sagar Pulyala (Temp) (QUIC)
> > >> <quic_vpulyala@quicinc.com>; Sandeep Maheswaram (Temp) (QUIC)
> > >> <quic_c_sanm@quicinc.com>
> > >> Subject: [PATCH v3 0/2] Skip phy initialization for DWC3 USB Controllers
> > >>
> > >> Runtime suspend of phy drivers was failing from DWC3 driver as runtime
> > >> usage value is 2 because the phy is initialized from
> > >> DWC3 core and HCD core.
> > >> Some controllers like DWC3 and CDNS3 manage phy in their core drivers.
> > >> This property can be set to avoid phy initialization in HCD core.
> > >>
> > >> v3:
> > >> Coming back to this series based on discussion at below thread
> > >> https://patchwork.kernel.org/project/linux-arm-msm/patch/1648103831-
> > >> 12347-4-git-send-email-quic_c_sanm@quicinc.com/
> > >> Dropped the dt bindings PATCH 1/3 in v2
> > >> https://patchwork.kernel.org/project/linux-arm-msm/cover/1636353710-
> > >> 25582-1-git-send-email-quic_c_sanm@quicinc.com/
> > >>
> > >> v2:
> > >> Updated the commit descriptions.
> > >> Changed subject prefix from dwc to dwc3.
> > >> Increased props array size.
> > >>
> > >> Sandeep Maheswaram (2):
> > >> usb: host: xhci-plat: Add device property to set XHCI_SKIP_PHY_INIT
> > >> quirk
> > >> usb: dwc3: host: Set the property usb-skip-phy-init
> > >>
> > >> drivers/usb/dwc3/host.c | 4 +++-
> > >> drivers/usb/host/xhci-plat.c | 3 +++
> > >> 2 files changed, 6 insertions(+), 1 deletion(-)
> > >>
> > >> --
> > >> 2.7.4
> > >
> > > Please let me know your opinion about this series.
> >
> > Otherwise looks good but wondering if we should document that new device
> > property somewhere.
> >
> > Couldn't find a standard way how those device properties excluded from
> > Documentation/devicetree/binding are documented
>
> Couldn't it be just documented in drivers/usb/host/xhci-plat.c for now?
That's not where DT properties are documented.
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v3 0/2] Skip phy initialization for DWC3 USB Controllers
2022-04-21 8:36 ` Greg Kroah-Hartman
@ 2022-04-21 8:41 ` Heikki Krogerus
2022-04-21 9:31 ` Greg Kroah-Hartman
0 siblings, 1 reply; 11+ messages in thread
From: Heikki Krogerus @ 2022-04-21 8:41 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Mathias Nyman, Sandeep Maheswaram (Temp) (QUIC),
Felipe Balbi, Stephen Boyd, Doug Anderson, Matthias Kaehlcke,
Mathias Nyman, linux-arm-msm, linux-usb, linux-kernel,
Pavan Kumar Kondeti (QUIC), Pratham Pratap (QUIC),
Krishna Kurapati PSSNV (QUIC), Vidya Sagar Pulyala (Temp) (QUIC)
On Thu, Apr 21, 2022 at 10:36:57AM +0200, Greg Kroah-Hartman wrote:
> On Thu, Apr 21, 2022 at 10:46:37AM +0300, Heikki Krogerus wrote:
> > On Wed, Apr 20, 2022 at 04:20:52PM +0300, Mathias Nyman wrote:
> > > On 19.4.2022 13.17, Sandeep Maheswaram (Temp) (QUIC) wrote:
> > > > Hi Mathias, Felipe,
> > > >
> > > >> -----Original Message-----
> > > >> From: Sandeep Maheswaram (Temp) (QUIC) <quic_c_sanm@quicinc.com>
> > > >> Sent: Thursday, April 7, 2022 3:01 PM
> > > >> To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>; Felipe Balbi
> > > >> <balbi@kernel.org>; Stephen Boyd <swboyd@chromium.org>; Doug
> > > >> Anderson <dianders@chromium.org>; Matthias Kaehlcke
> > > >> <mka@chromium.org>; Mathias Nyman <mathias.nyman@intel.com>
> > > >> Cc: linux-arm-msm@vger.kernel.org; linux-usb@vger.kernel.org; linux-
> > > >> kernel@vger.kernel.org; Pavan Kumar Kondeti (QUIC)
> > > >> <quic_pkondeti@quicinc.com>; Pratham Pratap (QUIC)
> > > >> <quic_ppratap@quicinc.com>; Krishna Kurapati PSSNV (QUIC)
> > > >> <quic_kriskura@quicinc.com>; Vidya Sagar Pulyala (Temp) (QUIC)
> > > >> <quic_vpulyala@quicinc.com>; Sandeep Maheswaram (Temp) (QUIC)
> > > >> <quic_c_sanm@quicinc.com>
> > > >> Subject: [PATCH v3 0/2] Skip phy initialization for DWC3 USB Controllers
> > > >>
> > > >> Runtime suspend of phy drivers was failing from DWC3 driver as runtime
> > > >> usage value is 2 because the phy is initialized from
> > > >> DWC3 core and HCD core.
> > > >> Some controllers like DWC3 and CDNS3 manage phy in their core drivers.
> > > >> This property can be set to avoid phy initialization in HCD core.
> > > >>
> > > >> v3:
> > > >> Coming back to this series based on discussion at below thread
> > > >> https://patchwork.kernel.org/project/linux-arm-msm/patch/1648103831-
> > > >> 12347-4-git-send-email-quic_c_sanm@quicinc.com/
> > > >> Dropped the dt bindings PATCH 1/3 in v2
> > > >> https://patchwork.kernel.org/project/linux-arm-msm/cover/1636353710-
> > > >> 25582-1-git-send-email-quic_c_sanm@quicinc.com/
> > > >>
> > > >> v2:
> > > >> Updated the commit descriptions.
> > > >> Changed subject prefix from dwc to dwc3.
> > > >> Increased props array size.
> > > >>
> > > >> Sandeep Maheswaram (2):
> > > >> usb: host: xhci-plat: Add device property to set XHCI_SKIP_PHY_INIT
> > > >> quirk
> > > >> usb: dwc3: host: Set the property usb-skip-phy-init
> > > >>
> > > >> drivers/usb/dwc3/host.c | 4 +++-
> > > >> drivers/usb/host/xhci-plat.c | 3 +++
> > > >> 2 files changed, 6 insertions(+), 1 deletion(-)
> > > >>
> > > >> --
> > > >> 2.7.4
> > > >
> > > > Please let me know your opinion about this series.
> > >
> > > Otherwise looks good but wondering if we should document that new device
> > > property somewhere.
> > >
> > > Couldn't find a standard way how those device properties excluded from
> > > Documentation/devicetree/binding are documented
> >
> > Couldn't it be just documented in drivers/usb/host/xhci-plat.c for now?
>
> That's not where DT properties are documented.
It's not a DT property.
--
heikki
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v3 0/2] Skip phy initialization for DWC3 USB Controllers
2022-04-21 8:41 ` Heikki Krogerus
@ 2022-04-21 9:31 ` Greg Kroah-Hartman
0 siblings, 0 replies; 11+ messages in thread
From: Greg Kroah-Hartman @ 2022-04-21 9:31 UTC (permalink / raw)
To: Heikki Krogerus
Cc: Mathias Nyman, Sandeep Maheswaram (Temp) (QUIC),
Felipe Balbi, Stephen Boyd, Doug Anderson, Matthias Kaehlcke,
Mathias Nyman, linux-arm-msm, linux-usb, linux-kernel,
Pavan Kumar Kondeti (QUIC), Pratham Pratap (QUIC),
Krishna Kurapati PSSNV (QUIC), Vidya Sagar Pulyala (Temp) (QUIC)
On Thu, Apr 21, 2022 at 11:41:33AM +0300, Heikki Krogerus wrote:
> On Thu, Apr 21, 2022 at 10:36:57AM +0200, Greg Kroah-Hartman wrote:
> > On Thu, Apr 21, 2022 at 10:46:37AM +0300, Heikki Krogerus wrote:
> > > On Wed, Apr 20, 2022 at 04:20:52PM +0300, Mathias Nyman wrote:
> > > > On 19.4.2022 13.17, Sandeep Maheswaram (Temp) (QUIC) wrote:
> > > > > Hi Mathias, Felipe,
> > > > >
> > > > >> -----Original Message-----
> > > > >> From: Sandeep Maheswaram (Temp) (QUIC) <quic_c_sanm@quicinc.com>
> > > > >> Sent: Thursday, April 7, 2022 3:01 PM
> > > > >> To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>; Felipe Balbi
> > > > >> <balbi@kernel.org>; Stephen Boyd <swboyd@chromium.org>; Doug
> > > > >> Anderson <dianders@chromium.org>; Matthias Kaehlcke
> > > > >> <mka@chromium.org>; Mathias Nyman <mathias.nyman@intel.com>
> > > > >> Cc: linux-arm-msm@vger.kernel.org; linux-usb@vger.kernel.org; linux-
> > > > >> kernel@vger.kernel.org; Pavan Kumar Kondeti (QUIC)
> > > > >> <quic_pkondeti@quicinc.com>; Pratham Pratap (QUIC)
> > > > >> <quic_ppratap@quicinc.com>; Krishna Kurapati PSSNV (QUIC)
> > > > >> <quic_kriskura@quicinc.com>; Vidya Sagar Pulyala (Temp) (QUIC)
> > > > >> <quic_vpulyala@quicinc.com>; Sandeep Maheswaram (Temp) (QUIC)
> > > > >> <quic_c_sanm@quicinc.com>
> > > > >> Subject: [PATCH v3 0/2] Skip phy initialization for DWC3 USB Controllers
> > > > >>
> > > > >> Runtime suspend of phy drivers was failing from DWC3 driver as runtime
> > > > >> usage value is 2 because the phy is initialized from
> > > > >> DWC3 core and HCD core.
> > > > >> Some controllers like DWC3 and CDNS3 manage phy in their core drivers.
> > > > >> This property can be set to avoid phy initialization in HCD core.
> > > > >>
> > > > >> v3:
> > > > >> Coming back to this series based on discussion at below thread
> > > > >> https://patchwork.kernel.org/project/linux-arm-msm/patch/1648103831-
> > > > >> 12347-4-git-send-email-quic_c_sanm@quicinc.com/
> > > > >> Dropped the dt bindings PATCH 1/3 in v2
> > > > >> https://patchwork.kernel.org/project/linux-arm-msm/cover/1636353710-
> > > > >> 25582-1-git-send-email-quic_c_sanm@quicinc.com/
> > > > >>
> > > > >> v2:
> > > > >> Updated the commit descriptions.
> > > > >> Changed subject prefix from dwc to dwc3.
> > > > >> Increased props array size.
> > > > >>
> > > > >> Sandeep Maheswaram (2):
> > > > >> usb: host: xhci-plat: Add device property to set XHCI_SKIP_PHY_INIT
> > > > >> quirk
> > > > >> usb: dwc3: host: Set the property usb-skip-phy-init
> > > > >>
> > > > >> drivers/usb/dwc3/host.c | 4 +++-
> > > > >> drivers/usb/host/xhci-plat.c | 3 +++
> > > > >> 2 files changed, 6 insertions(+), 1 deletion(-)
> > > > >>
> > > > >> --
> > > > >> 2.7.4
> > > > >
> > > > > Please let me know your opinion about this series.
> > > >
> > > > Otherwise looks good but wondering if we should document that new device
> > > > property somewhere.
> > > >
> > > > Couldn't find a standard way how those device properties excluded from
> > > > Documentation/devicetree/binding are documented
> > >
> > > Couldn't it be just documented in drivers/usb/host/xhci-plat.c for now?
> >
> > That's not where DT properties are documented.
>
> It's not a DT property.
Then what is it and why are the other properties documented?
Anyway, a new series has been submitted that does document this so I
don't think it's an argument anymore :)
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2022-04-21 9:32 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-07 9:31 [PATCH v3 0/2] Skip phy initialization for DWC3 USB Controllers Sandeep Maheswaram
2022-04-07 9:31 ` [PATCH v3 1/2] usb: host: xhci-plat: Add device property to set XHCI_SKIP_PHY_INIT quirk Sandeep Maheswaram
2022-04-20 15:36 ` Greg Kroah-Hartman
2022-04-21 4:11 ` Pavan Kondeti
2022-04-07 9:31 ` [PATCH v3 2/2] usb: dwc3: host: Set the property usb-skip-phy-init Sandeep Maheswaram
2022-04-19 10:17 ` [PATCH v3 0/2] Skip phy initialization for DWC3 USB Controllers Sandeep Maheswaram (Temp) (QUIC)
2022-04-20 13:20 ` Mathias Nyman
2022-04-21 7:46 ` Heikki Krogerus
2022-04-21 8:36 ` Greg Kroah-Hartman
2022-04-21 8:41 ` Heikki Krogerus
2022-04-21 9:31 ` Greg Kroah-Hartman
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.