* [PATCH V2] ethernet: Fix some formatting issues
@ 2022-04-07 10:36 Haowen Bai
2022-04-08 2:38 ` Jakub Kicinski
0 siblings, 1 reply; 2+ messages in thread
From: Haowen Bai @ 2022-04-07 10:36 UTC (permalink / raw)
To: David S. Miller, Jakub Kicinski, Paolo Abeni
Cc: Haowen Bai, netdev, linux-kernel
reported by checkpatch.pl
WARNING: suspect code indent for conditional statements (16, 16)
#732: FILE: drivers/net/ethernet/3com/3c589_cs.c:732:
CHECK: Alignment should match open parenthesis
#733: FILE: drivers/net/ethernet/3com/3c589_cs.c:733:
CHECK: Alignment should match open parenthesis
#735: FILE: drivers/net/ethernet/3com/3c589_cs.c:735:
WARNING: suspect code indent for conditional statements (16, 16)
#736: FILE: drivers/net/ethernet/3com/3c589_cs.c:736:
CHECK: Alignment should match open parenthesis
#737: FILE: drivers/net/ethernet/3com/3c589_cs.c:737:
CHECK: Alignment should match open parenthesis
#739: FILE: drivers/net/ethernet/3com/3c589_cs.c:739:
Signed-off-by: Haowen Bai <baihaowen@meizu.com>
---
V1->V2: add detail of description
drivers/net/ethernet/3com/3c589_cs.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/net/ethernet/3com/3c589_cs.c b/drivers/net/ethernet/3com/3c589_cs.c
index 4673bc1604e7..c46353375909 100644
--- a/drivers/net/ethernet/3com/3c589_cs.c
+++ b/drivers/net/ethernet/3com/3c589_cs.c
@@ -730,13 +730,13 @@ static void media_check(struct timer_list *t)
if (media != lp->media_status) {
if ((media & lp->media_status & 0x8000) &&
- ((lp->media_status ^ media) & 0x0800))
- netdev_info(dev, "%s link beat\n",
- (lp->media_status & 0x0800 ? "lost" : "found"));
+ ((lp->media_status ^ media) & 0x0800))
+ netdev_info(dev, "%s link beat\n",
+ (lp->media_status & 0x0800 ? "lost" : "found"));
else if ((media & lp->media_status & 0x4000) &&
- ((lp->media_status ^ media) & 0x0010))
- netdev_info(dev, "coax cable %s\n",
- (lp->media_status & 0x0010 ? "ok" : "problem"));
+ ((lp->media_status ^ media) & 0x0010))
+ netdev_info(dev, "coax cable %s\n",
+ (lp->media_status & 0x0010 ? "ok" : "problem"));
if (dev->if_port == 0) {
if (media & 0x8000) {
if (media & 0x0800)
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH V2] ethernet: Fix some formatting issues
2022-04-07 10:36 [PATCH V2] ethernet: Fix some formatting issues Haowen Bai
@ 2022-04-08 2:38 ` Jakub Kicinski
0 siblings, 0 replies; 2+ messages in thread
From: Jakub Kicinski @ 2022-04-08 2:38 UTC (permalink / raw)
To: Haowen Bai; +Cc: David S. Miller, Paolo Abeni, netdev, linux-kernel
On Thu, 7 Apr 2022 18:36:04 +0800 Haowen Bai wrote:
> reported by checkpatch.pl
Please don't send "checkpatch fixes" for networking.
> WARNING: suspect code indent for conditional statements (16, 16)
> #732: FILE: drivers/net/ethernet/3com/3c589_cs.c:732:
> CHECK: Alignment should match open parenthesis
> #733: FILE: drivers/net/ethernet/3com/3c589_cs.c:733:
> CHECK: Alignment should match open parenthesis
> #735: FILE: drivers/net/ethernet/3com/3c589_cs.c:735:
> WARNING: suspect code indent for conditional statements (16, 16)
> #736: FILE: drivers/net/ethernet/3com/3c589_cs.c:736:
> CHECK: Alignment should match open parenthesis
> #737: FILE: drivers/net/ethernet/3com/3c589_cs.c:737:
> CHECK: Alignment should match open parenthesis
> #739: FILE: drivers/net/ethernet/3com/3c589_cs.c:739:
> Signed-off-by: Haowen Bai <baihaowen@meizu.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-04-08 2:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-07 10:36 [PATCH V2] ethernet: Fix some formatting issues Haowen Bai
2022-04-08 2:38 ` Jakub Kicinski
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.