All of lore.kernel.org
 help / color / mirror / Atom feed
* [igt-dev] [PATCH i-g-t 1/2] tests/i915/kms_big_fb: move start of crc calculation past first commit
@ 2022-04-07 18:37 Juha-Pekka Heikkila
  2022-04-07 18:37 ` [igt-dev] [PATCH i-g-t 2/2] tests/i915/kms_big_fb: Don't fill small fb during test setup Juha-Pekka Heikkila
                   ` (10 more replies)
  0 siblings, 11 replies; 15+ messages in thread
From: Juha-Pekka Heikkila @ 2022-04-07 18:37 UTC (permalink / raw)
  To: igt-dev

First commit may cause modeset on two pipes which can on some machines
take enough time to fill up crc buffer on one pipe causing crc buffer
overflow messages. Moved crc calculation start past first commit
to avoid these messages.

Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
---
 tests/i915/kms_big_fb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/i915/kms_big_fb.c b/tests/i915/kms_big_fb.c
index 8724d6069..b7bcc3401 100644
--- a/tests/i915/kms_big_fb.c
+++ b/tests/i915/kms_big_fb.c
@@ -370,12 +370,12 @@ static bool test_plane(data_t *data)
 		 * rendering pipeline introduces slight differences into
 		 * the result if we try that, and so the crc will not match.
 		 */
-		igt_pipe_crc_start(data->pipe_crc);
 		copy_pattern(data, small_fb, 0, 0, big_fb, x, y,
 			     small_fb->width, small_fb->height);
 
 		igt_display_commit2(&data->display, data->display.is_atomic ?
 				    COMMIT_ATOMIC : COMMIT_UNIVERSAL);
+		igt_pipe_crc_start(data->pipe_crc);
 		igt_pipe_crc_get_current(data->display.drm_fd, data->pipe_crc, &small_crc);
 
 		igt_plane_set_fb(plane, big_fb);
-- 
2.28.0

^ permalink raw reply related	[flat|nested] 15+ messages in thread

end of thread, other threads:[~2022-04-22 11:44 UTC | newest]

Thread overview: 15+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-07 18:37 [igt-dev] [PATCH i-g-t 1/2] tests/i915/kms_big_fb: move start of crc calculation past first commit Juha-Pekka Heikkila
2022-04-07 18:37 ` [igt-dev] [PATCH i-g-t 2/2] tests/i915/kms_big_fb: Don't fill small fb during test setup Juha-Pekka Heikkila
2022-04-22 11:44   ` Kahola, Mika
2022-04-07 19:06 ` [igt-dev] ✗ Fi.CI.BAT: failure for series starting with [i-g-t,1/2] tests/i915/kms_big_fb: move start of crc calculation past first commit Patchwork
2022-04-07 21:13 ` [igt-dev] ✗ Fi.CI.BAT: failure for series starting with [i-g-t,1/2] tests/i915/kms_big_fb: move start of crc calculation past first commit (rev2) Patchwork
2022-04-08 17:18 ` [igt-dev] ✗ Fi.CI.BAT: failure for series starting with [i-g-t,1/2] tests/i915/kms_big_fb: move start of crc calculation past first commit (rev3) Patchwork
2022-04-11 20:48 ` [igt-dev] ✗ GitLab.Pipeline: warning for series starting with [i-g-t,1/2] tests/i915/kms_big_fb: move start of crc calculation past first commit (rev4) Patchwork
2022-04-11 21:12 ` [igt-dev] ✗ Fi.CI.BAT: failure " Patchwork
2022-04-12  7:11   ` Juha-Pekka Heikkila
2022-04-12 14:58     ` Vudum, Lakshminarayana
2022-04-12 14:57 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
2022-04-12 16:00 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2022-04-22  8:17 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/2] tests/i915/kms_big_fb: move start of crc calculation past first commit (rev5) Patchwork
2022-04-22 10:11 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2022-04-22 11:44 ` [igt-dev] [PATCH i-g-t 1/2] tests/i915/kms_big_fb: move start of crc calculation past first commit Kahola, Mika

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.