[PATCH 0/2] storvsc, netvsc: Improve logging

[PATCH 0/2] storvsc, netvsc: Improve logging

[Andrea Parri (Microsoft)]

Two small (and independent) patches to augment and "standardize" the error
messages.

Thanks,
  Andrea

Andrea Parri (Microsoft) (2):
  scsi: storvsc: Print value of invalid ID in
    storvsc_on_channel_callback()
  hv_netvsc: Print value of invalid ID in
    netvsc_send_{completion,tx_complete}()

 drivers/net/hyperv/netvsc.c | 8 ++++----
 drivers/scsi/storvsc_drv.c  | 3 ++-
 2 files changed, 6 insertions(+), 5 deletions(-)

-- 
2.25.1

[PATCH 1/2] scsi: storvsc: Print value of invalid ID in storvsc_on_channel_callback()

[Andrea Parri (Microsoft)]

That being useful for debugging purposes.

Signed-off-by: Andrea Parri (Microsoft) <parri.andrea@gmail.com>
---
 drivers/scsi/storvsc_drv.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c
index 9a0bba5a51a71..67ae2b5b1d5bb 100644
--- a/drivers/scsi/storvsc_drv.c
+++ b/drivers/scsi/storvsc_drv.c
@@ -1334,7 +1334,8 @@ static void storvsc_on_channel_callback(void *context)
 				/* Transaction 'rqst_id' corresponds to tag 'rqst_id - 1' */
 				scmnd = scsi_host_find_tag(shost, rqst_id - 1);
 				if (scmnd == NULL) {
-					dev_err(&device->device, "Incorrect transaction ID\n");
+					dev_err(&device->device, "Invalid transaction ID %llx\n",
+						rqst_id);
 					continue;
 				}
 				request = (struct storvsc_cmd_request *)scsi_cmd_priv(scmnd);
-- 
2.25.1

[PATCH 2/2] hv_netvsc: Print value of invalid ID in netvsc_send_{completion,tx_complete}()

[Andrea Parri (Microsoft)]

That being useful for debugging purposes.

Notice that the packet descriptor is in "private" guest memory, so
that Hyper-V can not tamper with it.

While at it, remove two unnecessary u64-casts.

Signed-off-by: Andrea Parri (Microsoft) <parri.andrea@gmail.com>
---
 drivers/net/hyperv/netvsc.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/net/hyperv/netvsc.c b/drivers/net/hyperv/netvsc.c
index 9442f751ad3aa..4061af5baaea3 100644
--- a/drivers/net/hyperv/netvsc.c
+++ b/drivers/net/hyperv/netvsc.c
@@ -792,9 +792,9 @@ static void netvsc_send_tx_complete(struct net_device *ndev,
 	int queue_sends;
 	u64 cmd_rqst;
 
-	cmd_rqst = channel->request_addr_callback(channel, (u64)desc->trans_id);
+	cmd_rqst = channel->request_addr_callback(channel, desc->trans_id);
 	if (cmd_rqst == VMBUS_RQST_ERROR) {
-		netdev_err(ndev, "Incorrect transaction id\n");
+		netdev_err(ndev, "Invalid transaction ID %llx\n", desc->trans_id);
 		return;
 	}
 
@@ -854,9 +854,9 @@ static void netvsc_send_completion(struct net_device *ndev,
 	/* First check if this is a VMBUS completion without data payload */
 	if (!msglen) {
 		cmd_rqst = incoming_channel->request_addr_callback(incoming_channel,
-								   (u64)desc->trans_id);
+								   desc->trans_id);
 		if (cmd_rqst == VMBUS_RQST_ERROR) {
-			netdev_err(ndev, "Invalid transaction id\n");
+			netdev_err(ndev, "Invalid transaction ID %llx\n", desc->trans_id);
 			return;
 		}
 
-- 
2.25.1

Re: [PATCH 0/2] storvsc, netvsc: Improve logging

[patchwork-bot+netdevbpf]

Hello:

This series was applied to netdev/net-next.git (master)
by Jakub Kicinski <kuba@kernel.org>:

On Thu,  7 Apr 2022 06:40:32 +0200 you wrote:
> Two small (and independent) patches to augment and "standardize" the error
> messages.
> 
> Thanks,
>   Andrea
> 
> Andrea Parri (Microsoft) (2):
>   scsi: storvsc: Print value of invalid ID in
>     storvsc_on_channel_callback()
>   hv_netvsc: Print value of invalid ID in
>     netvsc_send_{completion,tx_complete}()
> 
> [...]

Here is the summary with links:
  - [1/2] scsi: storvsc: Print value of invalid ID in storvsc_on_channel_callback()
    (no matching commit)
  - [2/2] hv_netvsc: Print value of invalid ID in netvsc_send_{completion,tx_complete}()
    https://git.kernel.org/netdev/net-next/c/26894cd97116

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html