How to comment or reply to others?

How to comment or reply to others?

[abdalrhman masalkhi]

[-- Attachment #1.1: Type: text/plain, Size: 556 bytes --]

Hello everyone, I am having some trouble replying to other comments, I have
submitted some patches and then I have received some comments from reviews,
I tried to reply to them by just prefixing the subject line Re: instead of
replying, I have posted a new thread..
I looked into the FAQ, I have not find the answer, I have google it, and I
have not find any answer.. could someone please direct me to the correct
article which talking about replying and comment in the lkml, or give me
some tips!
I would appreciate it.

Kind regards,
Abdalrhman Masalkhi

[-- Attachment #1.2: Type: text/html, Size: 694 bytes --]

[-- Attachment #2: Type: text/plain, Size: 170 bytes --]

_______________________________________________
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

Re: How to comment or reply to others?

[jim.cromie]

On Fri, Jul 2, 2021 at 2:11 PM abdalrhman masalkhi
<abd.masalkhi@gmail.com> wrote:
>
> Hello everyone, I am having some trouble replying to other comments, I have submitted some patches and then I have received some comments from reviews, I tried to reply to them by just prefixing the subject line Re: instead of replying, I have posted a new thread..
> I looked into the FAQ, I have not find the answer, I have google it, and I have not find any answer.. could someone please direct me to the correct article which talking about replying and comment in the lkml, or give me some tips!
> I would appreciate it.
>

if your messages are HTML, that might be a cause.
Many MLs will scrub those wo notice, since theyre so often spam.

This msg doesnt look like its HTML, but ...

since youre gmail, you use the web interface ? check more options at bottom



> Kind regards,
> Abdalrhman Masalkhi
>
> _______________________________________________
> Kernelnewbies mailing list
> Kernelnewbies@kernelnewbies.org
> https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

_______________________________________________
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

Re: How to comment or reply to others?

[Abd-Alrhman Masalkhi]

hello jim, thanks for your reply, I think that my question has not some useful information, I should have specify the problem more clearly

I am having some trouble replying and comment on threads in the Linux Kernel Mailing List, I have submitted some patches and then I have received some comments from reviews, I tried to reply to them by just prefixing the subject line with "Re:"

First, I made some changes and commit them using:

git commit -a

Then I have formatted the commit using:

git format-patch master..fix-warning

After that, I have edit the output from:

Subject: [PATCH] description-of-the-patch

to:

Subject: Re: [PATCH] description-of-the-patch

Then, I have send it using:

git send-email --to linux-block@vger.kernel.org --cc linux-kernel@vger.kernel.org name-of-the-patch.patch

I have allready set up the .gitconfig file with following configuration:

smtpEncryption = ssl
smtpServer = smtp.gmail.com
smtpUser = my-email-address@gmail.com
smtpServerPort = 465

It did not worked and what happened is that instead of replying to the reviewer, I end up creating a new thread in LKML... I know the path that I have taken does not seems right for replying to a commit lol, before doing all that, I looked into the FAQ in LKML website, for how to reply to comments I have not find an answer, I have google it, and also I have not find any answer then I tried to press on "reply all" in Gmail App on apple OS it did not worked too...

I posted the question on stackoverflow website, they advised me to use --in-reply-to option with git send-email, so now I have wrote the email and specified that option, I hope it worked.. after all that!

_______________________________________________
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

Re: How to comment or reply to others?

[Valdis Klētnieks]

[-- Attachment #1.1: Type: text/plain, Size: 563 bytes --]

On Sun, 04 Jul 2021 11:13:08 +0200, Abd-Alrhman Masalkhi said:

> I have allready set up the .gitconfig file with following configuration:
>
> smtpEncryption = ssl
> smtpServer = smtp.gmail.com
> smtpUser = my-email-address@gmail.com
> smtpServerPort = 465

Try 'smtpEncryption = tls' instead.  Gmail's email submission servers require
at least TLS 1.1 (current protocol version is 1.3), and they stopped allowing
SSL (the known-insecure predecessor of TLS) some 5 years ago.

https://threatpost.com/google-to-deprecate-sslv3-rc4-in-gmail-imappop-clients/118533/

[-- Attachment #1.2: Type: application/pgp-signature, Size: 832 bytes --]

[-- Attachment #2: Type: text/plain, Size: 170 bytes --]

_______________________________________________
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

Re: How to comment or reply to others?

[jim.cromie]

On Sun, Jul 4, 2021 at 9:36 AM Valdis Klētnieks <valdis.kletnieks@vt.edu> wrote:
>
> On Sun, 04 Jul 2021 11:13:08 +0200, Abd-Alrhman Masalkhi said:
>
> > I have allready set up the .gitconfig file with following configuration:
> >
> > smtpEncryption = ssl
> > smtpServer = smtp.gmail.com
> > smtpUser = my-email-address@gmail.com
> > smtpServerPort = 465
>
> Try 'smtpEncryption = tls' instead.  Gmail's email submission servers require
> at least TLS 1.1 (current protocol version is 1.3), and they stopped allowing
> SSL (the known-insecure predecessor of TLS) some 5 years ago.
>
> https://threatpost.com/google-to-deprecate-sslv3-rc4-in-gmail-imappop-clients/118533/

I have tls, and port = 587, and an smtppass

_______________________________________________
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

Re: How to comment or reply to others?

[Valdis Klētnieks]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.1: Type: text/plain; charset=us-ascii, Size: 412 bytes --]

On Thu, 08 Jul 2021 11:49:46 -0600, jim.cromie@gmail.com said:
> On Sun, Jul 4, 2021 at 9:36 AM Valdis Klētnieks <valdis.kletnieks@vt.edu> wrote:

> > > smtpEncryption = ssl
> > > smtpServer = smtp.gmail.com
> > > smtpUser = my-email-address@gmail.com
> > > smtpServerPort = 465

> I have tls, and port = 587, and an smtppass

Thanks for catching that.  I saw the encryption, and totally missed the other two.


[-- Attachment #1.2: Type: application/pgp-signature, Size: 494 bytes --]

[-- Attachment #2: Type: text/plain, Size: 170 bytes --]

_______________________________________________
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

Re: How to comment or reply to others?

[Konstantin Ryabitsev]

On Sun, Jul 04, 2021 at 11:13:08AM +0200, Abd-Alrhman Masalkhi wrote:
> hello jim, thanks for your reply, I think that my question has not some
> useful information, I should have specify the problem more clearly
> 
> I am having some trouble replying and comment on threads in the Linux Kernel
> Mailing List, I have submitted some patches and then I have received some
> comments from reviews, I tried to reply to them by just prefixing the
> subject line with "Re:"
> 
> First, I made some changes and commit them using:
> 
> git commit -a
> 
> Then I have formatted the commit using:
> 
> git format-patch master..fix-warning
> 
> After that, I have edit the output from:
> 
> Subject: [PATCH] description-of-the-patch
> 
> to:
> 
> Subject: Re: [PATCH] description-of-the-patch

This is not the workflow you should be using, as most developers do not care
to have the new revision of the patch be threaded to the previous version. Try
the following:

    git format-patch -v2 master..fix-warning

You may then open the resulting file and add extra information at the bottom
of the commit message, right before the diffstat like so:

    ---
    v2:
     - Fixed compiler warning

    v1:
     - Link: https://lore.kernel.org/r/message-id-of-the-previous-patch

    foo/somefile.c | 6 +++---
    1 file changed, 3 insertions(+), 3 deletions(-)

For example, see this patch for your reference:
https://lore.kernel.org/lkml/20210707055652.962-1-yao.jin@linux.intel.com/

If you then require v3 of the patch, just use the same format, copy-paste
previous changelog data and add v3, e.g.:

    ---
    v3:
     - Fixed something else

    v2:
     - Fixed compiler warning
     - Link: https://lore.kernel.org/r/message-id-of-v2-patch

    v1:
     - Link: https://lore.kernel.org/r/message-id-of-v1-patch

Not everyone posts links to the previous patch revisions, but this will
certainly help the maintainer if they need to review the actual patch
difference.

Best regards,
Konstantin

_______________________________________________
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

Re: How to comment or reply to others?

[jim.cromie]

>
> For example, see this patch for your reference:
> https://lore.kernel.org/lkml/20210707055652.962-1-yao.jin@linux.intel.com/
>
> If you then require v3 of the patch, just use the same format, copy-paste
> previous changelog data and add v3, e.g.:
>
>     ---

IIUC, that line is the "snip" that  maintainer scripts (or maybe git am ?)
use to strip the extra info in the patch from the commit ?

>     v3:
>      - Fixed something else
>

Any wisdom to share on content of 0/N  intro messages ?

I tend to put all -vN-1 info in 0/N, and not in 1-N/ messages,
and usually just -vN-1, -vN-2
I dont think anyone cares about what chunks got moved around while
grooming the patchset.
(which is not to say I know what Im doing...)

0/N messages dont appear to get into merge commits,
or at least not always, perhaps its a sub-tree or maintainer preference.
It does leave some ambiguity about where to explain the work;
overviews in 0/N that dont get into a merge message
leave 1..N/ under-explained.

maybe my 0/N overviews just suck. ;-)

_______________________________________________
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

Re: How to comment or reply to others?

[Abd-Alrhman Masalkhi]

I am working at the moment by lieferando, and I newbies in the linux kernel development. I do it  as hobby 

_______________________________________________
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies