All of lore.kernel.org
 help / color / mirror / Atom feed
From: <xinlei.lee@mediatek.com>
To: <chunkuang.hu@kernel.org>, <p.zabel@pengutronix.de>,
	<airlied@linux.ie>, <daniel@ffwll.ch>, <matthias.bgg@gmail.com>,
	<rex-bc.chen@mediatek.com>
Cc: <dri-devel@lists.freedesktop.org>,
	<linux-mediatek@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>, <jitao.shi@mediatek.com>,
	<Project_Global_Chrome_Upstream_Group@mediatek.com>,
	Xinlei Lee <xinlei.lee@mediatek.com>
Subject: [PATCH v4,1/4] drm/mediatek: Adjust the timing of mipi signal from LP00 to LP11
Date: Mon, 11 Apr 2022 10:31:45 +0800	[thread overview]
Message-ID: <1649644308-8455-2-git-send-email-xinlei.lee@mediatek.com> (raw)
In-Reply-To: <1649644308-8455-1-git-send-email-xinlei.lee@mediatek.com>

From: Jitao Shi <jitao.shi@mediatek.com>

Old sequence:
1. Pull the MIPI signal high
2. Delay & Dsi_reset
3. Set the dsi timing register
4. dsi clk & lanes leave ulp mode and enter hs mode

The sequence after patching is:
1. Set the dsi timing register
2. Pull the MIPI signal high
3. Delay & Dsi_reset
4. dsi clk & lanes leave ulp mode and enter hs mode

Fixes: 2dd8075d2185 ("drm/mediatek: mtk_dsi: Use the drm_panel_bridge API")

Signed-off-by: Jitao Shi <jitao.shi@mediatek.com>
Signed-off-by: Xinlei Lee <xinlei.lee@mediatek.com>
---
 drivers/gpu/drm/mediatek/mtk_dsi.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/mtk_dsi.c
index ccb0511b9cd5..262c027d8c2f 100644
--- a/drivers/gpu/drm/mediatek/mtk_dsi.c
+++ b/drivers/gpu/drm/mediatek/mtk_dsi.c
@@ -649,14 +649,14 @@ static int mtk_dsi_poweron(struct mtk_dsi *dsi)
 	mtk_dsi_reset_engine(dsi);
 	mtk_dsi_phy_timconfig(dsi);
 
-	mtk_dsi_rxtx_control(dsi);
-	usleep_range(30, 100);
-	mtk_dsi_reset_dphy(dsi);
 	mtk_dsi_ps_control_vact(dsi);
 	mtk_dsi_set_vm_cmd(dsi);
 	mtk_dsi_config_vdo_timing(dsi);
 	mtk_dsi_set_interrupt_enable(dsi);
 
+	mtk_dsi_rxtx_control(dsi);
+	usleep_range(30, 100);
+	mtk_dsi_reset_dphy(dsi);
 	mtk_dsi_clk_ulp_mode_leave(dsi);
 	mtk_dsi_lane0_ulp_mode_leave(dsi);
 	mtk_dsi_clk_hs_mode(dsi, 0);
-- 
2.18.0


WARNING: multiple messages have this Message-ID (diff)
From: <xinlei.lee@mediatek.com>
To: <chunkuang.hu@kernel.org>, <p.zabel@pengutronix.de>,
	<airlied@linux.ie>, <daniel@ffwll.ch>, <matthias.bgg@gmail.com>,
	<rex-bc.chen@mediatek.com>
Cc: jitao.shi@mediatek.com, Xinlei Lee <xinlei.lee@mediatek.com>,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	Project_Global_Chrome_Upstream_Group@mediatek.com,
	linux-mediatek@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4, 1/4] drm/mediatek: Adjust the timing of mipi signal from LP00 to LP11
Date: Mon, 11 Apr 2022 10:31:45 +0800	[thread overview]
Message-ID: <1649644308-8455-2-git-send-email-xinlei.lee@mediatek.com> (raw)
In-Reply-To: <1649644308-8455-1-git-send-email-xinlei.lee@mediatek.com>

From: Jitao Shi <jitao.shi@mediatek.com>

Old sequence:
1. Pull the MIPI signal high
2. Delay & Dsi_reset
3. Set the dsi timing register
4. dsi clk & lanes leave ulp mode and enter hs mode

The sequence after patching is:
1. Set the dsi timing register
2. Pull the MIPI signal high
3. Delay & Dsi_reset
4. dsi clk & lanes leave ulp mode and enter hs mode

Fixes: 2dd8075d2185 ("drm/mediatek: mtk_dsi: Use the drm_panel_bridge API")

Signed-off-by: Jitao Shi <jitao.shi@mediatek.com>
Signed-off-by: Xinlei Lee <xinlei.lee@mediatek.com>
---
 drivers/gpu/drm/mediatek/mtk_dsi.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/mtk_dsi.c
index ccb0511b9cd5..262c027d8c2f 100644
--- a/drivers/gpu/drm/mediatek/mtk_dsi.c
+++ b/drivers/gpu/drm/mediatek/mtk_dsi.c
@@ -649,14 +649,14 @@ static int mtk_dsi_poweron(struct mtk_dsi *dsi)
 	mtk_dsi_reset_engine(dsi);
 	mtk_dsi_phy_timconfig(dsi);
 
-	mtk_dsi_rxtx_control(dsi);
-	usleep_range(30, 100);
-	mtk_dsi_reset_dphy(dsi);
 	mtk_dsi_ps_control_vact(dsi);
 	mtk_dsi_set_vm_cmd(dsi);
 	mtk_dsi_config_vdo_timing(dsi);
 	mtk_dsi_set_interrupt_enable(dsi);
 
+	mtk_dsi_rxtx_control(dsi);
+	usleep_range(30, 100);
+	mtk_dsi_reset_dphy(dsi);
 	mtk_dsi_clk_ulp_mode_leave(dsi);
 	mtk_dsi_lane0_ulp_mode_leave(dsi);
 	mtk_dsi_clk_hs_mode(dsi, 0);
-- 
2.18.0


WARNING: multiple messages have this Message-ID (diff)
From: <xinlei.lee@mediatek.com>
To: <chunkuang.hu@kernel.org>, <p.zabel@pengutronix.de>,
	<airlied@linux.ie>, <daniel@ffwll.ch>, <matthias.bgg@gmail.com>,
	<rex-bc.chen@mediatek.com>
Cc: <dri-devel@lists.freedesktop.org>,
	<linux-mediatek@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>, <jitao.shi@mediatek.com>,
	<Project_Global_Chrome_Upstream_Group@mediatek.com>,
	Xinlei Lee <xinlei.lee@mediatek.com>
Subject: [PATCH v4, 1/4] drm/mediatek: Adjust the timing of mipi signal from LP00 to LP11
Date: Mon, 11 Apr 2022 10:31:45 +0800	[thread overview]
Message-ID: <1649644308-8455-2-git-send-email-xinlei.lee@mediatek.com> (raw)
In-Reply-To: <1649644308-8455-1-git-send-email-xinlei.lee@mediatek.com>

From: Jitao Shi <jitao.shi@mediatek.com>

Old sequence:
1. Pull the MIPI signal high
2. Delay & Dsi_reset
3. Set the dsi timing register
4. dsi clk & lanes leave ulp mode and enter hs mode

The sequence after patching is:
1. Set the dsi timing register
2. Pull the MIPI signal high
3. Delay & Dsi_reset
4. dsi clk & lanes leave ulp mode and enter hs mode

Fixes: 2dd8075d2185 ("drm/mediatek: mtk_dsi: Use the drm_panel_bridge API")

Signed-off-by: Jitao Shi <jitao.shi@mediatek.com>
Signed-off-by: Xinlei Lee <xinlei.lee@mediatek.com>
---
 drivers/gpu/drm/mediatek/mtk_dsi.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/mtk_dsi.c
index ccb0511b9cd5..262c027d8c2f 100644
--- a/drivers/gpu/drm/mediatek/mtk_dsi.c
+++ b/drivers/gpu/drm/mediatek/mtk_dsi.c
@@ -649,14 +649,14 @@ static int mtk_dsi_poweron(struct mtk_dsi *dsi)
 	mtk_dsi_reset_engine(dsi);
 	mtk_dsi_phy_timconfig(dsi);
 
-	mtk_dsi_rxtx_control(dsi);
-	usleep_range(30, 100);
-	mtk_dsi_reset_dphy(dsi);
 	mtk_dsi_ps_control_vact(dsi);
 	mtk_dsi_set_vm_cmd(dsi);
 	mtk_dsi_config_vdo_timing(dsi);
 	mtk_dsi_set_interrupt_enable(dsi);
 
+	mtk_dsi_rxtx_control(dsi);
+	usleep_range(30, 100);
+	mtk_dsi_reset_dphy(dsi);
 	mtk_dsi_clk_ulp_mode_leave(dsi);
 	mtk_dsi_lane0_ulp_mode_leave(dsi);
 	mtk_dsi_clk_hs_mode(dsi, 0);
-- 
2.18.0


_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

WARNING: multiple messages have this Message-ID (diff)
From: <xinlei.lee@mediatek.com>
To: <chunkuang.hu@kernel.org>, <p.zabel@pengutronix.de>,
	<airlied@linux.ie>, <daniel@ffwll.ch>, <matthias.bgg@gmail.com>,
	<rex-bc.chen@mediatek.com>
Cc: <dri-devel@lists.freedesktop.org>,
	<linux-mediatek@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>, <jitao.shi@mediatek.com>,
	<Project_Global_Chrome_Upstream_Group@mediatek.com>,
	Xinlei Lee <xinlei.lee@mediatek.com>
Subject: [PATCH v4, 1/4] drm/mediatek: Adjust the timing of mipi signal from LP00 to LP11
Date: Mon, 11 Apr 2022 10:31:45 +0800	[thread overview]
Message-ID: <1649644308-8455-2-git-send-email-xinlei.lee@mediatek.com> (raw)
In-Reply-To: <1649644308-8455-1-git-send-email-xinlei.lee@mediatek.com>

From: Jitao Shi <jitao.shi@mediatek.com>

Old sequence:
1. Pull the MIPI signal high
2. Delay & Dsi_reset
3. Set the dsi timing register
4. dsi clk & lanes leave ulp mode and enter hs mode

The sequence after patching is:
1. Set the dsi timing register
2. Pull the MIPI signal high
3. Delay & Dsi_reset
4. dsi clk & lanes leave ulp mode and enter hs mode

Fixes: 2dd8075d2185 ("drm/mediatek: mtk_dsi: Use the drm_panel_bridge API")

Signed-off-by: Jitao Shi <jitao.shi@mediatek.com>
Signed-off-by: Xinlei Lee <xinlei.lee@mediatek.com>
---
 drivers/gpu/drm/mediatek/mtk_dsi.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/mtk_dsi.c
index ccb0511b9cd5..262c027d8c2f 100644
--- a/drivers/gpu/drm/mediatek/mtk_dsi.c
+++ b/drivers/gpu/drm/mediatek/mtk_dsi.c
@@ -649,14 +649,14 @@ static int mtk_dsi_poweron(struct mtk_dsi *dsi)
 	mtk_dsi_reset_engine(dsi);
 	mtk_dsi_phy_timconfig(dsi);
 
-	mtk_dsi_rxtx_control(dsi);
-	usleep_range(30, 100);
-	mtk_dsi_reset_dphy(dsi);
 	mtk_dsi_ps_control_vact(dsi);
 	mtk_dsi_set_vm_cmd(dsi);
 	mtk_dsi_config_vdo_timing(dsi);
 	mtk_dsi_set_interrupt_enable(dsi);
 
+	mtk_dsi_rxtx_control(dsi);
+	usleep_range(30, 100);
+	mtk_dsi_reset_dphy(dsi);
 	mtk_dsi_clk_ulp_mode_leave(dsi);
 	mtk_dsi_lane0_ulp_mode_leave(dsi);
 	mtk_dsi_clk_hs_mode(dsi, 0);
-- 
2.18.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2022-04-11  2:32 UTC|newest]

Thread overview: 82+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-11  2:31 [PATCH v4,0/4] Cooperate with DSI RX devices to modify dsi funcs and delay mipi high to cooperate with panel sequence xinlei.lee
2022-04-11  2:31 ` [PATCH v4, 0/4] " xinlei.lee
2022-04-11  2:31 ` xinlei.lee
2022-04-11  2:31 ` xinlei.lee
2022-04-11  2:31 ` xinlei.lee [this message]
2022-04-11  2:31   ` [PATCH v4, 1/4] drm/mediatek: Adjust the timing of mipi signal from LP00 to LP11 xinlei.lee
2022-04-11  2:31   ` xinlei.lee
2022-04-11  2:31   ` xinlei.lee
2022-04-11  9:07   ` AngeloGioacchino Del Regno
2022-04-11  9:07     ` AngeloGioacchino Del Regno
2022-04-11  9:07     ` AngeloGioacchino Del Regno
2022-04-11  9:07     ` AngeloGioacchino Del Regno
2022-04-12  7:37   ` [PATCH v4,1/4] " Rex-BC Chen
2022-04-12  7:37     ` Rex-BC Chen
2022-04-12  7:37     ` Rex-BC Chen
2022-04-12  7:37     ` Rex-BC Chen
2022-04-13  1:59   ` [PATCH v4, 1/4] " CK Hu
2022-04-13  1:59     ` CK Hu
2022-04-13  1:59     ` CK Hu
2022-04-13  1:59     ` CK Hu
2022-04-15  2:23     ` xinlei.lee
2022-04-15  2:23       ` xinlei.lee
2022-04-15  2:23       ` xinlei.lee
2022-04-11  2:31 ` [PATCH v4,2/4] drm/mediatek: Separate poweron/poweroff from enable/disable and define new funcs xinlei.lee
2022-04-11  2:31   ` [PATCH v4, 2/4] " xinlei.lee
2022-04-11  2:31   ` xinlei.lee
2022-04-11  2:31   ` xinlei.lee
2022-04-11  9:07   ` AngeloGioacchino Del Regno
2022-04-11  9:07     ` AngeloGioacchino Del Regno
2022-04-11  9:07     ` AngeloGioacchino Del Regno
2022-04-11  9:07     ` AngeloGioacchino Del Regno
2022-04-12  7:38   ` [PATCH v4,2/4] " Rex-BC Chen
2022-04-12  7:38     ` Rex-BC Chen
2022-04-12  7:38     ` Rex-BC Chen
2022-04-12  7:38     ` Rex-BC Chen
2022-04-13  7:31   ` [PATCH v4, 2/4] " CK Hu
2022-04-13  7:31     ` CK Hu
2022-04-13  7:31     ` CK Hu
2022-04-13  7:31     ` CK Hu
2022-04-15  2:30     ` xinlei.lee
2022-04-15  2:30       ` xinlei.lee
2022-04-15  2:30       ` xinlei.lee
2022-04-11  2:31 ` [PATCH v4, 3/4] drm/mediatek: keep dsi as LP00 before dcs cmds transfer xinlei.lee
2022-04-11  2:31   ` xinlei.lee
2022-04-11  2:31   ` xinlei.lee
2022-04-11  2:31   ` [PATCH v4,3/4] " xinlei.lee
2022-04-11  9:07   ` [PATCH v4, 3/4] " AngeloGioacchino Del Regno
2022-04-11  9:07     ` AngeloGioacchino Del Regno
2022-04-11  9:07     ` AngeloGioacchino Del Regno
2022-04-11  9:07     ` AngeloGioacchino Del Regno
2022-04-12  7:43     ` Rex-BC Chen
2022-04-12  7:43       ` Rex-BC Chen
2022-04-12  7:43       ` Rex-BC Chen
2022-04-12  7:43       ` Rex-BC Chen
2022-04-12 13:09       ` xinlei.lee
2022-04-12 13:09         ` xinlei.lee
2022-04-12 13:09         ` xinlei.lee
2022-04-12 13:07     ` xinlei.lee
2022-04-12 13:07       ` xinlei.lee
2022-04-12 13:07       ` xinlei.lee
2022-04-13  8:31   ` CK Hu
2022-04-13  8:31     ` CK Hu
2022-04-13  8:31     ` CK Hu
2022-04-13  8:31     ` CK Hu
2022-04-15  1:58     ` xinlei.lee
2022-04-15  1:58       ` xinlei.lee
2022-04-15  1:58       ` xinlei.lee
2022-04-29  7:24       ` CK Hu
2022-04-29  7:24         ` CK Hu
2022-04-29  7:24         ` CK Hu
2022-04-11  2:31 ` [PATCH v4, 4/4] drm/mediatek: Add pull-down MIPI operation in mtk_dsi_poweroff function xinlei.lee
2022-04-11  2:31   ` xinlei.lee
2022-04-11  2:31   ` xinlei.lee
2022-04-11  2:31   ` [PATCH v4,4/4] " xinlei.lee
2022-04-12  7:39   ` Rex-BC Chen
2022-04-12  7:39     ` Rex-BC Chen
2022-04-12  7:39     ` Rex-BC Chen
2022-04-12  7:39     ` Rex-BC Chen
2022-04-13  9:04   ` [PATCH v4, 4/4] " CK Hu
2022-04-13  9:04     ` CK Hu
2022-04-13  9:04     ` CK Hu
2022-04-13  9:04     ` CK Hu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1649644308-8455-2-git-send-email-xinlei.lee@mediatek.com \
    --to=xinlei.lee@mediatek.com \
    --cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
    --cc=airlied@linux.ie \
    --cc=chunkuang.hu@kernel.org \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jitao.shi@mediatek.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    --cc=p.zabel@pengutronix.de \
    --cc=rex-bc.chen@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.