* [PATCH v4,2/2] drm/mediatek: Add mt8186 dpi compatible to mtk_dpi.c
@ 2022-04-11 2:53 ` xinlei.lee
0 siblings, 0 replies; 23+ messages in thread
From: xinlei.lee @ 2022-04-11 2:53 UTC (permalink / raw)
To: chunkuang.hu, p.zabel, airlied, daniel, robh+dt, matthias.bgg
Cc: dri-devel, linux-mediatek, devicetree, linux-kernel,
linux-arm-kernel, rex-bc.chen, jitao.shi,
Project_Global_Chrome_Upstream_Group, Xinlei Lee
From: Xinlei Lee <xinlei.lee@mediatek.com>
Add the compatible because use different .data in mt8186.
Signed-off-by: Xinlei Lee <xinlei.lee@mediatek.com>
---
drivers/gpu/drm/mediatek/mtk_dpi.c | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c b/drivers/gpu/drm/mediatek/mtk_dpi.c
index 4554e2de1430..824d7da41c6a 100644
--- a/drivers/gpu/drm/mediatek/mtk_dpi.c
+++ b/drivers/gpu/drm/mediatek/mtk_dpi.c
@@ -815,6 +815,14 @@ static const struct mtk_dpi_conf mt8183_conf = {
.num_output_fmts = ARRAY_SIZE(mt8183_output_fmts),
};
+static const struct mtk_dpi_conf mt8186_conf = {
+ .cal_factor = mt8183_calculate_factor,
+ .reg_h_fre_con = 0xe0,
+ .max_clock_khz = 150000,
+ .output_fmts = mt8183_output_fmts,
+ .num_output_fmts = ARRAY_SIZE(mt8183_output_fmts),
+};
+
static const struct mtk_dpi_conf mt8192_conf = {
.cal_factor = mt8183_calculate_factor,
.reg_h_fre_con = 0xe0,
@@ -942,6 +950,9 @@ static const struct of_device_id mtk_dpi_of_ids[] = {
{ .compatible = "mediatek,mt8183-dpi",
.data = &mt8183_conf,
},
+ { .compatible = "mediatek,mt8186-dpi",
+ .data = &mt8186_conf,
+ },
{ .compatible = "mediatek,mt8192-dpi",
.data = &mt8192_conf,
},
--
2.18.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 23+ messages in thread* [PATCH v4,2/2] drm/mediatek: Add mt8186 dpi compatible to mtk_dpi.c
@ 2022-04-11 2:53 ` xinlei.lee
0 siblings, 0 replies; 23+ messages in thread
From: xinlei.lee @ 2022-04-11 2:53 UTC (permalink / raw)
To: chunkuang.hu, p.zabel, airlied, daniel, robh+dt, matthias.bgg
Cc: dri-devel, linux-mediatek, devicetree, linux-kernel,
linux-arm-kernel, rex-bc.chen, jitao.shi,
Project_Global_Chrome_Upstream_Group, Xinlei Lee
From: Xinlei Lee <xinlei.lee@mediatek.com>
Add the compatible because use different .data in mt8186.
Signed-off-by: Xinlei Lee <xinlei.lee@mediatek.com>
---
drivers/gpu/drm/mediatek/mtk_dpi.c | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c b/drivers/gpu/drm/mediatek/mtk_dpi.c
index 4554e2de1430..824d7da41c6a 100644
--- a/drivers/gpu/drm/mediatek/mtk_dpi.c
+++ b/drivers/gpu/drm/mediatek/mtk_dpi.c
@@ -815,6 +815,14 @@ static const struct mtk_dpi_conf mt8183_conf = {
.num_output_fmts = ARRAY_SIZE(mt8183_output_fmts),
};
+static const struct mtk_dpi_conf mt8186_conf = {
+ .cal_factor = mt8183_calculate_factor,
+ .reg_h_fre_con = 0xe0,
+ .max_clock_khz = 150000,
+ .output_fmts = mt8183_output_fmts,
+ .num_output_fmts = ARRAY_SIZE(mt8183_output_fmts),
+};
+
static const struct mtk_dpi_conf mt8192_conf = {
.cal_factor = mt8183_calculate_factor,
.reg_h_fre_con = 0xe0,
@@ -942,6 +950,9 @@ static const struct of_device_id mtk_dpi_of_ids[] = {
{ .compatible = "mediatek,mt8183-dpi",
.data = &mt8183_conf,
},
+ { .compatible = "mediatek,mt8186-dpi",
+ .data = &mt8186_conf,
+ },
{ .compatible = "mediatek,mt8192-dpi",
.data = &mt8192_conf,
},
--
2.18.0
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply related [flat|nested] 23+ messages in thread* [PATCH v4,2/2] drm/mediatek: Add mt8186 dpi compatible to mtk_dpi.c
@ 2022-04-11 2:53 ` xinlei.lee
0 siblings, 0 replies; 23+ messages in thread
From: xinlei.lee @ 2022-04-11 2:53 UTC (permalink / raw)
To: chunkuang.hu, p.zabel, airlied, daniel, robh+dt, matthias.bgg
Cc: devicetree, jitao.shi, Xinlei Lee, linux-kernel, dri-devel,
Project_Global_Chrome_Upstream_Group, linux-mediatek,
rex-bc.chen, linux-arm-kernel
From: Xinlei Lee <xinlei.lee@mediatek.com>
Add the compatible because use different .data in mt8186.
Signed-off-by: Xinlei Lee <xinlei.lee@mediatek.com>
---
drivers/gpu/drm/mediatek/mtk_dpi.c | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c b/drivers/gpu/drm/mediatek/mtk_dpi.c
index 4554e2de1430..824d7da41c6a 100644
--- a/drivers/gpu/drm/mediatek/mtk_dpi.c
+++ b/drivers/gpu/drm/mediatek/mtk_dpi.c
@@ -815,6 +815,14 @@ static const struct mtk_dpi_conf mt8183_conf = {
.num_output_fmts = ARRAY_SIZE(mt8183_output_fmts),
};
+static const struct mtk_dpi_conf mt8186_conf = {
+ .cal_factor = mt8183_calculate_factor,
+ .reg_h_fre_con = 0xe0,
+ .max_clock_khz = 150000,
+ .output_fmts = mt8183_output_fmts,
+ .num_output_fmts = ARRAY_SIZE(mt8183_output_fmts),
+};
+
static const struct mtk_dpi_conf mt8192_conf = {
.cal_factor = mt8183_calculate_factor,
.reg_h_fre_con = 0xe0,
@@ -942,6 +950,9 @@ static const struct of_device_id mtk_dpi_of_ids[] = {
{ .compatible = "mediatek,mt8183-dpi",
.data = &mt8183_conf,
},
+ { .compatible = "mediatek,mt8186-dpi",
+ .data = &mt8186_conf,
+ },
{ .compatible = "mediatek,mt8192-dpi",
.data = &mt8192_conf,
},
--
2.18.0
^ permalink raw reply related [flat|nested] 23+ messages in thread* Re: [PATCH v4,2/2] drm/mediatek: Add mt8186 dpi compatible to mtk_dpi.c
2022-04-11 2:53 ` xinlei.lee
(?)
(?)
@ 2022-04-11 3:33 ` Rex-BC Chen
-1 siblings, 0 replies; 23+ messages in thread
From: Rex-BC Chen @ 2022-04-11 3:33 UTC (permalink / raw)
To: xinlei.lee, chunkuang.hu, p.zabel, airlied, daniel, robh+dt,
matthias.bgg
Cc: dri-devel, linux-mediatek, devicetree, linux-kernel,
linux-arm-kernel, jitao.shi,
Project_Global_Chrome_Upstream_Group
On Mon, 2022-04-11 at 10:53 +0800, xinlei.lee@mediatek.com wrote:
> From: Xinlei Lee <xinlei.lee@mediatek.com>
>
> Add the compatible because use different .data in mt8186.
>
> Signed-off-by: Xinlei Lee <xinlei.lee@mediatek.com>
> ---
> drivers/gpu/drm/mediatek/mtk_dpi.c | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c
> b/drivers/gpu/drm/mediatek/mtk_dpi.c
> index 4554e2de1430..824d7da41c6a 100644
> --- a/drivers/gpu/drm/mediatek/mtk_dpi.c
> +++ b/drivers/gpu/drm/mediatek/mtk_dpi.c
> @@ -815,6 +815,14 @@ static const struct mtk_dpi_conf mt8183_conf = {
> .num_output_fmts = ARRAY_SIZE(mt8183_output_fmts),
> };
>
> +static const struct mtk_dpi_conf mt8186_conf = {
> + .cal_factor = mt8183_calculate_factor,
> + .reg_h_fre_con = 0xe0,
> + .max_clock_khz = 150000,
> + .output_fmts = mt8183_output_fmts,
> + .num_output_fmts = ARRAY_SIZE(mt8183_output_fmts),
> +};
> +
> static const struct mtk_dpi_conf mt8192_conf = {
> .cal_factor = mt8183_calculate_factor,
> .reg_h_fre_con = 0xe0,
> @@ -942,6 +950,9 @@ static const struct of_device_id mtk_dpi_of_ids[]
> = {
> { .compatible = "mediatek,mt8183-dpi",
> .data = &mt8183_conf,
> },
> + { .compatible = "mediatek,mt8186-dpi",
> + .data = &mt8186_conf,
> + },
> { .compatible = "mediatek,mt8192-dpi",
> .data = &mt8192_conf,
> },
Reviewed-by: Rex-BC Chen <rex-bc.chen@mediatek.com>
^ permalink raw reply [flat|nested] 23+ messages in thread* Re: [PATCH v4,2/2] drm/mediatek: Add mt8186 dpi compatible to mtk_dpi.c
@ 2022-04-11 3:33 ` Rex-BC Chen
0 siblings, 0 replies; 23+ messages in thread
From: Rex-BC Chen @ 2022-04-11 3:33 UTC (permalink / raw)
To: xinlei.lee, chunkuang.hu, p.zabel, airlied, daniel, robh+dt,
matthias.bgg
Cc: dri-devel, linux-mediatek, devicetree, linux-kernel,
linux-arm-kernel, jitao.shi,
Project_Global_Chrome_Upstream_Group
On Mon, 2022-04-11 at 10:53 +0800, xinlei.lee@mediatek.com wrote:
> From: Xinlei Lee <xinlei.lee@mediatek.com>
>
> Add the compatible because use different .data in mt8186.
>
> Signed-off-by: Xinlei Lee <xinlei.lee@mediatek.com>
> ---
> drivers/gpu/drm/mediatek/mtk_dpi.c | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c
> b/drivers/gpu/drm/mediatek/mtk_dpi.c
> index 4554e2de1430..824d7da41c6a 100644
> --- a/drivers/gpu/drm/mediatek/mtk_dpi.c
> +++ b/drivers/gpu/drm/mediatek/mtk_dpi.c
> @@ -815,6 +815,14 @@ static const struct mtk_dpi_conf mt8183_conf = {
> .num_output_fmts = ARRAY_SIZE(mt8183_output_fmts),
> };
>
> +static const struct mtk_dpi_conf mt8186_conf = {
> + .cal_factor = mt8183_calculate_factor,
> + .reg_h_fre_con = 0xe0,
> + .max_clock_khz = 150000,
> + .output_fmts = mt8183_output_fmts,
> + .num_output_fmts = ARRAY_SIZE(mt8183_output_fmts),
> +};
> +
> static const struct mtk_dpi_conf mt8192_conf = {
> .cal_factor = mt8183_calculate_factor,
> .reg_h_fre_con = 0xe0,
> @@ -942,6 +950,9 @@ static const struct of_device_id mtk_dpi_of_ids[]
> = {
> { .compatible = "mediatek,mt8183-dpi",
> .data = &mt8183_conf,
> },
> + { .compatible = "mediatek,mt8186-dpi",
> + .data = &mt8186_conf,
> + },
> { .compatible = "mediatek,mt8192-dpi",
> .data = &mt8192_conf,
> },
Reviewed-by: Rex-BC Chen <rex-bc.chen@mediatek.com>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 23+ messages in thread* Re: [PATCH v4,2/2] drm/mediatek: Add mt8186 dpi compatible to mtk_dpi.c
@ 2022-04-11 3:33 ` Rex-BC Chen
0 siblings, 0 replies; 23+ messages in thread
From: Rex-BC Chen @ 2022-04-11 3:33 UTC (permalink / raw)
To: xinlei.lee, chunkuang.hu, p.zabel, airlied, daniel, robh+dt,
matthias.bgg
Cc: devicetree, jitao.shi, linux-kernel, dri-devel,
Project_Global_Chrome_Upstream_Group, linux-mediatek,
linux-arm-kernel
On Mon, 2022-04-11 at 10:53 +0800, xinlei.lee@mediatek.com wrote:
> From: Xinlei Lee <xinlei.lee@mediatek.com>
>
> Add the compatible because use different .data in mt8186.
>
> Signed-off-by: Xinlei Lee <xinlei.lee@mediatek.com>
> ---
> drivers/gpu/drm/mediatek/mtk_dpi.c | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c
> b/drivers/gpu/drm/mediatek/mtk_dpi.c
> index 4554e2de1430..824d7da41c6a 100644
> --- a/drivers/gpu/drm/mediatek/mtk_dpi.c
> +++ b/drivers/gpu/drm/mediatek/mtk_dpi.c
> @@ -815,6 +815,14 @@ static const struct mtk_dpi_conf mt8183_conf = {
> .num_output_fmts = ARRAY_SIZE(mt8183_output_fmts),
> };
>
> +static const struct mtk_dpi_conf mt8186_conf = {
> + .cal_factor = mt8183_calculate_factor,
> + .reg_h_fre_con = 0xe0,
> + .max_clock_khz = 150000,
> + .output_fmts = mt8183_output_fmts,
> + .num_output_fmts = ARRAY_SIZE(mt8183_output_fmts),
> +};
> +
> static const struct mtk_dpi_conf mt8192_conf = {
> .cal_factor = mt8183_calculate_factor,
> .reg_h_fre_con = 0xe0,
> @@ -942,6 +950,9 @@ static const struct of_device_id mtk_dpi_of_ids[]
> = {
> { .compatible = "mediatek,mt8183-dpi",
> .data = &mt8183_conf,
> },
> + { .compatible = "mediatek,mt8186-dpi",
> + .data = &mt8186_conf,
> + },
> { .compatible = "mediatek,mt8192-dpi",
> .data = &mt8192_conf,
> },
Reviewed-by: Rex-BC Chen <rex-bc.chen@mediatek.com>
^ permalink raw reply [flat|nested] 23+ messages in thread* Re: [PATCH v4,2/2] drm/mediatek: Add mt8186 dpi compatible to mtk_dpi.c
@ 2022-04-11 3:33 ` Rex-BC Chen
0 siblings, 0 replies; 23+ messages in thread
From: Rex-BC Chen @ 2022-04-11 3:33 UTC (permalink / raw)
To: xinlei.lee, chunkuang.hu, p.zabel, airlied, daniel, robh+dt,
matthias.bgg
Cc: dri-devel, linux-mediatek, devicetree, linux-kernel,
linux-arm-kernel, jitao.shi,
Project_Global_Chrome_Upstream_Group
On Mon, 2022-04-11 at 10:53 +0800, xinlei.lee@mediatek.com wrote:
> From: Xinlei Lee <xinlei.lee@mediatek.com>
>
> Add the compatible because use different .data in mt8186.
>
> Signed-off-by: Xinlei Lee <xinlei.lee@mediatek.com>
> ---
> drivers/gpu/drm/mediatek/mtk_dpi.c | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c
> b/drivers/gpu/drm/mediatek/mtk_dpi.c
> index 4554e2de1430..824d7da41c6a 100644
> --- a/drivers/gpu/drm/mediatek/mtk_dpi.c
> +++ b/drivers/gpu/drm/mediatek/mtk_dpi.c
> @@ -815,6 +815,14 @@ static const struct mtk_dpi_conf mt8183_conf = {
> .num_output_fmts = ARRAY_SIZE(mt8183_output_fmts),
> };
>
> +static const struct mtk_dpi_conf mt8186_conf = {
> + .cal_factor = mt8183_calculate_factor,
> + .reg_h_fre_con = 0xe0,
> + .max_clock_khz = 150000,
> + .output_fmts = mt8183_output_fmts,
> + .num_output_fmts = ARRAY_SIZE(mt8183_output_fmts),
> +};
> +
> static const struct mtk_dpi_conf mt8192_conf = {
> .cal_factor = mt8183_calculate_factor,
> .reg_h_fre_con = 0xe0,
> @@ -942,6 +950,9 @@ static const struct of_device_id mtk_dpi_of_ids[]
> = {
> { .compatible = "mediatek,mt8183-dpi",
> .data = &mt8183_conf,
> },
> + { .compatible = "mediatek,mt8186-dpi",
> + .data = &mt8186_conf,
> + },
> { .compatible = "mediatek,mt8192-dpi",
> .data = &mt8192_conf,
> },
Reviewed-by: Rex-BC Chen <rex-bc.chen@mediatek.com>
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH v4,2/2] drm/mediatek: Add mt8186 dpi compatible to mtk_dpi.c
2022-04-11 2:53 ` xinlei.lee
(?)
(?)
@ 2022-04-12 8:20 ` CK Hu
-1 siblings, 0 replies; 23+ messages in thread
From: CK Hu @ 2022-04-12 8:20 UTC (permalink / raw)
To: xinlei.lee, chunkuang.hu, p.zabel, airlied, daniel, robh+dt,
matthias.bgg
Cc: devicetree, jitao.shi, linux-kernel, dri-devel,
Project_Global_Chrome_Upstream_Group, linux-mediatek,
rex-bc.chen, linux-arm-kernel
Hi, Xinlei:
On Mon, 2022-04-11 at 10:53 +0800, xinlei.lee@mediatek.com wrote:
> From: Xinlei Lee <xinlei.lee@mediatek.com>
>
> Add the compatible because use different .data in mt8186.
>
> Signed-off-by: Xinlei Lee <xinlei.lee@mediatek.com>
> ---
> drivers/gpu/drm/mediatek/mtk_dpi.c | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c
> b/drivers/gpu/drm/mediatek/mtk_dpi.c
> index 4554e2de1430..824d7da41c6a 100644
> --- a/drivers/gpu/drm/mediatek/mtk_dpi.c
> +++ b/drivers/gpu/drm/mediatek/mtk_dpi.c
> @@ -815,6 +815,14 @@ static const struct mtk_dpi_conf mt8183_conf = {
> .num_output_fmts = ARRAY_SIZE(mt8183_output_fmts),
> };
>
> +static const struct mtk_dpi_conf mt8186_conf = {
> + .cal_factor = mt8183_calculate_factor,
> + .reg_h_fre_con = 0xe0,
> + .max_clock_khz = 150000,
> + .output_fmts = mt8183_output_fmts,
> + .num_output_fmts = ARRAY_SIZE(mt8183_output_fmts),
> +};
> +
> static const struct mtk_dpi_conf mt8192_conf = {
> .cal_factor = mt8183_calculate_factor,
> .reg_h_fre_con = 0xe0,
> @@ -942,6 +950,9 @@ static const struct of_device_id mtk_dpi_of_ids[]
> = {
> { .compatible = "mediatek,mt8183-dpi",
> .data = &mt8183_conf,
> },
> + { .compatible = "mediatek,mt8186-dpi",
> + .data = &mt8186_conf,
If Nicolas' patch [1] is correct, this should be
.data = &mt8192_conf,
Could you help to comfirm patch [1] is correct or not?
[1]
https://patchwork.kernel.org/project/linux-mediatek/patch/20220408013950.674477-1-nfraprado@collabora.com/
Regards,
CK
> + },
> { .compatible = "mediatek,mt8192-dpi",
> .data = &mt8192_conf,
> },
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 23+ messages in thread* Re: [PATCH v4,2/2] drm/mediatek: Add mt8186 dpi compatible to mtk_dpi.c
@ 2022-04-12 8:20 ` CK Hu
0 siblings, 0 replies; 23+ messages in thread
From: CK Hu @ 2022-04-12 8:20 UTC (permalink / raw)
To: xinlei.lee, chunkuang.hu, p.zabel, airlied, daniel, robh+dt,
matthias.bgg
Cc: devicetree, jitao.shi, linux-kernel, dri-devel,
Project_Global_Chrome_Upstream_Group, linux-mediatek,
rex-bc.chen, linux-arm-kernel
Hi, Xinlei:
On Mon, 2022-04-11 at 10:53 +0800, xinlei.lee@mediatek.com wrote:
> From: Xinlei Lee <xinlei.lee@mediatek.com>
>
> Add the compatible because use different .data in mt8186.
>
> Signed-off-by: Xinlei Lee <xinlei.lee@mediatek.com>
> ---
> drivers/gpu/drm/mediatek/mtk_dpi.c | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c
> b/drivers/gpu/drm/mediatek/mtk_dpi.c
> index 4554e2de1430..824d7da41c6a 100644
> --- a/drivers/gpu/drm/mediatek/mtk_dpi.c
> +++ b/drivers/gpu/drm/mediatek/mtk_dpi.c
> @@ -815,6 +815,14 @@ static const struct mtk_dpi_conf mt8183_conf = {
> .num_output_fmts = ARRAY_SIZE(mt8183_output_fmts),
> };
>
> +static const struct mtk_dpi_conf mt8186_conf = {
> + .cal_factor = mt8183_calculate_factor,
> + .reg_h_fre_con = 0xe0,
> + .max_clock_khz = 150000,
> + .output_fmts = mt8183_output_fmts,
> + .num_output_fmts = ARRAY_SIZE(mt8183_output_fmts),
> +};
> +
> static const struct mtk_dpi_conf mt8192_conf = {
> .cal_factor = mt8183_calculate_factor,
> .reg_h_fre_con = 0xe0,
> @@ -942,6 +950,9 @@ static const struct of_device_id mtk_dpi_of_ids[]
> = {
> { .compatible = "mediatek,mt8183-dpi",
> .data = &mt8183_conf,
> },
> + { .compatible = "mediatek,mt8186-dpi",
> + .data = &mt8186_conf,
If Nicolas' patch [1] is correct, this should be
.data = &mt8192_conf,
Could you help to comfirm patch [1] is correct or not?
[1]
https://patchwork.kernel.org/project/linux-mediatek/patch/20220408013950.674477-1-nfraprado@collabora.com/
Regards,
CK
> + },
> { .compatible = "mediatek,mt8192-dpi",
> .data = &mt8192_conf,
> },
^ permalink raw reply [flat|nested] 23+ messages in thread* Re: [PATCH v4,2/2] drm/mediatek: Add mt8186 dpi compatible to mtk_dpi.c
@ 2022-04-12 8:20 ` CK Hu
0 siblings, 0 replies; 23+ messages in thread
From: CK Hu @ 2022-04-12 8:20 UTC (permalink / raw)
To: xinlei.lee, chunkuang.hu, p.zabel, airlied, daniel, robh+dt,
matthias.bgg
Cc: devicetree, jitao.shi, linux-kernel, dri-devel,
Project_Global_Chrome_Upstream_Group, linux-mediatek,
rex-bc.chen, linux-arm-kernel
Hi, Xinlei:
On Mon, 2022-04-11 at 10:53 +0800, xinlei.lee@mediatek.com wrote:
> From: Xinlei Lee <xinlei.lee@mediatek.com>
>
> Add the compatible because use different .data in mt8186.
>
> Signed-off-by: Xinlei Lee <xinlei.lee@mediatek.com>
> ---
> drivers/gpu/drm/mediatek/mtk_dpi.c | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c
> b/drivers/gpu/drm/mediatek/mtk_dpi.c
> index 4554e2de1430..824d7da41c6a 100644
> --- a/drivers/gpu/drm/mediatek/mtk_dpi.c
> +++ b/drivers/gpu/drm/mediatek/mtk_dpi.c
> @@ -815,6 +815,14 @@ static const struct mtk_dpi_conf mt8183_conf = {
> .num_output_fmts = ARRAY_SIZE(mt8183_output_fmts),
> };
>
> +static const struct mtk_dpi_conf mt8186_conf = {
> + .cal_factor = mt8183_calculate_factor,
> + .reg_h_fre_con = 0xe0,
> + .max_clock_khz = 150000,
> + .output_fmts = mt8183_output_fmts,
> + .num_output_fmts = ARRAY_SIZE(mt8183_output_fmts),
> +};
> +
> static const struct mtk_dpi_conf mt8192_conf = {
> .cal_factor = mt8183_calculate_factor,
> .reg_h_fre_con = 0xe0,
> @@ -942,6 +950,9 @@ static const struct of_device_id mtk_dpi_of_ids[]
> = {
> { .compatible = "mediatek,mt8183-dpi",
> .data = &mt8183_conf,
> },
> + { .compatible = "mediatek,mt8186-dpi",
> + .data = &mt8186_conf,
If Nicolas' patch [1] is correct, this should be
.data = &mt8192_conf,
Could you help to comfirm patch [1] is correct or not?
[1]
https://patchwork.kernel.org/project/linux-mediatek/patch/20220408013950.674477-1-nfraprado@collabora.com/
Regards,
CK
> + },
> { .compatible = "mediatek,mt8192-dpi",
> .data = &mt8192_conf,
> },
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 23+ messages in thread* Re: [PATCH v4,2/2] drm/mediatek: Add mt8186 dpi compatible to mtk_dpi.c
@ 2022-04-12 8:20 ` CK Hu
0 siblings, 0 replies; 23+ messages in thread
From: CK Hu @ 2022-04-12 8:20 UTC (permalink / raw)
To: xinlei.lee, chunkuang.hu, p.zabel, airlied, daniel, robh+dt,
matthias.bgg
Cc: devicetree, jitao.shi, linux-kernel, dri-devel,
Project_Global_Chrome_Upstream_Group, linux-mediatek,
rex-bc.chen, linux-arm-kernel
Hi, Xinlei:
On Mon, 2022-04-11 at 10:53 +0800, xinlei.lee@mediatek.com wrote:
> From: Xinlei Lee <xinlei.lee@mediatek.com>
>
> Add the compatible because use different .data in mt8186.
>
> Signed-off-by: Xinlei Lee <xinlei.lee@mediatek.com>
> ---
> drivers/gpu/drm/mediatek/mtk_dpi.c | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c
> b/drivers/gpu/drm/mediatek/mtk_dpi.c
> index 4554e2de1430..824d7da41c6a 100644
> --- a/drivers/gpu/drm/mediatek/mtk_dpi.c
> +++ b/drivers/gpu/drm/mediatek/mtk_dpi.c
> @@ -815,6 +815,14 @@ static const struct mtk_dpi_conf mt8183_conf = {
> .num_output_fmts = ARRAY_SIZE(mt8183_output_fmts),
> };
>
> +static const struct mtk_dpi_conf mt8186_conf = {
> + .cal_factor = mt8183_calculate_factor,
> + .reg_h_fre_con = 0xe0,
> + .max_clock_khz = 150000,
> + .output_fmts = mt8183_output_fmts,
> + .num_output_fmts = ARRAY_SIZE(mt8183_output_fmts),
> +};
> +
> static const struct mtk_dpi_conf mt8192_conf = {
> .cal_factor = mt8183_calculate_factor,
> .reg_h_fre_con = 0xe0,
> @@ -942,6 +950,9 @@ static const struct of_device_id mtk_dpi_of_ids[]
> = {
> { .compatible = "mediatek,mt8183-dpi",
> .data = &mt8183_conf,
> },
> + { .compatible = "mediatek,mt8186-dpi",
> + .data = &mt8186_conf,
If Nicolas' patch [1] is correct, this should be
.data = &mt8192_conf,
Could you help to comfirm patch [1] is correct or not?
[1]
https://patchwork.kernel.org/project/linux-mediatek/patch/20220408013950.674477-1-nfraprado@collabora.com/
Regards,
CK
> + },
> { .compatible = "mediatek,mt8192-dpi",
> .data = &mt8192_conf,
> },
^ permalink raw reply [flat|nested] 23+ messages in thread* Re: [PATCH v4,2/2] drm/mediatek: Add mt8186 dpi compatible to mtk_dpi.c
2022-04-12 8:20 ` CK Hu
(?)
@ 2022-04-12 12:56 ` xinlei.lee
-1 siblings, 0 replies; 23+ messages in thread
From: xinlei.lee @ 2022-04-12 12:56 UTC (permalink / raw)
To: CK Hu, chunkuang.hu, p.zabel, airlied, daniel, robh+dt, matthias.bgg
Cc: devicetree, jitao.shi, linux-kernel, dri-devel,
Project_Global_Chrome_Upstream_Group, linux-mediatek,
rex-bc.chen, linux-arm-kernel
On Tue, 2022-04-12 at 16:20 +0800, CK Hu wrote:
> Hi, Xinlei:
>
> On Mon, 2022-04-11 at 10:53 +0800, xinlei.lee@mediatek.com wrote:
> > From: Xinlei Lee <xinlei.lee@mediatek.com>
> >
> > Add the compatible because use different .data in mt8186.
> >
> > Signed-off-by: Xinlei Lee <xinlei.lee@mediatek.com>
> > ---
> > drivers/gpu/drm/mediatek/mtk_dpi.c | 11 +++++++++++
> > 1 file changed, 11 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c
> > b/drivers/gpu/drm/mediatek/mtk_dpi.c
> > index 4554e2de1430..824d7da41c6a 100644
> > --- a/drivers/gpu/drm/mediatek/mtk_dpi.c
> > +++ b/drivers/gpu/drm/mediatek/mtk_dpi.c
> > @@ -815,6 +815,14 @@ static const struct mtk_dpi_conf mt8183_conf =
> > {
> > .num_output_fmts = ARRAY_SIZE(mt8183_output_fmts),
> > };
> >
> > +static const struct mtk_dpi_conf mt8186_conf = {
> > + .cal_factor = mt8183_calculate_factor,
> > + .reg_h_fre_con = 0xe0,
> > + .max_clock_khz = 150000,
> > + .output_fmts = mt8183_output_fmts,
> > + .num_output_fmts = ARRAY_SIZE(mt8183_output_fmts),
> > +};
> > +
> > static const struct mtk_dpi_conf mt8192_conf = {
> > .cal_factor = mt8183_calculate_factor,
> > .reg_h_fre_con = 0xe0,
> > @@ -942,6 +950,9 @@ static const struct of_device_id
> > mtk_dpi_of_ids[]
> > = {
> > { .compatible = "mediatek,mt8183-dpi",
> > .data = &mt8183_conf,
> > },
> > + { .compatible = "mediatek,mt8186-dpi",
> > + .data = &mt8186_conf,
>
> If Nicolas' patch [1] is correct, this should be
>
> .data = &mt8192_conf,
>
> Could you help to comfirm patch [1] is correct or not?
>
> [1]
>
https://patchwork.kernel.org/project/linux-mediatek/patch/20220408013950.674477-1-nfraprado@collabora.com/
>
> Regards,
> CK
>
> > + },
> > { .compatible = "mediatek,mt8192-dpi",
> > .data = &mt8192_conf,
> > },
>
>
Hi CK:
Thanks for your review.
I checked that mt8186_conf & mt8192_conf are the same.
In the next version, I will remove mt8186_conf and reuse mt8192_conf.
Best Regards!
xinlei
^ permalink raw reply [flat|nested] 23+ messages in thread* Re: [PATCH v4,2/2] drm/mediatek: Add mt8186 dpi compatible to mtk_dpi.c
@ 2022-04-12 12:56 ` xinlei.lee
0 siblings, 0 replies; 23+ messages in thread
From: xinlei.lee @ 2022-04-12 12:56 UTC (permalink / raw)
To: CK Hu, chunkuang.hu, p.zabel, airlied, daniel, robh+dt, matthias.bgg
Cc: devicetree, jitao.shi, linux-kernel, dri-devel,
Project_Global_Chrome_Upstream_Group, linux-mediatek,
rex-bc.chen, linux-arm-kernel
On Tue, 2022-04-12 at 16:20 +0800, CK Hu wrote:
> Hi, Xinlei:
>
> On Mon, 2022-04-11 at 10:53 +0800, xinlei.lee@mediatek.com wrote:
> > From: Xinlei Lee <xinlei.lee@mediatek.com>
> >
> > Add the compatible because use different .data in mt8186.
> >
> > Signed-off-by: Xinlei Lee <xinlei.lee@mediatek.com>
> > ---
> > drivers/gpu/drm/mediatek/mtk_dpi.c | 11 +++++++++++
> > 1 file changed, 11 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c
> > b/drivers/gpu/drm/mediatek/mtk_dpi.c
> > index 4554e2de1430..824d7da41c6a 100644
> > --- a/drivers/gpu/drm/mediatek/mtk_dpi.c
> > +++ b/drivers/gpu/drm/mediatek/mtk_dpi.c
> > @@ -815,6 +815,14 @@ static const struct mtk_dpi_conf mt8183_conf =
> > {
> > .num_output_fmts = ARRAY_SIZE(mt8183_output_fmts),
> > };
> >
> > +static const struct mtk_dpi_conf mt8186_conf = {
> > + .cal_factor = mt8183_calculate_factor,
> > + .reg_h_fre_con = 0xe0,
> > + .max_clock_khz = 150000,
> > + .output_fmts = mt8183_output_fmts,
> > + .num_output_fmts = ARRAY_SIZE(mt8183_output_fmts),
> > +};
> > +
> > static const struct mtk_dpi_conf mt8192_conf = {
> > .cal_factor = mt8183_calculate_factor,
> > .reg_h_fre_con = 0xe0,
> > @@ -942,6 +950,9 @@ static const struct of_device_id
> > mtk_dpi_of_ids[]
> > = {
> > { .compatible = "mediatek,mt8183-dpi",
> > .data = &mt8183_conf,
> > },
> > + { .compatible = "mediatek,mt8186-dpi",
> > + .data = &mt8186_conf,
>
> If Nicolas' patch [1] is correct, this should be
>
> .data = &mt8192_conf,
>
> Could you help to comfirm patch [1] is correct or not?
>
> [1]
>
https://patchwork.kernel.org/project/linux-mediatek/patch/20220408013950.674477-1-nfraprado@collabora.com/
>
> Regards,
> CK
>
> > + },
> > { .compatible = "mediatek,mt8192-dpi",
> > .data = &mt8192_conf,
> > },
>
>
Hi CK:
Thanks for your review.
I checked that mt8186_conf & mt8192_conf are the same.
In the next version, I will remove mt8186_conf and reuse mt8192_conf.
Best Regards!
xinlei
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 23+ messages in thread* Re: [PATCH v4,2/2] drm/mediatek: Add mt8186 dpi compatible to mtk_dpi.c
@ 2022-04-12 12:56 ` xinlei.lee
0 siblings, 0 replies; 23+ messages in thread
From: xinlei.lee @ 2022-04-12 12:56 UTC (permalink / raw)
To: CK Hu, chunkuang.hu, p.zabel, airlied, daniel, robh+dt, matthias.bgg
Cc: devicetree, jitao.shi, linux-kernel, dri-devel,
Project_Global_Chrome_Upstream_Group, linux-mediatek,
rex-bc.chen, linux-arm-kernel
On Tue, 2022-04-12 at 16:20 +0800, CK Hu wrote:
> Hi, Xinlei:
>
> On Mon, 2022-04-11 at 10:53 +0800, xinlei.lee@mediatek.com wrote:
> > From: Xinlei Lee <xinlei.lee@mediatek.com>
> >
> > Add the compatible because use different .data in mt8186.
> >
> > Signed-off-by: Xinlei Lee <xinlei.lee@mediatek.com>
> > ---
> > drivers/gpu/drm/mediatek/mtk_dpi.c | 11 +++++++++++
> > 1 file changed, 11 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c
> > b/drivers/gpu/drm/mediatek/mtk_dpi.c
> > index 4554e2de1430..824d7da41c6a 100644
> > --- a/drivers/gpu/drm/mediatek/mtk_dpi.c
> > +++ b/drivers/gpu/drm/mediatek/mtk_dpi.c
> > @@ -815,6 +815,14 @@ static const struct mtk_dpi_conf mt8183_conf =
> > {
> > .num_output_fmts = ARRAY_SIZE(mt8183_output_fmts),
> > };
> >
> > +static const struct mtk_dpi_conf mt8186_conf = {
> > + .cal_factor = mt8183_calculate_factor,
> > + .reg_h_fre_con = 0xe0,
> > + .max_clock_khz = 150000,
> > + .output_fmts = mt8183_output_fmts,
> > + .num_output_fmts = ARRAY_SIZE(mt8183_output_fmts),
> > +};
> > +
> > static const struct mtk_dpi_conf mt8192_conf = {
> > .cal_factor = mt8183_calculate_factor,
> > .reg_h_fre_con = 0xe0,
> > @@ -942,6 +950,9 @@ static const struct of_device_id
> > mtk_dpi_of_ids[]
> > = {
> > { .compatible = "mediatek,mt8183-dpi",
> > .data = &mt8183_conf,
> > },
> > + { .compatible = "mediatek,mt8186-dpi",
> > + .data = &mt8186_conf,
>
> If Nicolas' patch [1] is correct, this should be
>
> .data = &mt8192_conf,
>
> Could you help to comfirm patch [1] is correct or not?
>
> [1]
>
https://patchwork.kernel.org/project/linux-mediatek/patch/20220408013950.674477-1-nfraprado@collabora.com/
>
> Regards,
> CK
>
> > + },
> > { .compatible = "mediatek,mt8192-dpi",
> > .data = &mt8192_conf,
> > },
>
>
Hi CK:
Thanks for your review.
I checked that mt8186_conf & mt8192_conf are the same.
In the next version, I will remove mt8186_conf and reuse mt8192_conf.
Best Regards!
xinlei
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 23+ messages in thread