* [PATCH v2 0/2] rtw88: 8821ce: add support for device ID 0xb821
@ 2022-04-07 7:51 Jimmy Hon
2022-04-07 7:51 ` [PATCH 1/2] " Jimmy Hon
2022-04-07 7:51 ` [PATCH 2/2] rtw88: 8821ce: Disable PCIe ASPM L1 for 8821CE using chip ID Jimmy Hon
0 siblings, 2 replies; 6+ messages in thread
From: Jimmy Hon @ 2022-04-07 7:51 UTC (permalink / raw)
To: tony0620emma; +Cc: linux-wireless, Jimmy Hon
Jimmy Hon (2):
rtw88: 8821ce: add support for device ID 0xb821
rtw88: 8821ce: Disable PCIe ASPM L1 for 8821CE using chip ID
drivers/net/wireless/realtek/rtw88/pci.c | 2 +-
drivers/net/wireless/realtek/rtw88/rtw8821ce.c | 4 ++++
2 files changed, 5 insertions(+), 1 deletion(-)
--
2.35.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 1/2] rtw88: 8821ce: add support for device ID 0xb821
2022-04-07 7:51 [PATCH v2 0/2] rtw88: 8821ce: add support for device ID 0xb821 Jimmy Hon
@ 2022-04-07 7:51 ` Jimmy Hon
2022-04-07 9:35 ` Pkshih
2022-04-12 13:53 ` Kalle Valo
2022-04-07 7:51 ` [PATCH 2/2] rtw88: 8821ce: Disable PCIe ASPM L1 for 8821CE using chip ID Jimmy Hon
1 sibling, 2 replies; 6+ messages in thread
From: Jimmy Hon @ 2022-04-07 7:51 UTC (permalink / raw)
To: tony0620emma; +Cc: linux-wireless, Jimmy Hon
New device ID 0xb821 found on TP-Link T2E
Tested it with c821 driver. 2.4GHz and 5GHz works.
PCI id:
05:00.0 Network controller: Realtek Semiconductor Co., Ltd. Device b821
Subsystem: Realtek Semiconductor Co., Ltd. Device b821
Signed-off-by: Jimmy Hon <honyuenkwun@gmail.com>
---
drivers/net/wireless/realtek/rtw88/rtw8821ce.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/net/wireless/realtek/rtw88/rtw8821ce.c b/drivers/net/wireless/realtek/rtw88/rtw8821ce.c
index f34de115e4bc..56d22f9de904 100644
--- a/drivers/net/wireless/realtek/rtw88/rtw8821ce.c
+++ b/drivers/net/wireless/realtek/rtw88/rtw8821ce.c
@@ -8,6 +8,10 @@
#include "rtw8821ce.h"
static const struct pci_device_id rtw_8821ce_id_table[] = {
+ {
+ PCI_DEVICE(PCI_VENDOR_ID_REALTEK, 0xB821),
+ .driver_data = (kernel_ulong_t)&rtw8821c_hw_spec
+ },
{
PCI_DEVICE(PCI_VENDOR_ID_REALTEK, 0xC821),
.driver_data = (kernel_ulong_t)&rtw8821c_hw_spec
--
2.35.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 2/2] rtw88: 8821ce: Disable PCIe ASPM L1 for 8821CE using chip ID
2022-04-07 7:51 [PATCH v2 0/2] rtw88: 8821ce: add support for device ID 0xb821 Jimmy Hon
2022-04-07 7:51 ` [PATCH 1/2] " Jimmy Hon
@ 2022-04-07 7:51 ` Jimmy Hon
2022-04-07 9:35 ` Pkshih
1 sibling, 1 reply; 6+ messages in thread
From: Jimmy Hon @ 2022-04-07 7:51 UTC (permalink / raw)
To: tony0620emma; +Cc: linux-wireless, Jimmy Hon
Make workaround work for other 8821CE devices with different PCI ID
Signed-off-by: Jimmy Hon <honyuenkwun@gmail.com>
---
drivers/net/wireless/realtek/rtw88/pci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/realtek/rtw88/pci.c b/drivers/net/wireless/realtek/rtw88/pci.c
index a0991d3f15c0..0edb5711b546 100644
--- a/drivers/net/wireless/realtek/rtw88/pci.c
+++ b/drivers/net/wireless/realtek/rtw88/pci.c
@@ -1770,7 +1770,7 @@ int rtw_pci_probe(struct pci_dev *pdev,
}
/* Disable PCIe ASPM L1 while doing NAPI poll for 8821CE */
- if (pdev->device == 0xc821 && bridge->vendor == PCI_VENDOR_ID_INTEL)
+ if (rtwdev->chip->id == RTW_CHIP_TYPE_8821C && bridge->vendor == PCI_VENDOR_ID_INTEL)
rtwpci->rx_no_aspm = true;
rtw_pci_phy_cfg(rtwdev);
--
2.35.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] rtw88: 8821ce: add support for device ID 0xb821
2022-04-07 7:51 ` [PATCH 1/2] " Jimmy Hon
@ 2022-04-07 9:35 ` Pkshih
2022-04-12 13:53 ` Kalle Valo
1 sibling, 0 replies; 6+ messages in thread
From: Pkshih @ 2022-04-07 9:35 UTC (permalink / raw)
To: tony0620emma, honyuenkwun; +Cc: linux-wireless
On Thu, 2022-04-07 at 02:51 -0500, Jimmy Hon wrote:
> New device ID 0xb821 found on TP-Link T2E
> Tested it with c821 driver. 2.4GHz and 5GHz works.
>
> PCI id:
> 05:00.0 Network controller: Realtek Semiconductor Co., Ltd. Device b821
> Subsystem: Realtek Semiconductor Co., Ltd. Device b821
>
> Signed-off-by: Jimmy Hon <honyuenkwun@gmail.com>
Reviewed-by: Ping-Ke Shih <pkshih@realtek.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] rtw88: 8821ce: Disable PCIe ASPM L1 for 8821CE using chip ID
2022-04-07 7:51 ` [PATCH 2/2] rtw88: 8821ce: Disable PCIe ASPM L1 for 8821CE using chip ID Jimmy Hon
@ 2022-04-07 9:35 ` Pkshih
0 siblings, 0 replies; 6+ messages in thread
From: Pkshih @ 2022-04-07 9:35 UTC (permalink / raw)
To: tony0620emma, honyuenkwun; +Cc: linux-wireless
On Thu, 2022-04-07 at 02:51 -0500, Jimmy Hon wrote:
> Make workaround work for other 8821CE devices with different PCI ID
>
> Signed-off-by: Jimmy Hon <honyuenkwun@gmail.com>
Reviewed-by: Ping-Ke Shih <pkshih@realtek.com>
> ---
> drivers/net/wireless/realtek/rtw88/pci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/realtek/rtw88/pci.c b/drivers/net/wireless/realtek/rtw88/pci.c
> index a0991d3f15c0..0edb5711b546 100644
> --- a/drivers/net/wireless/realtek/rtw88/pci.c
> +++ b/drivers/net/wireless/realtek/rtw88/pci.c
> @@ -1770,7 +1770,7 @@ int rtw_pci_probe(struct pci_dev *pdev,
> }
>
> /* Disable PCIe ASPM L1 while doing NAPI poll for 8821CE */
> - if (pdev->device == 0xc821 && bridge->vendor == PCI_VENDOR_ID_INTEL)
> + if (rtwdev->chip->id == RTW_CHIP_TYPE_8821C && bridge->vendor == PCI_VENDOR_ID_INTEL)
> rtwpci->rx_no_aspm = true;
>
> rtw_pci_phy_cfg(rtwdev);
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] rtw88: 8821ce: add support for device ID 0xb821
2022-04-07 7:51 ` [PATCH 1/2] " Jimmy Hon
2022-04-07 9:35 ` Pkshih
@ 2022-04-12 13:53 ` Kalle Valo
1 sibling, 0 replies; 6+ messages in thread
From: Kalle Valo @ 2022-04-12 13:53 UTC (permalink / raw)
To: Jimmy Hon; +Cc: tony0620emma, linux-wireless, Jimmy Hon
Jimmy Hon <honyuenkwun@gmail.com> wrote:
> New device ID 0xb821 found on TP-Link T2E
> Tested it with c821 driver. 2.4GHz and 5GHz works.
>
> PCI id:
> 05:00.0 Network controller: Realtek Semiconductor Co., Ltd. Device b821
> Subsystem: Realtek Semiconductor Co., Ltd. Device b821
>
> Signed-off-by: Jimmy Hon <honyuenkwun@gmail.com>
> Reviewed-by: Ping-Ke Shih <pkshih@realtek.com>
2 patches applied to wireless-next.git, thanks.
d5286826201e rtw88: 8821ce: add support for device ID 0xb821
b9eb5f0742d1 rtw88: 8821ce: Disable PCIe ASPM L1 for 8821CE using chip ID
--
https://patchwork.kernel.org/project/linux-wireless/patch/20220407075123.420696-2-honyuenkwun@gmail.com/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-04-12 13:53 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-07 7:51 [PATCH v2 0/2] rtw88: 8821ce: add support for device ID 0xb821 Jimmy Hon
2022-04-07 7:51 ` [PATCH 1/2] " Jimmy Hon
2022-04-07 9:35 ` Pkshih
2022-04-12 13:53 ` Kalle Valo
2022-04-07 7:51 ` [PATCH 2/2] rtw88: 8821ce: Disable PCIe ASPM L1 for 8821CE using chip ID Jimmy Hon
2022-04-07 9:35 ` Pkshih
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.