* [PATCH] clk: renesas: Fix memory leak of 'cpg'
@ 2022-04-13 7:55 Haowen Bai
0 siblings, 0 replies; 7+ messages in thread
From: Haowen Bai @ 2022-04-13 7:55 UTC (permalink / raw)
To: Geert Uytterhoeven, Michael Turquette, Stephen Boyd
Cc: Haowen Bai, linux-renesas-soc, linux-clk, linux-kernel
Fix this issue by freeing the cpg when exiting the function in the
error/normal path.
Signed-off-by: Haowen Bai <baihaowen@meizu.com>
---
drivers/clk/renesas/clk-r8a7740.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/clk/renesas/clk-r8a7740.c b/drivers/clk/renesas/clk-r8a7740.c
index d8190f007a81..f3ddae554fcd 100644
--- a/drivers/clk/renesas/clk-r8a7740.c
+++ b/drivers/clk/renesas/clk-r8a7740.c
@@ -174,7 +174,7 @@ static void __init r8a7740_cpg_clocks_init(struct device_node *np)
cpg->reg = of_iomap(np, 0);
if (WARN_ON(cpg->reg == NULL))
- return;
+ goto out_free_cpg;
for (i = 0; i < num_clks; ++i) {
const char *name;
@@ -192,6 +192,8 @@ static void __init r8a7740_cpg_clocks_init(struct device_node *np)
}
of_clk_add_provider(np, of_clk_src_onecell_get, &cpg->data);
+out_free_cpg:
+ kfree(cpg);
}
CLK_OF_DECLARE(r8a7740_cpg_clks, "renesas,r8a7740-cpg-clocks",
r8a7740_cpg_clocks_init);
--
2.7.4
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH] clk: renesas: Fix memory leak of 'cpg'
@ 2022-04-13 8:27 Haowen Bai
0 siblings, 0 replies; 7+ messages in thread
From: Haowen Bai @ 2022-04-13 8:27 UTC (permalink / raw)
To: Geert Uytterhoeven, Michael Turquette, Stephen Boyd
Cc: Haowen Bai, linux-renesas-soc, linux-clk, linux-kernel
Fix this issue by freeing the cpg when exiting the function in the
error/normal path.
Signed-off-by: Haowen Bai <baihaowen@meizu.com>
---
drivers/clk/renesas/clk-r8a73a4.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/clk/renesas/clk-r8a73a4.c b/drivers/clk/renesas/clk-r8a73a4.c
index cfed11c659d9..5a8d976f49e0 100644
--- a/drivers/clk/renesas/clk-r8a73a4.c
+++ b/drivers/clk/renesas/clk-r8a73a4.c
@@ -215,7 +215,7 @@ static void __init r8a73a4_cpg_clocks_init(struct device_node *np)
cpg->reg = of_iomap(np, 0);
if (WARN_ON(cpg->reg == NULL))
- return;
+ goto out_free_cpg;
for (i = 0; i < num_clks; ++i) {
const char *name;
@@ -233,6 +233,9 @@ static void __init r8a73a4_cpg_clocks_init(struct device_node *np)
}
of_clk_add_provider(np, of_clk_src_onecell_get, &cpg->data);
+out_free_cpg:
+ kfree(cpg);
+ kfree(clks);
}
CLK_OF_DECLARE(r8a73a4_cpg_clks, "renesas,r8a73a4-cpg-clocks",
r8a73a4_cpg_clocks_init);
--
2.7.4
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH] clk: renesas: Fix memory leak of 'cpg'
@ 2022-04-13 8:22 Haowen Bai
0 siblings, 0 replies; 7+ messages in thread
From: Haowen Bai @ 2022-04-13 8:22 UTC (permalink / raw)
To: Geert Uytterhoeven, Michael Turquette, Stephen Boyd
Cc: Haowen Bai, linux-renesas-soc, linux-clk, linux-kernel
Fix this issue by freeing the cpg when exiting the function in the
error/normal path.
Signed-off-by: Haowen Bai <baihaowen@meizu.com>
---
drivers/clk/renesas/clk-r8a73a4.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/clk/renesas/clk-r8a73a4.c b/drivers/clk/renesas/clk-r8a73a4.c
index cfed11c659d9..5a8d976f49e0 100644
--- a/drivers/clk/renesas/clk-r8a73a4.c
+++ b/drivers/clk/renesas/clk-r8a73a4.c
@@ -215,7 +215,7 @@ static void __init r8a73a4_cpg_clocks_init(struct device_node *np)
cpg->reg = of_iomap(np, 0);
if (WARN_ON(cpg->reg == NULL))
- return;
+ goto out_free_cpg;
for (i = 0; i < num_clks; ++i) {
const char *name;
@@ -233,6 +233,9 @@ static void __init r8a73a4_cpg_clocks_init(struct device_node *np)
}
of_clk_add_provider(np, of_clk_src_onecell_get, &cpg->data);
+out_free_cpg:
+ kfree(cpg);
+ kfree(clks);
}
CLK_OF_DECLARE(r8a73a4_cpg_clks, "renesas,r8a73a4-cpg-clocks",
r8a73a4_cpg_clocks_init);
--
2.7.4
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH] clk: renesas: Fix memory leak of 'cpg'
@ 2022-04-13 8:06 Haowen Bai
0 siblings, 0 replies; 7+ messages in thread
From: Haowen Bai @ 2022-04-13 8:06 UTC (permalink / raw)
To: Geert Uytterhoeven, Michael Turquette, Stephen Boyd
Cc: Haowen Bai, linux-renesas-soc, linux-clk, linux-kernel
Fix this issue by freeing the cpg when exiting the function in the
error/normal path.
Signed-off-by: Haowen Bai <baihaowen@meizu.com>
---
drivers/clk/renesas/clk-r8a7779.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/clk/renesas/clk-r8a7779.c b/drivers/clk/renesas/clk-r8a7779.c
index 9f3b5522eef5..dd7c67f522fd 100644
--- a/drivers/clk/renesas/clk-r8a7779.c
+++ b/drivers/clk/renesas/clk-r8a7779.c
@@ -170,6 +170,9 @@ static void __init r8a7779_cpg_clocks_init(struct device_node *np)
of_clk_add_provider(np, of_clk_src_onecell_get, &cpg->data);
cpg_mstp_add_clk_domain(np);
+
+ kfree(cpg);
+ kfree(clks);
}
CLK_OF_DECLARE(r8a7779_cpg_clks, "renesas,r8a7779-cpg-clocks",
r8a7779_cpg_clocks_init);
--
2.7.4
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH] clk: renesas: Fix memory leak of 'cpg'
@ 2022-04-13 7:57 Haowen Bai
0 siblings, 0 replies; 7+ messages in thread
From: Haowen Bai @ 2022-04-13 7:57 UTC (permalink / raw)
To: Geert Uytterhoeven, Michael Turquette, Stephen Boyd
Cc: Haowen Bai, linux-renesas-soc, linux-clk, linux-kernel
Fix this issue by freeing the cpg when exiting the function in the
error/normal path.
Signed-off-by: Haowen Bai <baihaowen@meizu.com>
---
drivers/clk/renesas/clk-r8a7778.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/clk/renesas/clk-r8a7778.c b/drivers/clk/renesas/clk-r8a7778.c
index 3ccc53685bdd..ad2c080402c1 100644
--- a/drivers/clk/renesas/clk-r8a7778.c
+++ b/drivers/clk/renesas/clk-r8a7778.c
@@ -116,7 +116,7 @@ static void __init r8a7778_cpg_clocks_init(struct device_node *np)
cpg->reg = of_iomap(np, 0);
if (WARN_ON(cpg->reg == NULL))
- return;
+ goto out_free_cpg;
for (i = 0; i < num_clks; ++i) {
const char *name;
@@ -136,6 +136,8 @@ static void __init r8a7778_cpg_clocks_init(struct device_node *np)
of_clk_add_provider(np, of_clk_src_onecell_get, &cpg->data);
cpg_mstp_add_clk_domain(np);
+out_free_cpg:
+ kfree(cpg);
}
CLK_OF_DECLARE(r8a7778_cpg_clks, "renesas,r8a7778-cpg-clocks",
--
2.7.4
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH] clk: renesas: Fix memory leak of 'cpg'
@ 2022-04-13 7:53 Haowen Bai
0 siblings, 0 replies; 7+ messages in thread
From: Haowen Bai @ 2022-04-13 7:53 UTC (permalink / raw)
To: Geert Uytterhoeven, Michael Turquette, Stephen Boyd
Cc: Haowen Bai, linux-renesas-soc, linux-clk, linux-kernel
Fix this issue by freeing the cpg when exiting the function in the
error/normal path.
Signed-off-by: Haowen Bai <baihaowen@meizu.com>
---
drivers/clk/renesas/clk-r8a7740.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/clk/renesas/clk-r8a7740.c b/drivers/clk/renesas/clk-r8a7740.c
index d8190f007a81..f3ddae554fcd 100644
--- a/drivers/clk/renesas/clk-r8a7740.c
+++ b/drivers/clk/renesas/clk-r8a7740.c
@@ -174,7 +174,7 @@ static void __init r8a7740_cpg_clocks_init(struct device_node *np)
cpg->reg = of_iomap(np, 0);
if (WARN_ON(cpg->reg == NULL))
- return;
+ goto out_free_cpg;
for (i = 0; i < num_clks; ++i) {
const char *name;
@@ -192,6 +192,8 @@ static void __init r8a7740_cpg_clocks_init(struct device_node *np)
}
of_clk_add_provider(np, of_clk_src_onecell_get, &cpg->data);
+out_free_cpg:
+ kfree(cpg);
}
CLK_OF_DECLARE(r8a7740_cpg_clks, "renesas,r8a7740-cpg-clocks",
r8a7740_cpg_clocks_init);
--
2.7.4
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH] clk: renesas: Fix memory leak of 'cpg'
@ 2022-04-13 7:50 Haowen Bai
0 siblings, 0 replies; 7+ messages in thread
From: Haowen Bai @ 2022-04-13 7:50 UTC (permalink / raw)
To: Geert Uytterhoeven, Michael Turquette, Stephen Boyd
Cc: Haowen Bai, linux-renesas-soc, linux-clk, linux-kernel
Fix this issue by freeing the cpg when exiting the function in the
error/normal path.
Signed-off-by: Haowen Bai <baihaowen@meizu.com>
---
drivers/clk/renesas/clk-r8a73a4.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/clk/renesas/clk-r8a73a4.c b/drivers/clk/renesas/clk-r8a73a4.c
index cfed11c659d9..6cacda1f91d8 100644
--- a/drivers/clk/renesas/clk-r8a73a4.c
+++ b/drivers/clk/renesas/clk-r8a73a4.c
@@ -215,7 +215,7 @@ static void __init r8a73a4_cpg_clocks_init(struct device_node *np)
cpg->reg = of_iomap(np, 0);
if (WARN_ON(cpg->reg == NULL))
- return;
+ goto out_free_cpg;
for (i = 0; i < num_clks; ++i) {
const char *name;
@@ -233,6 +233,8 @@ static void __init r8a73a4_cpg_clocks_init(struct device_node *np)
}
of_clk_add_provider(np, of_clk_src_onecell_get, &cpg->data);
+out_free_cpg:
+ kfree(cpg);
}
CLK_OF_DECLARE(r8a73a4_cpg_clks, "renesas,r8a73a4-cpg-clocks",
r8a73a4_cpg_clocks_init);
--
2.7.4
^ permalink raw reply related [flat|nested] 7+ messages in thread
end of thread, other threads:[~2022-04-13 8:28 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-13 7:55 [PATCH] clk: renesas: Fix memory leak of 'cpg' Haowen Bai
-- strict thread matches above, loose matches on Subject: below --
2022-04-13 8:27 Haowen Bai
2022-04-13 8:22 Haowen Bai
2022-04-13 8:06 Haowen Bai
2022-04-13 7:57 Haowen Bai
2022-04-13 7:53 Haowen Bai
2022-04-13 7:50 Haowen Bai
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.