* [PATCH] PCI/docs: Fix references to DMA set mask function
@ 2022-04-20 20:45 Alex Williamson
2022-04-21 5:35 ` Christoph Hellwig
2022-04-21 17:12 ` Bjorn Helgaas
0 siblings, 2 replies; 3+ messages in thread
From: Alex Williamson @ 2022-04-20 20:45 UTC (permalink / raw)
To: bhelgaas; +Cc: linux-pci, hch
The function is dma_set_mask(), fix a missed instance of the old
pci_set_dma_mask() and a reference to a function that doesn't exist.
Fixes: 05b0ebd06ae6 ("PCI/doc: cleanup references to the legacy PCI DMA API")
Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
---
Documentation/PCI/pci.rst | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/PCI/pci.rst b/Documentation/PCI/pci.rst
index 67a850b55617..cced568d78e9 100644
--- a/Documentation/PCI/pci.rst
+++ b/Documentation/PCI/pci.rst
@@ -273,12 +273,12 @@ Set the DMA mask size
While all drivers should explicitly indicate the DMA capability
(e.g. 32 or 64 bit) of the PCI bus master, devices with more than
32-bit bus master capability for streaming data need the driver
-to "register" this capability by calling pci_set_dma_mask() with
+to "register" this capability by calling dma_set_mask() with
appropriate parameters. In general this allows more efficient DMA
on systems where System RAM exists above 4G _physical_ address.
Drivers for all PCI-X and PCIe compliant devices must call
-set_dma_mask() as they are 64-bit DMA devices.
+dma_set_mask() as they are 64-bit DMA devices.
Similarly, drivers must also "register" this capability if the device
can directly address "coherent memory" in System RAM above 4G physical
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] PCI/docs: Fix references to DMA set mask function
2022-04-20 20:45 [PATCH] PCI/docs: Fix references to DMA set mask function Alex Williamson
@ 2022-04-21 5:35 ` Christoph Hellwig
2022-04-21 17:12 ` Bjorn Helgaas
1 sibling, 0 replies; 3+ messages in thread
From: Christoph Hellwig @ 2022-04-21 5:35 UTC (permalink / raw)
To: Alex Williamson; +Cc: bhelgaas, linux-pci, hch
On Wed, Apr 20, 2022 at 02:45:05PM -0600, Alex Williamson wrote:
> The function is dma_set_mask(), fix a missed instance of the old
> pci_set_dma_mask() and a reference to a function that doesn't exist.
Thanks, looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] PCI/docs: Fix references to DMA set mask function
2022-04-20 20:45 [PATCH] PCI/docs: Fix references to DMA set mask function Alex Williamson
2022-04-21 5:35 ` Christoph Hellwig
@ 2022-04-21 17:12 ` Bjorn Helgaas
1 sibling, 0 replies; 3+ messages in thread
From: Bjorn Helgaas @ 2022-04-21 17:12 UTC (permalink / raw)
To: Alex Williamson; +Cc: bhelgaas, linux-pci, hch
On Wed, Apr 20, 2022 at 02:45:05PM -0600, Alex Williamson wrote:
> The function is dma_set_mask(), fix a missed instance of the old
> pci_set_dma_mask() and a reference to a function that doesn't exist.
>
> Fixes: 05b0ebd06ae6 ("PCI/doc: cleanup references to the legacy PCI DMA API")
> Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
Applied to pci/misc for v5.19 with Christoph's reviewed-by, thank you!
> ---
> Documentation/PCI/pci.rst | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/PCI/pci.rst b/Documentation/PCI/pci.rst
> index 67a850b55617..cced568d78e9 100644
> --- a/Documentation/PCI/pci.rst
> +++ b/Documentation/PCI/pci.rst
> @@ -273,12 +273,12 @@ Set the DMA mask size
> While all drivers should explicitly indicate the DMA capability
> (e.g. 32 or 64 bit) of the PCI bus master, devices with more than
> 32-bit bus master capability for streaming data need the driver
> -to "register" this capability by calling pci_set_dma_mask() with
> +to "register" this capability by calling dma_set_mask() with
> appropriate parameters. In general this allows more efficient DMA
> on systems where System RAM exists above 4G _physical_ address.
>
> Drivers for all PCI-X and PCIe compliant devices must call
> -set_dma_mask() as they are 64-bit DMA devices.
> +dma_set_mask() as they are 64-bit DMA devices.
>
> Similarly, drivers must also "register" this capability if the device
> can directly address "coherent memory" in System RAM above 4G physical
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-04-21 17:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-20 20:45 [PATCH] PCI/docs: Fix references to DMA set mask function Alex Williamson
2022-04-21 5:35 ` Christoph Hellwig
2022-04-21 17:12 ` Bjorn Helgaas
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.