* [PATCH] scsi: qedf: Remove useless code
@ 2022-04-21 10:24 Haowen Bai
2022-05-03 0:51 ` Martin K. Petersen
0 siblings, 1 reply; 2+ messages in thread
From: Haowen Bai @ 2022-04-21 10:24 UTC (permalink / raw)
To: Saurav Kashyap, Javed Hasan, GR-QLogic-Storage-Upstream,
James E.J. Bottomley, Martin K. Petersen
Cc: Haowen Bai, linux-scsi, linux-kernel
buf msg only memset but no use at all, so we drop it.
Signed-off-by: Haowen Bai <baihaowen@meizu.com>
---
drivers/scsi/qedf/qedf_attr.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/scsi/qedf/qedf_attr.c b/drivers/scsi/qedf/qedf_attr.c
index fdc66d294813..8d8c760eee43 100644
--- a/drivers/scsi/qedf/qedf_attr.c
+++ b/drivers/scsi/qedf/qedf_attr.c
@@ -131,7 +131,6 @@ qedf_sysfs_write_grcdump(struct file *filep, struct kobject *kobj,
struct qedf_ctx *qedf = NULL;
long reading;
int ret = 0;
- char msg[40];
if (off != 0)
return ret;
@@ -148,7 +147,6 @@ qedf_sysfs_write_grcdump(struct file *filep, struct kobject *kobj,
return ret;
}
- memset(msg, 0, sizeof(msg));
switch (reading) {
case 0:
memset(qedf->grcdump, 0, qedf->grcdump_size);
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] scsi: qedf: Remove useless code
2022-04-21 10:24 [PATCH] scsi: qedf: Remove useless code Haowen Bai
@ 2022-05-03 0:51 ` Martin K. Petersen
0 siblings, 0 replies; 2+ messages in thread
From: Martin K. Petersen @ 2022-05-03 0:51 UTC (permalink / raw)
To: James E.J. Bottomley, Saurav Kashyap, GR-QLogic-Storage-Upstream,
Haowen Bai, Javed Hasan
Cc: Martin K . Petersen, linux-kernel, linux-scsi
On Thu, 21 Apr 2022 18:24:53 +0800, Haowen Bai wrote:
> buf msg only memset but no use at all, so we drop it.
>
>
Applied to 5.19/scsi-queue, thanks!
[1/1] scsi: qedf: Remove useless code
https://git.kernel.org/mkp/scsi/c/21faafff6abb
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-05-06 11:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-21 10:24 [PATCH] scsi: qedf: Remove useless code Haowen Bai
2022-05-03 0:51 ` Martin K. Petersen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.