All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/amd/display: Remove useless code
@ 2022-04-21 10:28 ` Haowen Bai
  0 siblings, 0 replies; 6+ messages in thread
From: Haowen Bai @ 2022-04-21 10:28 UTC (permalink / raw)
  To: Harry Wentland, Leo Li, Rodrigo Siqueira, Alex Deucher,
	Christian König, Pan, Xinhui, David Airlie, Daniel Vetter
  Cc: Haowen Bai, amd-gfx, dri-devel, linux-kernel

aux_rep only memset but no use at all, so we drop it.

Signed-off-by: Haowen Bai <baihaowen@meizu.com>
---
 drivers/gpu/drm/amd/display/dc/dce/dce_aux.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/gpu/drm/amd/display/dc/dce/dce_aux.c b/drivers/gpu/drm/amd/display/dc/dce/dce_aux.c
index 8e814000db62..29e20d92b0bb 100644
--- a/drivers/gpu/drm/amd/display/dc/dce/dce_aux.c
+++ b/drivers/gpu/drm/amd/display/dc/dce/dce_aux.c
@@ -565,13 +565,11 @@ int dce_aux_transfer_raw(struct ddc_service *ddc,
 	struct ddc *ddc_pin = ddc->ddc_pin;
 	struct dce_aux *aux_engine;
 	struct aux_request_transaction_data aux_req;
-	struct aux_reply_transaction_data aux_rep;
 	uint8_t returned_bytes = 0;
 	int res = -1;
 	uint32_t status;
 
 	memset(&aux_req, 0, sizeof(aux_req));
-	memset(&aux_rep, 0, sizeof(aux_rep));
 
 	aux_engine = ddc->ctx->dc->res_pool->engines[ddc_pin->pin_data->en];
 	if (!acquire(aux_engine, ddc_pin)) {
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [PATCH] drm/amd/display: Remove useless code
@ 2022-04-21 10:28 ` Haowen Bai
  0 siblings, 0 replies; 6+ messages in thread
From: Haowen Bai @ 2022-04-21 10:28 UTC (permalink / raw)
  To: Harry Wentland, Leo Li, Rodrigo Siqueira, Alex Deucher,
	Christian König, Pan, Xinhui, David Airlie, Daniel Vetter
  Cc: Haowen Bai, dri-devel, amd-gfx, linux-kernel

aux_rep only memset but no use at all, so we drop it.

Signed-off-by: Haowen Bai <baihaowen@meizu.com>
---
 drivers/gpu/drm/amd/display/dc/dce/dce_aux.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/gpu/drm/amd/display/dc/dce/dce_aux.c b/drivers/gpu/drm/amd/display/dc/dce/dce_aux.c
index 8e814000db62..29e20d92b0bb 100644
--- a/drivers/gpu/drm/amd/display/dc/dce/dce_aux.c
+++ b/drivers/gpu/drm/amd/display/dc/dce/dce_aux.c
@@ -565,13 +565,11 @@ int dce_aux_transfer_raw(struct ddc_service *ddc,
 	struct ddc *ddc_pin = ddc->ddc_pin;
 	struct dce_aux *aux_engine;
 	struct aux_request_transaction_data aux_req;
-	struct aux_reply_transaction_data aux_rep;
 	uint8_t returned_bytes = 0;
 	int res = -1;
 	uint32_t status;
 
 	memset(&aux_req, 0, sizeof(aux_req));
-	memset(&aux_rep, 0, sizeof(aux_rep));
 
 	aux_engine = ddc->ctx->dc->res_pool->engines[ddc_pin->pin_data->en];
 	if (!acquire(aux_engine, ddc_pin)) {
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [PATCH] drm/amd/display: Remove useless code
  2022-04-21 10:28 ` Haowen Bai
  (?)
@ 2022-04-21 14:18   ` Alex Deucher
  -1 siblings, 0 replies; 6+ messages in thread
From: Alex Deucher @ 2022-04-21 14:18 UTC (permalink / raw)
  To: Haowen Bai
  Cc: Harry Wentland, Leo Li, Rodrigo Siqueira, Alex Deucher,
	Christian König, Pan, Xinhui, David Airlie, Daniel Vetter,
	Maling list - DRI developers, amd-gfx list, LKML

Applied.  Thanks!

Alex

On Thu, Apr 21, 2022 at 6:29 AM Haowen Bai <baihaowen@meizu.com> wrote:
>
> aux_rep only memset but no use at all, so we drop it.
>
> Signed-off-by: Haowen Bai <baihaowen@meizu.com>
> ---
>  drivers/gpu/drm/amd/display/dc/dce/dce_aux.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dce/dce_aux.c b/drivers/gpu/drm/amd/display/dc/dce/dce_aux.c
> index 8e814000db62..29e20d92b0bb 100644
> --- a/drivers/gpu/drm/amd/display/dc/dce/dce_aux.c
> +++ b/drivers/gpu/drm/amd/display/dc/dce/dce_aux.c
> @@ -565,13 +565,11 @@ int dce_aux_transfer_raw(struct ddc_service *ddc,
>         struct ddc *ddc_pin = ddc->ddc_pin;
>         struct dce_aux *aux_engine;
>         struct aux_request_transaction_data aux_req;
> -       struct aux_reply_transaction_data aux_rep;
>         uint8_t returned_bytes = 0;
>         int res = -1;
>         uint32_t status;
>
>         memset(&aux_req, 0, sizeof(aux_req));
> -       memset(&aux_rep, 0, sizeof(aux_rep));
>
>         aux_engine = ddc->ctx->dc->res_pool->engines[ddc_pin->pin_data->en];
>         if (!acquire(aux_engine, ddc_pin)) {
> --
> 2.7.4
>

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] drm/amd/display: Remove useless code
@ 2022-04-21 14:18   ` Alex Deucher
  0 siblings, 0 replies; 6+ messages in thread
From: Alex Deucher @ 2022-04-21 14:18 UTC (permalink / raw)
  To: Haowen Bai
  Cc: Leo Li, Pan, Xinhui, Rodrigo Siqueira, LKML,
	Maling list - DRI developers, David Airlie, amd-gfx list,
	Alex Deucher, Christian König

Applied.  Thanks!

Alex

On Thu, Apr 21, 2022 at 6:29 AM Haowen Bai <baihaowen@meizu.com> wrote:
>
> aux_rep only memset but no use at all, so we drop it.
>
> Signed-off-by: Haowen Bai <baihaowen@meizu.com>
> ---
>  drivers/gpu/drm/amd/display/dc/dce/dce_aux.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dce/dce_aux.c b/drivers/gpu/drm/amd/display/dc/dce/dce_aux.c
> index 8e814000db62..29e20d92b0bb 100644
> --- a/drivers/gpu/drm/amd/display/dc/dce/dce_aux.c
> +++ b/drivers/gpu/drm/amd/display/dc/dce/dce_aux.c
> @@ -565,13 +565,11 @@ int dce_aux_transfer_raw(struct ddc_service *ddc,
>         struct ddc *ddc_pin = ddc->ddc_pin;
>         struct dce_aux *aux_engine;
>         struct aux_request_transaction_data aux_req;
> -       struct aux_reply_transaction_data aux_rep;
>         uint8_t returned_bytes = 0;
>         int res = -1;
>         uint32_t status;
>
>         memset(&aux_req, 0, sizeof(aux_req));
> -       memset(&aux_rep, 0, sizeof(aux_rep));
>
>         aux_engine = ddc->ctx->dc->res_pool->engines[ddc_pin->pin_data->en];
>         if (!acquire(aux_engine, ddc_pin)) {
> --
> 2.7.4
>

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] drm/amd/display: Remove useless code
@ 2022-04-21 14:18   ` Alex Deucher
  0 siblings, 0 replies; 6+ messages in thread
From: Alex Deucher @ 2022-04-21 14:18 UTC (permalink / raw)
  To: Haowen Bai
  Cc: Leo Li, Pan, Xinhui, Rodrigo Siqueira, LKML,
	Maling list - DRI developers, David Airlie, amd-gfx list,
	Daniel Vetter, Alex Deucher, Harry Wentland,
	Christian König

Applied.  Thanks!

Alex

On Thu, Apr 21, 2022 at 6:29 AM Haowen Bai <baihaowen@meizu.com> wrote:
>
> aux_rep only memset but no use at all, so we drop it.
>
> Signed-off-by: Haowen Bai <baihaowen@meizu.com>
> ---
>  drivers/gpu/drm/amd/display/dc/dce/dce_aux.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dce/dce_aux.c b/drivers/gpu/drm/amd/display/dc/dce/dce_aux.c
> index 8e814000db62..29e20d92b0bb 100644
> --- a/drivers/gpu/drm/amd/display/dc/dce/dce_aux.c
> +++ b/drivers/gpu/drm/amd/display/dc/dce/dce_aux.c
> @@ -565,13 +565,11 @@ int dce_aux_transfer_raw(struct ddc_service *ddc,
>         struct ddc *ddc_pin = ddc->ddc_pin;
>         struct dce_aux *aux_engine;
>         struct aux_request_transaction_data aux_req;
> -       struct aux_reply_transaction_data aux_rep;
>         uint8_t returned_bytes = 0;
>         int res = -1;
>         uint32_t status;
>
>         memset(&aux_req, 0, sizeof(aux_req));
> -       memset(&aux_rep, 0, sizeof(aux_rep));
>
>         aux_engine = ddc->ctx->dc->res_pool->engines[ddc_pin->pin_data->en];
>         if (!acquire(aux_engine, ddc_pin)) {
> --
> 2.7.4
>

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [PATCH] drm/amd/display: Remove useless code
@ 2022-04-21 10:31 Haowen Bai
  0 siblings, 0 replies; 6+ messages in thread
From: Haowen Bai @ 2022-04-21 10:31 UTC (permalink / raw)
  To: Vladimir Oltean, Claudiu Manoil, Alexandre Belloni,
	UNGLinuxDriver, David S. Miller, Jakub Kicinski, Paolo Abeni
  Cc: Haowen Bai, netdev, linux-kernel

payload only memset but no use at all, so we drop them.

Signed-off-by: Haowen Bai <baihaowen@meizu.com>
---
 drivers/net/ethernet/mscc/ocelot_vcap.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/net/ethernet/mscc/ocelot_vcap.c b/drivers/net/ethernet/mscc/ocelot_vcap.c
index c8701ac955a8..1e74bdb215ec 100644
--- a/drivers/net/ethernet/mscc/ocelot_vcap.c
+++ b/drivers/net/ethernet/mscc/ocelot_vcap.c
@@ -672,12 +672,10 @@ static void is1_entry_set(struct ocelot *ocelot, int ix,
 {
 	const struct vcap_props *vcap = &ocelot->vcap[VCAP_IS1];
 	struct ocelot_vcap_key_vlan *tag = &filter->vlan;
-	struct ocelot_vcap_u64 payload;
 	struct vcap_data data;
 	int row = ix / 2;
 	u32 type;
 
-	memset(&payload, 0, sizeof(payload));
 	memset(&data, 0, sizeof(data));
 
 	/* Read row */
@@ -813,11 +811,9 @@ static void es0_entry_set(struct ocelot *ocelot, int ix,
 {
 	const struct vcap_props *vcap = &ocelot->vcap[VCAP_ES0];
 	struct ocelot_vcap_key_vlan *tag = &filter->vlan;
-	struct ocelot_vcap_u64 payload;
 	struct vcap_data data;
 	int row = ix;
 
-	memset(&payload, 0, sizeof(payload));
 	memset(&data, 0, sizeof(data));
 
 	/* Read row */
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-04-21 14:19 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-21 10:28 [PATCH] drm/amd/display: Remove useless code Haowen Bai
2022-04-21 10:28 ` Haowen Bai
2022-04-21 14:18 ` Alex Deucher
2022-04-21 14:18   ` Alex Deucher
2022-04-21 14:18   ` Alex Deucher
2022-04-21 10:31 Haowen Bai

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.