All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH liburing] arch/x86/syscall: Remove TODO comment
@ 2022-04-21  7:52 Ammar Faizi
  2022-04-21 12:28 ` Jens Axboe
  0 siblings, 1 reply; 2+ messages in thread
From: Ammar Faizi @ 2022-04-21  7:52 UTC (permalink / raw)
  To: Jens Axboe
  Cc: GNU/Weeb Mailing List, io-uring Mailing List,
	Alviro Iskandar Setiawan, Ammar Faizi

From: Ammar Faizi <ammarfaizi2@gnuweeb.org>

nolibc support for x86 32-bit has been added in commit b7d8dd8bbf5b855
("arch/x86/syscall: Add x86 32-bit native syscall support"). But I
forgot to remove the comment that says "We can't use CONFIG_NOLIBC for
x86 (32-bit)".

Remove it.

Signed-off-by: Ammar Faizi <ammarfaizi2@gnuweeb.org>
---

Hi Jens,

Hopefully, this is the last x86 changes before v2.2 release.

 src/arch/x86/syscall.h | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/src/arch/x86/syscall.h b/src/arch/x86/syscall.h
index 8cd24dd..43c576b 100644
--- a/src/arch/x86/syscall.h
+++ b/src/arch/x86/syscall.h
@@ -144,12 +144,6 @@
 
 #else /* #if defined(__x86_64__) */
 
-/*
- * For x86 (32-bit), fallback to libc wrapper.
- * We can't use CONFIG_NOLIBC for x86 (32-bit) at the moment.
- *
- * TODO: Add x86 (32-bit) nolibc support.
- */
 #ifdef CONFIG_NOLIBC
 /**
  * Note for syscall registers usage (x86, 32-bit):
-- 
Ammar Faizi


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH liburing] arch/x86/syscall: Remove TODO comment
  2022-04-21  7:52 [PATCH liburing] arch/x86/syscall: Remove TODO comment Ammar Faizi
@ 2022-04-21 12:28 ` Jens Axboe
  0 siblings, 0 replies; 2+ messages in thread
From: Jens Axboe @ 2022-04-21 12:28 UTC (permalink / raw)
  To: ammarfaizi2; +Cc: alviro.iskandar, gwml, io-uring

On Thu, 21 Apr 2022 14:52:30 +0700, Ammar Faizi wrote:
> From: Ammar Faizi <ammarfaizi2@gnuweeb.org>
> 
> nolibc support for x86 32-bit has been added in commit b7d8dd8bbf5b855
> ("arch/x86/syscall: Add x86 32-bit native syscall support"). But I
> forgot to remove the comment that says "We can't use CONFIG_NOLIBC for
> x86 (32-bit)".
> 
> [...]

Applied, thanks!

[1/1] arch/x86/syscall: Remove TODO comment
      commit: 4ad972d6d1b16e4fb069fc2f006265942cf33103

Best regards,
-- 
Jens Axboe



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-04-21 12:28 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-21  7:52 [PATCH liburing] arch/x86/syscall: Remove TODO comment Ammar Faizi
2022-04-21 12:28 ` Jens Axboe

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.