* [PATCH v2 1/2] ASoC: Intel: avs: Enable AVS driver only on x86 platforms
@ 2022-04-25 9:16 Amadeusz Sławiński
2022-04-25 9:16 ` [PATCH v2 2/2] ASoC: Intel: avs: Depend on SND_INTEL_DSP_CONFIG Amadeusz Sławiński
2022-04-25 17:24 ` [PATCH v2 1/2] ASoC: Intel: avs: Enable AVS driver only on x86 platforms Mark Brown
0 siblings, 2 replies; 3+ messages in thread
From: Amadeusz Sławiński @ 2022-04-25 9:16 UTC (permalink / raw)
To: Liam Girdwood, Mark Brown
Cc: Pierre-Louis Bossart, Cezary Rojewski, alsa-devel, Takashi Iwai,
Amadeusz Sławiński
Only supported platform for AVS are x86 machines, so there is no reason
for it to be enabled on other architectures. Allow exception for compile
tests.
Fixes: 274d79e51875 ("ASoC: Intel: avs: Configure modules according to their type")
Reviewed-by: Cezary Rojewski <cezary.rojewski@intel.com>
Signed-off-by: Amadeusz Sławiński <amadeuszx.slawinski@linux.intel.com>
---
Changes in v2:
* Actually fix the problem reported by kernel test robot in following
patch
* Add COMPILE_TEST to allow test building on other architectures
---
sound/soc/intel/Kconfig | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/sound/soc/intel/Kconfig b/sound/soc/intel/Kconfig
index c364ddf22267..4ef9a1fee121 100644
--- a/sound/soc/intel/Kconfig
+++ b/sound/soc/intel/Kconfig
@@ -211,7 +211,8 @@ config SND_SOC_INTEL_KEEMBAY
config SND_SOC_INTEL_AVS
tristate "Intel AVS driver"
- depends on PCI && ACPI
+ depends on (X86 && ACPI) || COMPILE_TEST
+ depends on PCI
depends on COMMON_CLK
select SND_SOC_ACPI
select SND_SOC_TOPOLOGY
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH v2 2/2] ASoC: Intel: avs: Depend on SND_INTEL_DSP_CONFIG
2022-04-25 9:16 [PATCH v2 1/2] ASoC: Intel: avs: Enable AVS driver only on x86 platforms Amadeusz Sławiński
@ 2022-04-25 9:16 ` Amadeusz Sławiński
2022-04-25 17:24 ` [PATCH v2 1/2] ASoC: Intel: avs: Enable AVS driver only on x86 platforms Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Amadeusz Sławiński @ 2022-04-25 9:16 UTC (permalink / raw)
To: Liam Girdwood, Mark Brown
Cc: Pierre-Louis Bossart, Cezary Rojewski, kernel test robot,
alsa-devel, Takashi Iwai, Amadeusz Sławiński
In order to enable NHLT support one must select SND_INTEL_DSP_CONFIG,
which will select SND_INTEL_NHLT. Otherwise the file containing NHLT
code doesn't get build leading to errors when linking.
Fixes: 274d79e51875 ("ASoC: Intel: avs: Configure modules according to their type")
Reported-by: kernel test robot <lkp@intel.com>
Reviewed-by: Cezary Rojewski <cezary.rojewski@intel.com>
Signed-off-by: Amadeusz Sławiński <amadeuszx.slawinski@linux.intel.com>
---
sound/soc/intel/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/intel/Kconfig b/sound/soc/intel/Kconfig
index 4ef9a1fee121..be42c4eff165 100644
--- a/sound/soc/intel/Kconfig
+++ b/sound/soc/intel/Kconfig
@@ -218,7 +218,7 @@ config SND_SOC_INTEL_AVS
select SND_SOC_TOPOLOGY
select SND_HDA_EXT_CORE
select SND_HDA_DSP_LOADER
- select SND_INTEL_NHLT
+ select SND_INTEL_DSP_CONFIG
help
Enable support for Intel(R) cAVS 1.5 platforms with DSP
capabilities. This includes Skylake, Kabylake, Amberlake and
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2 1/2] ASoC: Intel: avs: Enable AVS driver only on x86 platforms
2022-04-25 9:16 [PATCH v2 1/2] ASoC: Intel: avs: Enable AVS driver only on x86 platforms Amadeusz Sławiński
2022-04-25 9:16 ` [PATCH v2 2/2] ASoC: Intel: avs: Depend on SND_INTEL_DSP_CONFIG Amadeusz Sławiński
@ 2022-04-25 17:24 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2022-04-25 17:24 UTC (permalink / raw)
To: amadeuszx.slawinski, lgirdwood
Cc: cezary.rojewski, alsa-devel, tiwai, pierre-louis.bossart
On Mon, 25 Apr 2022 11:16:45 +0200, Amadeusz Sławiński wrote:
> Only supported platform for AVS are x86 machines, so there is no reason
> for it to be enabled on other architectures. Allow exception for compile
> tests.
>
>
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
Thanks!
[1/2] ASoC: Intel: avs: Enable AVS driver only on x86 platforms
commit: 47a1886a610aca6a55c18ee677f9176e73162e97
[2/2] ASoC: Intel: avs: Depend on SND_INTEL_DSP_CONFIG
commit: 5755d0f63c677b8b63b82dceacd26d96617e3ba8
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-04-25 17:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-25 9:16 [PATCH v2 1/2] ASoC: Intel: avs: Enable AVS driver only on x86 platforms Amadeusz Sławiński
2022-04-25 9:16 ` [PATCH v2 2/2] ASoC: Intel: avs: Depend on SND_INTEL_DSP_CONFIG Amadeusz Sławiński
2022-04-25 17:24 ` [PATCH v2 1/2] ASoC: Intel: avs: Enable AVS driver only on x86 platforms Mark Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.