* [Intel-gfx] [PATCH] i915/guc/reset: Make __guc_reset_context aware of guilty engines
@ 2022-04-26 0:30 Umesh Nerlige Ramappa
2022-04-26 1:39 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Umesh Nerlige Ramappa @ 2022-04-26 0:30 UTC (permalink / raw)
To: intel-gfx, daniele.ceraolospurio, john.c.harrison, Matthew Brost
There are 2 ways an engine can get reset in i915 and the method of reset
affects how KMD labels a context as guilty/innocent.
(1) GuC initiated engine-reset: GuC resets a hung engine and notifies
KMD. The context that hung on the engine is marked guilty and all other
contexts are innocent. The innocent contexts are resubmitted.
(2) GT based reset: When an engine heartbeat fails to tick, KMD
initiates a gt/chip reset. All active contexts are marked as guilty and
discarded.
In order to correctly mark the contexts as guilty/innocent, pass a mask
of engines that were reset to __guc_reset_context.
Fixes: eb5e7da736f3 ("drm/i915/guc: Reset implementation for new GuC interface")
Signed-off-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
---
drivers/gpu/drm/i915/gt/intel_reset.c | 2 +-
drivers/gpu/drm/i915/gt/uc/intel_guc.h | 2 +-
.../gpu/drm/i915/gt/uc/intel_guc_submission.c | 16 ++++++++--------
drivers/gpu/drm/i915/gt/uc/intel_uc.c | 2 +-
drivers/gpu/drm/i915/gt/uc/intel_uc.h | 2 +-
5 files changed, 12 insertions(+), 12 deletions(-)
diff --git a/drivers/gpu/drm/i915/gt/intel_reset.c b/drivers/gpu/drm/i915/gt/intel_reset.c
index 5422a3b84bd4..a5338c3fde7a 100644
--- a/drivers/gpu/drm/i915/gt/intel_reset.c
+++ b/drivers/gpu/drm/i915/gt/intel_reset.c
@@ -808,7 +808,7 @@ static int gt_reset(struct intel_gt *gt, intel_engine_mask_t stalled_mask)
__intel_engine_reset(engine, stalled_mask & engine->mask);
local_bh_enable();
- intel_uc_reset(>->uc, true);
+ intel_uc_reset(>->uc, ALL_ENGINES);
intel_ggtt_restore_fences(gt->ggtt);
diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc.h b/drivers/gpu/drm/i915/gt/uc/intel_guc.h
index 3f3373f68123..966e69a8b1c1 100644
--- a/drivers/gpu/drm/i915/gt/uc/intel_guc.h
+++ b/drivers/gpu/drm/i915/gt/uc/intel_guc.h
@@ -443,7 +443,7 @@ int intel_guc_global_policies_update(struct intel_guc *guc);
void intel_guc_context_ban(struct intel_context *ce, struct i915_request *rq);
void intel_guc_submission_reset_prepare(struct intel_guc *guc);
-void intel_guc_submission_reset(struct intel_guc *guc, bool stalled);
+void intel_guc_submission_reset(struct intel_guc *guc, intel_engine_mask_t stalled);
void intel_guc_submission_reset_finish(struct intel_guc *guc);
void intel_guc_submission_cancel_requests(struct intel_guc *guc);
diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c b/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c
index 61a6f2424e24..1fbf7b6c2740 100644
--- a/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c
+++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c
@@ -1667,9 +1667,9 @@ __unwind_incomplete_requests(struct intel_context *ce)
spin_unlock_irqrestore(&sched_engine->lock, flags);
}
-static void __guc_reset_context(struct intel_context *ce, bool stalled)
+static void __guc_reset_context(struct intel_context *ce, intel_engine_mask_t stalled)
{
- bool local_stalled;
+ bool guilty;
struct i915_request *rq;
unsigned long flags;
u32 head;
@@ -1697,7 +1697,7 @@ static void __guc_reset_context(struct intel_context *ce, bool stalled)
if (!intel_context_is_pinned(ce))
goto next_context;
- local_stalled = false;
+ guilty = false;
rq = intel_context_find_active_request(ce);
if (!rq) {
head = ce->ring->tail;
@@ -1705,14 +1705,14 @@ static void __guc_reset_context(struct intel_context *ce, bool stalled)
}
if (i915_request_started(rq))
- local_stalled = true;
+ guilty = stalled & ce->engine->mask;
GEM_BUG_ON(i915_active_is_idle(&ce->active));
head = intel_ring_wrap(ce->ring, rq->head);
- __i915_request_reset(rq, local_stalled && stalled);
+ __i915_request_reset(rq, guilty);
out_replay:
- guc_reset_state(ce, head, local_stalled && stalled);
+ guc_reset_state(ce, head, guilty);
next_context:
if (i != number_children)
ce = list_next_entry(ce, parallel.child_link);
@@ -1722,7 +1722,7 @@ static void __guc_reset_context(struct intel_context *ce, bool stalled)
intel_context_put(parent);
}
-void intel_guc_submission_reset(struct intel_guc *guc, bool stalled)
+void intel_guc_submission_reset(struct intel_guc *guc, intel_engine_mask_t stalled)
{
struct intel_context *ce;
unsigned long index;
@@ -4217,7 +4217,7 @@ static void guc_context_replay(struct intel_context *ce)
{
struct i915_sched_engine *sched_engine = ce->engine->sched_engine;
- __guc_reset_context(ce, true);
+ __guc_reset_context(ce, ce->engine->mask);
tasklet_hi_schedule(&sched_engine->tasklet);
}
diff --git a/drivers/gpu/drm/i915/gt/uc/intel_uc.c b/drivers/gpu/drm/i915/gt/uc/intel_uc.c
index 8c9ef690ac9d..e8f099360e01 100644
--- a/drivers/gpu/drm/i915/gt/uc/intel_uc.c
+++ b/drivers/gpu/drm/i915/gt/uc/intel_uc.c
@@ -595,7 +595,7 @@ void intel_uc_reset_prepare(struct intel_uc *uc)
__uc_sanitize(uc);
}
-void intel_uc_reset(struct intel_uc *uc, bool stalled)
+void intel_uc_reset(struct intel_uc *uc, intel_engine_mask_t stalled)
{
struct intel_guc *guc = &uc->guc;
diff --git a/drivers/gpu/drm/i915/gt/uc/intel_uc.h b/drivers/gpu/drm/i915/gt/uc/intel_uc.h
index 866b462821c0..a8f38c2c60e2 100644
--- a/drivers/gpu/drm/i915/gt/uc/intel_uc.h
+++ b/drivers/gpu/drm/i915/gt/uc/intel_uc.h
@@ -42,7 +42,7 @@ void intel_uc_driver_late_release(struct intel_uc *uc);
void intel_uc_driver_remove(struct intel_uc *uc);
void intel_uc_init_mmio(struct intel_uc *uc);
void intel_uc_reset_prepare(struct intel_uc *uc);
-void intel_uc_reset(struct intel_uc *uc, bool stalled);
+void intel_uc_reset(struct intel_uc *uc, intel_engine_mask_t stalled);
void intel_uc_reset_finish(struct intel_uc *uc);
void intel_uc_cancel_requests(struct intel_uc *uc);
void intel_uc_suspend(struct intel_uc *uc);
--
2.35.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for i915/guc/reset: Make __guc_reset_context aware of guilty engines
2022-04-26 0:30 [Intel-gfx] [PATCH] i915/guc/reset: Make __guc_reset_context aware of guilty engines Umesh Nerlige Ramappa
@ 2022-04-26 1:39 ` Patchwork
2022-04-26 3:46 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2022-04-28 16:13 ` [Intel-gfx] [PATCH] " Teres Alexis, Alan Previn
2 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2022-04-26 1:39 UTC (permalink / raw)
To: Umesh Nerlige Ramappa; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 8429 bytes --]
== Series Details ==
Series: i915/guc/reset: Make __guc_reset_context aware of guilty engines
URL : https://patchwork.freedesktop.org/series/103111/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11550 -> Patchwork_103111v1
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103111v1/index.html
Participating hosts (43 -> 42)
------------------------------
Additional (2): bat-adlm-1 bat-dg1-6
Missing (3): fi-hsw-4770 bat-rpls-2 fi-bsw-cyan
Known issues
------------
Here are the changes found in Patchwork_103111v1 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_suspend@basic-s0@smem:
- bat-dg1-6: NOTRUN -> [INCOMPLETE][1] ([i915#5827])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103111v1/bat-dg1-6/igt@gem_exec_suspend@basic-s0@smem.html
* igt@gem_exec_suspend@basic-s3@smem:
- fi-bdw-5557u: [PASS][2] -> [INCOMPLETE][3] ([i915#146])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11550/fi-bdw-5557u/igt@gem_exec_suspend@basic-s3@smem.html
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103111v1/fi-bdw-5557u/igt@gem_exec_suspend@basic-s3@smem.html
* igt@i915_selftest@live@gt_pm:
- fi-tgl-1115g4: [PASS][4] -> [DMESG-FAIL][5] ([i915#3987])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11550/fi-tgl-1115g4/igt@i915_selftest@live@gt_pm.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103111v1/fi-tgl-1115g4/igt@i915_selftest@live@gt_pm.html
#### Possible fixes ####
* igt@i915_selftest@live@gt_heartbeat:
- fi-cfl-guc: [DMESG-FAIL][6] ([i915#5334]) -> [PASS][7]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11550/fi-cfl-guc/igt@i915_selftest@live@gt_heartbeat.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103111v1/fi-cfl-guc/igt@i915_selftest@live@gt_heartbeat.html
* igt@kms_busy@basic@modeset:
- {bat-adlp-6}: [DMESG-WARN][8] ([i915#3576]) -> [PASS][9]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11550/bat-adlp-6/igt@kms_busy@basic@modeset.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103111v1/bat-adlp-6/igt@kms_busy@basic@modeset.html
#### Warnings ####
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-c:
- fi-kbl-7567u: [SKIP][10] ([fdo#109271] / [i915#5341]) -> [SKIP][11] ([fdo#109271])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11550/fi-kbl-7567u/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-c.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103111v1/fi-kbl-7567u/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-c.html
- fi-pnv-d510: [SKIP][12] ([fdo#109271] / [i915#5341]) -> [SKIP][13] ([fdo#109271])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11550/fi-pnv-d510/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-c.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103111v1/fi-pnv-d510/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-c.html
- fi-snb-2520m: [SKIP][14] ([fdo#109271] / [i915#5341]) -> [SKIP][15] ([fdo#109271])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11550/fi-snb-2520m/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-c.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103111v1/fi-snb-2520m/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-c.html
- fi-bsw-kefka: [SKIP][16] ([fdo#109271] / [i915#5341]) -> [SKIP][17] ([fdo#109271])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11550/fi-bsw-kefka/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-c.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103111v1/fi-bsw-kefka/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-c.html
- fi-kbl-8809g: [SKIP][18] ([fdo#109271] / [i915#5341]) -> [SKIP][19] ([fdo#109271])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11550/fi-kbl-8809g/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-c.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103111v1/fi-kbl-8809g/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-c.html
- fi-bsw-nick: [SKIP][20] ([fdo#109271] / [i915#5341]) -> [SKIP][21] ([fdo#109271])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11550/fi-bsw-nick/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-c.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103111v1/fi-bsw-nick/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-c.html
- fi-bwr-2160: [SKIP][22] ([fdo#109271] / [i915#5341]) -> [SKIP][23] ([fdo#109271])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11550/fi-bwr-2160/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-c.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103111v1/fi-bwr-2160/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-c.html
- fi-snb-2600: [SKIP][24] ([fdo#109271] / [i915#5341]) -> [SKIP][25] ([fdo#109271])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11550/fi-snb-2600/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-c.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103111v1/fi-snb-2600/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-c.html
- fi-elk-e7500: [SKIP][26] ([fdo#109271] / [i915#5341]) -> [SKIP][27] ([fdo#109271])
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11550/fi-elk-e7500/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-c.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103111v1/fi-elk-e7500/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-c.html
- fi-blb-e6850: [SKIP][28] ([fdo#109271] / [i915#5341]) -> [SKIP][29] ([fdo#109271])
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11550/fi-blb-e6850/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-c.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103111v1/fi-blb-e6850/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-c.html
- fi-ilk-650: [SKIP][30] ([fdo#109271] / [i915#5341]) -> [SKIP][31] ([fdo#109271])
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11550/fi-ilk-650/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-c.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103111v1/fi-ilk-650/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-c.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1155]: https://gitlab.freedesktop.org/drm/intel/issues/1155
[i915#146]: https://gitlab.freedesktop.org/drm/intel/issues/146
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3576]: https://gitlab.freedesktop.org/drm/intel/issues/3576
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#3987]: https://gitlab.freedesktop.org/drm/intel/issues/3987
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334
[i915#5341]: https://gitlab.freedesktop.org/drm/intel/issues/5341
[i915#5414]: https://gitlab.freedesktop.org/drm/intel/issues/5414
[i915#5827]: https://gitlab.freedesktop.org/drm/intel/issues/5827
Build changes
-------------
* Linux: CI_DRM_11550 -> Patchwork_103111v1
CI-20190529: 20190529
CI_DRM_11550: 56b089ae03ef8ea8ab7f474eaa70367898891ef0 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6451: f055bd83bd831a938d639718c2359516224f15f9 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_103111v1: 56b089ae03ef8ea8ab7f474eaa70367898891ef0 @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
d79e3a167173 i915/guc/reset: Make __guc_reset_context aware of guilty engines
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103111v1/index.html
[-- Attachment #2: Type: text/html, Size: 10651 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for i915/guc/reset: Make __guc_reset_context aware of guilty engines
2022-04-26 0:30 [Intel-gfx] [PATCH] i915/guc/reset: Make __guc_reset_context aware of guilty engines Umesh Nerlige Ramappa
2022-04-26 1:39 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
@ 2022-04-26 3:46 ` Patchwork
2022-04-28 16:13 ` [Intel-gfx] [PATCH] " Teres Alexis, Alan Previn
2 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2022-04-26 3:46 UTC (permalink / raw)
To: Umesh Nerlige Ramappa; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 38045 bytes --]
== Series Details ==
Series: i915/guc/reset: Make __guc_reset_context aware of guilty engines
URL : https://patchwork.freedesktop.org/series/103111/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11550_full -> Patchwork_103111v1_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Participating hosts (10 -> 12)
------------------------------
Additional (2): shard-rkl shard-tglu
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_103111v1_full:
### IGT changes ###
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* igt@kms_prime@basic-crc@second-to-first:
- {shard-rkl}: NOTRUN -> [SKIP][1]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103111v1/shard-rkl-3/igt@kms_prime@basic-crc@second-to-first.html
Known issues
------------
Here are the changes found in Patchwork_103111v1_full that come from known issues:
### CI changes ###
#### Possible fixes ####
* boot:
- shard-skl: ([PASS][2], [PASS][3], [PASS][4], [PASS][5], [PASS][6], [PASS][7], [PASS][8], [PASS][9], [PASS][10], [PASS][11], [PASS][12], [PASS][13], [FAIL][14], [PASS][15], [PASS][16], [PASS][17], [PASS][18], [PASS][19], [PASS][20], [PASS][21], [PASS][22], [PASS][23], [PASS][24], [PASS][25]) ([i915#5032]) -> ([PASS][26], [PASS][27], [PASS][28], [PASS][29], [PASS][30], [PASS][31], [PASS][32], [PASS][33], [PASS][34], [PASS][35], [PASS][36], [PASS][37], [PASS][38], [PASS][39], [PASS][40], [PASS][41], [PASS][42], [PASS][43], [PASS][44], [PASS][45])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11550/shard-skl9/boot.html
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11550/shard-skl9/boot.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11550/shard-skl8/boot.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11550/shard-skl8/boot.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11550/shard-skl7/boot.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11550/shard-skl7/boot.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11550/shard-skl6/boot.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11550/shard-skl6/boot.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11550/shard-skl6/boot.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11550/shard-skl5/boot.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11550/shard-skl5/boot.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11550/shard-skl5/boot.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11550/shard-skl5/boot.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11550/shard-skl4/boot.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11550/shard-skl4/boot.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11550/shard-skl4/boot.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11550/shard-skl3/boot.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11550/shard-skl3/boot.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11550/shard-skl2/boot.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11550/shard-skl2/boot.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11550/shard-skl1/boot.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11550/shard-skl1/boot.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11550/shard-skl10/boot.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11550/shard-skl10/boot.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103111v1/shard-skl9/boot.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103111v1/shard-skl9/boot.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103111v1/shard-skl9/boot.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103111v1/shard-skl8/boot.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103111v1/shard-skl8/boot.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103111v1/shard-skl8/boot.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103111v1/shard-skl7/boot.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103111v1/shard-skl7/boot.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103111v1/shard-skl6/boot.html
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103111v1/shard-skl6/boot.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103111v1/shard-skl4/boot.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103111v1/shard-skl4/boot.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103111v1/shard-skl4/boot.html
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103111v1/shard-skl3/boot.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103111v1/shard-skl3/boot.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103111v1/shard-skl1/boot.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103111v1/shard-skl1/boot.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103111v1/shard-skl1/boot.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103111v1/shard-skl10/boot.html
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103111v1/shard-skl10/boot.html
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_balancer@parallel-balancer:
- shard-iclb: [PASS][46] -> [SKIP][47] ([i915#4525])
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11550/shard-iclb2/igt@gem_exec_balancer@parallel-balancer.html
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103111v1/shard-iclb5/igt@gem_exec_balancer@parallel-balancer.html
* igt@gem_exec_fair@basic-flow@rcs0:
- shard-skl: NOTRUN -> [SKIP][48] ([fdo#109271]) +82 similar issues
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103111v1/shard-skl9/igt@gem_exec_fair@basic-flow@rcs0.html
* igt@gem_exec_fair@basic-none-vip@rcs0:
- shard-kbl: [PASS][49] -> [FAIL][50] ([i915#2842]) +3 similar issues
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11550/shard-kbl1/igt@gem_exec_fair@basic-none-vip@rcs0.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103111v1/shard-kbl6/igt@gem_exec_fair@basic-none-vip@rcs0.html
* igt@gem_exec_fair@basic-pace@vcs1:
- shard-iclb: NOTRUN -> [FAIL][51] ([i915#2842])
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103111v1/shard-iclb1/igt@gem_exec_fair@basic-pace@vcs1.html
* igt@gem_exec_flush@basic-wb-set-default:
- shard-snb: [PASS][52] -> [SKIP][53] ([fdo#109271]) +1 similar issue
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11550/shard-snb2/igt@gem_exec_flush@basic-wb-set-default.html
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103111v1/shard-snb6/igt@gem_exec_flush@basic-wb-set-default.html
* igt@gem_exec_suspend@basic-s3@smem:
- shard-apl: [PASS][54] -> [DMESG-WARN][55] ([i915#180]) +2 similar issues
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11550/shard-apl6/igt@gem_exec_suspend@basic-s3@smem.html
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103111v1/shard-apl4/igt@gem_exec_suspend@basic-s3@smem.html
* igt@gem_huc_copy@huc-copy:
- shard-skl: NOTRUN -> [SKIP][56] ([fdo#109271] / [i915#2190])
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103111v1/shard-skl7/igt@gem_huc_copy@huc-copy.html
* igt@gem_lmem_swapping@parallel-random:
- shard-iclb: NOTRUN -> [SKIP][57] ([i915#4613]) +1 similar issue
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103111v1/shard-iclb3/igt@gem_lmem_swapping@parallel-random.html
* igt@gem_lmem_swapping@smem-oom:
- shard-skl: NOTRUN -> [SKIP][58] ([fdo#109271] / [i915#4613]) +1 similar issue
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103111v1/shard-skl9/igt@gem_lmem_swapping@smem-oom.html
* igt@gem_lmem_swapping@verify-random-ccs:
- shard-apl: NOTRUN -> [SKIP][59] ([fdo#109271] / [i915#4613])
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103111v1/shard-apl6/igt@gem_lmem_swapping@verify-random-ccs.html
* igt@gem_render_copy@y-tiled-to-vebox-y-tiled:
- shard-iclb: NOTRUN -> [SKIP][60] ([i915#768])
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103111v1/shard-iclb3/igt@gem_render_copy@y-tiled-to-vebox-y-tiled.html
* igt@gem_userptr_blits@dmabuf-sync:
- shard-apl: NOTRUN -> [SKIP][61] ([fdo#109271] / [i915#3323])
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103111v1/shard-apl8/igt@gem_userptr_blits@dmabuf-sync.html
* igt@gen9_exec_parse@basic-rejected-ctx-param:
- shard-iclb: NOTRUN -> [SKIP][62] ([i915#2856])
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103111v1/shard-iclb3/igt@gen9_exec_parse@basic-rejected-ctx-param.html
* igt@i915_pm_dc@dc6-dpms:
- shard-iclb: NOTRUN -> [FAIL][63] ([i915#454])
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103111v1/shard-iclb3/igt@i915_pm_dc@dc6-dpms.html
* igt@i915_selftest@live@hangcheck:
- shard-snb: [PASS][64] -> [INCOMPLETE][65] ([i915#3921])
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11550/shard-snb4/igt@i915_selftest@live@hangcheck.html
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103111v1/shard-snb2/igt@i915_selftest@live@hangcheck.html
* igt@kms_big_fb@4-tiled-16bpp-rotate-270:
- shard-iclb: NOTRUN -> [SKIP][66] ([i915#5286]) +2 similar issues
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103111v1/shard-iclb3/igt@kms_big_fb@4-tiled-16bpp-rotate-270.html
* igt@kms_big_fb@linear-16bpp-rotate-270:
- shard-iclb: NOTRUN -> [SKIP][67] ([fdo#110725] / [fdo#111614])
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103111v1/shard-iclb3/igt@kms_big_fb@linear-16bpp-rotate-270.html
* igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-180-hflip-async-flip:
- shard-apl: NOTRUN -> [SKIP][68] ([fdo#109271] / [i915#3777])
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103111v1/shard-apl8/igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-180-hflip-async-flip.html
* igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-180-hflip-async-flip:
- shard-skl: NOTRUN -> [SKIP][69] ([fdo#109271] / [i915#3777])
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103111v1/shard-skl9/igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-180-hflip-async-flip.html
* igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-0-hflip:
- shard-iclb: NOTRUN -> [SKIP][70] ([fdo#110723])
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103111v1/shard-iclb3/igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-0-hflip.html
* igt@kms_ccs@pipe-a-crc-sprite-planes-basic-y_tiled_gen12_rc_ccs:
- shard-apl: NOTRUN -> [SKIP][71] ([fdo#109271]) +76 similar issues
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103111v1/shard-apl6/igt@kms_ccs@pipe-a-crc-sprite-planes-basic-y_tiled_gen12_rc_ccs.html
* igt@kms_ccs@pipe-b-random-ccs-data-y_tiled_gen12_mc_ccs:
- shard-iclb: NOTRUN -> [SKIP][72] ([fdo#109278] / [i915#3886]) +4 similar issues
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103111v1/shard-iclb3/igt@kms_ccs@pipe-b-random-ccs-data-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-c-ccs-on-another-bo-y_tiled_gen12_mc_ccs:
- shard-apl: NOTRUN -> [SKIP][73] ([fdo#109271] / [i915#3886]) +2 similar issues
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103111v1/shard-apl8/igt@kms_ccs@pipe-c-ccs-on-another-bo-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-c-crc-sprite-planes-basic-y_tiled_gen12_mc_ccs:
- shard-skl: NOTRUN -> [SKIP][74] ([fdo#109271] / [i915#3886]) +4 similar issues
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103111v1/shard-skl9/igt@kms_ccs@pipe-c-crc-sprite-planes-basic-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-d-bad-rotation-90-y_tiled_gen12_rc_ccs_cc:
- shard-iclb: NOTRUN -> [SKIP][75] ([fdo#109278]) +20 similar issues
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103111v1/shard-iclb3/igt@kms_ccs@pipe-d-bad-rotation-90-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_chamelium@hdmi-mode-timings:
- shard-iclb: NOTRUN -> [SKIP][76] ([fdo#109284] / [fdo#111827]) +4 similar issues
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103111v1/shard-iclb3/igt@kms_chamelium@hdmi-mode-timings.html
* igt@kms_color@pipe-a-deep-color:
- shard-iclb: NOTRUN -> [SKIP][77] ([fdo#109278] / [i915#3555])
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103111v1/shard-iclb3/igt@kms_color@pipe-a-deep-color.html
* igt@kms_color_chamelium@pipe-b-gamma:
- shard-apl: NOTRUN -> [SKIP][78] ([fdo#109271] / [fdo#111827]) +4 similar issues
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103111v1/shard-apl8/igt@kms_color_chamelium@pipe-b-gamma.html
* igt@kms_color_chamelium@pipe-d-ctm-0-25:
- shard-skl: NOTRUN -> [SKIP][79] ([fdo#109271] / [fdo#111827]) +6 similar issues
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103111v1/shard-skl4/igt@kms_color_chamelium@pipe-d-ctm-0-25.html
* igt@kms_color_chamelium@pipe-d-ctm-blue-to-red:
- shard-iclb: NOTRUN -> [SKIP][80] ([fdo#109278] / [fdo#109284] / [fdo#111827])
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103111v1/shard-iclb3/igt@kms_color_chamelium@pipe-d-ctm-blue-to-red.html
* igt@kms_cursor_crc@pipe-a-cursor-512x512-rapid-movement:
- shard-iclb: NOTRUN -> [SKIP][81] ([fdo#109278] / [fdo#109279]) +1 similar issue
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103111v1/shard-iclb3/igt@kms_cursor_crc@pipe-a-cursor-512x512-rapid-movement.html
* igt@kms_cursor_legacy@2x-long-flip-vs-cursor-legacy:
- shard-iclb: NOTRUN -> [SKIP][82] ([fdo#109274] / [fdo#109278]) +1 similar issue
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103111v1/shard-iclb3/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-legacy.html
* igt@kms_draw_crc@draw-method-rgb565-mmap-cpu-4tiled:
- shard-iclb: NOTRUN -> [SKIP][83] ([i915#5287])
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103111v1/shard-iclb3/igt@kms_draw_crc@draw-method-rgb565-mmap-cpu-4tiled.html
* igt@kms_fbcon_fbt@psr-suspend:
- shard-skl: [PASS][84] -> [INCOMPLETE][85] ([i915#1982] / [i915#4939])
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11550/shard-skl8/igt@kms_fbcon_fbt@psr-suspend.html
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103111v1/shard-skl1/igt@kms_fbcon_fbt@psr-suspend.html
* igt@kms_flip@2x-flip-vs-expired-vblank:
- shard-iclb: NOTRUN -> [SKIP][86] ([fdo#109274])
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103111v1/shard-iclb3/igt@kms_flip@2x-flip-vs-expired-vblank.html
* igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-16bpp-ytile-downscaling:
- shard-skl: NOTRUN -> [SKIP][87] ([fdo#109271] / [i915#3701])
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103111v1/shard-skl8/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-16bpp-ytile-downscaling.html
* igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-cur-indfb-draw-pwrite:
- shard-iclb: NOTRUN -> [SKIP][88] ([fdo#109280]) +6 similar issues
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103111v1/shard-iclb3/igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-cur-indfb-draw-pwrite.html
* igt@kms_frontbuffer_tracking@psr-suspend:
- shard-skl: [PASS][89] -> [INCOMPLETE][90] ([i915#123] / [i915#1982])
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11550/shard-skl7/igt@kms_frontbuffer_tracking@psr-suspend.html
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103111v1/shard-skl1/igt@kms_frontbuffer_tracking@psr-suspend.html
* igt@kms_invalid_mode@clock-too-high:
- shard-iclb: NOTRUN -> [SKIP][91] ([i915#4278])
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103111v1/shard-iclb3/igt@kms_invalid_mode@clock-too-high.html
* igt@kms_plane_scaling@upscale-with-rotation-factor-0-25@pipe-b-edp-1-upscale-with-rotation:
- shard-iclb: NOTRUN -> [SKIP][92] ([i915#5176]) +2 similar issues
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103111v1/shard-iclb3/igt@kms_plane_scaling@upscale-with-rotation-factor-0-25@pipe-b-edp-1-upscale-with-rotation.html
* igt@kms_psr@psr2_dpms:
- shard-iclb: NOTRUN -> [SKIP][93] ([fdo#109441])
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103111v1/shard-iclb3/igt@kms_psr@psr2_dpms.html
* igt@kms_vrr@flip-dpms:
- shard-iclb: NOTRUN -> [SKIP][94] ([i915#3555])
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103111v1/shard-iclb3/igt@kms_vrr@flip-dpms.html
* igt@kms_writeback@writeback-invalid-parameters:
- shard-apl: NOTRUN -> [SKIP][95] ([fdo#109271] / [i915#2437])
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103111v1/shard-apl6/igt@kms_writeback@writeback-invalid-parameters.html
* igt@prime_nv_pcopy@test3_4:
- shard-iclb: NOTRUN -> [SKIP][96] ([fdo#109291])
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103111v1/shard-iclb3/igt@prime_nv_pcopy@test3_4.html
* igt@syncobj_timeline@invalid-transfer-non-existent-point:
- shard-skl: NOTRUN -> [DMESG-WARN][97] ([i915#5098])
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103111v1/shard-skl9/igt@syncobj_timeline@invalid-transfer-non-existent-point.html
* igt@sysfs_clients@fair-3:
- shard-skl: NOTRUN -> [SKIP][98] ([fdo#109271] / [i915#2994]) +1 similar issue
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103111v1/shard-skl9/igt@sysfs_clients@fair-3.html
#### Possible fixes ####
* igt@gem_eio@in-flight-contexts-10ms:
- shard-tglb: [TIMEOUT][99] ([i915#3063]) -> [PASS][100]
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11550/shard-tglb3/igt@gem_eio@in-flight-contexts-10ms.html
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103111v1/shard-tglb7/igt@gem_eio@in-flight-contexts-10ms.html
* igt@gem_eio@kms:
- shard-tglb: [FAIL][101] ([i915#232]) -> [PASS][102]
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11550/shard-tglb3/igt@gem_eio@kms.html
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103111v1/shard-tglb7/igt@gem_eio@kms.html
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-tglb: [FAIL][103] ([i915#2842]) -> [PASS][104]
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11550/shard-tglb2/igt@gem_exec_fair@basic-pace-share@rcs0.html
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103111v1/shard-tglb2/igt@gem_exec_fair@basic-pace-share@rcs0.html
* igt@gem_exec_fair@basic-pace@rcs0:
- shard-kbl: [FAIL][105] ([i915#2842]) -> [PASS][106]
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11550/shard-kbl4/igt@gem_exec_fair@basic-pace@rcs0.html
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103111v1/shard-kbl4/igt@gem_exec_fair@basic-pace@rcs0.html
* igt@gem_exec_flush@basic-uc-rw-default:
- shard-snb: [SKIP][107] ([fdo#109271]) -> [PASS][108] +1 similar issue
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11550/shard-snb6/igt@gem_exec_flush@basic-uc-rw-default.html
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103111v1/shard-snb7/igt@gem_exec_flush@basic-uc-rw-default.html
* igt@gem_exec_whisper@basic-fds-forked-all:
- shard-skl: [INCOMPLETE][109] -> [PASS][110]
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11550/shard-skl5/igt@gem_exec_whisper@basic-fds-forked-all.html
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103111v1/shard-skl8/igt@gem_exec_whisper@basic-fds-forked-all.html
* igt@gem_softpin@softpin:
- shard-skl: [DMESG-WARN][111] ([i915#1982]) -> [PASS][112]
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11550/shard-skl10/igt@gem_softpin@softpin.html
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103111v1/shard-skl3/igt@gem_softpin@softpin.html
* igt@kms_async_flips@alternate-sync-async-flip:
- shard-glk: [FAIL][113] ([i915#2521]) -> [PASS][114]
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11550/shard-glk6/igt@kms_async_flips@alternate-sync-async-flip.html
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103111v1/shard-glk3/igt@kms_async_flips@alternate-sync-async-flip.html
- shard-kbl: [FAIL][115] ([i915#2521]) -> [PASS][116]
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11550/shard-kbl3/igt@kms_async_flips@alternate-sync-async-flip.html
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103111v1/shard-kbl1/igt@kms_async_flips@alternate-sync-async-flip.html
* igt@kms_cursor_crc@pipe-c-cursor-suspend:
- shard-apl: [DMESG-WARN][117] ([i915#180]) -> [PASS][118] +1 similar issue
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11550/shard-apl7/igt@kms_cursor_crc@pipe-c-cursor-suspend.html
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103111v1/shard-apl8/igt@kms_cursor_crc@pipe-c-cursor-suspend.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1:
- shard-skl: [FAIL][119] ([i915#79]) -> [PASS][120]
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11550/shard-skl3/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1.html
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103111v1/shard-skl8/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible@c-edp1:
- shard-skl: [FAIL][121] ([i915#2122]) -> [PASS][122]
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11550/shard-skl3/igt@kms_flip@flip-vs-expired-vblank-interruptible@c-edp1.html
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103111v1/shard-skl8/igt@kms_flip@flip-vs-expired-vblank-interruptible@c-edp1.html
* igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min:
- shard-skl: [FAIL][123] ([fdo#108145] / [i915#265]) -> [PASS][124]
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11550/shard-skl1/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min.html
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103111v1/shard-skl7/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min.html
* igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-5@pipe-b-edp-1-planes-upscale-downscale:
- shard-iclb: [SKIP][125] ([i915#5235]) -> [PASS][126] +2 similar issues
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11550/shard-iclb2/igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-5@pipe-b-edp-1-planes-upscale-downscale.html
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103111v1/shard-iclb5/igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-5@pipe-b-edp-1-planes-upscale-downscale.html
* igt@kms_psr@psr2_basic:
- shard-iclb: [SKIP][127] ([fdo#109441]) -> [PASS][128] +1 similar issue
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11550/shard-iclb3/igt@kms_psr@psr2_basic.html
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103111v1/shard-iclb2/igt@kms_psr@psr2_basic.html
#### Warnings ####
* igt@gem_exec_balancer@parallel:
- shard-iclb: [SKIP][129] ([i915#4525]) -> [DMESG-WARN][130] ([i915#5614]) +1 similar issue
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11550/shard-iclb6/igt@gem_exec_balancer@parallel.html
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103111v1/shard-iclb1/igt@gem_exec_balancer@parallel.html
* igt@gem_exec_balancer@parallel-contexts:
- shard-iclb: [DMESG-WARN][131] ([i915#5614]) -> [SKIP][132] ([i915#4525]) +1 similar issue
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11550/shard-iclb4/igt@gem_exec_balancer@parallel-contexts.html
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103111v1/shard-iclb3/igt@gem_exec_balancer@parallel-contexts.html
* igt@i915_pm_dc@dc3co-vpb-simulation:
- shard-iclb: [SKIP][133] ([i915#588]) -> [SKIP][134] ([i915#658])
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11550/shard-iclb2/igt@i915_pm_dc@dc3co-vpb-simulation.html
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103111v1/shard-iclb5/igt@i915_pm_dc@dc3co-vpb-simulation.html
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-c:
- shard-snb: [SKIP][135] ([fdo#109271] / [i915#5341]) -> [SKIP][136] ([fdo#109271])
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11550/shard-snb7/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-c.html
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103111v1/shard-snb5/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-c.html
* igt@kms_psr2_sf@cursor-plane-move-continuous-sf:
- shard-iclb: [SKIP][137] ([i915#2920]) -> [SKIP][138] ([i915#658])
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11550/shard-iclb2/igt@kms_psr2_sf@cursor-plane-move-continuous-sf.html
[138]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103111v1/shard-iclb8/igt@kms_psr2_sf@cursor-plane-move-continuous-sf.html
* igt@kms_psr2_sf@overlay-plane-move-continuous-sf:
- shard-iclb: [SKIP][139] ([i915#658]) -> [SKIP][140] ([i915#2920])
[139]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11550/shard-iclb7/igt@kms_psr2_sf@overlay-plane-move-continuous-sf.html
[140]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103111v1/shard-iclb2/igt@kms_psr2_sf@overlay-plane-move-continuous-sf.html
* igt@kms_psr2_sf@plane-move-sf-dmg-area:
- shard-iclb: [SKIP][141] ([i915#2920]) -> [SKIP][142] ([fdo#111068] / [i915#658]) +1 similar issue
[141]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11550/shard-iclb2/igt@kms_psr2_sf@plane-move-sf-dmg-area.html
[142]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103111v1/shard-iclb5/igt@kms_psr2_sf@plane-move-sf-dmg-area.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109279]: https://bugs.freedesktop.org/show_bug.cgi?id=109279
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109283]: https://bugs.freedesktop.org/show_bug.cgi?id=109283
[fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109291]: https://bugs.freedesktop.org/show_bug.cgi?id=109291
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[fdo#109300]: https://bugs.freedesktop.org/show_bug.cgi?id=109300
[fdo#109302]: https://bugs.freedesktop.org/show_bug.cgi?id=109302
[fdo#109303]: https://bugs.freedesktop.org/show_bug.cgi?id=109303
[fdo#109307]: https://bugs.freedesktop.org/show_bug.cgi?id=109307
[fdo#109308]: https://bugs.freedesktop.org/show_bug.cgi?id=109308
[fdo#109309]: https://bugs.freedesktop.org/show_bug.cgi?id=109309
[fdo#109312]: https://bugs.freedesktop.org/show_bug.cgi?id=109312
[fdo#109313]: https://bugs.freedesktop.org/show_bug.cgi?id=109313
[fdo#109314]: https://bugs.freedesktop.org/show_bug.cgi?id=109314
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109506]: https://bugs.freedesktop.org/show_bug.cgi?id=109506
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#110542]: https://bugs.freedesktop.org/show_bug.cgi?id=110542
[fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723
[fdo#110725]: https://bugs.freedesktop.org/show_bug.cgi?id=110725
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111314]: https://bugs.freedesktop.org/show_bug.cgi?id=111314
[fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111644]: https://bugs.freedesktop.org/show_bug.cgi?id=111644
[fdo#111656]: https://bugs.freedesktop.org/show_bug.cgi?id=111656
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[fdo#112022]: https://bugs.freedesktop.org/show_bug.cgi?id=112022
[fdo#112054]: https://bugs.freedesktop.org/show_bug.cgi?id=112054
[fdo#112283]: https://bugs.freedesktop.org/show_bug.cgi?id=112283
[i915#1063]: https://gitlab.freedesktop.org/drm/intel/issues/1063
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1149]: https://gitlab.freedesktop.org/drm/intel/issues/1149
[i915#1155]: https://gitlab.freedesktop.org/drm/intel/issues/1155
[i915#123]: https://gitlab.freedesktop.org/drm/intel/issues/123
[i915#132]: https://gitlab.freedesktop.org/drm/intel/issues/132
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#1722]: https://gitlab.freedesktop.org/drm/intel/issues/1722
[i915#1769]: https://gitlab.freedesktop.org/drm/intel/issues/1769
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825
[i915#1836]: https://gitlab.freedesktop.org/drm/intel/issues/1836
[i915#1839]: https://gitlab.freedesktop.org/drm/intel/issues/1839
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849
[i915#1850]: https://gitlab.freedesktop.org/drm/intel/issues/1850
[i915#1902]: https://gitlab.freedesktop.org/drm/intel/issues/1902
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2295]: https://gitlab.freedesktop.org/drm/intel/issues/2295
[i915#232]: https://gitlab.freedesktop.org/drm/intel/issues/232
[i915#2410]: https://gitlab.freedesktop.org/drm/intel/issues/2410
[i915#2434]: https://gitlab.freedesktop.org/drm/intel/issues/2434
[i915#2435]: https://gitlab.freedesktop.org/drm/intel/issues/2435
[i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
[i915#2521]: https://gitlab.freedesktop.org/drm/intel/issues/2521
[i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
[i915#2530]: https://gitlab.freedesktop.org/drm/intel/issues/2530
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#2658]: https://gitlab.freedesktop.org/drm/intel/issues/2658
[i915#2681]: https://gitlab.freedesktop.org/drm/intel/issues/2681
[i915#2705]: https://gitlab.freedesktop.org/drm/intel/issues/2705
[i915#280]: https://gitlab.freedesktop.org/drm/intel/issues/280
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2856]: https://gitlab.freedesktop.org/drm/intel/issues/2856
[i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
[i915#2994]: https://gitlab.freedesktop.org/drm/intel/issues/2994
[i915#3002]: https://gitlab.freedesktop.org/drm/intel/issues/3002
[i915#3012]: https://gitlab.freedesktop.org/drm/intel/issues/3012
[i915#3063]: https://gitlab.freedesktop.org/drm/intel/issues/3063
[i915#3116]: https://gitlab.freedesktop.org/drm/intel/issues/3116
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291
[i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
[i915#3299]: https://gitlab.freedesktop.org/drm/intel/issues/3299
[i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301
[i915#3318]: https://gitlab.freedesktop.org/drm/intel/issues/3318
[i915#3319]: https://gitlab.freedesktop.org/drm/intel/issues/3319
[i915#3323]: https://gitlab.freedesktop.org/drm/intel/issues/3323
[i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359
[i915#3376]: https://gitlab.freedesktop.org/drm/intel/issues/3376
[i915#3464]: https://gitlab.freedesktop.org/drm/intel/issues/3464
[i915#3469]: https://gitlab.freedesktop.org/drm/intel/issues/3469
[i915#3528]: https://gitlab.freedesktop.org/drm/intel/issues/3528
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3558]: https://gitlab.freedesktop.org/drm/intel/issues/3558
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638
[i915#3648]: https://gitlab.freedesktop.org/drm/intel/issues/3648
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3701]: https://gitlab.freedesktop.org/drm/intel/issues/3701
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#3734]: https://gitlab.freedesktop.org/drm/intel/issues/3734
[i915#3736]: https://gitlab.freedesktop.org/drm/intel/issues/3736
[i915#3742]: https://gitlab.freedesktop.org/drm/intel/issues/3742
[i915#3777]: https://gitlab.freedesktop.org/drm/intel/issues/3777
[i915#3825]: https://gitlab.freedesktop.org/drm/intel/issues/3825
[i915#3826]: https://gitlab.freedesktop.org/drm/intel/issues/3826
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3921]: https://gitlab.freedesktop.org/drm/intel/issues/3921
[i915#3955]: https://gitlab.freedesktop.org/drm/intel/issues/3955
[i915#3966]: https://gitlab.freedesktop.org/drm/intel/issues/3966
[i915#404]: https://gitlab.freedesktop.org/drm/intel/issues/404
[i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070
[i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#426]: https://gitlab.freedesktop.org/drm/intel/issues/426
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#4278]: https://gitlab.freedesktop.org/drm/intel/issues/4278
[i915#4281]: https://gitlab.freedesktop.org/drm/intel/issues/4281
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4369]: https://gitlab.freedesktop.org/drm/intel/issues/4369
[i915#4387]: https://gitlab.freedesktop.org/drm/intel/issues/4387
[i915#4525]: https://gitlab.freedesktop.org/drm/intel/issues/4525
[i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4877]: https://gitlab.freedesktop.org/drm/intel/issues/4877
[i915#4939]: https://gitlab.freedesktop.org/drm/intel/issues/4939
[i915#4991]: https://gitlab.freedesktop.org/drm/intel/issues/4991
[i915#5032]: https://gitlab.freedesktop.org/drm/intel/issues/5032
[i915#5076]: https://gitlab.freedesktop.org/drm/intel/issues/5076
[i915#5098]: https://gitlab.freedesktop.org/drm/intel/issues/5098
[i915#5115]: https://gitlab.freedesktop.org/drm/intel/issues/5115
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5182]: https://gitlab.freedesktop.org/drm/intel/issues/5182
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5257]: https://gitlab.freedesktop.org/drm/intel/issues/5257
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5287]: https://gitlab.freedesktop.org/drm/intel/issues/5287
[i915#5288]: https://gitlab.freedesktop.org/drm/intel/issues/5288
[i915#5289]: https://gitlab.freedesktop.org/drm/intel/issues/5289
[i915#5325]: https://gitlab.freedesktop.org/drm/intel/issues/5325
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#5341]: https://gitlab.freedesktop.org/drm/intel/issues/5341
[i915#5385]: https://gitlab.freedesktop.org/drm/intel/issues/5385
[i915#5439]: https://gitlab.freedesktop.org/drm/intel/issues/5439
[i915#5461]: https://gitlab.freedesktop.org/drm/intel/issues/5461
[i915#5614]: https://gitlab.freedesktop.org/drm/intel/issues/5614
[i915#5691]: https://gitlab.freedesktop.org/drm/intel/issues/5691
[i915#5723]: https://gitlab.freedesktop.org/drm/intel/issues/5723
[i915#588]: https://gitlab.freedesktop.org/drm/intel/issues/588
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#768]: https://gitlab.freedesktop.org/drm/intel/issues/768
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
Build changes
-------------
* Linux: CI_DRM_11550 -> Patchwork_103111v1
CI-20190529: 20190529
CI_DRM_11550: 56b089ae03ef8ea8ab7f474eaa70367898891ef0 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6451: f055bd83bd831a938d639718c2359516224f15f9 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_103111v1: 56b089ae03ef8ea8ab7f474eaa70367898891ef0 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103111v1/index.html
[-- Attachment #2: Type: text/html, Size: 36923 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Intel-gfx] [PATCH] i915/guc/reset: Make __guc_reset_context aware of guilty engines
2022-04-26 0:30 [Intel-gfx] [PATCH] i915/guc/reset: Make __guc_reset_context aware of guilty engines Umesh Nerlige Ramappa
2022-04-26 1:39 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2022-04-26 3:46 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
@ 2022-04-28 16:13 ` Teres Alexis, Alan Previn
2022-05-02 20:07 ` Umesh Nerlige Ramappa
2 siblings, 1 reply; 6+ messages in thread
From: Teres Alexis, Alan Previn @ 2022-04-28 16:13 UTC (permalink / raw)
To: Harrison, John C, Nerlige Ramappa, Umesh, intel-gfx,
Ceraolo Spurio, Daniele, Brost, Matthew
At a high level, this change looks good and simple.
However, inside __guc_reset_context, i think there might be
an observed change in behavior for parallel submission.
(or perhaps this change is part the intent?):
Unless my understanding is incorrect, assuming a
parallel submission comes in with virtual engines that
repeat the same kinds of workloads across multiple
physical engines (which i assume would be the typical
end-user usage of this UAPI feature), we would end up
marking the parent content (and other children contexts
that use the same engine) as guilty but not children
contexts that are running on a different engine.
I'm not sure if this would be an expected UAPI response
for parallel submission. (i.e. one or more children
get a re-run on other engines? I havent checked if
the replay is revoked later if the parent's or sibling's
'request' was reset and marked as -EIO ... this marking
of req->force_error as -EIO or -EAGAIN is part of the
call to __i915_request_reset where the guilty param
value sees this change i am referring to).
Is this intended / expected?
...alan
On Mon, 2022-04-25 at 17:30 -0700, Umesh Nerlige Ramappa wrote:
> There are 2 ways an engine can get reset in i915 and the method of reset
> affects how KMD labels a context as guilty/innocent.
>
> (1) GuC initiated engine-reset: GuC resets a hung engine and notifies
> KMD. The context that hung on the engine is marked guilty and all other
> contexts are innocent. The innocent contexts are resubmitted.
>
> (2) GT based reset: When an engine heartbeat fails to tick, KMD
> initiates a gt/chip reset. All active contexts are marked as guilty and
> discarded.
>
> In order to correctly mark the contexts as guilty/innocent, pass a mask
> of engines that were reset to __guc_reset_context.
>
> Fixes: eb5e7da736f3 ("drm/i915/guc: Reset implementation for new GuC interface")
> Signed-off-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
> ---
> drivers/gpu/drm/i915/gt/intel_reset.c | 2 +-
> drivers/gpu/drm/i915/gt/uc/intel_guc.h | 2 +-
> .../gpu/drm/i915/gt/uc/intel_guc_submission.c | 16 ++++++++--------
> drivers/gpu/drm/i915/gt/uc/intel_uc.c | 2 +-
> drivers/gpu/drm/i915/gt/uc/intel_uc.h | 2 +-
> 5 files changed, 12 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/intel_reset.c b/drivers/gpu/drm/i915/gt/intel_reset.c
> index 5422a3b84bd4..a5338c3fde7a 100644
> --- a/drivers/gpu/drm/i915/gt/intel_reset.c
> +++ b/drivers/gpu/drm/i915/gt/intel_reset.c
> @@ -808,7 +808,7 @@ static int gt_reset(struct intel_gt *gt, intel_engine_mask_t stalled_mask)
> __intel_engine_reset(engine, stalled_mask & engine->mask);
> local_bh_enable();
>
> - intel_uc_reset(>->uc, true);
> + intel_uc_reset(>->uc, ALL_ENGINES);
>
> intel_ggtt_restore_fences(gt->ggtt);
>
> diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc.h b/drivers/gpu/drm/i915/gt/uc/intel_guc.h
> index 3f3373f68123..966e69a8b1c1 100644
> --- a/drivers/gpu/drm/i915/gt/uc/intel_guc.h
> +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc.h
> @@ -443,7 +443,7 @@ int intel_guc_global_policies_update(struct intel_guc *guc);
> void intel_guc_context_ban(struct intel_context *ce, struct i915_request *rq);
>
> void intel_guc_submission_reset_prepare(struct intel_guc *guc);
> -void intel_guc_submission_reset(struct intel_guc *guc, bool stalled);
> +void intel_guc_submission_reset(struct intel_guc *guc, intel_engine_mask_t stalled);
> void intel_guc_submission_reset_finish(struct intel_guc *guc);
> void intel_guc_submission_cancel_requests(struct intel_guc *guc);
>
> diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c b/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c
> index 61a6f2424e24..1fbf7b6c2740 100644
> --- a/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c
> +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c
> @@ -1667,9 +1667,9 @@ __unwind_incomplete_requests(struct intel_context *ce)
> spin_unlock_irqrestore(&sched_engine->lock, flags);
> }
>
> -static void __guc_reset_context(struct intel_context *ce, bool stalled)
> +static void __guc_reset_context(struct intel_context *ce, intel_engine_mask_t stalled)
> {
> - bool local_stalled;
> + bool guilty;
> struct i915_request *rq;
> unsigned long flags;
> u32 head;
> @@ -1697,7 +1697,7 @@ static void __guc_reset_context(struct intel_context *ce, bool stalled)
> if (!intel_context_is_pinned(ce))
> goto next_context;
>
> - local_stalled = false;
> + guilty = false;
> rq = intel_context_find_active_request(ce);
> if (!rq) {
> head = ce->ring->tail;
> @@ -1705,14 +1705,14 @@ static void __guc_reset_context(struct intel_context *ce, bool stalled)
> }
>
> if (i915_request_started(rq))
> - local_stalled = true;
> + guilty = stalled & ce->engine->mask;
>
> GEM_BUG_ON(i915_active_is_idle(&ce->active));
> head = intel_ring_wrap(ce->ring, rq->head);
>
> - __i915_request_reset(rq, local_stalled && stalled);
> + __i915_request_reset(rq, guilty);
> out_replay:
> - guc_reset_state(ce, head, local_stalled && stalled);
> + guc_reset_state(ce, head, guilty);
> next_context:
> if (i != number_children)
> ce = list_next_entry(ce, parallel.child_link);
> @@ -1722,7 +1722,7 @@ static void __guc_reset_context(struct intel_context *ce, bool stalled)
> intel_context_put(parent);
> }
>
> -void intel_guc_submission_reset(struct intel_guc *guc, bool stalled)
> +void intel_guc_submission_reset(struct intel_guc *guc, intel_engine_mask_t stalled)
> {
> struct intel_context *ce;
> unsigned long index;
> @@ -4217,7 +4217,7 @@ static void guc_context_replay(struct intel_context *ce)
> {
> struct i915_sched_engine *sched_engine = ce->engine->sched_engine;
>
> - __guc_reset_context(ce, true);
> + __guc_reset_context(ce, ce->engine->mask);
> tasklet_hi_schedule(&sched_engine->tasklet);
> }
>
> diff --git a/drivers/gpu/drm/i915/gt/uc/intel_uc.c b/drivers/gpu/drm/i915/gt/uc/intel_uc.c
> index 8c9ef690ac9d..e8f099360e01 100644
> --- a/drivers/gpu/drm/i915/gt/uc/intel_uc.c
> +++ b/drivers/gpu/drm/i915/gt/uc/intel_uc.c
> @@ -595,7 +595,7 @@ void intel_uc_reset_prepare(struct intel_uc *uc)
> __uc_sanitize(uc);
> }
>
> -void intel_uc_reset(struct intel_uc *uc, bool stalled)
> +void intel_uc_reset(struct intel_uc *uc, intel_engine_mask_t stalled)
> {
> struct intel_guc *guc = &uc->guc;
>
> diff --git a/drivers/gpu/drm/i915/gt/uc/intel_uc.h b/drivers/gpu/drm/i915/gt/uc/intel_uc.h
> index 866b462821c0..a8f38c2c60e2 100644
> --- a/drivers/gpu/drm/i915/gt/uc/intel_uc.h
> +++ b/drivers/gpu/drm/i915/gt/uc/intel_uc.h
> @@ -42,7 +42,7 @@ void intel_uc_driver_late_release(struct intel_uc *uc);
> void intel_uc_driver_remove(struct intel_uc *uc);
> void intel_uc_init_mmio(struct intel_uc *uc);
> void intel_uc_reset_prepare(struct intel_uc *uc);
> -void intel_uc_reset(struct intel_uc *uc, bool stalled);
> +void intel_uc_reset(struct intel_uc *uc, intel_engine_mask_t stalled);
> void intel_uc_reset_finish(struct intel_uc *uc);
> void intel_uc_cancel_requests(struct intel_uc *uc);
> void intel_uc_suspend(struct intel_uc *uc);
> --
> 2.35.1
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Intel-gfx] [PATCH] i915/guc/reset: Make __guc_reset_context aware of guilty engines
2022-04-28 16:13 ` [Intel-gfx] [PATCH] " Teres Alexis, Alan Previn
@ 2022-05-02 20:07 ` Umesh Nerlige Ramappa
2022-05-04 21:01 ` Teres Alexis, Alan Previn
0 siblings, 1 reply; 6+ messages in thread
From: Umesh Nerlige Ramappa @ 2022-05-02 20:07 UTC (permalink / raw)
To: Teres Alexis, Alan Previn; +Cc: intel-gfx
On Thu, Apr 28, 2022 at 09:13:57AM -0700, Teres Alexis, Alan Previn wrote:
>At a high level, this change looks good and simple.
>However, inside __guc_reset_context, i think there might be
>an observed change in behavior for parallel submission.
>(or perhaps this change is part the intent?):
>
> Unless my understanding is incorrect, assuming a
> parallel submission comes in with virtual engines that
> repeat the same kinds of workloads across multiple
> physical engines (which i assume would be the typical
> end-user usage of this UAPI feature), we would end up
> marking the parent content (and other children contexts
> that use the same engine) as guilty but not children
> contexts that are running on a different engine.
> I'm not sure if this would be an expected UAPI response
> for parallel submission. (i.e. one or more children
> get a re-run on other engines? I havent checked if
> the replay is revoked later if the parent's or sibling's
> 'request' was reset and marked as -EIO ... this marking
> of req->force_error as -EIO or -EAGAIN is part of the
> call to __i915_request_reset where the guilty param
> value sees this change i am referring to).
>
>Is this intended / expected?
Expectation: For virtual engine, only the virtual context must be marked
guilty. For parallel engines, parent/child contexts must be marked as
guilty.
Looking into the code, I see the expected behavior is already taken care
of.
For virtual engines, only one context is created with a mask of engines
that can be used by GuC. This context is registered with GuC and the
workloads are run on any one of these engines. When a reset occurs, the
G2H notification points to this context. When the __guc_reset_context
executes, it will only mark this context as guilty.
fwiu, for parallel submission, if N engines can run in parallel, then N
contexts are submitted. If there are no siblings, then there is only one
parent and the below reset logic works fine because G2H has only the
parent context.
If there are more than 1 siblings in parallel submission, then the
execution between siblings is just treated like virtual engines where
the parent has the mask of engines used. In this case, G2H points to
parent context and parent has a mask of all sibling engines, so this
works as expected too (in __guc_reset_context).
Thanks,
Umesh
>
>...alan
>
>
>On Mon, 2022-04-25 at 17:30 -0700, Umesh Nerlige Ramappa wrote:
>> There are 2 ways an engine can get reset in i915 and the method of reset
>> affects how KMD labels a context as guilty/innocent.
>>
>> (1) GuC initiated engine-reset: GuC resets a hung engine and notifies
>> KMD. The context that hung on the engine is marked guilty and all other
>> contexts are innocent. The innocent contexts are resubmitted.
>>
>> (2) GT based reset: When an engine heartbeat fails to tick, KMD
>> initiates a gt/chip reset. All active contexts are marked as guilty and
>> discarded.
>>
>> In order to correctly mark the contexts as guilty/innocent, pass a mask
>> of engines that were reset to __guc_reset_context.
>>
>> Fixes: eb5e7da736f3 ("drm/i915/guc: Reset implementation for new GuC interface")
>> Signed-off-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
>> ---
>> drivers/gpu/drm/i915/gt/intel_reset.c | 2 +-
>> drivers/gpu/drm/i915/gt/uc/intel_guc.h | 2 +-
>> .../gpu/drm/i915/gt/uc/intel_guc_submission.c | 16 ++++++++--------
>> drivers/gpu/drm/i915/gt/uc/intel_uc.c | 2 +-
>> drivers/gpu/drm/i915/gt/uc/intel_uc.h | 2 +-
>> 5 files changed, 12 insertions(+), 12 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/gt/intel_reset.c b/drivers/gpu/drm/i915/gt/intel_reset.c
>> index 5422a3b84bd4..a5338c3fde7a 100644
>> --- a/drivers/gpu/drm/i915/gt/intel_reset.c
>> +++ b/drivers/gpu/drm/i915/gt/intel_reset.c
>> @@ -808,7 +808,7 @@ static int gt_reset(struct intel_gt *gt, intel_engine_mask_t stalled_mask)
>> __intel_engine_reset(engine, stalled_mask & engine->mask);
>> local_bh_enable();
>>
>> - intel_uc_reset(>->uc, true);
>> + intel_uc_reset(>->uc, ALL_ENGINES);
>>
>> intel_ggtt_restore_fences(gt->ggtt);
>>
>> diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc.h b/drivers/gpu/drm/i915/gt/uc/intel_guc.h
>> index 3f3373f68123..966e69a8b1c1 100644
>> --- a/drivers/gpu/drm/i915/gt/uc/intel_guc.h
>> +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc.h
>> @@ -443,7 +443,7 @@ int intel_guc_global_policies_update(struct intel_guc *guc);
>> void intel_guc_context_ban(struct intel_context *ce, struct i915_request *rq);
>>
>> void intel_guc_submission_reset_prepare(struct intel_guc *guc);
>> -void intel_guc_submission_reset(struct intel_guc *guc, bool stalled);
>> +void intel_guc_submission_reset(struct intel_guc *guc, intel_engine_mask_t stalled);
>> void intel_guc_submission_reset_finish(struct intel_guc *guc);
>> void intel_guc_submission_cancel_requests(struct intel_guc *guc);
>>
>> diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c b/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c
>> index 61a6f2424e24..1fbf7b6c2740 100644
>> --- a/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c
>> +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c
>> @@ -1667,9 +1667,9 @@ __unwind_incomplete_requests(struct intel_context *ce)
>> spin_unlock_irqrestore(&sched_engine->lock, flags);
>> }
>>
>> -static void __guc_reset_context(struct intel_context *ce, bool stalled)
>> +static void __guc_reset_context(struct intel_context *ce, intel_engine_mask_t stalled)
>> {
>> - bool local_stalled;
>> + bool guilty;
>> struct i915_request *rq;
>> unsigned long flags;
>> u32 head;
>> @@ -1697,7 +1697,7 @@ static void __guc_reset_context(struct intel_context *ce, bool stalled)
>> if (!intel_context_is_pinned(ce))
>> goto next_context;
>>
>> - local_stalled = false;
>> + guilty = false;
>> rq = intel_context_find_active_request(ce);
>> if (!rq) {
>> head = ce->ring->tail;
>> @@ -1705,14 +1705,14 @@ static void __guc_reset_context(struct intel_context *ce, bool stalled)
>> }
>>
>> if (i915_request_started(rq))
>> - local_stalled = true;
>> + guilty = stalled & ce->engine->mask;
>>
>> GEM_BUG_ON(i915_active_is_idle(&ce->active));
>> head = intel_ring_wrap(ce->ring, rq->head);
>>
>> - __i915_request_reset(rq, local_stalled && stalled);
>> + __i915_request_reset(rq, guilty);
>> out_replay:
>> - guc_reset_state(ce, head, local_stalled && stalled);
>> + guc_reset_state(ce, head, guilty);
>> next_context:
>> if (i != number_children)
>> ce = list_next_entry(ce, parallel.child_link);
>> @@ -1722,7 +1722,7 @@ static void __guc_reset_context(struct intel_context *ce, bool stalled)
>> intel_context_put(parent);
>> }
>>
>> -void intel_guc_submission_reset(struct intel_guc *guc, bool stalled)
>> +void intel_guc_submission_reset(struct intel_guc *guc, intel_engine_mask_t stalled)
>> {
>> struct intel_context *ce;
>> unsigned long index;
>> @@ -4217,7 +4217,7 @@ static void guc_context_replay(struct intel_context *ce)
>> {
>> struct i915_sched_engine *sched_engine = ce->engine->sched_engine;
>>
>> - __guc_reset_context(ce, true);
>> + __guc_reset_context(ce, ce->engine->mask);
>> tasklet_hi_schedule(&sched_engine->tasklet);
>> }
>>
>> diff --git a/drivers/gpu/drm/i915/gt/uc/intel_uc.c b/drivers/gpu/drm/i915/gt/uc/intel_uc.c
>> index 8c9ef690ac9d..e8f099360e01 100644
>> --- a/drivers/gpu/drm/i915/gt/uc/intel_uc.c
>> +++ b/drivers/gpu/drm/i915/gt/uc/intel_uc.c
>> @@ -595,7 +595,7 @@ void intel_uc_reset_prepare(struct intel_uc *uc)
>> __uc_sanitize(uc);
>> }
>>
>> -void intel_uc_reset(struct intel_uc *uc, bool stalled)
>> +void intel_uc_reset(struct intel_uc *uc, intel_engine_mask_t stalled)
>> {
>> struct intel_guc *guc = &uc->guc;
>>
>> diff --git a/drivers/gpu/drm/i915/gt/uc/intel_uc.h b/drivers/gpu/drm/i915/gt/uc/intel_uc.h
>> index 866b462821c0..a8f38c2c60e2 100644
>> --- a/drivers/gpu/drm/i915/gt/uc/intel_uc.h
>> +++ b/drivers/gpu/drm/i915/gt/uc/intel_uc.h
>> @@ -42,7 +42,7 @@ void intel_uc_driver_late_release(struct intel_uc *uc);
>> void intel_uc_driver_remove(struct intel_uc *uc);
>> void intel_uc_init_mmio(struct intel_uc *uc);
>> void intel_uc_reset_prepare(struct intel_uc *uc);
>> -void intel_uc_reset(struct intel_uc *uc, bool stalled);
>> +void intel_uc_reset(struct intel_uc *uc, intel_engine_mask_t stalled);
>> void intel_uc_reset_finish(struct intel_uc *uc);
>> void intel_uc_cancel_requests(struct intel_uc *uc);
>> void intel_uc_suspend(struct intel_uc *uc);
>> --
>> 2.35.1
>>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Intel-gfx] [PATCH] i915/guc/reset: Make __guc_reset_context aware of guilty engines
2022-05-02 20:07 ` Umesh Nerlige Ramappa
@ 2022-05-04 21:01 ` Teres Alexis, Alan Previn
0 siblings, 0 replies; 6+ messages in thread
From: Teres Alexis, Alan Previn @ 2022-05-04 21:01 UTC (permalink / raw)
To: Nerlige Ramappa, Umesh; +Cc: intel-gfx
Thanks Umesh for clarifying that question. With that, here is my rvb and apologies for the tardiness.
Reviewed-by: Alan Previn <alan.previn.teres.alexis@intel.com>
On Mon, 2022-05-02 at 13:07 -0700, Umesh Nerlige Ramappa wrote:
> On Thu, Apr 28, 2022 at 09:13:57AM -0700, Teres Alexis, Alan Previn wrote:
> > At a high level, this change looks good and simple.
> > However, inside __guc_reset_context, i think there might be
> > an observed change in behavior for parallel submission.
> > (or perhaps this change is part the intent?):
> >
> > Unless my understanding is incorrect, assuming a
> > parallel submission comes in with virtual engines that
> > repeat the same kinds of workloads across multiple
> > physical engines (which i assume would be the typical
> > end-user usage of this UAPI feature), we would end up
> > marking the parent content (and other children contexts
> > that use the same engine) as guilty but not children
> > contexts that are running on a different engine.
> > I'm not sure if this would be an expected UAPI response
> > for parallel submission. (i.e. one or more children
> > get a re-run on other engines? I havent checked if
> > the replay is revoked later if the parent's or sibling's
> > 'request' was reset and marked as -EIO ... this marking
> > of req->force_error as -EIO or -EAGAIN is part of the
> > call to __i915_request_reset where the guilty param
> > value sees this change i am referring to).
> >
> > Is this intended / expected?
>
> Expectation: For virtual engine, only the virtual context must be marked
> guilty. For parallel engines, parent/child contexts must be marked as
> guilty.
>
> Looking into the code, I see the expected behavior is already taken care
> of.
>
> For virtual engines, only one context is created with a mask of engines
> that can be used by GuC. This context is registered with GuC and the
> workloads are run on any one of these engines. When a reset occurs, the
> G2H notification points to this context. When the __guc_reset_context
> executes, it will only mark this context as guilty.
>
> fwiu, for parallel submission, if N engines can run in parallel, then N
> contexts are submitted. If there are no siblings, then there is only one
> parent and the below reset logic works fine because G2H has only the
> parent context.
>
> If there are more than 1 siblings in parallel submission, then the
> execution between siblings is just treated like virtual engines where
> the parent has the mask of engines used. In this case, G2H points to
> parent context and parent has a mask of all sibling engines, so this
> works as expected too (in __guc_reset_context).
>
> Thanks,
> Umesh
>
> > ...alan
> >
> >
> > On Mon, 2022-04-25 at 17:30 -0700, Umesh Nerlige Ramappa wrote:
> > > There are 2 ways an engine can get reset in i915 and the method of reset
> > > affects how KMD labels a context as guilty/innocent.
> > >
> > > (1) GuC initiated engine-reset: GuC resets a hung engine and notifies
> > > KMD. The context that hung on the engine is marked guilty and all other
> > > contexts are innocent. The innocent contexts are resubmitted.
> > >
> > > (2) GT based reset: When an engine heartbeat fails to tick, KMD
> > > initiates a gt/chip reset. All active contexts are marked as guilty and
> > > discarded.
> > >
> > > In order to correctly mark the contexts as guilty/innocent, pass a mask
> > > of engines that were reset to __guc_reset_context.
> > >
> > > Fixes: eb5e7da736f3 ("drm/i915/guc: Reset implementation for new GuC interface")
> > > Signed-off-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
> > > ---
> > > drivers/gpu/drm/i915/gt/intel_reset.c | 2 +-
> > > drivers/gpu/drm/i915/gt/uc/intel_guc.h | 2 +-
> > > .../gpu/drm/i915/gt/uc/intel_guc_submission.c | 16 ++++++++--------
> > > drivers/gpu/drm/i915/gt/uc/intel_uc.c | 2 +-
> > > drivers/gpu/drm/i915/gt/uc/intel_uc.h | 2 +-
> > > 5 files changed, 12 insertions(+), 12 deletions(-)
> > >
> > > diff --git a/drivers/gpu/drm/i915/gt/intel_reset.c b/drivers/gpu/drm/i915/gt/intel_reset.c
> > > index 5422a3b84bd4..a5338c3fde7a 100644
> > > --- a/drivers/gpu/drm/i915/gt/intel_reset.c
> > > +++ b/drivers/gpu/drm/i915/gt/intel_reset.c
> > > @@ -808,7 +808,7 @@ static int gt_reset(struct intel_gt *gt, intel_engine_mask_t stalled_mask)
> > > __intel_engine_reset(engine, stalled_mask & engine->mask);
> > > local_bh_enable();
> > >
> > > - intel_uc_reset(>->uc, true);
> > > + intel_uc_reset(>->uc, ALL_ENGINES);
> > >
> > > intel_ggtt_restore_fences(gt->ggtt);
> > >
> > > diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc.h b/drivers/gpu/drm/i915/gt/uc/intel_guc.h
> > > index 3f3373f68123..966e69a8b1c1 100644
> > > --- a/drivers/gpu/drm/i915/gt/uc/intel_guc.h
> > > +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc.h
> > > @@ -443,7 +443,7 @@ int intel_guc_global_policies_update(struct intel_guc *guc);
> > > void intel_guc_context_ban(struct intel_context *ce, struct i915_request *rq);
> > >
> > > void intel_guc_submission_reset_prepare(struct intel_guc *guc);
> > > -void intel_guc_submission_reset(struct intel_guc *guc, bool stalled);
> > > +void intel_guc_submission_reset(struct intel_guc *guc, intel_engine_mask_t stalled);
> > > void intel_guc_submission_reset_finish(struct intel_guc *guc);
> > > void intel_guc_submission_cancel_requests(struct intel_guc *guc);
> > >
> > > diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c b/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c
> > > index 61a6f2424e24..1fbf7b6c2740 100644
> > > --- a/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c
> > > +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c
> > > @@ -1667,9 +1667,9 @@ __unwind_incomplete_requests(struct intel_context *ce)
> > > spin_unlock_irqrestore(&sched_engine->lock, flags);
> > > }
> > >
> > > -static void __guc_reset_context(struct intel_context *ce, bool stalled)
> > > +static void __guc_reset_context(struct intel_context *ce, intel_engine_mask_t stalled)
> > > {
> > > - bool local_stalled;
> > > + bool guilty;
> > > struct i915_request *rq;
> > > unsigned long flags;
> > > u32 head;
> > > @@ -1697,7 +1697,7 @@ static void __guc_reset_context(struct intel_context *ce, bool stalled)
> > > if (!intel_context_is_pinned(ce))
> > > goto next_context;
> > >
> > > - local_stalled = false;
> > > + guilty = false;
> > > rq = intel_context_find_active_request(ce);
> > > if (!rq) {
> > > head = ce->ring->tail;
> > > @@ -1705,14 +1705,14 @@ static void __guc_reset_context(struct intel_context *ce, bool stalled)
> > > }
> > >
> > > if (i915_request_started(rq))
> > > - local_stalled = true;
> > > + guilty = stalled & ce->engine->mask;
> > >
> > > GEM_BUG_ON(i915_active_is_idle(&ce->active));
> > > head = intel_ring_wrap(ce->ring, rq->head);
> > >
> > > - __i915_request_reset(rq, local_stalled && stalled);
> > > + __i915_request_reset(rq, guilty);
> > > out_replay:
> > > - guc_reset_state(ce, head, local_stalled && stalled);
> > > + guc_reset_state(ce, head, guilty);
> > > next_context:
> > > if (i != number_children)
> > > ce = list_next_entry(ce, parallel.child_link);
> > > @@ -1722,7 +1722,7 @@ static void __guc_reset_context(struct intel_context *ce, bool stalled)
> > > intel_context_put(parent);
> > > }
> > >
> > > -void intel_guc_submission_reset(struct intel_guc *guc, bool stalled)
> > > +void intel_guc_submission_reset(struct intel_guc *guc, intel_engine_mask_t stalled)
> > > {
> > > struct intel_context *ce;
> > > unsigned long index;
> > > @@ -4217,7 +4217,7 @@ static void guc_context_replay(struct intel_context *ce)
> > > {
> > > struct i915_sched_engine *sched_engine = ce->engine->sched_engine;
> > >
> > > - __guc_reset_context(ce, true);
> > > + __guc_reset_context(ce, ce->engine->mask);
> > > tasklet_hi_schedule(&sched_engine->tasklet);
> > > }
> > >
> > > diff --git a/drivers/gpu/drm/i915/gt/uc/intel_uc.c b/drivers/gpu/drm/i915/gt/uc/intel_uc.c
> > > index 8c9ef690ac9d..e8f099360e01 100644
> > > --- a/drivers/gpu/drm/i915/gt/uc/intel_uc.c
> > > +++ b/drivers/gpu/drm/i915/gt/uc/intel_uc.c
> > > @@ -595,7 +595,7 @@ void intel_uc_reset_prepare(struct intel_uc *uc)
> > > __uc_sanitize(uc);
> > > }
> > >
> > > -void intel_uc_reset(struct intel_uc *uc, bool stalled)
> > > +void intel_uc_reset(struct intel_uc *uc, intel_engine_mask_t stalled)
> > > {
> > > struct intel_guc *guc = &uc->guc;
> > >
> > > diff --git a/drivers/gpu/drm/i915/gt/uc/intel_uc.h b/drivers/gpu/drm/i915/gt/uc/intel_uc.h
> > > index 866b462821c0..a8f38c2c60e2 100644
> > > --- a/drivers/gpu/drm/i915/gt/uc/intel_uc.h
> > > +++ b/drivers/gpu/drm/i915/gt/uc/intel_uc.h
> > > @@ -42,7 +42,7 @@ void intel_uc_driver_late_release(struct intel_uc *uc);
> > > void intel_uc_driver_remove(struct intel_uc *uc);
> > > void intel_uc_init_mmio(struct intel_uc *uc);
> > > void intel_uc_reset_prepare(struct intel_uc *uc);
> > > -void intel_uc_reset(struct intel_uc *uc, bool stalled);
> > > +void intel_uc_reset(struct intel_uc *uc, intel_engine_mask_t stalled);
> > > void intel_uc_reset_finish(struct intel_uc *uc);
> > > void intel_uc_cancel_requests(struct intel_uc *uc);
> > > void intel_uc_suspend(struct intel_uc *uc);
> > > --
> > > 2.35.1
> > >
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-05-04 21:02 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-26 0:30 [Intel-gfx] [PATCH] i915/guc/reset: Make __guc_reset_context aware of guilty engines Umesh Nerlige Ramappa
2022-04-26 1:39 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2022-04-26 3:46 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2022-04-28 16:13 ` [Intel-gfx] [PATCH] " Teres Alexis, Alan Previn
2022-05-02 20:07 ` Umesh Nerlige Ramappa
2022-05-04 21:01 ` Teres Alexis, Alan Previn
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.