From: Kalle Valo <kvalo@kernel.org>
To: Kevin Lo <kevlo@kevlo.org>
Cc: Ping-Ke Shih <pkshih@realtek.com>, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] rtw88: use the correct bit in the REG_HCI_OPT_CTRL register
Date: Wed, 27 Apr 2022 04:58:18 +0000 (UTC) [thread overview]
Message-ID: <165103549637.18987.9142437749277361997.kvalo@kernel.org> (raw)
In-Reply-To: <YmLAzuyPr0P4Y6BP@ns.kevlo.org>
Kevin Lo <kevlo@kevlo.org> wrote:
> Write the BIT_USB_SUS_DIS bit rather than BIT_BT_DIG_CLK_EN to the
> REG_HCI_OPT_CTRL register for fixing failure to PCIe power on.
>
> Signed-off-by: Kevin Lo <kevlo@kevlo.org>
> Acked-by: Ping-Ke Shih <pkshih@realtek.com>
>
> diff --git a/drivers/net/wireless/realtek/rtw88/mac.c b/drivers/net/wireless/realtek/rtw88/mac.c
> index d1678aed9d9c..caf2603da2d6 100644
> --- a/drivers/net/wireless/realtek/rtw88/mac.c
> +++ b/drivers/net/wireless/realtek/rtw88/mac.c
> @@ -75,7 +75,7 @@ static int rtw_mac_pre_system_cfg(struct rtw_dev *rtwdev)
>
> switch (rtw_hci_type(rtwdev)) {
> case RTW_HCI_TYPE_PCIE:
> - rtw_write32_set(rtwdev, REG_HCI_OPT_CTRL, BIT_BT_DIG_CLK_EN);
> + rtw_write32_set(rtwdev, REG_HCI_OPT_CTRL, BIT_USB_SUS_DIS);
> break;
> case RTW_HCI_TYPE_USB:
> break;
Patch applied to wireless-next.git, thanks.
fc6234d7e2e3 rtw88: use the correct bit in the REG_HCI_OPT_CTRL register
--
https://patchwork.kernel.org/project/linux-wireless/patch/YmLAzuyPr0P4Y6BP@ns.kevlo.org/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2022-04-27 4:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-22 14:50 [PATCH] rtw88: use the correct bit in the REG_HCI_OPT_CTRL register Kevin Lo
2022-04-24 23:49 ` Pkshih
2022-04-27 4:58 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=165103549637.18987.9142437749277361997.kvalo@kernel.org \
--to=kvalo@kernel.org \
--cc=kevlo@kevlo.org \
--cc=linux-wireless@vger.kernel.org \
--cc=pkshih@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.