[PATCH] rtw88: use the correct bit in the REG_HCI_OPT_CTRL register

[PATCH] rtw88: use the correct bit in the REG_HCI_OPT_CTRL register

[Kevin Lo]

Write the BIT_USB_SUS_DIS bit rather than BIT_BT_DIG_CLK_EN to the
REG_HCI_OPT_CTRL register for fixing failure to PCIe power on.

Signed-off-by: Kevin Lo <kevlo@kevlo.org>
---
diff --git a/drivers/net/wireless/realtek/rtw88/mac.c b/drivers/net/wireless/realtek/rtw88/mac.c
index d1678aed9d9c..caf2603da2d6 100644
--- a/drivers/net/wireless/realtek/rtw88/mac.c
+++ b/drivers/net/wireless/realtek/rtw88/mac.c
@@ -75,7 +75,7 @@ static int rtw_mac_pre_system_cfg(struct rtw_dev *rtwdev)
 
 	switch (rtw_hci_type(rtwdev)) {
 	case RTW_HCI_TYPE_PCIE:
-		rtw_write32_set(rtwdev, REG_HCI_OPT_CTRL, BIT_BT_DIG_CLK_EN);
+		rtw_write32_set(rtwdev, REG_HCI_OPT_CTRL, BIT_USB_SUS_DIS);
 		break;
 	case RTW_HCI_TYPE_USB:
 		break;

Re: [PATCH] rtw88: use the correct bit in the REG_HCI_OPT_CTRL register

[Pkshih]

On Fri, 2022-04-22 at 22:50 +0800, Kevin Lo wrote:
> Write the BIT_USB_SUS_DIS bit rather than BIT_BT_DIG_CLK_EN to the
> REG_HCI_OPT_CTRL register for fixing failure to PCIe power on.
> 
> Signed-off-by: Kevin Lo <kevlo@kevlo.org>

Acked-by: Ping-Ke Shih <pkshih@realtek.com>

> ---
> diff --git a/drivers/net/wireless/realtek/rtw88/mac.c b/drivers/net/wireless/realtek/rtw88/mac.c
> index d1678aed9d9c..caf2603da2d6 100644
> --- a/drivers/net/wireless/realtek/rtw88/mac.c
> +++ b/drivers/net/wireless/realtek/rtw88/mac.c
> @@ -75,7 +75,7 @@ static int rtw_mac_pre_system_cfg(struct rtw_dev *rtwdev)
>  
>  	switch (rtw_hci_type(rtwdev)) {
>  	case RTW_HCI_TYPE_PCIE:
> -		rtw_write32_set(rtwdev, REG_HCI_OPT_CTRL, BIT_BT_DIG_CLK_EN);
> +		rtw_write32_set(rtwdev, REG_HCI_OPT_CTRL, BIT_USB_SUS_DIS);
>  		break;
>  	case RTW_HCI_TYPE_USB:
>  		break;
> ------Please consider the environment before printing this e-mail.

Re: [PATCH] rtw88: use the correct bit in the REG_HCI_OPT_CTRL register

[Kalle Valo]

Kevin Lo <kevlo@kevlo.org> wrote:

> Write the BIT_USB_SUS_DIS bit rather than BIT_BT_DIG_CLK_EN to the
> REG_HCI_OPT_CTRL register for fixing failure to PCIe power on.
> 
> Signed-off-by: Kevin Lo <kevlo@kevlo.org>
> Acked-by: Ping-Ke Shih <pkshih@realtek.com>
> 
> diff --git a/drivers/net/wireless/realtek/rtw88/mac.c b/drivers/net/wireless/realtek/rtw88/mac.c
> index d1678aed9d9c..caf2603da2d6 100644
> --- a/drivers/net/wireless/realtek/rtw88/mac.c
> +++ b/drivers/net/wireless/realtek/rtw88/mac.c
> @@ -75,7 +75,7 @@ static int rtw_mac_pre_system_cfg(struct rtw_dev *rtwdev)
>  
>  	switch (rtw_hci_type(rtwdev)) {
>  	case RTW_HCI_TYPE_PCIE:
> -		rtw_write32_set(rtwdev, REG_HCI_OPT_CTRL, BIT_BT_DIG_CLK_EN);
> +		rtw_write32_set(rtwdev, REG_HCI_OPT_CTRL, BIT_USB_SUS_DIS);
>  		break;
>  	case RTW_HCI_TYPE_USB:
>  		break;

Patch applied to wireless-next.git, thanks.

fc6234d7e2e3 rtw88: use the correct bit in the REG_HCI_OPT_CTRL register

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/YmLAzuyPr0P4Y6BP@ns.kevlo.org/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches