All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] net: fec: add missing of_node_put() in fec_enet_init_stop_mode()
@ 2022-04-26 12:52 Yang Yingliang
  2022-04-28  1:00 ` patchwork-bot+netdevbpf
  0 siblings, 1 reply; 2+ messages in thread
From: Yang Yingliang @ 2022-04-26 12:52 UTC (permalink / raw)
  To: linux-kernel, netdev; +Cc: qiangqing.zhang, fugang.duan, davem, kuba

Put device node in error path in fec_enet_init_stop_mode().

Fixes: 8a448bf832af ("net: ethernet: fec: move GPR register offset and bit into DT")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
 drivers/net/ethernet/freescale/fec_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c
index 11227f51404c..9f33ec838b52 100644
--- a/drivers/net/ethernet/freescale/fec_main.c
+++ b/drivers/net/ethernet/freescale/fec_main.c
@@ -3731,7 +3731,7 @@ static int fec_enet_init_stop_mode(struct fec_enet_private *fep,
 					 ARRAY_SIZE(out_val));
 	if (ret) {
 		dev_dbg(&fep->pdev->dev, "no stop mode property\n");
-		return ret;
+		goto out;
 	}
 
 	fep->stop_gpr.gpr = syscon_node_to_regmap(gpr_np);
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] net: fec: add missing of_node_put() in fec_enet_init_stop_mode()
  2022-04-26 12:52 [PATCH] net: fec: add missing of_node_put() in fec_enet_init_stop_mode() Yang Yingliang
@ 2022-04-28  1:00 ` patchwork-bot+netdevbpf
  0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-04-28  1:00 UTC (permalink / raw)
  To: Yang Yingliang
  Cc: linux-kernel, netdev, qiangqing.zhang, fugang.duan, davem, kuba

Hello:

This patch was applied to netdev/net.git (master)
by Jakub Kicinski <kuba@kernel.org>:

On Tue, 26 Apr 2022 20:52:31 +0800 you wrote:
> Put device node in error path in fec_enet_init_stop_mode().
> 
> Fixes: 8a448bf832af ("net: ethernet: fec: move GPR register offset and bit into DT")
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> ---
>  drivers/net/ethernet/freescale/fec_main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Here is the summary with links:
  - net: fec: add missing of_node_put() in fec_enet_init_stop_mode()
    https://git.kernel.org/netdev/net/c/d2b52ec056d5

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-04-28  1:00 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-26 12:52 [PATCH] net: fec: add missing of_node_put() in fec_enet_init_stop_mode() Yang Yingliang
2022-04-28  1:00 ` patchwork-bot+netdevbpf

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.