* [PATCH] ath9k: hif_usb: simplify if-if to if-else
@ 2022-04-24 9:44 Wan Jiabing
2022-04-27 8:09 ` Toke Høiland-Jørgensen
2022-04-29 6:05 ` Kalle Valo
0 siblings, 2 replies; 3+ messages in thread
From: Wan Jiabing @ 2022-04-24 9:44 UTC (permalink / raw)
To: Toke Høiland-Jørgensen, Kalle Valo, David S. Miller,
Jakub Kicinski, Paolo Abeni, linux-wireless, netdev,
linux-kernel
Cc: kael_w, Wan Jiabing
Use if and else instead of if(A) and if (!A).
Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
---
drivers/net/wireless/ath/ath9k/hif_usb.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/net/wireless/ath/ath9k/hif_usb.c b/drivers/net/wireless/ath/ath9k/hif_usb.c
index f06eec99de68..518deb5098a2 100644
--- a/drivers/net/wireless/ath/ath9k/hif_usb.c
+++ b/drivers/net/wireless/ath/ath9k/hif_usb.c
@@ -368,10 +368,9 @@ static int __hif_usb_tx(struct hif_device_usb *hif_dev)
__skb_queue_head_init(&tx_buf->skb_queue);
list_move_tail(&tx_buf->list, &hif_dev->tx.tx_buf);
hif_dev->tx.tx_buf_cnt++;
- }
-
- if (!ret)
+ } else {
TX_STAT_INC(buf_queued);
+ }
return ret;
}
--
2.35.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ath9k: hif_usb: simplify if-if to if-else
2022-04-24 9:44 [PATCH] ath9k: hif_usb: simplify if-if to if-else Wan Jiabing
@ 2022-04-27 8:09 ` Toke Høiland-Jørgensen
2022-04-29 6:05 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Toke Høiland-Jørgensen @ 2022-04-27 8:09 UTC (permalink / raw)
To: Wan Jiabing, Kalle Valo, David S. Miller, Jakub Kicinski,
Paolo Abeni, linux-wireless, netdev, linux-kernel
Cc: kael_w, Wan Jiabing
Wan Jiabing <wanjiabing@vivo.com> writes:
> Use if and else instead of if(A) and if (!A).
>
> Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
Acked-by: Toke Høiland-Jørgensen <toke@toke.dk>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ath9k: hif_usb: simplify if-if to if-else
2022-04-24 9:44 [PATCH] ath9k: hif_usb: simplify if-if to if-else Wan Jiabing
2022-04-27 8:09 ` Toke Høiland-Jørgensen
@ 2022-04-29 6:05 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Kalle Valo @ 2022-04-29 6:05 UTC (permalink / raw)
To: Wan Jiabing
Cc: Toke Høiland-Jørgensen, David S. Miller,
Jakub Kicinski, Paolo Abeni, linux-wireless, netdev,
linux-kernel, kael_w, Wan Jiabing
Wan Jiabing <wanjiabing@vivo.com> wrote:
> Use if and else instead of if(A) and if (!A).
>
> Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
> Acked-by: Toke Høiland-Jørgensen <toke@toke.dk>
> Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>
Patch applied to ath-next branch of ath.git, thanks.
2950833f10cf ath9k: hif_usb: simplify if-if to if-else
--
https://patchwork.kernel.org/project/linux-wireless/patch/20220424094441.104937-1-wanjiabing@vivo.com/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-04-29 6:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-24 9:44 [PATCH] ath9k: hif_usb: simplify if-if to if-else Wan Jiabing
2022-04-27 8:09 ` Toke Høiland-Jørgensen
2022-04-29 6:05 ` Kalle Valo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.