* [PATCH] scsi:fnic: remove unneeded flush_workqueue
@ 2022-04-24 6:54 cgel.zte
2022-05-03 0:51 ` Martin K. Petersen
0 siblings, 1 reply; 2+ messages in thread
From: cgel.zte @ 2022-04-24 6:54 UTC (permalink / raw)
To: satishkh
Cc: sebaddel, kartilak, jejb, martin.petersen, linux-scsi,
linux-kernel, ran jianping, Zeal Robot
From: ran jianping <ran.jianping@zte.com.cn>
All work currently pending will be done first by calling destroy_workqueue,
so there is no need to flush it explicitly.
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: ran jianping <ran.jianping@zte.com.cn>
---
drivers/scsi/fnic/fnic_main.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/scsi/fnic/fnic_main.c b/drivers/scsi/fnic/fnic_main.c
index 9161bd2fd421..460e03a55096 100644
--- a/drivers/scsi/fnic/fnic_main.c
+++ b/drivers/scsi/fnic/fnic_main.c
@@ -1146,10 +1146,8 @@ static void __exit fnic_cleanup_module(void)
{
pci_unregister_driver(&fnic_driver);
destroy_workqueue(fnic_event_queue);
- if (fnic_fip_queue) {
- flush_workqueue(fnic_fip_queue);
+ if (fnic_fip_queue)
destroy_workqueue(fnic_fip_queue);
- }
kmem_cache_destroy(fnic_sgl_cache[FNIC_SGL_CACHE_MAX]);
kmem_cache_destroy(fnic_sgl_cache[FNIC_SGL_CACHE_DFLT]);
kmem_cache_destroy(fnic_io_req_cache);
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] scsi:fnic: remove unneeded flush_workqueue
2022-04-24 6:54 [PATCH] scsi:fnic: remove unneeded flush_workqueue cgel.zte
@ 2022-05-03 0:51 ` Martin K. Petersen
0 siblings, 0 replies; 2+ messages in thread
From: Martin K. Petersen @ 2022-05-03 0:51 UTC (permalink / raw)
To: cgel.zte, satishkh
Cc: Martin K . Petersen, ran jianping, linux-kernel, jejb, sebaddel,
Zeal Robot, kartilak, linux-scsi
On Sun, 24 Apr 2022 06:54:06 +0000, cgel.zte@gmail.com wrote:
> From: ran jianping <ran.jianping@zte.com.cn>
>
> All work currently pending will be done first by calling destroy_workqueue,
> so there is no need to flush it explicitly.
>
>
Applied to 5.19/scsi-queue, thanks!
[1/1] scsi:fnic: remove unneeded flush_workqueue
https://git.kernel.org/mkp/scsi/c/671a52f2aeaf
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-05-04 0:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-24 6:54 [PATCH] scsi:fnic: remove unneeded flush_workqueue cgel.zte
2022-05-03 0:51 ` Martin K. Petersen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.