* [RESEND][PATCH] qedf: remove an unneeded NULL check on list iterator
@ 2022-04-05 0:40 Xiaomeng Tong
2022-04-26 12:38 ` Martin K. Petersen
2022-05-03 0:51 ` Martin K. Petersen
0 siblings, 2 replies; 3+ messages in thread
From: Xiaomeng Tong @ 2022-04-05 0:40 UTC (permalink / raw)
To: skashyap, jhasan, GR-QLogic-Storage-Upstream, jejb, martin.petersen
Cc: linux-scsi, linux-kernel, Xiaomeng Tong
The list iterator 'fcport' is always non-NULL so it doesn't need to be
checked. Thus just remove the unnecessary NULL check. Also remove the
unnecessary initializer because the list iterator is always initialized.
And adjust the position of blank lines.
Signed-off-by: Xiaomeng Tong <xiam0nd.tong@gmail.com>
---
drivers/scsi/qedf/qedf_main.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/scsi/qedf/qedf_main.c b/drivers/scsi/qedf/qedf_main.c
index 6ad28bc8e948..1bfa30983b92 100644
--- a/drivers/scsi/qedf/qedf_main.c
+++ b/drivers/scsi/qedf/qedf_main.c
@@ -873,7 +873,7 @@ static int qedf_eh_device_reset(struct scsi_cmnd *sc_cmd)
bool qedf_wait_for_upload(struct qedf_ctx *qedf)
{
- struct qedf_rport *fcport = NULL;
+ struct qedf_rport *fcport;
int wait_cnt = 120;
while (wait_cnt--) {
@@ -888,7 +888,7 @@ bool qedf_wait_for_upload(struct qedf_ctx *qedf)
rcu_read_lock();
list_for_each_entry_rcu(fcport, &qedf->fcports, peers) {
- if (fcport && test_bit(QEDF_RPORT_SESSION_READY,
+ if (test_bit(QEDF_RPORT_SESSION_READY,
&fcport->flags)) {
if (fcport->rdata)
QEDF_ERR(&qedf->dbg_ctx,
@@ -899,9 +899,9 @@ bool qedf_wait_for_upload(struct qedf_ctx *qedf)
"Waiting for fcport %p.\n", fcport);
}
}
+
rcu_read_unlock();
return false;
-
}
/* Performs soft reset of qedf_ctx by simulating a link down/up */
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [RESEND][PATCH] qedf: remove an unneeded NULL check on list iterator
2022-04-05 0:40 [RESEND][PATCH] qedf: remove an unneeded NULL check on list iterator Xiaomeng Tong
@ 2022-04-26 12:38 ` Martin K. Petersen
2022-05-03 0:51 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2022-04-26 12:38 UTC (permalink / raw)
To: Xiaomeng Tong
Cc: skashyap, jhasan, GR-QLogic-Storage-Upstream, jejb,
martin.petersen, linux-scsi, linux-kernel
Xiaomeng,
> The list iterator 'fcport' is always non-NULL so it doesn't need to be
> checked. Thus just remove the unnecessary NULL check. Also remove the
> unnecessary initializer because the list iterator is always initialized.
> And adjust the position of blank lines.
Applied to 5.19/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [RESEND][PATCH] qedf: remove an unneeded NULL check on list iterator
2022-04-05 0:40 [RESEND][PATCH] qedf: remove an unneeded NULL check on list iterator Xiaomeng Tong
2022-04-26 12:38 ` Martin K. Petersen
@ 2022-05-03 0:51 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2022-05-03 0:51 UTC (permalink / raw)
To: GR-QLogic-Storage-Upstream, Xiaomeng Tong, jejb, skashyap, jhasan
Cc: Martin K . Petersen, linux-kernel, linux-scsi
On Tue, 5 Apr 2022 08:40:55 +0800, Xiaomeng Tong wrote:
> The list iterator 'fcport' is always non-NULL so it doesn't need to be
> checked. Thus just remove the unnecessary NULL check. Also remove the
> unnecessary initializer because the list iterator is always initialized.
> And adjust the position of blank lines.
>
>
Applied to 5.19/scsi-queue, thanks!
[1/1] qedf: remove an unneeded NULL check on list iterator
https://git.kernel.org/mkp/scsi/c/505420bd5543
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-05-06 5:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-05 0:40 [RESEND][PATCH] qedf: remove an unneeded NULL check on list iterator Xiaomeng Tong
2022-04-26 12:38 ` Martin K. Petersen
2022-05-03 0:51 ` Martin K. Petersen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.