[PATCH net 1/2] selftests/net: so_txtime: fix parsing on 32 bit systems and help text

[PATCH net 1/2] selftests/net: so_txtime: fix parsing on 32 bit systems and help text

[Marc Kleine-Budde]

Hello,

while playing with so_txime on a 32 bit ARM system I noticed that the
start time is not correctly parsed, also the help text is not correct.

regards,
Marc

[PATCH net 1/2] selftests/net: so_txtime: fix parsing of start time stamp on 32 bit systems

[Marc Kleine-Budde]

This patch fixes the parsing of the cmd line supplied start time on 32
bit systems. A "long" on 32 bit systems is only 32 bit wide and cannot
hold a timestamp in nano second resolution.

Fixes: 040806343bb4 ("selftests/net: so_txtime multi-host support")
Cc: Carlos Llamas <cmllamas@google.com>
Cc: Willem de Bruijn <willemb@google.com>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
---
 tools/testing/selftests/net/so_txtime.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/net/so_txtime.c b/tools/testing/selftests/net/so_txtime.c
index 59067f64b775..103f6bf28e35 100644
--- a/tools/testing/selftests/net/so_txtime.c
+++ b/tools/testing/selftests/net/so_txtime.c
@@ -475,7 +475,7 @@ static void parse_opts(int argc, char **argv)
 			cfg_rx = true;
 			break;
 		case 't':
-			cfg_start_time_ns = strtol(optarg, NULL, 0);
+			cfg_start_time_ns = strtoll(optarg, NULL, 0);
 			break;
 		case 'm':
 			cfg_mark = strtol(optarg, NULL, 0);

base-commit: 79396934e289dbc501316c1d1f975bb4c88ae460
-- 
2.35.1

[PATCH net 2/2] selftests/net: so_txtime: usage(): fix documentation of default clock

[Marc Kleine-Budde]

The program uses CLOCK_TAI as default clock since it was added to the
Linux repo. In commit:
| 040806343bb4 ("selftests/net: so_txtime multi-host support")
a help text stating the wrong default clock was added.

This patch fixes the help text.

Fixes: 040806343bb4 ("selftests/net: so_txtime multi-host support")
Cc: Carlos Llamas <cmllamas@google.com>
Cc: Willem de Bruijn <willemb@google.com>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
---
 tools/testing/selftests/net/so_txtime.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/net/so_txtime.c b/tools/testing/selftests/net/so_txtime.c
index 103f6bf28e35..2672ac0b6d1f 100644
--- a/tools/testing/selftests/net/so_txtime.c
+++ b/tools/testing/selftests/net/so_txtime.c
@@ -421,7 +421,7 @@ static void usage(const char *progname)
 			"Options:\n"
 			"  -4            only IPv4\n"
 			"  -6            only IPv6\n"
-			"  -c <clock>    monotonic (default) or tai\n"
+			"  -c <clock>    monotonic or tai (default)\n"
 			"  -D <addr>     destination IP address (server)\n"
 			"  -S <addr>     source IP address (client)\n"
 			"  -r            run rx mode\n"
-- 
2.35.1

Re: [PATCH net 1/2] selftests/net: so_txtime: fix parsing of start time stamp on 32 bit systems

[Willem de Bruijn]

On Mon, May 2, 2022 at 5:46 AM Marc Kleine-Budde <mkl@pengutronix.de> wrote:
>
> This patch fixes the parsing of the cmd line supplied start time on 32
> bit systems. A "long" on 32 bit systems is only 32 bit wide and cannot
> hold a timestamp in nano second resolution.
>
> Fixes: 040806343bb4 ("selftests/net: so_txtime multi-host support")
> Cc: Carlos Llamas <cmllamas@google.com>
> Cc: Willem de Bruijn <willemb@google.com>
> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>

Acked-by: Willem de Bruijn <willemb@google.com>

Re: [PATCH net 2/2] selftests/net: so_txtime: usage(): fix documentation of default clock

[Willem de Bruijn]

On Mon, May 2, 2022 at 5:46 AM Marc Kleine-Budde <mkl@pengutronix.de> wrote:
>
> The program uses CLOCK_TAI as default clock since it was added to the
> Linux repo. In commit:
> | 040806343bb4 ("selftests/net: so_txtime multi-host support")
> a help text stating the wrong default clock was added.
>
> This patch fixes the help text.
>
> Fixes: 040806343bb4 ("selftests/net: so_txtime multi-host support")
> Cc: Carlos Llamas <cmllamas@google.com>
> Cc: Willem de Bruijn <willemb@google.com>
> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>

Acked-by: Willem de Bruijn <willemb@google.com>

Re: [PATCH net 1/2] selftests/net: so_txtime: fix parsing of start time stamp on 32 bit systems

[Carlos Llamas]

On Mon, May 02, 2022 at 11:46:37AM +0200, Marc Kleine-Budde wrote:
> This patch fixes the parsing of the cmd line supplied start time on 32
> bit systems. A "long" on 32 bit systems is only 32 bit wide and cannot
> hold a timestamp in nano second resolution.
> 
> Fixes: 040806343bb4 ("selftests/net: so_txtime multi-host support")
> Cc: Carlos Llamas <cmllamas@google.com>
> Cc: Willem de Bruijn <willemb@google.com>
> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
> ---

LGTM, thanks.

Reviewed-by: Carlos Llamas <cmllamas@google.com>

--
Carlos Llamas

Re: [PATCH net 2/2] selftests/net: so_txtime: usage(): fix documentation of default clock

[Carlos Llamas]

On Mon, May 02, 2022 at 11:46:38AM +0200, Marc Kleine-Budde wrote:
> The program uses CLOCK_TAI as default clock since it was added to the
> Linux repo. In commit:
> | 040806343bb4 ("selftests/net: so_txtime multi-host support")
> a help text stating the wrong default clock was added.
> 
> This patch fixes the help text.
> 
> Fixes: 040806343bb4 ("selftests/net: so_txtime multi-host support")
> Cc: Carlos Llamas <cmllamas@google.com>
> Cc: Willem de Bruijn <willemb@google.com>
> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
> ---

LGTM, thanks.

Reviewed-by: Carlos Llamas <cmllamas@google.com>

--
Carlos Llamas

Re: [PATCH net 1/2] selftests/net: so_txtime: fix parsing of start time stamp on 32 bit systems

[patchwork-bot+netdevbpf]

Hello:

This series was applied to netdev/net.git (master)
by Paolo Abeni <pabeni@redhat.com>:

On Mon,  2 May 2022 11:46:37 +0200 you wrote:
> This patch fixes the parsing of the cmd line supplied start time on 32
> bit systems. A "long" on 32 bit systems is only 32 bit wide and cannot
> hold a timestamp in nano second resolution.
> 
> Fixes: 040806343bb4 ("selftests/net: so_txtime multi-host support")
> Cc: Carlos Llamas <cmllamas@google.com>
> Cc: Willem de Bruijn <willemb@google.com>
> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
> 
> [...]

Here is the summary with links:
  - [net,1/2] selftests/net: so_txtime: fix parsing of start time stamp on 32 bit systems
    https://git.kernel.org/netdev/net/c/97926d5a847c
  - [net,2/2] selftests/net: so_txtime: usage(): fix documentation of default clock
    https://git.kernel.org/netdev/net/c/f5c2174a3775

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html